Commit graph

4502 commits

Author SHA1 Message Date
jdlrobson f5acba28f3 QA: Remove redundant test so beta cluster tests pass
Currently beta cluster tests are failing because of a single test.

The test for whether a "tagline" appears on special pages is outdated. We now
show taglines on all special pages (defaulting to empty)

Let's thus remove it.

Additional changes:
* Rephrase "wikidata description" as "tagline" - we use the tagline to display
things other than wikidata descriptions e.g. the tagline on Special:MobileOptions

Change-Id: Icb66563cb3a5e7043ca41f59c826bd4247d89d52
2018-11-14 22:39:06 +00:00
Bjornskjald dc61408a59
Add checking if template should output <sup>β</sup>
Bug: T208185
Change-Id: I4d564d9398947ea650b935b42cf79ef4a36d1b7e
2018-11-14 21:39:26 +01:00
jenkins-bot 986f8a3013 Merge "QA: Don't check when_visible twice" 2018-11-14 01:10:29 +00:00
jdlrobson f2639e7a73 QA: Don't check when_visible twice
Instead check the element is in the DOM before testing its
visibility.

This might help T208808 but it's a stab in the dark.

Change-Id: If7ccf5f2f03073c247de7fa497b3a6e31b570918
2018-11-13 16:49:24 -08:00
jenkins-bot 9582c298b2 Merge "Special:MobileOptions: Consistent padding of heading" 2018-11-13 22:29:50 +00:00
Bartosz Dziewoński b17d3f70da Remove 'skins.minerva.editor' module (moved to MobileFrontend)
Added in MobileFrontend in Iaaed72c32b9c4f4e15c320b79e29e9af3609069a.

(The module's name is included in cached page HTML, so to avoid
breaking them, 'skins.minerva.editor' must temporarily remain as an
alias for 'mobile.editor'. It is otherwise unused and can be removed
after caches expire on Wikimedia wikis.)

Depends-On: Iaaed72c32b9c4f4e15c320b79e29e9af3609069a
Bug: T198765
Change-Id: I52c4e0941dcf8f176e3ac32d8a1f72a0f8e1d6a6
2018-11-13 23:27:29 +01:00
takidelfin 17a3b5b6b0 Special:MobileOptions: Consistent padding of heading
Fixed it by adding a new media query for <720px and defining `default` for MobileOptions regardless of screen width.

Bug: T202557
Change-Id: I11deac1a36d9ab02ccfbce639490a95ca176f136
2018-11-13 15:42:03 +01:00
jdlrobson f173dabf75 Avoid overlapping text on Russian and Farsi projects
Account for the fact that many wikis use `mbox-text-div` rather
than `mbox-text-span` and that the element might not be display
block/inline block

Bug: T206887
Change-Id: I6b3cee4339fc7ddb035a99fb4929b1ab67f22333
2018-11-12 16:44:06 -08:00
Translation updater bot 6bc349f1d5 Localisation updates from https://translatewiki.net.
Change-Id: I769985bb9f72ce82e673de559ce80fa515dd0ee7
2018-11-12 21:58:12 +01:00
jenkins-bot 6dfde3c19f Merge "Hygiene: remove package-lock.json" 2018-11-12 20:48:50 +00:00
jenkins-bot 16c0567578 Merge "skins.minerva.editor: Remove unused dependencies" 2018-11-12 20:48:48 +00:00
Stephen Niedzielski d0c035ea3e Hygiene: remove package-lock.json
Remove package-lock.json until a Node.js version that supports it is
possible.

Change-Id: Id26bbd63aefabbc1e06f2e108dc2c23868138b31
2018-11-12 07:53:49 -07:00
Translation updater bot 3b6d2cf9d8 Localisation updates from https://translatewiki.net.
Change-Id: Id85c6546e1d825cad963ab5d2324f9b1e46a5679
2018-11-10 22:06:35 +01:00
jenkins-bot 90629a0578 Merge "Move canEdit checks to server from client" 2018-11-09 22:07:47 +00:00
arcayn c64a4cf811 Move canEdit checks to server from client
Bug: T206262
Change-Id: I08bfc56998f4fb42c8ce76cc2ad9fba83106d476
2018-11-09 21:26:49 +00:00
Translation updater bot 084d255fa4 Localisation updates from https://translatewiki.net.
Change-Id: I9df1e3acaf11b47be95e43105db9fcd9f7713e36
2018-11-09 21:56:29 +01:00
jenkins-bot 241c319bbb Merge "skins.minerva.editor: Remove remaining uses of 'skins.minerva.scripts'" 2018-11-09 17:19:18 +00:00
jenkins-bot 5a1dd4a52a Merge "skins.minerva.scripts/init: Use singleton OverlayManager from MF" 2018-11-09 17:19:16 +00:00
jenkins-bot 65b00b4a41 Merge "Merge remote-tracking branch 'gerrit/page-issues-cleanup'" 2018-11-09 01:11:10 +00:00
jdlrobson 846b37c708 Update references to deprecated modules
Change-Id: Id5ec727eb32c7b5207bb1175ebcdb0c1c4a4911a
Depends-On: I7b0090c3e4268ea147f1d8707ee62f90e7d48724
Bug: T207805
2018-11-08 13:34:50 -08:00
Translation updater bot 6681de52de Localisation updates from https://translatewiki.net.
Change-Id: Ic48b3a4f7b7594cfba0cc4ca6631d6f385f2d677
2018-11-08 22:00:23 +01:00
Bartosz Dziewoński 3a0e46907b skins.minerva.editor: Remove unused dependencies
We were not using some of the code this was depending on. No idea when
it stopped being required.

'skins.minerva.scripts' was used until recently (d27a9481, 72cd31f2),
but now its only purpose was to load other dependencies. Add them
separately instead.

Removed dependencies:
* mediawiki.ui.input
* skins.minerva.icons.images.scripts
* skins.minerva.scripts
* skins.minerva.toggling

Added dependencies:
* mediawiki.api
* mediawiki.storage
* mediawiki.user
* mobile.init

Bug: T198765
Change-Id: Ic80ba016adca377cb539adf672793fa103deb150
2018-11-08 17:42:53 +01:00
jenkins-bot 880607b55a Merge "No Minerva variables should be loaded on a non-Minerva skin" 2018-11-08 16:32:30 +00:00
Bartosz Dziewoński d27a9481bc skins.minerva.editor: Remove remaining uses of 'skins.minerva.scripts'
We want to remove dependencies on Minerva code from this file to move
it to MobileFrontend.

* Use 'mobile.init/skin' instead of 'skins.minerva.scripts/skin'.
* Use 'mobile.startup/OverlayManager' and #getSingleton
  instead of 'skins.minerva.scripts/overlayManager'.

Both of them are just aliases for modules defined in MobileFrontend.

Bug: T198765
Change-Id: Id017dd4b6d1fe31a735613f991721c4dddafbde9
2018-11-08 16:17:21 +01:00
Bartosz Dziewoński 7bbba14ee1 skins.minerva.scripts/init: Use singleton OverlayManager from MF
Bug: T198765
Depends-On: Ie83846e7dfabe302006d0979f2f21913839e1795
Change-Id: I9c07863ab9c68886d6c5b5f09756e034a4d96477
2018-11-08 16:14:40 +01:00
Bartosz Dziewoński 7b5928d795 Merge remote-tracking branch 'gerrit/page-issues-cleanup'
Bug: T198765
Bug: T208514
Change-Id: I9467101c9b01cbd7682de859e43e04966760eea6
2018-11-08 16:00:39 +01:00
Translation updater bot eee902beff Localisation updates from https://translatewiki.net.
Change-Id: I86b27a622e2af8b15a36ea98674720cbd5fd5218
2018-11-07 22:03:12 +01:00
jdlrobson dabb909887 No Minerva variables should be loaded on a non-Minerva skin
Bug: T186062
Change-Id: I13c2ca804e92bc2ab839b370de48299c2ccd474f
2018-11-07 11:04:00 -08:00
jenkins-bot 10eaabbeeb Merge "Fix invalid HTML produced by DownloadIcon" 2018-11-06 22:37:54 +00:00
Bjornskjald bc303e50cc Fix invalid HTML produced by DownloadIcon
Depends-On: I549e15f8a3352761e4960abdaaef6cd4bfb133e6
Bug: T205359
Change-Id: Id67b8a6591a8dec92d1c577851661c65973d593f
2018-11-06 12:42:58 -08:00
jenkins-bot 69eddce6be Merge "Disable mobile editor (skins.minerva.editor) on desktop" 2018-11-05 22:11:12 +00:00
Translation updater bot 4306bf1bb2 Localisation updates from https://translatewiki.net.
Change-Id: I739e4db72822cd386591150448e7dc9958243f6f
2018-11-05 22:06:44 +01:00
Translation updater bot c009db0f70 Localisation updates from https://translatewiki.net.
Change-Id: Ic904a16401330a5e40dd0d912b4492fe8aa5a00e
2018-11-04 22:11:05 +01:00
jenkins-bot 9bc962e075 Merge "Add showing toast/drawer when visiting protected article with editor link" 2018-11-03 18:04:58 +00:00
Bjornskjald 8f1cfa4b81
Add showing toast/drawer when visiting protected article with editor link
Bug: T205630
Change-Id: I0c25f491c894d12775d236ecc9250bfdad17a13b
2018-11-03 18:39:11 +01:00
Umherirrender f78c1aa4e6 Revert "Localisation updates from https://translatewiki.net."
Removed message key is still in en.json

This reverts commit 77ab4f66b4.

Change-Id: I7bef45396ecff24c3197a23b85bf93d81f2c3d49
2018-11-03 14:43:56 +00:00
Translation updater bot 77ab4f66b4 Localisation updates from https://translatewiki.net.
Change-Id: I53b71b49ee310f55aa78d4943de5ebdc90073c18
2018-11-03 10:39:58 +01:00
Bjornskjald 10978e5022
Add drawer when user is not logged in and anonymous edits are disabled
Bug: T206823
Change-Id: Ibd77ff0966f2d4b86e61f66caaafb94e85b02235
2018-11-02 23:01:22 +01:00
jdlrobson 6a73c395f1 Don't ship wgMFDescription if you're not using it
There are no occurances in the codebase using this description
so do not include it.

Bug: T186062
Change-Id: Icd06329af2756d3fcd143deab528e6a7c7d56d30
2018-11-01 18:58:49 +00:00
jenkins-bot b08643cbab Merge "Fix undefined NS issue with @coversDefaultClass" 2018-11-01 14:22:48 +00:00
Alangi Derick 679a45677e Explicitly use "MediaWiki\Minerva\SkinUserPageHelper;" on-top of file
To make things neat, use "MediaWiki\Minerva\SkinUserPageHelper;" at the top
of the file and then mock class directly (shorter and easily readable).

Change-Id: Ie2ee64e75c38fff77d41af20bdea01015ed39a87
2018-11-01 14:35:57 +01:00
Alangi Derick e2e5cbc3d7 Fix undefined NS issue with @coversDefaultClass
In skin MinervaNeue, correctly cover SkinUserPageHelper
namespace in SkilUserPageHelperTest.php

Change-Id: I8c8bd9986c2b3989f093bfb585d90647e8da60ef
2018-11-01 14:28:20 +01:00
jdlrobson eba2b3a1fa Remove unreferenced skin style
Follow up to I9c87f6a676186928787c130e61d3c312214e1853
which removed the reference but not the file

Bug: T208340
Change-Id: I416062a7ee48dd00a705abee2675f781491c3e00
2018-10-31 15:11:44 -07:00
jdlrobson 5ad1a0ff5a Article width should not be full screen
Follow up to I5fb67f4abd7aee1fce41e60fe24e8fd6b45e5146 which
incorrectly set a min-width not a max-width.

Bug: T193061
Change-Id: I385061ea47a4dbf011eec2582594f94a4749f713
2018-10-31 11:20:53 -07:00
jenkins-bot 109d737621 Merge "Remove obsolete Special:Preferences styles after its transformation to OOUI" 2018-10-30 22:18:03 +00:00
Volker E fd67163292 Remove obsolete Special:Preferences styles after its transformation to OOUI
The styles in this stylesheet match no elements in the
Special:Preferences page since the OOUI transformation.

Bug: T208340
Change-Id: I9c87f6a676186928787c130e61d3c312214e1853
2018-10-30 22:04:40 +00:00
Volker E b4287378fd Provide ARIA label on main search input
Bug: T208290
Change-Id: I594ab47ffcba3596e52f02a751eaed6084db207b
2018-10-29 22:21:27 -07:00
Bartosz Dziewoński d57f8290c3 Disable mobile editor (skins.minerva.editor) on desktop
This module is no longer necessary to allow editing pages in the
Minerva skin. When it is not loaded, the normal desktop editor will
be used instead (that may be WikiEditor, VisualEditor, just the plain
textarea from MediaWiki core, or something else).

Bug: T198765
Bug: T208068
Change-Id: I1eb9d4b4bc937522e527dbdc0d6be82baf3b7413
2018-10-30 03:46:13 +01:00
jenkins-bot 6cf66a2ad8 Merge "Revert "autocomplete is not necessary on search input types"" 2018-10-30 00:15:05 +00:00
Jdlrobson b71e36313f Revert "autocomplete is not necessary on search input types"
This reverts commit 05fd384803.

Looks like it is needed.  On android i am now seeing autocomplete unexpectedly...

Change-Id: I9c4476346c183d6dcc9e25965530f3e2478ed88f
2018-10-27 06:03:00 +00:00