Commit graph

2553 commits

Author SHA1 Message Date
jdlrobson 7408d87465 Run bundlesize tests on every commit
It was added in 7340485014
but for some reason never enabled.

This was supposed to be protecting us from performance regressions
by monitoring the size of modules in the repo. It appears to be
broken both locally and on Jenkins when run on the due to some changes
in Phabricator.

Since then we've added bundle size tests to Vector using a different
more foolproof method. I think that method is more preferable as it
also provides coverage for JS and icons so the
associated script is copied over and used in Minerva
and activated on all commits.

Bug: T259080
Change-Id: I9ba2dcc060ec09d91814c947d5be3f71b055a66e
2020-07-28 23:43:38 +00:00
jdlrobson 065b6e52b2 QA: Restore nested reference test
References clicks should now apply to the `sup` element not `a`
as the `a` element can contain spans.

Depends-On: I0d5bb398e99465ade357743dd3ff34ae551243c5
Bug: T258096
Change-Id: I5d8cae5f465a86282796b3fdc6bc658f6c836432
2020-07-28 21:53:19 +00:00
Edward Tadros 6f1fb87414 Selenium: Skip nested reference test.
BUG: T258096
Change-Id: Ie16eb622384a48ad2b060a720ea3e8e6abfb1fa2
2020-07-28 13:55:36 -07:00
Ed Sanders 13449aed52 Remove styles moved over to Echo
Bug: T258936
Depends-On: I72bedc3c3d633e8898c93d5e7d570b8ee7b6a1ff
Change-Id: Ic9b03bab0db39ccbed5b05c89577be18bb17c8de
2020-07-28 09:49:33 +00:00
Ed Sanders 58b9721e9c Remove -affixed selector
'affixed' no longer appears anywhere else in Minerva or Echo.

Change-Id: I540beddd7bfee12d699e3596130c65bcf041d036
2020-07-28 09:49:26 +00:00
Ed Sanders 84e1ddd5a8 Fix layout of NotificationsInboxWidget on narrow screen
Bug: T258939
Change-Id: Idfb9b3b5613932c92493df5aa93b5353cc07d7c2
2020-07-28 09:49:09 +00:00
Translation updater bot 26dd206510 Localisation updates from https://translatewiki.net.
Change-Id: Iad703000b5d8935de4e566e87a7beff45552bf9b
2020-07-28 08:26:33 +02:00
jenkins-bot 4cfe275cdc Merge "Add languages/all route for LanguageInfo overlay" 2020-07-28 01:44:48 +00:00
Kosta Harlan f915d69872 Add languages/all route for LanguageInfo overlay
Depends-On: Ic0f1613e8fd27788f67ed6235386491f0fe077c3
Bug: T232410
Change-Id: Ib558dc7c46cc56ff667957f9126bbe0471d25b8e
2020-07-27 12:39:50 +02:00
Translation updater bot b5c20d2d64 Localisation updates from https://translatewiki.net.
Change-Id: I5f3a45bb7ec3c36a2189971168aa6b1fb83b0318
2020-07-27 08:41:11 +02:00
jenkins-bot 9a4abda6e8 Merge "Nested references should not trigger console warning" 2020-07-24 22:50:43 +00:00
jdlrobson 346bfba3f4 Nested references should not trigger console warning
I don't think it will fix the failing browser tests
but it will rule out Minerva / MobileFrontend as the cause in the
analysis.

This mirrors the codepath in Minerva that's triggering the warning.

Bug: T258096
Change-Id: Idd1c224c02e3d300889b6735fa1b9800212690ff
2020-07-24 22:09:07 +00:00
jenkins-bot c912396b67 Merge "MinervaHooks: Remove unreachable code related to Special:MobileMenu" 2020-07-24 16:11:18 +00:00
Derick A 568367a8c0 MinervaHooks: Remove unreachable code related to Special:MobileMenu
This is a follow-up work on: I30b1af8b88dd146d62f0de7a6352c4117a7cdd90.

Bug: T252005
Change-Id: Iefb56ad9b9c68196d06b96209a73e94aa69a1e2e
2020-07-24 15:43:21 +00:00
Ed Sanders bc945fa15c Apply mobile width fixes to infoboxes explicitly
Previously they were just inheriting from `table`, but
now we don't require .infobox to use a specific element
they should be applied separately.

Fix table max-width override to use !important as this
too could be specified inline.

Bug: T258011
Change-Id: I4f28414fd965ae9f608b5e52047b9d474427853a
2020-07-24 15:42:59 +00:00
Translation updater bot 5294147136 Localisation updates from https://translatewiki.net.
Change-Id: I05781a420489068dda56b07b0b181314637d2025
2020-07-24 08:29:25 +02:00
jenkins-bot 55a34beafd Merge "Apply infobox styles to any element with the class" 2020-07-24 00:40:48 +00:00
Translation updater bot e85e8f64db Localisation updates from https://translatewiki.net.
Change-Id: Ia7131e1821597dd7f640ea9ac738986658b33d2c
2020-07-23 08:31:00 +02:00
Translation updater bot d0c30b4b24 Localisation updates from https://translatewiki.net.
Change-Id: I62d09a8fcc1b95f2bda03b9661d81b8c3ea6a6bd
2020-07-22 08:29:01 +02:00
libraryupgrader bfd7129ced build: Updating grunt to 1.2.1
Change-Id: Ic7c65bd8f950dfbe9651294fd83a25e2b9b89f25
2020-07-21 22:23:47 +00:00
Translation updater bot 2f2f40a4bd Localisation updates from https://translatewiki.net.
Change-Id: I91c9798bae17363a4c3c36383aefe9692734e64f
2020-07-21 09:18:35 +02:00
Translation updater bot d885ccea30 Localisation updates from https://translatewiki.net.
Change-Id: I0c4f2f67be930ad16418a41b8950baf4b773bae4
2020-07-20 09:04:18 +02:00
Ed Sanders e8d5462bb3 Apply infobox styles to any element with the class
MoveLeadParagraphTransform treats div.infobox the same as table.infobox,
and should be fixed to match any element too.

Fix specificity of tablet overrides.

Bug: T258011
Change-Id: I9ada6d1b8b19b46dba6527f1f66edd2547fa0c88
2020-07-17 22:09:30 +01:00
jdlrobson 6b8f8568a1 Restrict the number of errors we log in a given session
One IP address, logged 3,029 errors across 2 pages
This is not helpful as it makes the error seem more widespread
than it really is so let's not logged errors after the first 5.

Change-Id: I8abfc3c3852827ab84a06740356e9b9f659a2d03
2020-07-17 19:05:25 +00:00
Translation updater bot ba5918bd74 Localisation updates from https://translatewiki.net.
Change-Id: I7f5e75c6e16368d624d3db71be13478d5b9ec0d3
2020-07-17 08:31:12 +02:00
libraryupgrader 101730e31d build: Updating eslint-config-wikimedia to 0.16.2
Change-Id: I4d39554093ea299f5e86c26ebec89ff0b135bf81
2020-07-16 04:24:20 +00:00
Translation updater bot 306f99cdd3 Localisation updates from https://translatewiki.net.
Change-Id: Ie627233229277f6f2de6368c53a8f23b48aa9792
2020-07-15 09:07:32 +02:00
jenkins-bot 18c0eb4964 Merge "Selenium: Update WebdriverIO to version 6" 2020-07-14 13:55:34 +00:00
Edward Tadros 49c8c0f0e1 Selenium: Update WebdriverIO to version 6
Bug: T255447
Change-Id: I51daa462187983462d7f6529e5f76f47b21e5ef2
2020-07-13 07:38:36 -07:00
libraryupgrader 22bf7fadfc build: Updating lodash to 4.17.19
* https://npmjs.com/advisories/1523
* CVE-2019-10744

Change-Id: Ib5c1127c579cf2703ce1774fd742a45a3798540a
2020-07-11 15:06:48 +00:00
DannyS712 4e1284996f Deprecate the MinervaPreRender hook, unused
Bug: T256079
Change-Id: Ic4b4ee679d7b78a6fa48fca353f51c1de1ee8a48
2020-07-11 00:35:01 +00:00
Edward Tadros d4ff1f2d2a Selenium: Setup Visual Studio code debugging
Change-Id: Ic3b2a920a6e9ccb06725aa06104f0a124346e7f8
2020-07-08 07:49:13 -07:00
Ed Sanders 9716e52f30 eslint: Remove upstreamed OO global
Change-Id: Iced0659f0e0c31a31d890e393997d0e08fdbc1d6
2020-07-07 21:51:30 +01:00
Translation updater bot a447d9e7d9 Localisation updates from https://translatewiki.net.
Change-Id: Ie3c286fa6e501e1d30a2b97015fc8c2afeb559ca
2020-07-06 09:57:29 +02:00
Translation updater bot 0b8c2501df Localisation updates from https://translatewiki.net.
Change-Id: I5ddee37196349d4dfc32cbf6d10a745e804ac42d
2020-07-03 08:36:25 +02:00
Translation updater bot a1cd9c4ec3 Localisation updates from https://translatewiki.net.
Change-Id: I51d995f5a6febcfcdfbdeea5f38d429c5f4337ea
2020-07-02 08:45:16 +02:00
Edward Tadros c8ce9608c0 Selenium: Update WebdriverIO to version 5
Bug: T255447
Change-Id: I4cdde3070a6dc4e742ea37a78a17dfd556103dd6
2020-06-30 08:27:05 -07:00
Translation updater bot e350281010 Localisation updates from https://translatewiki.net.
Change-Id: I8dac854271bc95c21215c1930134263fd851be2e
2020-06-30 08:36:16 +02:00
jdlrobson 2e450e104e Donate link should be in a separate group in main menu
Bug: T219793
Change-Id: I7501c87eaa799e4c8a9052f5e3f650a89f376d1b
2020-06-29 14:38:34 -07:00
Translation updater bot 36384b6050 Localisation updates from https://translatewiki.net.
Change-Id: Icd47334a5d9bb896dfff3e3ccd92daa66c799ba1
2020-06-29 16:28:32 +02:00
Ammar Abdulhamid ca2faa877d Restore redlink color to .new link elements
The color of the children will not apply back to the parent.

This was removed in I0c151ba under the assumption that elements
is loaded by the Minerva ResourceLoaderSkinModule which it is not.

Bug: T256503
Change-Id: Iffb4b623de61088871c82aa5f02344d765611398
2020-06-27 16:50:56 +00:00
Ammar Abdulhamid f9b5ca1f26 Minerva: Remove usage of two deprecated methods
* BaseTemplate::getToolbox()
* BaseTemplate::getPersonalTools()

Bug: T256272
Change-Id: I7de2be43e1fbe94c10cbe8bba49adc07692f9219
2020-06-26 12:43:27 +01:00
jenkins-bot 027e2697e3 Merge "Remove obsolete '@tocFontSize' variable" 2020-06-25 21:37:23 +00:00
Volker E b5eeb29fc1 Remove obsolete '@tocFontSize' variable
Seems to have been replaced by `@font-size-minerva-small`.

Bug: T255230
Change-Id: I94d565913b44fa4fb569e587eaa85d1f3823ccbc
2020-06-25 13:57:31 -07:00
jdlrobson de595ccf04 Disable donate link
After checking with Alex the donate link is in the wrong place
because of a mix up on the phabricator ticket. Disabling for now
while we reposition.

Change-Id: Icd12026f9e7c617bac8b7d6b4143a634948422a8
2020-06-25 13:45:40 -07:00
jenkins-bot 7871d763ab Merge "Rename @fontFamily* variables to WikimediaUI Base naming convention" 2020-06-25 20:35:37 +00:00
jenkins-bot c38b9fc341 Merge "Mobile web donate link" 2020-06-25 20:18:36 +00:00
AronDemian e0193eba9b Rename @fontFamily* variables to WikimediaUI Base naming convention
Renaming:
- @fontFamilySans -> @font-family-system-sans
- @fontFamilyBase -> @font-family-base
As defined in: https://phabricator.wikimedia.org/source/wikimedia-ui-base/browse/master/wikimedia-ui-base.less$201

Bug: T245136
Change-Id: Idec2c516efe2a6ee82efdf3cc6be173bedbb5b56
2020-06-25 19:51:11 +00:00
Volker E fea419f543 Use default @border-radius-base variable
Following WikimediaUI Base variable naming scheme.

Bug: T255230
Change-Id: I71f49d2b554dbca726aee43b19b1554969449403
2020-06-25 19:07:17 +00:00
Volker E 4cef1791c2 Use correctly named variables background-color-base and color-base--inverted
Depends-On: I7b7534223c672a47a11e69fc07bea535ec0085a1
Bug: T255230
Change-Id: Ibf5c0410e446cff18fc26fe2e80d120a72209c04
2020-06-25 19:07:12 +00:00