Commit graph

234 commits

Author SHA1 Message Date
Ed Sanders 86caa17713 build: Update linters and linter config
* Update stylelint-config-wikimedia to 0.13.0
* Ensure eslintrc.js and root files are linted
  with server config

Change-Id: I59c49fedd5b0c4c5620f960b78e4f781a6bc5abb
2022-05-18 14:33:23 +01:00
Jon Robson 9ffc476b1d Contributions headings should be border box
On mobile devices this is adding horizontal scrolling

Bug: T301798
Change-Id: Ibee771dce4924b138d3dd3df502659b2ea17c66d
2022-03-31 10:30:11 -07:00
Jon Robson 5586526d18 Show the mw-index-pager-list-header
Note this will not go into effect until Iae32ce9eab163bcb5b5b95dfd19c03276bc0f1a9
has been merged which enables skin styling.

The order is intentional to avoid leaving master in a state where
the heading is unstyled but shown.

Bug: T301798
Change-Id: Ia7836a42bfd90379fab981cbd6c64a1c00b29399
2022-03-23 19:22:12 +00:00
Jon Robson 3f9e007745 Remove message box h2 style
Depends-On: Ia57d98d4be39028aa2dfe4ed737755fca79c0db3
Bug: T300306
Change-Id: I1a5ba80ffb219cd7c1e26ea6b18e12237bd78482
2022-02-09 17:49:51 +00:00
jdlrobson f9a8703a64 Minerva uses core page title handling
Bug: T265892
Change-Id: I2ffdedd64414ffb3c6e441391a75fd6e744847a4
2021-12-20 19:39:42 +00:00
Derk-Jan Hartman a0bb9e41ee Fix viewport overflow in RC/Watchlist editsummaries
Set a max-width on this floated element

Bug: T297045
Change-Id: Ie33d7052eb1138cb98543c53410c1f376f3e0e64
2021-12-06 22:22:22 +00:00
Volker E 9c38f7ec82 drawers: Remove outdated supported browser property
IE9 on Windows Phone workarounds are of no use any more.
The `right: 0` and `left: 0` properties below are sufficient in
currently supported browsers.

Change-Id: Ibfb29d1b009cb0ea33bc3cb9be39ee579e981b1a
2021-12-02 13:47:08 -08:00
bwang 03387718cf Clean up MobileFrontend overlay skin styles
Bug: T294033
Depends-on: Ibd4ef00615a1119601c729f2481ff87adaf8c86c
Change-Id: Id1c07205aec59481cc14ddb39c441fafa256e46b
2021-11-04 20:50:49 +00:00
bwang f1c828e19d Refactor Minerva header and overlay headers to use flexbox
- Move new header styles to header.less
- Remove unnecessary styles
- Update search overlay to be aligned with the heading searchbox on all screen sizes
- Add temporary skin style to ensure no regressions in mobile VE

Bug: T294033
Change-Id: Ib9867d1b76b602f3355e9f2689f137bc84b0c929
2021-11-04 15:50:00 -05:00
bwang d1049e5407 Restrict overlay button styles to non icon buttons
Bug: T294146
Change-Id: I5f5568407dda5f3a021d64de9efc2bc7aeb5b458
2021-10-22 18:48:26 +00:00
jdlrobson a7b66f6f63 Remove MinervaTemplate::getContentHtml
* Move method to SkinMinerva
* Turn preparePageContent into a getter that returns the subject
page
* Use getSubjectPage in template

For mobile special pages this now means the page has two .content elements
On those pages I've disabled the initial content element. It also means
various .content <heading> and .content ul  rules now apply that need to be
disabled.

While testing several other issues were taken care of - for example
the h2 in errors

Depends-On: I7761396d6a33830f279742be01240796573556a7
Bug: T291871
Change-Id: I13bc4b5dae7aed86eca31ef306212365e1759481
2021-10-15 20:49:23 +00:00
jdlrobson 3a88911209 Remove whitespace to right of search input in overlay
Bug: T292107
Change-Id: I1143747600a1ffb25dcfe8600c5cd352afb25159
2021-10-12 16:26:53 +00:00
Kosta Harlan 9fac869b8e Revert "Search header should be vertically centered, not top aligned."
This reverts commit d6d26e45bb.

Reason for revert: T292030

Bug: T292030
Change-Id: Ie564139ae0ae5e79389fd9b2beca4e69f36e3e5e
2021-09-29 08:30:03 +00:00
jdlrobson d6d26e45bb Search header should be vertically centered, not top aligned.
Change-Id: I6aa643266a85ec61f2220b12907822d2d03f33c9
2021-09-27 21:35:27 +00:00
jenkins-bot 7791635c0f Merge "minerva-header class is now in cached HTML, remove old header class" 2021-07-21 23:54:23 +00:00
jdlrobson 9fa0f3a64d Use MediaWiki UI version 2 from core in Minerva
Depends-on: Ibc136a17662ae839f90babb21e0f7e8f27b7a7d5
Bug: T191021
Change-Id: Ifdc3a3273aa93129177a11814651ec811c20f49c
2021-07-20 11:59:23 -07:00
jdlrobson ca18ad75d3 minerva-header class is now in cached HTML, remove old header class
This completes the migration from header to minerva-header

Bug: T172626
Change-Id: Ibb86359e683e08d86091f855e3813a99e0ad2cee
2021-07-20 18:36:39 +00:00
ExE Boss 27525d0bff Fix style conflict with content using class="header"
Content using `header` as a CSS class was affected by skin styles
in Minerva being insufficiently specific to the skin‑specific elements.

This changes Minerva to use `class="minerva‑header"`, thus avoiding
the conflict and matching what Vector does.

Bug: T172626
Change-Id: Id8fbe61b2d1d4a89ec11ddfdf7837be797b3bd20
2021-07-16 20:39:24 +00:00
Alexander Vorwerk 9494e1dc80 Drop unused class and style
Droping the unused .navigation-full-screen class and the unused MobileMenu Skin style. This is a follow-up work on: I30b1af8b88dd146d62f0de7a6352c4117a7cdd90

Bug: T252005
Change-Id: Ia1698b5477a159f17a16a6591ee774920f403b79
2021-05-02 17:42:43 +02:00
jdlrobson 685387220f Message box styles for Minerva come from core
Just as before styles for message boxes will be
kept off the critical path of most page views and
loaded on special pages, old revisions and action= URIs,
however unlike before the CSS will come from the definition
in core.

It must also be loaded in JavaScript for compatibility
with the use of warnings in JavaScript, for example 
MobileFrontend overlays.

This change will allow us to remove the
mobile.messageBox.styles module in MobileFrontend
I8b6bdfceaf33b9527dbe6790d2a39e335fb692b2

Bug: T233160
Change-Id: I7d8d1d34621c36c26ec03a3773d4d1e67bd14f2e
2021-04-12 21:45:53 +00:00
yash9265 b14d4e04af Add max-width limit to empty watchlist page
On the Watchlist, when there are no results, the page uses .info and
.empty-page classes. This results in text running without max-length.

Add max-width rule to contain it.

Bug: T222872
Change-Id: I768f800a49e756da1ad2c123c842c37d18fa3310
2021-01-21 19:49:32 +00:00
Sam Wilson df14b078c0 Fix style of clock icon in changes lists
Override core styles for the watchlist expiry clock icon in
Recent Changes and Watchlists.

Bug: T261415
Depends-On: I621b1571b57686beb9fb5802533b1e70d293bc2a
Change-Id: Iefdd271aeb6135771aae832e930fe02c73248110
2020-09-23 10:47:45 +08:00
Sam Wilson e9ad028a5b Center and align the expiry dropdown in watchstar widget
Move the watchlist expiry dropdown list to be aligned in the
centre, and its contents to be left-aligned.

Bug: T261990
Change-Id: I3073618606636c78e6afb5bf19726c7b3973292b
2020-09-21 13:24:03 +08:00
Peter Ovchyn 402aaad6ff Move css styles related to lazy-image-placeholder to skinStyles
`lazy-image-placeholder` is needed only when MobileFrontend is enabled.
So it makes sense to move those styles to mobile.init css. See more details here: T199351#6380240

Bug: T260406
Change-Id: I16ca734af33fb0f3c4c67f20bbca8631279d7778
2020-08-18 16:51:02 +00:00
Ed Sanders 13449aed52 Remove styles moved over to Echo
Bug: T258936
Depends-On: I72bedc3c3d633e8898c93d5e7d570b8ee7b6a1ff
Change-Id: Ic9b03bab0db39ccbed5b05c89577be18bb17c8de
2020-07-28 09:49:33 +00:00
Ed Sanders 58b9721e9c Remove -affixed selector
'affixed' no longer appears anywhere else in Minerva or Echo.

Change-Id: I540beddd7bfee12d699e3596130c65bcf041d036
2020-07-28 09:49:26 +00:00
Ed Sanders 84e1ddd5a8 Fix layout of NotificationsInboxWidget on narrow screen
Bug: T258939
Change-Id: Idfb9b3b5613932c92493df5aa93b5353cc07d7c2
2020-07-28 09:49:09 +00:00
AronDemian e0193eba9b Rename @fontFamily* variables to WikimediaUI Base naming convention
Renaming:
- @fontFamilySans -> @font-family-system-sans
- @fontFamilyBase -> @font-family-base
As defined in: https://phabricator.wikimedia.org/source/wikimedia-ui-base/browse/master/wikimedia-ui-base.less$201

Bug: T245136
Change-Id: Idec2c516efe2a6ee82efdf3cc6be173bedbb5b56
2020-06-25 19:51:11 +00:00
Volker E fea419f543 Use default @border-radius-base variable
Following WikimediaUI Base variable naming scheme.

Bug: T255230
Change-Id: I71f49d2b554dbca726aee43b19b1554969449403
2020-06-25 19:07:17 +00:00
Volker E 4cef1791c2 Use correctly named variables background-color-base and color-base--inverted
Depends-On: I7b7534223c672a47a11e69fc07bea535ec0085a1
Bug: T255230
Change-Id: Ibf5c0410e446cff18fc26fe2e80d120a72209c04
2020-06-25 19:07:12 +00:00
Volker E 1c340f2b36 PageHistory: Remove input overrides breaking mobile Firefox
Luckily, the reset rules, that these overrides have tackled, don't
exist any more. Applying border-color or background removes all default
OS styling from radio and checkbox inputs. If not done comprehensibly
(as in this case before current patch), it renders affected inputs weakly.

Bug: T247683
Change-Id: If5823a435e8f11b7e445c5db62641173d4e6df9d
2020-05-18 13:20:37 -07:00
Jan Drewniak 833a93d909 AMC history page visual fixes
- Reduces space between diff size and comment block.
- Places tags and undo button on same line.

Bug: T249518
Change-Id: I8451654933875346720dbbe8fdcd2da070fe29f9
2020-05-11 11:19:18 +02:00
Jan Drewniak d781d08c5e Small fixes to AMC history page items
This fixes the alignment of the (cur|prev) buttons, by floating
them right, and removes some space between the "undo" button and
the tags by floating it right as well.

Bug: T249518
Change-Id: I9ff697f4146073355f8b9a61f4b0633e24c85ce6
2020-05-07 15:59:17 +02:00
Volker E 18ab61d4fe Use .text-overflow() mixin from 'mediawiki.mixins'
Removing MinervaNeue's own mixin now that it's possible.
Also unify code instances to use new mixin.

Depends-On: Ia8d6e7229b49598b0f4cb19dff463ffe2f11a43d
Change-Id: Iaffcefcb7a239d5ddecbe17097573d06099de88e
2020-04-21 11:49:30 -07:00
Volker E ee4dbd39dd Use opacity for aligning icon color
Also adding corresponding variable.

Depends-On: I6e43a32366802775ae05e94859e
Change-Id: Iba1b12817b1620db96096f7fad34db194ce0775c
2020-04-18 00:28:20 +00:00
Ed Sanders 2a52e7f15c build: Update linters
Change-Id: Iaf0c760d5a69bc41505b782ab9f05864c37c7196
2020-04-13 16:05:10 +01:00
jdlrobson 313f2ac220 AMC History page design tweaks
Since a few months ago this page has regressed with changes to the
other pages e.g. Special:RecentChanges

Since the history page has its own stylesheet these styles can be
applied safely without worrying about them impacting other pages.

Change-Id: Ia8d038b6d22a3fe1b537aebe483d5d1683d785a2
2020-04-03 06:42:45 +00:00
jdlrobson ae2c0279d7 Also break word in .mw-contributions-title
Bug: T237230
Change-Id: I15b8d824b73e659ce17f71e9dad85fd7c0b55dbc
2020-03-27 02:04:11 +00:00
jdlrobson e56302a3f6 Break title on watchlist and scope non-hyphenated links
Non-hyphenated links according to T230860 were added for
infoboxes but the default is no hyphens so these no
longer should be needed. It was likely working around
a recently removed bit of CSS in MediaWiki:Minerva.css
(See T248415)

The new selector is needed for Special:Contributions

Bug: T237230
Change-Id: I500ca1a6182f505ceb31441c49e4dcacd597a5d3
2020-03-27 00:30:54 +00:00
Jack Phoenix 004d265c16 Only hide the "remember me" checkbox instead of all (incl. extension-added) checkboxes on Special:UserLogin
Bug: T246135
Change-Id: Ie6102ff8060d32a24cce80914db6eeb7bfaf0ab1
Depends-On: 322a43583cc6e5908bc3f1d17622737c47f62600
2020-03-25 11:20:00 +02:00
jdlrobson 6c6cfac189 Limit title on Special:Watchlist and Special:RecentChanges
Bug: T237230
Change-Id: I8e5e833290ce1968d4610554411f36c92b56e9b7
2020-03-23 16:27:51 +00:00
Umherirrender 53fab7c03d Always enable stylelint rules after disable
Change-Id: I3c677fb6e3ff9666e8e50f3a2ad9cd9ac57c29b8
2020-03-11 15:50:14 -07:00
Volker E 30fbd44efd Reduce selector specificity to necessary minimum
Further reducing selector specificity. `.action-history` does
a sufficient job.

Change-Id: I9393316b28aa86d99797a03ca164a589f5a942a9
2020-03-05 14:00:43 -08:00
Volker E f955bda480 Word-break overlong usernames
Also de-specify styles, we're already in `.action-history`, specificity
resulted from form elements below.

Bug: T237230
Change-Id: I82d9ab071084624025f1c723d2772a409750dbc9
2020-03-05 13:28:35 -08:00
jenkins-bot 00f515cce5 Merge "Reduce margin in icon and label combination" 2020-02-26 18:50:27 +00:00
jenkins-bot c81c1432d0 Merge "PageActionsMenu: Reduce spacing between icons and text in tablet mode" 2020-02-26 18:50:25 +00:00
jenkins-bot c583930c0c Merge "Remove 'new' indicator styles on mobile options" 2020-02-24 21:52:17 +00:00
Volker E 328f46379d Remove hover background on clear indicator
Align to standard component design. Clear indicator doesn't receive
background hover in an input.

Change-Id: Ibf329b450c6dd1c9913744ab1f6f4af13ec6a35f
2020-02-20 08:25:28 -08:00
Volker E d7039ab8ac Remove 'new' indicator styles on mobile options
These have been only in use for AMC, in case we need them again, we
will bring them back.

Bug: T245654
Depends-On: I0bfcbd9378b3fea4d532b78b250ce05a13f71edb
Change-Id: Ibdb69e92de5a0cf20413b0fb576a6797f7bf1771
2020-02-19 19:50:01 +00:00
Volker E a34f9853b5 Ensure hover state is only available on active elements
Exclude disabled icon elements from visual hover feedback.

Change-Id: I0a77f90b1a9a098d2201a360e08541fb718cbf91
2020-02-14 18:51:54 +00:00