Commit graph

739 commits

Author SHA1 Message Date
jdlrobson 8ad57f9b0e QA: Stabilise browser tests
Changes:
* Default skin is not configured so noticed on test runs it's using
Default skin for desktop mode. Given this has no footer and way to
switch to mobile this could be problematic in future.
* Remove empty README
* Drop suggested language integration test - setting up interwiki links currently
happens via InterwikiLoadPrefix hook however this seems to be unreliable. The beta
cluster is a much more reliable place to test language links so let's rely on that
instead.
* Drop unnecessary heading check from "Successful edit" scenario. It's unnecessary
and flakey (presumably given the title doesn't change)
* Rename test scenario and remove a duplicate scenario

Depends-On: I888b3c546f77fa350853a7bf9bfbfbeb8ed6de67
Change-Id: I45792a95df7fd4c3299accbffadfa447baefe0ce
2018-06-08 19:59:05 +00:00
Translation updater bot f44487d966 Localisation updates from https://translatewiki.net.
Change-Id: Iaf0ca081057af1c691a4edc6d3da674b2d8ea140
2018-06-07 23:22:44 +02:00
jenkins-bot a0dfcf4e75 Merge "Add "center" layout rules based on mediawiki.skinning in core." 2018-06-06 12:33:55 +00:00
Jan Drewniak 81ef4caaa7 Add "center" layout rules based on mediawiki.skinning in core.
Bug: T193595
Change-Id: I2fa991c68786be95a82132ff720ed6e61074bc99
2018-06-06 11:46:40 +00:00
jenkins-bot 92a6e01791 Merge "Provide gender parameter" 2018-06-06 08:22:36 +00:00
Translation updater bot cb451329df Localisation updates from https://translatewiki.net.
Change-Id: I92744971543f5887470e4617d0a245bea875d6c2
2018-06-05 22:01:16 +02:00
Piotr Miazga 52e8e93020 Provide gender parameter
Bug: T194868
Change-Id: I20fb6aee13c6bf7bc66bf3cae9560548a336e04d
2018-06-05 16:40:11 +02:00
Translation updater bot b3a4721574 Localisation updates from https://translatewiki.net.
Change-Id: I4bc48e46f892ebc96c949ddb7d8c00dc0f847f70
2018-06-04 22:30:15 +02:00
David Lynch e91295a5ea Fix action!=edit opening the editor
Bug: T196150
Change-Id: I5bd4b5ce231f5269676d0706e6762f33f6faa344
2018-06-04 10:20:22 -05:00
Translation updater bot ec83db7d2d Localisation updates from https://translatewiki.net.
Change-Id: If0651c8ef93de7d48817a4601ced88ffad347b50
2018-06-03 22:19:08 +02:00
Translation updater bot 32c067a48b Localisation updates from https://translatewiki.net.
Change-Id: Ide2d306b112d242542927d141a34cfe792d601c3
2018-06-02 22:27:07 +02:00
Translation updater bot 6614ffba59 Localisation updates from https://translatewiki.net.
Change-Id: I1b90996e0889ee8fb1105ade08bc0bf643cbfb31
2018-06-01 22:07:11 +02:00
jenkins-bot 86330f25d8 Merge "Don't turn off listening to reference clicks" 2018-05-31 20:19:25 +00:00
Translation updater bot e2b81c328a Localisation updates from https://translatewiki.net.
Change-Id: I70b88aff9e93c8f3f5d2a3691c9b0ff581ac3ddd
2018-05-31 22:12:03 +02:00
Baha ee9ec00234 Don't turn off listening to reference clicks
For event logging purposes we need to be able to listen to reference and
backlink clicks. Clicks on these elements were disabled before this patch.

Although clicking on backlinks was disabled, it wasn't working properly
as the user could click on those links and be taken to the reference.
Thus this piece of code has been removed.

Bug: T191086
Change-Id: Idbaa39523a35f3b649f521be05c83255aa2b1396
2018-05-31 20:10:31 +00:00
Volker E 8f0e102211 Remove special font-size treatment of VE overlay
Reverting of I6b8a031c2d78785604070ff5fc1c7242bbbc080f as first step
of resolving issues and complex inheritance of VE mobile tools CSS.

Bug: T195791
Change-Id: Ief66c0d3565d3b67399e5aa2a749035a9a4b47bc
2018-05-31 17:36:58 +02:00
Translation updater bot 4e19596f26 Localisation updates from https://translatewiki.net.
Change-Id: Id4df4c0da2588440704a5d88e162c30870574b85
2018-05-30 22:09:59 +02:00
Fomafix 648491015c Allow type Language for $lang of doEditSectionLink
wfGetLangObj() allows type Language already.

Change-Id: Ibe295e7020e995eea52e319feaf59c635f8bb4dc
2018-05-30 14:40:25 +00:00
jenkins-bot e08d4a4af4 Merge "Edit infobox style to properly position captions" 2018-05-30 09:54:26 +00:00
Translation updater bot 9902ac7a03 Localisation updates from https://translatewiki.net.
Change-Id: I96ab03135b2b9934c29758d3d0cc6032d325338e
2018-05-29 22:05:24 +02:00
Timo Tijhof 64134bd8a6 Remove minerva.less from global import path
Use local imports instead given all relevant files are within the
same repository, and don't vary by configuraion.

Bug: T140807
Depends-On: If3edac9a35b346af0320c12f70c0d978a6346201
Change-Id: Ife3cc345a63aff452e93accbe0a593fbaa358732
2018-05-29 12:19:00 +00:00
Timo Tijhof 91a3adacb7 Move remaining Minerva skinStyles from MobileFrontend
To be removed in MobileFrontend by If3edac9a35b346a.

Bug: T140807
Change-Id: Ifb073d1e67602b80e0e9b45f338806f5b9cb675b
2018-05-29 09:30:48 +00:00
Piotr Miazga 5a1a9c1b03 Add gender support to skin-minerva-blocked-drawer-creator-header
Bug: T194868
Change-Id: If0ab25dd349a8fc90a7818fc6af257199b5f7f99
2018-05-28 22:51:12 +02:00
jenkins-bot 1ede203d0e Merge "Use . operator instead of + operator" 2018-05-26 21:25:40 +00:00
libraryupgrader a47d585583 build: Updating mediawiki/mediawiki-codesniffer to 20.0.0
Change-Id: I3c15fa6f6f54a24d35697d50556024482a6b854d
2018-05-26 08:37:53 +00:00
RazeSoldier 91f285127e Use . operator instead of + operator
String concatenation should use . operator, not +, otherwise it will
report some Warning

Bug: T195645
Change-Id: Id27c981622e5ed87519324193abd2249aa1df7b6
2018-05-26 16:37:41 +08:00
Translation updater bot 57a959c483 Localisation updates from https://translatewiki.net.
Change-Id: I2c5aa7b04b84aa7221609f61bf59d4b7766a1e69
2018-05-25 21:59:39 +02:00
Translation updater bot 71e013d03e Localisation updates from https://translatewiki.net.
Change-Id: I1849199be856df8c3899cdff28db445a6a46b2e5
2018-05-24 21:56:08 +02:00
Jan Drewniak 03a7b57a20 Edit infobox style to properly position captions
Bug: T193881
Change-Id: Ie20dafc0fbf02d654cd9ac137f51ef1436ca97f1
2018-05-24 14:19:58 +02:00
Translation updater bot 773bd3173e Localisation updates from https://translatewiki.net.
Change-Id: I57a255e71cdd23145b09744414699035f3269ce9
2018-05-23 22:05:15 +02:00
Translation updater bot 22265d7483 Localisation updates from https://translatewiki.net.
Change-Id: I4278d56a5a4b3cd714b43ac6383e2cbfae047c9d
2018-05-20 22:27:24 +02:00
jenkins-bot 43a459bf5f Merge "Intercept desktop editor links" 2018-05-20 17:10:55 +00:00
David Lynch ea0ef071a2 Intercept desktop editor links
Make ?veaction=edit/editsource and ?action=edit trigger the appropriate mobile
editing mode.

Bug: T185729
Change-Id: I2275b011d2b3c03462e3c1711d3135ce672596e8
2018-05-20 12:41:21 +02:00
Translation updater bot 22022a5a3e Localisation updates from https://translatewiki.net.
Change-Id: Ie3f6db40744ed18c716c58557b439e70aef62ee9
2018-05-18 22:26:15 +02:00
Translation updater bot 72d16027de Localisation updates from https://translatewiki.net.
Change-Id: I604553a9390b8b1d7479f7add9c747ccaf2747eb
2018-05-17 22:02:59 +02:00
Translation updater bot e69310377c Localisation updates from https://translatewiki.net.
Change-Id: Iea0b3488ca0180619ad1730655eb9a5601a5e7d2
2018-05-16 22:48:52 +02:00
Translation updater bot cde5afffc5 Localisation updates from https://translatewiki.net.
Change-Id: I308461e3fdb2cfd9518d505581bf9a1073032b69
2018-05-15 22:02:58 +02:00
Translation updater bot c9423aaeb9 Localisation updates from https://translatewiki.net.
Change-Id: I566a5769c0a110bdcfb59307e67789bd27ea7e4d
2018-05-14 22:20:43 +02:00
Translation updater bot 45ae96c616 Localisation updates from https://translatewiki.net.
Change-Id: Iba7176b6a224a5dc03ca806f9e28780ee3f8e844
2018-05-13 00:33:11 +02:00
Translation updater bot 90b195af3b Localisation updates from https://translatewiki.net.
Change-Id: I8f965967bba7c3c53e4e325d264e86e58a21f16b
2018-05-11 22:04:44 +02:00
Translation updater bot ed845c44d6 Localisation updates from https://translatewiki.net.
Change-Id: Ib1562546210f1a7f0f21d3cb3a24a3cf8b79b60c
2018-05-10 22:06:17 +02:00
Translation updater bot f19b8c8420 Localisation updates from https://translatewiki.net.
Change-Id: I955fd3f9ca2b1311b839f9f8d796932ea29b8b3b
2018-05-09 22:24:46 +02:00
jdlrobson f7e8df65b2 Merge profile icon with user-avatar icon
Both are the same but different variants - so use the variants
ResourceLoader module to keep this modules consistent in color
and form.

Change-Id: Ib75e1ff741fa46ad9698e89c4433b6edbad4d376
2018-05-08 23:35:44 +00:00
jenkins-bot d32e74d46c Merge "Use a Drawer for Block Notices" 2018-05-08 21:11:47 +00:00
Translation updater bot 78bb624d7a Localisation updates from https://translatewiki.net.
Change-Id: I1b345dfa0c101e2082a91c76425be373f19059a6
2018-05-08 22:00:53 +02:00
David Barratt f51cf7db7b
Use a Drawer for Block Notices
When a user is blocked, the toast message provides insufficent information to
the user. To provide more information, as well as a better design, the block
message will be moved into a drawer.

Bug: T165535
Change-Id: Ib025db3a8a4d1fd7bd05b69f9b5326943288372f
Depends-On: I926918d0bd7f2176f188a2154dc5e99f6a8a7ad1
2018-05-08 13:20:00 -04:00
jenkins-bot 4d0474e90a Merge "Move skin metadata keys to top of skin.json" 2018-05-08 16:21:40 +00:00
Stephen Niedzielski 9ccad5a405 Hygiene: replace calledOnce / Twice w/ callCount
Replace all test assertions for calledOnce / Twice with callCount.
assert.ok( calledOnce / Twice ) only lets the dev know that a test
fails. assert.strictEqual( callCount, EXPECTATION ) starts the debugging
process when it fails since it provides the difference in the failure
output. strictEqual() was deliberately used since it's a saner default
and the codebase already favors === equivalency checks.

  find tests -name \*.js|
  xargs -rd\\n sed -ri '
    s%ok\(([^,]+)calledOnce%strictEqual(\1callCount, 1%g;
    s%ok\(([^,]+)calledTwice%strictEqual(\1callCount, 2%g;
  '

Change-Id: I5c4c595c4520cecfad46d652f639a63a1c2c00b4
2018-05-08 16:12:04 +00:00
Kunal Mehta e07e5103a4 Move skin metadata keys to top of skin.json
The keys that form the credits (name/description/url/etc.) are usually
on top, and manifest_version is typically on the bottom.

Change-Id: I1767b1e176c9cf892c1f627db4f5891fa6aade18
2018-05-07 18:19:40 -07:00
Translation updater bot dcc69d816f Localisation updates from https://translatewiki.net.
Change-Id: Ia197cc2e1789266824e55a67a539208600508a3b
2018-05-06 21:55:01 +02:00