Copies approach for the text of the first heading should be
accounting for the fact that the toast can have an empty
message "" at any given time.
Bug: T170890
Change-Id: Iba8a503a2aea30cb46fba27f000843183e9c46f1
A toast autohides within 5 seconds and its display properties are
inherited from #mw-notification-area. This slight tweak waits for
mw-notification-area to be visible before verifying toast and its
contents
Change-Id: I89beaf9d131155e958cc9aae84a9e30ffd8e9e4f
The `getLeadSectionElement` method of `Page` may return a `null`. Do
not try to access the `text` method of the returned object if it's
`null`.
Bug: T157995
Change-Id: Ia752fa52d1b09a307dc4b803a6b7e1bdcfe7f867
The string '0' evals to false in the if( $pageTitle ) condition, hence
the title was not shown for the page named '0'.
Bug: T163084
Change-Id: I27ab379bf67634c484c4cf5e12e391d69702f464
This brings Parsoid styles when viewed in Minerva consistent with
MediaWiki parser output styles.
You can verify this with:
https://gerrit.wikimedia.org/r/#/c/368287/
Bug: T171727
Change-Id: If4bd7671a99aefdf074061dd1d5b0bac93620e9e
Introduces a new generic
"I should see a toast with message ".*""
step reducing toast steps to two generic ones.
Change-Id: Ic8b91c78f6df088244f15223ee4ed658847a05b5
Changes:
- removed MobileFrontend existence check from MinervaHooks
- added MobileFrontend as a requirement inside skin.json
Additional benefit: Skin will work only with MobileFrontend v2.0.0
and higher.
Change-Id: I1f2f5de3dbc0cf5159a06bc8f47e1cf401a2fcdb
* Add global View and Page
* Remove inheritdoc statements for globals - docs
cannot be inherited from a class defined in another repo
Note:
you'll need to `gem install jsduck` for this to work
Bug: T170639
Change-Id: Idb3a6e9edbd45889047e7904561b84033569a689
Changes:
* Update docs
* Update browser test artifacts
* Update comments
* Update phpunit test groups
* Update phpunit test namespace
* Update `die` when MobileFrontend not installed
* Remove the migrate script which is no longer needed
Change-Id: I83432b3f7f0bcd07ed08259972b8ff89147104b6
stylelint is part of config, but not run by default
Also update to 0.4.1, it is the current default in many wmf extensions
Change-Id: I55f81489182628c088e362e081417514e252e6d6
Because there is no easy way to detect failed user login/account
creation, do not show warning box during POST request. This should
do the trick as there shouldn't be possible to display valid
login/usercreate form during POST request.
Bug: T149413
Change-Id: Ieb7a34068aaad99616ad6c43de48f70a6775882e
Depends-On: I6ba28ddaeb0f9af17fa875bd9d1265509db4b927
* Get ConfigFactory via its accessor, not getService()
* Avoid array_merge, use simpler syntax
* Don't use string interpolation when one variable is the entire string
Change-Id: Ic4c138fb3b83e6e9c6ff9a001dd39e03ca5029b1
Sniffs that are currently failing are disabled in phpcs.xml.
Additional changes:
* Fix problem in test file
Change-Id: I53642e9d7bc1ef96e359cfe04a8f93dabbc977eb
Test scenario for getContextSpecificModules() mocks only Skin->getTitle()
behavior, but while executing isAllowedPageAction() Skin will create a
UserPageHelper with default RequestContext. As RequestContext is not mocked,
$context->getTitle() will return undefined what could lead to tests crash
Changes:
- instead of mocking SkinMinerva::getTitle() pass test context with injected
title. Other tests will work properly as MediaWikiTestCase::tearDown() always
restes RequestContext to default
Bug: T170624
Change-Id: I872fddf8d9c52a6875bb6c69a12407a8125fba4c
