8 commits

Author	SHA1	Message	Date
Timo Tijhof	548e94da98	tests: Adopt private require() for skins.minerva.scripts ... Added to MediaWiki core last year with I9fca9fdf9b7623b1. This fixes a confusing assertion in page-issues/index.test.js, where for "insertBannersOrNotice()" it was asserting that the HTML contain "⧼skin-minerva-issue-learn-more⧽", where the ⧼ character indicates the message is not found (i.e. an error). The test had to be written this way in order to pass, because the skins.minerva.scripts module was not actually loaded, and thus its templates and messages are not present either. This lack was filled in by index.js for mw.templates, but not mw.messages. By adopting private require(), these workarounds can all be removed. == Motivation == In change I3a4024ccf90e505581, I'm working on improving the testrunner config to enforce uselang=qqx on all tests. This is passing except for GrowthExperiments and Minerva, both of which have the above workarounds in place that caused a message to be undefined, and then kept in the assertion expectation. When using uselang=qqx, values are returned as (key) instead of ⧼key⧽, which exposes these message existence errors. By removing this workaround, the test will simply import the module in the test as normal, thus the messages will exist, and thus it will expect (key), and thus it will continue to pass even after enforcing uselang=qqx. Change-Id: Ib68f45d93a7054ed8bd35fc5644e2852f2f90248	2024-08-23 19:04:36 +00:00
Ed Sanders	a6ab8d6da3	Prefer arrow callbacks (ESLint autofix) ... Change-Id: I52b2feacd6216e99e04f193ba963e897b3e1a771	2024-06-04 08:01:54 -07:00
Fomafix	c43cdce48c	Some small JavaScript/jQuery improvements ... Change-Id: I33feb8bccbd870f589a01dc187e6155b7498714c	2024-04-08 19:45:22 +00:00
Fomafix	effd4fe133	Use eslint rule "no-var": "error" and replace all var ... Change-Id: I67acf88e1b8de55054248d7cf8ca622d5772ea6f	2024-03-29 07:40:22 +00:00
Ed Sanders	8ef144f936	build: Update linters ... Change-Id: I5aa3ab891890b52057a5fc855315e5b1b2203037	2024-01-24 22:02:12 +00:00
Jon Robson	d342cb32ef	[Icons] Use Button template in PageActionsMenu. ... Use the Button.mustache partial in the PageActionsMenu.mustache template. This converts the page actions menu to use the Button template in a way that doesn't change the existing HTML. The mw-ui-icon-element and mw-ui-icon-with-label-desktop classes are placed onto the Button.mustache markup. Bug: T342908 Change-Id: Ib5dadd929eea2e72a24e061c4174348615890617	2023-08-10 19:27:44 +00:00
bwang	bcdfd66fa6	Use watchstar() instead of deprecated jQuery event to update watchstar classes ... Depends-on: I88af8585e8fc75f77ebef867d267199aeb2c6592 Change-Id: I859c9d763e77bb06b5109d419fb581258f3bd665	2021-12-21 16:43:57 +00:00
Dayllan Maza	0fc40f71c5	watchstar: Add temp-watched css class when expiry is present ... MobileFrontend extension is currently tracking watched/temp-watch css classes and applying animations to the "watch" event. This patch starts adding temp-watched accordingly now that the expiry is part of the event's data. Note: this patch does not fix the lack of animation when transitioning from half-star to empty-star or on page-load when the page is temporarily watched but it fixes the awkward angle the half-star icon was left in when transitioning from a full-star to a half-star Bug: T262862 Change-Id: I1c8cb9c33cda76b87b6a9f15e408d88edbf61d93	2020-09-24 12:21:33 -04:00