while read svgfile; do
SC2162: read without -r will mangle backslashes.
if [ $(wc -c < "$svgfile") -gt $(wc -c < "$outfile") ];
SC2046: quote to prevent word splitting
found increment was done in a subshell and hence would not be properly
incremented. Instead of:
find | while
Switch to:
while < <( find )
Based on https://github.com/koalaman/shellcheck/wiki/SC2031 , this way
$found is kept in the same context.
Change-Id: Id8eb1027eed373161c8e7932b7745d4f53f2fc6c
Adjust tagline margin per Nirzar:
https://phabricator.wikimedia.org/T180095#3801719
Note, this will enable the tagline everywhere.
Change-Id: I3bce2a3472ab2e53261965c953572f35cc740eed
Bug: T180095
This will use the srcset attrribute which was introduced with HTML5,
in order to load the svg image on supported browsers.
Should fix the bug after merging change 394820.
Bug: T166684
Change-Id: I2337b750c80e79c816dc817dfe230e063eed0345
Correct some options names and make minor adjustments to the
constructor function
Bug: T181348
Change-Id: Ia9fe9d2923b895d3dc530280e3987e27c88d3282
(cherry picked from commit 89909ccf53)
Replacing `#9aa0a7` with standard subtle `#999` print color.
Also clarfiying LESS variable naming and removing unused variable
`@printBorderColorLight`.
Change-Id: I2c1b36099935aa99d63a3316b3a107a23ffa0afd
The MinervaDownloadIcon config option is replaced with a
more specific wgMinervaDownloadNamespaces config option.
If the list is empty then the download button will not be
shown.
Since the download icon is enabled everywhere in production now
this is good as it means Minerva reflects the production value.
Bug: T181152
Change-Id: Id78c1de9e8e9013530106bc0d45d3cf0297897b5
On Special:MobileOptions we want to make the form take up the full
width but pad the fields in the form
(per https://phabricator.wikimedia.org/T180095#3795514)
This change is harmless but is necessary as soon as we port
the page to OOjs UI (I70f68df9d2d305126444319b05675702af75de87)
Bug: T180095
Change-Id: I1dda3eb4d0e7ebbec544dc0f5763b079e38f5cc8
* Create several sub functions to manage complexity of the history link
* Clean up MinervaTemplate to use data directly and remove isMainPage
template variable which is no longer being used.
Change-Id: I124aec9637f3635a335c58e559e578b2a56eb4c5
Looks like window.print may block so keep the spinner until
it's finished execution.
This may or may not fix the larger issue being discussed in the bug
but is harmless so why not.
Bug: T181261
Change-Id: I927d4bc8c96d74c14463f71b7ce6dec62618a485
If FlaggedRevisions is being used then older revisions will be
shown as if they are the current revision of the page. This causes
problems as it makes it hard to give a true indication of when
something was last modified - do you show the last time someone
made an edit or the last time someone approved an edit?
The same issue applies on revisions and we attempted to fix this
earlier in T153125 but in doing so caused this problem.
Bug: T180116
Change-Id: I6d47adf272c99791d4af9f97afa02799d495887e
When the print button is clicked, load all images from the page
before calling window.print
Add a timeout to make sure the user doesnt wait too long.
Change-Id: Ie922d239f9c5b5757237dc10b673fb500ff203ad
Depends-on: Id7f21606be3db22fe8dfde2db675f9905547cfea
Bug: T180058
Passing null to wfTimestamp will result in the current time.
Protect against that happening
Bug: T180103
Change-Id: I6ef9577bf52609bf387b0146f1d8a4a53be58cd7
Align SVG markup across Foundation products by:
- unifying XML declaration,
- adding `width` and `height` attributes where missing,
- removing all unnecessary `g` group elements where applicable,
- putting attributes in order,
- removing unnecessary ids and
- unifying whitespace.
Bug: T178867
Change-Id: I6860c9259553e0e41f7656f9e98534db8e02bbc2
In Id9b0e955d6e2a113f91484c7ee6bbc9275e3a2ec the css selector
was weakened and started impacting the footer as well.
This restores the old behaviour.
Bug: T180375
Change-Id: Ibfff6e249a3249ae2ee97d31fd50d2f5272a25ae
