Commit graph

4506 commits

Author SHA1 Message Date
Bartosz Dziewoński 50fc799b07 Fix various problems with print styles
These styles have drifted away from the HTML structure since they were
written in 2017.

General:
* Add some comments
* Replace complicated selectors with simple class selectors

styles.less:
* Hide section edit links (previously we relied on MobileFrontend
  styles, which one handled some cases - removing them in I9a88b80c2a)
* Show print footer, hide Minerva footer

header.less:
* Remove FIXME (resolved in c323c6858a).
* Fix hiding the search box. In 0bee6a1eb6 a <form> for the search box
  was added to the header, and these styles (using tag selectors) were
  not updated. Use class selectors instead.
* Remove styles for <h1>. The element was changed to <a> in
  a905b1c161, styles to override font-size etc. are no longer needed.
* Consolidate 'padding' rules and remove unneeded !important.

article.less:
* Replace the `[ class|='mw-content' ]` selector, which was not
  matching anything. It would match elements with `class="mw-content"`
  or `class="mw-content-…"`, but the node we're trying to style has
  `class="mw-body-content mw-content-ltr"` (since 7cda5b0bf8 in
  MediaWiki core). Use a class selector instead.
* Replace the `.mw-body > .content` selector too. While this one
  works, it is also needlessly complicated.

footer.less:
* Fix and simplify how last-modified info and license text is unhidden
  (while other parts of the footer remain hidden).
* Remove styles for .license. Unused since 1f2b7dff15, use the desktop
  footer added in that commit instead.
* Use the desktop footer for last-modified info, since it's more
  suitable for "archiving" (it has a date rather than time ago).

Bug: T323636
Change-Id: I21ef26355e3e6dd8b0c34ae933b7f5b0b222655c
2023-01-03 21:57:11 +00:00
Translation updater bot 0017d7e03c Localisation updates from https://translatewiki.net.
Change-Id: I3a4dcebbdd61d49f45d10649957b0485720048f1
2023-01-03 08:23:11 +01:00
Translation updater bot d337f69dc7 Localisation updates from https://translatewiki.net.
Change-Id: Ic3351ecb315268c480b658f25c39644c6e8ecc21
2023-01-02 08:47:14 +01:00
Translation updater bot b584bdd60f Localisation updates from https://translatewiki.net.
Change-Id: Iec6a00ecfd092ed0ba94cdf3111e028a59c2c970
2022-12-29 10:05:46 +01:00
Translation updater bot dbf1aae301 Localisation updates from https://translatewiki.net.
Change-Id: Ib5b9c66299442ff754d01a47fd6941b8e74ee15a
2022-12-26 09:13:53 +01:00
Translation updater bot f810583289 Localisation updates from https://translatewiki.net.
Change-Id: I0fb2f8918d9128871088008e862e1e9d06352ca1
2022-12-23 09:10:58 +01:00
Umherirrender b21e4a98bc Avoid use of deprecated User::idFromName
Use a UserFactory instead of getting an id and the user objects on
second request

Also replace another deprecated User class and use the injected factory

Bug: T325687
Change-Id: Id610ee39e0ef865b97f7ae8506188eea04a86ac5
2022-12-21 22:35:49 +01:00
Translation updater bot f88414ade9 Localisation updates from https://translatewiki.net.
Change-Id: I5b3ec5b1ebff3b67bf2a4a94e1fa328f3440f127
2022-12-21 09:22:31 +01:00
Translation updater bot 0511e5f2d7 Localisation updates from https://translatewiki.net.
Change-Id: I44ca3f23286a6bea4d5c70b4db1690df7a78bcf0
2022-12-20 09:32:30 +01:00
Translation updater bot ba16b35855 Localisation updates from https://translatewiki.net.
Change-Id: I77edfc01f8228c6e77969cf5f9ecafe770d2c4a0
2022-12-19 09:06:50 +01:00
jenkins-bot 8011edcecb Merge "Always show search results at full width" 2022-12-16 08:46:59 +00:00
Jon Robson 57f86745e9 Show the thanks button on mobile special pages
Now the confirmation step code works, we can show this button.
Update styling to generalize the thanks/rollback styling.

Depends-On: Ia03038e86c6a607c8b75eefedbf0285ca1a2f8c8
Depends-On: I5286e80f9dd683ba55b03664dc31de77c19722b7
Bug: T230657
Change-Id: Iab32d8b30d4f2d946ffdaefea72ca9b43448998d
2022-12-15 22:46:33 +00:00
Translation updater bot e51e33cac8 Localisation updates from https://translatewiki.net.
Change-Id: I43ad9141e14e1db164d269c5d5a4bfd9e81f9e48
2022-12-15 11:39:30 +01:00
Matthias Mullie 4a4f8f279e Always show search results at full width
Ieebc40073eb3d0c8a56ebc8aec3f060199943ddc lowers the breakpoint
at which search will break into 2 columns (search + interwiki),
in large part because the 2nd column will also be occupied by
Extension:SearchVue's side panel.

On mobile, Extension:SearchVue presents differently (directly
below a search result), so there's not as much need for a 2nd
column this early - wider search results are prefered.

Bug: T321377
Change-Id: I22c46cfad2e054be679d79cce9b8d1ae04e3c6f1
2022-12-15 09:38:36 +01:00
jenkins-bot 754b73c8e2 Merge "Tweak margins/paddings of Echo icons" 2022-12-14 16:43:52 +00:00
Translation updater bot 55dcffe98f Localisation updates from https://translatewiki.net.
Change-Id: I7025184e4fbd0c8120987596fdeaaacbb6b644c4
2022-12-14 08:18:02 +01:00
jenkins-bot 3c6a66d1af Merge "Use standard subtitle markup" 2022-12-14 04:13:59 +00:00
Bartosz Dziewoński 433458ba98 Tweak margins/paddings of Echo icons
On desktop, the "Alert" icon had more white space around it than the
"Notice" icon, and its popup displayed with a different offset.

On mobile, the combined icon jumped around while the page was loading.

Change-Id: Icdd5bc6e8478f3453b6461a35b7fb53e8ab014e9
2022-12-14 04:36:14 +01:00
jenkins-bot 97e2899a90 Merge "Show both Echo icons in desktop Minerva" 2022-12-14 02:49:55 +00:00
Jon Robson f6f2c4f1e4 Show both Echo icons in desktop Minerva
For consistency with desktop Vector, Minerva should show two
icons. This also removes the duplicate #pt-notifications-alert
element in the skin.

Bug: T313609
Change-Id: I6449f0c29b52fd2092d63fbef23205ed8f57d50f
2022-12-14 02:08:44 +00:00
jenkins-bot 3e73f6a4b2 Merge "Echo icon should reflect seen status" 2022-12-14 02:05:39 +00:00
Jon Robson 028ab69a8b Echo icon should reflect seen status
Bug: T310358
Change-Id: I681a2540979ceeca677e576fca2efd91e1b80e15
2022-12-13 16:21:50 -08:00
Translation updater bot 7bedd7215d Localisation updates from https://translatewiki.net.
Change-Id: I7b7ec8612fe9943f8631d8c4fd0d994c03a7bf61
2022-12-13 08:19:08 +01:00
Jon Robson 64fb00e237 Use standard subtitle markup
Bug: T324876
Depends-On: I8e538939a6d7d4474f2e96b93040f3c68c2f98ec
Depends-On: I4b178f67b6718fa9a84827e1804ec4eb1483f735
Change-Id: Ie24c0215d07d5e4605d8479ed9e950a3d9c9b086
2022-12-13 01:32:37 +00:00
Bartosz Dziewoński f8240fea6e Display correct numbers on the combined notification badge
Bug: T310559
Bug: T324690
Change-Id: If7568da5d34840853de43cd50a477a2aa9a18d0f
2022-12-12 23:39:25 +00:00
Translation updater bot 46620392bf Localisation updates from https://translatewiki.net.
Change-Id: Id1a789f237bfb449624c7a25f0ca32e9e8768a30
2022-12-12 08:24:53 +01:00
Translation updater bot 5322677701 Localisation updates from https://translatewiki.net.
Change-Id: I43cd2fb8b34391d75dc80a2a7bc822aabb65c3ae
2022-12-08 08:32:09 +01:00
Željko Filipin da92d66df1 selenium: Skip flaky test
"Wikitext Editor.Closing editor (overlay button)" is breaking CI in core.

Bug: T313775
Change-Id: I3dd3d196a09d7a62faf78d31239e3c8d00141704
2022-12-07 15:47:58 +01:00
Translation updater bot e842a49c7b Localisation updates from https://translatewiki.net.
Change-Id: Id1fa1e0a2e7f8adb5ff68beadfc19801a04cae04
2022-12-07 08:15:46 +01:00
jenkins-bot 073b4c5902 Merge "selenium: Delete failing test" 2022-12-06 15:16:27 +00:00
Translation updater bot 7b36d08895 Localisation updates from https://translatewiki.net.
Change-Id: I03b3b9c352e66750aefb50cc12e2372b2f95df66
2022-12-06 08:57:18 +01:00
Translation updater bot a373549a8f Localisation updates from https://translatewiki.net.
Change-Id: Ib15e58720bdf45ae5f95bf071698e9d9c6329239
2022-12-05 08:36:51 +01:00
Translation updater bot 564b2f35dc Localisation updates from https://translatewiki.net.
Change-Id: Id24bc04556f8b8957f40b9e874136f00b0a35ab5
2022-12-01 08:19:08 +01:00
Arlo Breault c4fe708a36 Remove b/c for media typeof
Bug: T270150
Bug: T203211
Depends-On: I44b3fb432dd00120a4d5cd5556ba5ba8bc4e65d5
Change-Id: I58d8ce9e2e58916d55c8d838c3fbfb96e2a05f02
2022-11-30 13:55:32 -05:00
Željko Filipin e4abf9c0fb selenium: Delete failing test
"Wikitext Editor (Makes actual saves).Broken redirects" is constantly
breaking CI in core.

I have enabled it in
b9a92ef717
but it isn't as stable as I thought.

Bug: T280652
Change-Id: I667f65a27fd420a3a70f39fb5e1606907e465897
2022-11-30 18:57:21 +01:00
Translation updater bot 69e842812a Localisation updates from https://translatewiki.net.
Change-Id: If9eef265cde98fb0495b5e5537eb63faf12efb3e
2022-11-29 09:00:46 +01:00
jenkins-bot 16bcb0e716 Merge "selenium: Enable one skipped test, delete one failing test" 2022-11-28 22:07:04 +00:00
Translation updater bot 68346a5953 Localisation updates from https://translatewiki.net.
Change-Id: Id5aa32cee13e4667ea1ccc96ba75ea9c576ee214
2022-11-28 08:52:37 +01:00
jenkins-bot 64047ef32e Merge "tests: Replace assertEmpty with assertSame" 2022-11-25 12:20:55 +00:00
Translation updater bot 093c4e4c6e Localisation updates from https://translatewiki.net.
Change-Id: Idb0b398ed365272c148f851399dc5f27162fedcf
2022-11-25 08:28:52 +01:00
Umherirrender 7346ac5494 tests: Replace assertEmpty with assertSame
assertSame avoids use of loose comparisons and
allows to check the expected type

Change-Id: Icd903f3b4397896380e2a087d0e8029920d7be92
2022-11-24 22:51:26 +01:00
Željko Filipin b9a92ef717 selenium: Enable one skipped test, delete one failing test
'Broken redirects' was disabled in 69a100cb45
'should be creatable' was disabled in 5e0dd88af0

'should be creatable' is failing so it is deleted.
'Broken redirects' is passing so it is enabled.

To be sure that the passing test is not flaky, the CI has ran it 100
times, it never failed.

Bug: T280652
Change-Id: I34a863dcbd126c2da8a98624e6ba1fa916eac0cf
2022-11-24 12:31:34 +00:00
Translation updater bot ef8bd6dc22 Localisation updates from https://translatewiki.net.
Change-Id: I3c34720a06a8d4dc57607a05cc4458a2f548615f
2022-11-24 08:20:19 +01:00
Translation updater bot 26da24b0fe Localisation updates from https://translatewiki.net.
Change-Id: I291472f8d87b27239e4d6e456d6f63d476e8ee0e
2022-11-23 08:35:31 +01:00
jenkins-bot c966853dca Merge "Remove styles for dd that cause content to be cut off" 2022-11-23 01:41:01 +00:00
Bartosz Dziewoński 4648848cbf Remove styles for dd that cause content to be cut off
They reference T160946, but in that task it was explained that the
problem was caused by faulty wikitext (T160946#3230740), so I don't
know why they were added.

Bug: T323640
Change-Id: I73d654d1f9127e22365d94909681c1c5f5f39597
2022-11-22 20:32:56 +01:00
Translation updater bot 6b62e8839a Localisation updates from https://translatewiki.net.
Change-Id: Ib1a018102cef4be894ed78e03b60bf2bef10ccb3
2022-11-22 08:36:22 +01:00
jenkins-bot e914576438 Merge "Disable auto-capitalization hint on search field of wikis with $wgCapitalLinks = false" 2022-11-21 13:24:21 +00:00
jenkins-bot aef8e35b3f Merge " HookRunner - Change PreferencesGetLayoutHook params" 2022-11-21 13:17:44 +00:00
Translation updater bot 723b1e5b28 Localisation updates from https://translatewiki.net.
Change-Id: Ife32ba07f1757c5f4a242fb6d6adb5b1ae844171
2022-11-21 08:19:22 +01:00