Commit graph

4507 commits

Author SHA1 Message Date
jenkins-bot e6fbd13fcc Merge "Revert "Use array instead of string for class list"" 2024-10-30 17:26:35 +00:00
Ammarpad 7ca5240292 Revert "Use array instead of string for class list"
This reverts commit c12f61709b.

Reason for revert: Does not work and broke the train

Bug: T378531
Change-Id: I3a91169276b8ebffbdf409aac4e3731298047196
2024-10-30 12:30:08 +00:00
jenkins-bot e5a54f9288 Merge "Use explicit nullable type on parameter arguments" 2024-10-29 18:15:45 +00:00
Translation updater bot c0c2ff2789
Localisation updates from https://translatewiki.net.
Change-Id: Icebd40c06cc4d168b86e4d0b200ad877ca6b3a89
2024-10-29 08:45:07 +01:00
Reedy ae6dc84fed Use explicit nullable type on parameter arguments
Bug: T376276
Change-Id: I646483668294133240d43a34ce74b6ca1060f848
2024-10-28 22:23:56 +00:00
jenkins-bot ecd660e0f7 Merge "Use array instead of string for class list" 2024-10-28 18:20:07 +00:00
jenkins-bot 3f733beaad Merge "Use PHP type hints in PHPUnit tests" 2024-10-28 18:20:06 +00:00
Ammarpad 6a655ccb2b main menu: show login link (for anon) on private wikis
Bug: T376975
Change-Id: I6e40fa531b98a00fc4bb69446d45db3a26258c06
2024-10-28 16:34:22 +00:00
Translation updater bot c4f9350a46
Localisation updates from https://translatewiki.net.
Change-Id: I81be52701f1e87a23591e4c6a8c31e708b62f9f1
2024-10-28 08:27:15 +01:00
jenkins-bot 6deafc4d64 Merge "Use '' instead of false for parameter $className" 2024-10-28 06:29:16 +00:00
jenkins-bot 67136c0350 Merge "Partial Revert "Make sure contributor's name is on its line"" 2024-10-28 05:04:50 +00:00
Jdlrobson b130c93b8f Partial Revert "Make sure contributor's name is on its line"
This partially reverts commit f8d410fb98.
and replaces the selector with a selector that considers spans which have link inside them. This ensures the whole row remains clickable
and takes the user to the diff.

Reason for revert: Caused
https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Recent_changes_on_mobile

Bug: T378142
Change-Id: Iff944817d9fe1664a60ec30413c159247706a5e7
2024-10-27 21:35:04 +00:00
Translation updater bot 3bb2ed1c7c
Localisation updates from https://translatewiki.net.
Change-Id: I8728358c51baf5ec9329804f9e4dbf2f7991a8a6
2024-10-25 09:58:46 +02:00
matr1x-101 29219736a6 Allow IP information popup to overlay on top of "compare selected versions" box
Set bottom "compare selected versions" box to use z-index zero so IP information popup goes over "compare selected versions" box

Bug: T304944
Change-Id: Id78e643f73dbba740501c67912c869621786a4b3
2024-10-23 19:56:18 +00:00
Fomafix 9e4d83ec4f Use '' instead of false for parameter $className
SingleMenuEntry expects string|array for the parameter $className.
Currently the ltrim converts a false to a ''.

Change-Id: Icac8d41c01331cf7550e3592ee0366bdc561b547
2024-10-22 09:36:35 +00:00
Translation updater bot f20a565158
Localisation updates from https://translatewiki.net.
Change-Id: I9eca66886394b2e125f74df1479a347a7e3bfbf2
2024-10-22 09:31:20 +02:00
Ebrahim Byagowi f8d410fb98 Make sure contributor's name is on its line
There was an overlooked usecase in T377503 which regressed
by change of hidden characters in the core, this change
makes it possible to remove the last hidden character
there in I3f08595d654fbfe18627b44839eaa5c9fd38274c
and fix that overlooked usecase.

Bug: T377503
Change-Id: Ifb458f80f08d9c6f717f4c035c7d5120cccb04cf
2024-10-21 23:26:41 +00:00
Fomafix c12f61709b Use array instead of string for class list
This change avoids manual handling of the class separator spaces.
The rendered HTML doesn't contain multiple spaces in sequence anymore.

Change-Id: I1614281c704558fe2536951975a860ee406d9079
2024-10-21 21:28:20 +00:00
Fomafix 229a610ae7 Use PHP type hints in PHPUnit tests
* Add PHP type hints to private functions.
* Remove @param and @return if redundant to type declaration.

Change-Id: I40df9579af92ad1af820d3706a8cd907e9950ce2
2024-10-21 19:20:00 +00:00
Translation updater bot c3efe290b1
Localisation updates from https://translatewiki.net.
Change-Id: I278325f088b444c0e6f4cd23ff0df8291b826fc8
2024-10-21 18:20:26 +02:00
Translation updater bot ec1ae7672a
Localisation updates from https://translatewiki.net.
Change-Id: Ief39910bac39a3bfb84afab4673bfc461c7ec051
2024-10-21 09:22:50 +02:00
Umherirrender 8ade6611aa Use namespaced classes
Changes to the use statements done automatically via script

Change-Id: I17aa533bb81078ec68f67e81e44f9a66477b61ab
2024-10-20 09:28:03 +02:00
Translation updater bot 32e0995048
Localisation updates from https://translatewiki.net.
Change-Id: Ia1030ae4c53f59205799475df569f0f8fbae10e8
2024-10-18 09:27:20 +02:00
Translation updater bot e6add2d133
Localisation updates from https://translatewiki.net.
Change-Id: I63bab03aeb86301787764f9083093ab3374f7ec8
2024-10-17 09:24:44 +02:00
Jon Robson 98521bbb68 Drop base20 icon class suffix
Following the migration to Codex, icons do not need suffixes for
their icons.

If we merge this now, we don't need to worry about caching when working
on Bug T266361.

Bug: T266361
Change-Id: Iafeb21858c89df1af35660eb63889fa5335e2b34
2024-10-16 15:15:47 -07:00
jenkins-bot 1f218c4511 Merge "Fixes markup for logout link" 2024-10-16 21:12:32 +00:00
Jon Robson 710d1f7cd4 Fixes markup for logout link
With AMC disabled, the logout link does not have the class
menu__item--logout - this breaks the behaviour of the logout
function which has JavaScript that manages a confirmation
workflow.

The issue is a typo - class is mapped to classes in
SingleMenuEntryItem::getComponents

Change-Id: I891ed700edadfad80888120c6e0666b6e7589377
2024-10-16 10:40:33 -07:00
Željko Filipin b85fdb68d7 selenium: Delete tests disabled more than a year ago
Tests in the three deleted files were all disabled in 2022 and 2023.

Bug: T280652
Change-Id: I727acd43726075282f10811c4529daad91ad71c5
2024-10-16 12:36:54 +02:00
Translation updater bot b4bcfa0db2
Localisation updates from https://translatewiki.net.
Change-Id: I1eae17733bdfcab2041f18d7b3e96063e55ed32e
2024-10-14 09:32:43 +02:00
jenkins-bot 3d1cbeb86c Merge "Reverse the watch star animation for RTL" 2024-10-12 11:12:16 +00:00
Jdlrobson 43ed38c2bc Revert "Fix missing wikibase link in Minerva sidebar"
This reverts commit 0585dea9f9.

Reason for revert: Moved logic for wikibase link into Wikibase repo (see 1079302)

Change-Id: I780baa6cd17f8b52ae4bae88e6686c22760f410d
2024-10-11 11:58:51 +00:00
Ebrahim Byagowi 4323ad1478 Reverse the watch star animation for RTL
Bug: T376898
Change-Id: Idb5bb4d57dfe7eac25d4568b1a470b98a8582d02
2024-10-11 12:43:18 +03:30
jenkins-bot 86d38f3428 Merge "Remove initial animation of watch star" 2024-10-10 22:05:30 +00:00
Ebrahim Byagowi 4c5bbc34ba Remove initial animation of watch star
It moves watchStar.less from .scripts to .base as star is
visible also when JavaScript isn't enabled so the right
time to apply styles to it isn't after scripts are added
but right from beginning to avoid initial animations.

It also limits minerva-animations-ready to transition
as that's the only style that needs page load to actually
happen and otherwise the styles will be limited to
JavaScript clients which isn't intended here.

Bug: T376872
Bug: T376559
Change-Id: I394d21689cae01822cf8791b361cd450771f5c31
2024-10-10 13:25:59 +00:00
Translation updater bot cd9018dc05
Localisation updates from https://translatewiki.net.
Change-Id: Idc73e290950de6a35e21e6728ed38ef1aadf0713
2024-10-10 09:24:05 +02:00
Translation updater bot c2a675b1b6
Localisation updates from https://translatewiki.net.
Change-Id: I4e3d6d6c15f3ef3dbee447ab57a80ba8a5f93341
2024-10-08 09:48:35 +02:00
jenkins-bot f54a40080e Merge "Cleanup: Drop unused code in Minerva" 2024-10-08 01:19:05 +00:00
Jon Robson 9435136ac0 Cleanup: Drop unused code in Minerva
The configuration flag $wgMinervaPageIssuesNewTreatment
no longer exists.

Change-Id: I1b3d928479cbfe47bb46214eef7936f4e8edd7dc
2024-10-07 11:34:42 -07:00
Jon Robson ca232770db Strengthen CSS selectors for Minerva Echo icons
The .minerva-icon rule sets a transparent PNG. If rules are loaded
before (as in the case of Echo) they get overriden. Make these rules
more specific so they do not apply.

Bug: T376491
Change-Id: Ia5399fa500df69b0a0d34931e30d961fe62a2124
2024-10-07 18:16:40 +00:00
jenkins-bot ad43e50cc8 Merge "selenium: Document when, how and why a test is skipped" 2024-10-07 14:32:12 +00:00
Željko Filipin 35800f195b selenium: Document when, how and why a test is skipped
Bug: T280652
Change-Id: I444ae022d34c7a263abfc60370fb9341413efb4b
2024-10-07 15:58:11 +02:00
jenkins-bot dadcab3f32 Merge "Fixes Watchstar display when clicked" 2024-10-07 13:52:39 +00:00
Translation updater bot ace70b75cf
Localisation updates from https://translatewiki.net.
Change-Id: Ia8ba75f62f3ea5e4c5853e97d04634c032b9ff86
2024-10-07 09:29:13 +02:00
Jon Robson fa7c131470 Page issues overlay should not show bulleted list icons
Seen on [[en:The_Black_Stork]] when clicking the page issue banner
while testing the links patch.

Change-Id: Ic9417dbe6f08bd4ada8a882b55646e76ae6c5589
2024-10-05 00:13:01 +00:00
Jon Robson 3bf80a62ef Fixes Watchstar display when clicked
Bug: T376359
Change-Id: Iaeda67b6ef063596a9c4ba43084aa6bc2472e0e7
2024-10-04 19:52:18 +00:00
Jdrewniak faf428550b Use :where() for link styling
Bug: T376394
Bug: T376361
Bug: T376126
Bug: T376098
Bug: T376363
Bug: T367892
Bug: T375994
Change-Id: I91b34a1b2bffaf1bebe2d60abd8b44877182d45e
2024-10-04 19:20:43 +00:00
ksarabia 678d02b1cd Fixes the notification circle button
* The switch to mask-image caused the regression
* Adds rule for notification circle to disable mask-image

Bug: T376414
Change-Id: I777d30458202698966ed8facfa4f7c1210d4feb2
2024-10-04 17:55:54 +00:00
jenkins-bot 5089a7d10f Merge "Disable unused icon variants" 2024-10-03 19:01:20 +00:00
bwang ca85c75536 Add minerva__tab-text class
Bug: T376363
Change-Id: I3aad38dac8029692556faebab4795784c776881f
2024-10-03 12:50:54 -05:00
Jon Robson 1b38bfbfc6 Disable unused icon variants
By default this module was inheriting variants and since it doesnt declare a
property selectorWithVariant it was using the default selectorWithVariant
rule which impacts OOUI icons.

Explicitly disable the variants for this module as they are unused. This
reduces the size of the modules.

Follow up to: I87b060cf98194d81679da2610944f58e8d941389

Bug: T374145
Bug: T376226
Change-Id: Icc008449ee498a946066c4ce5d46adcac194bd3b
2024-10-03 17:15:25 +00:00