Commit graph

761 commits

Author SHA1 Message Date
Jan Drewniak 03a7b57a20 Edit infobox style to properly position captions
Bug: T193881
Change-Id: Ie20dafc0fbf02d654cd9ac137f51ef1436ca97f1
2018-05-24 14:19:58 +02:00
Translation updater bot 773bd3173e Localisation updates from https://translatewiki.net.
Change-Id: I57a255e71cdd23145b09744414699035f3269ce9
2018-05-23 22:05:15 +02:00
Translation updater bot 22265d7483 Localisation updates from https://translatewiki.net.
Change-Id: I4278d56a5a4b3cd714b43ac6383e2cbfae047c9d
2018-05-20 22:27:24 +02:00
jenkins-bot 43a459bf5f Merge "Intercept desktop editor links" 2018-05-20 17:10:55 +00:00
David Lynch ea0ef071a2 Intercept desktop editor links
Make ?veaction=edit/editsource and ?action=edit trigger the appropriate mobile
editing mode.

Bug: T185729
Change-Id: I2275b011d2b3c03462e3c1711d3135ce672596e8
2018-05-20 12:41:21 +02:00
Translation updater bot 22022a5a3e Localisation updates from https://translatewiki.net.
Change-Id: Ie3f6db40744ed18c716c58557b439e70aef62ee9
2018-05-18 22:26:15 +02:00
Translation updater bot 72d16027de Localisation updates from https://translatewiki.net.
Change-Id: I604553a9390b8b1d7479f7add9c747ccaf2747eb
2018-05-17 22:02:59 +02:00
Translation updater bot e69310377c Localisation updates from https://translatewiki.net.
Change-Id: Iea0b3488ca0180619ad1730655eb9a5601a5e7d2
2018-05-16 22:48:52 +02:00
Translation updater bot cde5afffc5 Localisation updates from https://translatewiki.net.
Change-Id: I308461e3fdb2cfd9518d505581bf9a1073032b69
2018-05-15 22:02:58 +02:00
Translation updater bot c9423aaeb9 Localisation updates from https://translatewiki.net.
Change-Id: I566a5769c0a110bdcfb59307e67789bd27ea7e4d
2018-05-14 22:20:43 +02:00
Translation updater bot 45ae96c616 Localisation updates from https://translatewiki.net.
Change-Id: Iba7176b6a224a5dc03ca806f9e28780ee3f8e844
2018-05-13 00:33:11 +02:00
Translation updater bot 90b195af3b Localisation updates from https://translatewiki.net.
Change-Id: I8f965967bba7c3c53e4e325d264e86e58a21f16b
2018-05-11 22:04:44 +02:00
Translation updater bot ed845c44d6 Localisation updates from https://translatewiki.net.
Change-Id: Ib1562546210f1a7f0f21d3cb3a24a3cf8b79b60c
2018-05-10 22:06:17 +02:00
Translation updater bot f19b8c8420 Localisation updates from https://translatewiki.net.
Change-Id: I955fd3f9ca2b1311b839f9f8d796932ea29b8b3b
2018-05-09 22:24:46 +02:00
jdlrobson f7e8df65b2 Merge profile icon with user-avatar icon
Both are the same but different variants - so use the variants
ResourceLoader module to keep this modules consistent in color
and form.

Change-Id: Ib75e1ff741fa46ad9698e89c4433b6edbad4d376
2018-05-08 23:35:44 +00:00
jenkins-bot d32e74d46c Merge "Use a Drawer for Block Notices" 2018-05-08 21:11:47 +00:00
Translation updater bot 78bb624d7a Localisation updates from https://translatewiki.net.
Change-Id: I1b345dfa0c101e2082a91c76425be373f19059a6
2018-05-08 22:00:53 +02:00
David Barratt f51cf7db7b
Use a Drawer for Block Notices
When a user is blocked, the toast message provides insufficent information to
the user. To provide more information, as well as a better design, the block
message will be moved into a drawer.

Bug: T165535
Change-Id: Ib025db3a8a4d1fd7bd05b69f9b5326943288372f
Depends-On: I926918d0bd7f2176f188a2154dc5e99f6a8a7ad1
2018-05-08 13:20:00 -04:00
jenkins-bot 4d0474e90a Merge "Move skin metadata keys to top of skin.json" 2018-05-08 16:21:40 +00:00
Stephen Niedzielski 9ccad5a405 Hygiene: replace calledOnce / Twice w/ callCount
Replace all test assertions for calledOnce / Twice with callCount.
assert.ok( calledOnce / Twice ) only lets the dev know that a test
fails. assert.strictEqual( callCount, EXPECTATION ) starts the debugging
process when it fails since it provides the difference in the failure
output. strictEqual() was deliberately used since it's a saner default
and the codebase already favors === equivalency checks.

  find tests -name \*.js|
  xargs -rd\\n sed -ri '
    s%ok\(([^,]+)calledOnce%strictEqual(\1callCount, 1%g;
    s%ok\(([^,]+)calledTwice%strictEqual(\1callCount, 2%g;
  '

Change-Id: I5c4c595c4520cecfad46d652f639a63a1c2c00b4
2018-05-08 16:12:04 +00:00
Kunal Mehta e07e5103a4 Move skin metadata keys to top of skin.json
The keys that form the credits (name/description/url/etc.) are usually
on top, and manifest_version is typically on the bottom.

Change-Id: I1767b1e176c9cf892c1f627db4f5891fa6aade18
2018-05-07 18:19:40 -07:00
Translation updater bot dcc69d816f Localisation updates from https://translatewiki.net.
Change-Id: Ia197cc2e1789266824e55a67a539208600508a3b
2018-05-06 21:55:01 +02:00
Translation updater bot ad38ab06f7 Localisation updates from https://translatewiki.net.
Change-Id: Id9f42b7c05c82fb0666d87092ba3737001c62922
2018-05-05 21:57:27 +02:00
jdlrobson 6267ac8ca0 Override 'core' styles for Minerva
Minerva purposely does not load mediawiki.legacy.shared
This should still be the same when setupSkinUserCss is
deprecated.

Change-Id: Ib2b19ba165a9d646a770702cdf1724509156b93e
2018-05-04 23:41:56 +00:00
Translation updater bot 77e4ffed91 Localisation updates from https://translatewiki.net.
Change-Id: I5b7020c88f6133a088e90028cb7c4c7120e3a64d
2018-05-03 22:05:06 +02:00
jdlrobson ddc1e2a30d Content area needs a z-index
The content area is the sibling of the overlay.
For the overlay to overlay it and its children it
must explicitly setting a z-index

additional changes:
* Move UI styles from skins.minerva.mainMenu.styles
to their more logical place (note skins.minerva.mainMenu.styles
is loaded via JavaScript unncessarily)

Bug: T193444
Depends-On: I7c0d02f073a2fe165a6027e3c6d1455e22c1b563
Change-Id: I8be31c7daf254e22ccaed81704cbcd2b638c54f6
2018-05-03 18:01:51 +00:00
Jan Drewniak 503756822c Run npm test as a pre-commit hook
Adds the `pre-commit` npm package which automatically
handles git pre-commit hooks via package.json and runs
`npm run test` by default.

https://www.npmjs.com/package/pre-commit

Requires an `npm install`

Change-Id: Ia5950242bced753c42fc804fd686bc239c335aa3
2018-05-02 17:18:16 +02:00
jenkins-bot 142bb570c1 Merge "Dequeue render blocking styles" 2018-05-01 17:26:10 +00:00
jdlrobson cf1629aa0d Improve use of whitespace on tablets
1) Remove collapsible heading rule
Introduced for T43401 this no longer seems to be needed
now that we do not support Blackberry's and infoboxes can
be floated within articles and is now creating a reflow

This addresses issues with floating on the United States
and Taiwan page.

2) Allow table's to float in tablet.
Only disable floats on mobile resolutions.

Bug: T193418
Change-Id: I64748e08516e1be4b53af22b6897560b7fc87632
2018-04-30 13:39:03 -07:00
jenkins-bot a44370b2b0 Merge "Regression: Avoid reflows on lazy image placeholders" 2018-04-30 18:13:17 +00:00
jdlrobson e7e1aa8229 Regression: Avoid reflows on lazy image placeholders
Now we are applying width: 100% to all placeholders we are causing
significant reflows for the entire page.

Restrict altering the height on only real images which can be distorted
by dimensional changes

Bug: T191893
Change-Id: I982d928273dc3b6f30974f2401760d5d44ce4b82
2018-04-30 10:53:03 -07:00
Jan Drewniak 0374ef64a0 Display content beside infobox instead of below.
Removing CSS rules that that push content below infoboxes.

Bug: T189688
Change-Id: I59736720b36f251c49a27a2dd7f5343d58629992
2018-04-30 17:33:08 +00:00
jenkins-bot 10c672acba Merge "Removing aqua-colored tap highlight color for links on android" 2018-04-30 16:46:11 +00:00
Translation updater bot d040616bf7 Localisation updates from https://translatewiki.net.
Change-Id: I0eaff6696cba7e7a933729976b98fb9c0c810a3b
2018-04-29 22:08:12 +02:00
jenkins-bot deef073013 Merge "Change strategy for undoing '.content table' overrides" 2018-04-27 18:53:59 +00:00
Timo Tijhof 1fd6ce6db2 Change strategy for undoing '.content table' overrides
This is effectively a no-op for Minerva itself, but
automatically fixes a bunch of bugs, such as the
lack of centerring on WikiHiero elements.

Bug: T184221
Change-Id: I0af4df2391be1fab3c93fcbfea6624074fc96414
2018-04-27 18:40:14 +00:00
jdlrobson e2d72f4ba1 Dequeue render blocking styles
The change in If9c8f0974e3a4b08e4a66d37f7f5adf67d73054e
will introduce styles that are incompatible with Minerva due
to the blanking of the content array. The styles content
array should also be blanked.

Bug: T42812
Change-Id: I3388c3c4f91cdbab11e89cdc95973b688d3f1ce7
2018-04-26 13:04:04 -07:00
Translation updater bot 54b6179efc Localisation updates from https://translatewiki.net.
Change-Id: I4beb5f4744bcbd8bcf989e2442838c668432f074
2018-04-26 21:58:37 +02:00
Jan Drewniak 65bd3bfbea Removing aqua-colored tap highlight color for links on android
Bug: T189627
Change-Id: I303b007dd1885115bbc85ff4edad7a812a721a26
2018-04-26 15:58:54 +02:00
jenkins-bot db26e58e1e Merge "Remove unused CSS code" 2018-04-25 22:43:07 +00:00
jdlrobson 026b1ff305 Remove unused CSS code
Remove:
* no-edit-js
* .content_block

Document existence of Parsoid selector
* mw-ref

Change-Id: I0cb695dd437f9e070d57adf60170788dd2047137
2018-04-25 15:16:05 -07:00
jdlrobson b7e1ef4468 Restrict lazy thumbnail placeholder width
Follow up to Ibbba75fcb978b3b049f4cb100f39146d39ebf6af
Bug: T191893

Change-Id: I62a11322ea236498cec464735e741aea173b4c63
2018-04-24 15:34:24 -07:00
Translation updater bot ea258c8e37 Localisation updates from https://translatewiki.net.
Change-Id: I563ec705ef9bdf6bf2a1c16dbac063880466855e
2018-04-24 22:01:45 +02:00
jdlrobson a03f159e55 Size restrict images inside noscript tags
Bug: T191893
Change-Id: Ibbba75fcb978b3b049f4cb100f39146d39ebf6af
2018-04-23 13:42:31 -07:00
Translation updater bot c31f546bc0 Localisation updates from https://translatewiki.net.
Change-Id: I4f5078ed0191559002d142de13e04f8df9a07166
2018-04-23 22:14:52 +02:00
Translation updater bot 06e5a0499b Localisation updates from https://translatewiki.net.
Change-Id: Ia766f2065a0008b59983f7ac45c922ad6df86f90
2018-04-22 21:56:07 +02:00
jenkins-bot f11c4e44f5 Merge "Restrict gallery styles to only pages which need it" 2018-04-20 21:19:57 +00:00
jenkins-bot 9007208281 Merge "Hygiene: Document that insertWatchlistMenuItem doesnt work for anons" 2018-04-20 20:32:47 +00:00
Translation updater bot 364a9b3e98 Localisation updates from https://translatewiki.net.
Change-Id: I83786dfbc026618855eafb635a5ceafde70e6970
2018-04-20 21:59:46 +02:00
Kunal Mehta f5b9a5d64c Let special pages redirect to the login page themselves
SkinMinerva::getPersonalUrl() is supposed to link to the login page if the
user isn't logged in, building a URL that will redirect them back to the
proper special page. Except the two special pages that use this function
will already automatically redirect to the login page if you're not logged
in.

Manually handling the redirect requries additional complexity, and
duplication of things like message keys.

Change-Id: Id5bfca1049f84e52476b179b8fdda50d030d7c1c
2018-04-20 01:11:40 +00:00