Commit graph

4376 commits

Author SHA1 Message Date
Baha ee9ec00234 Don't turn off listening to reference clicks
For event logging purposes we need to be able to listen to reference and
backlink clicks. Clicks on these elements were disabled before this patch.

Although clicking on backlinks was disabled, it wasn't working properly
as the user could click on those links and be taken to the reference.
Thus this piece of code has been removed.

Bug: T191086
Change-Id: Idbaa39523a35f3b649f521be05c83255aa2b1396
2018-05-31 20:10:31 +00:00
Volker E 8f0e102211 Remove special font-size treatment of VE overlay
Reverting of I6b8a031c2d78785604070ff5fc1c7242bbbc080f as first step
of resolving issues and complex inheritance of VE mobile tools CSS.

Bug: T195791
Change-Id: Ief66c0d3565d3b67399e5aa2a749035a9a4b47bc
2018-05-31 17:36:58 +02:00
Translation updater bot 4e19596f26 Localisation updates from https://translatewiki.net.
Change-Id: Id4df4c0da2588440704a5d88e162c30870574b85
2018-05-30 22:09:59 +02:00
Fomafix 648491015c Allow type Language for $lang of doEditSectionLink
wfGetLangObj() allows type Language already.

Change-Id: Ibe295e7020e995eea52e319feaf59c635f8bb4dc
2018-05-30 14:40:25 +00:00
jenkins-bot e08d4a4af4 Merge "Edit infobox style to properly position captions" 2018-05-30 09:54:26 +00:00
Translation updater bot 9902ac7a03 Localisation updates from https://translatewiki.net.
Change-Id: I96ab03135b2b9934c29758d3d0cc6032d325338e
2018-05-29 22:05:24 +02:00
Timo Tijhof 64134bd8a6 Remove minerva.less from global import path
Use local imports instead given all relevant files are within the
same repository, and don't vary by configuraion.

Bug: T140807
Depends-On: If3edac9a35b346af0320c12f70c0d978a6346201
Change-Id: Ife3cc345a63aff452e93accbe0a593fbaa358732
2018-05-29 12:19:00 +00:00
Timo Tijhof 91a3adacb7 Move remaining Minerva skinStyles from MobileFrontend
To be removed in MobileFrontend by If3edac9a35b346a.

Bug: T140807
Change-Id: Ifb073d1e67602b80e0e9b45f338806f5b9cb675b
2018-05-29 09:30:48 +00:00
Piotr Miazga 5a1a9c1b03 Add gender support to skin-minerva-blocked-drawer-creator-header
Bug: T194868
Change-Id: If0ab25dd349a8fc90a7818fc6af257199b5f7f99
2018-05-28 22:51:12 +02:00
jenkins-bot 1ede203d0e Merge "Use . operator instead of + operator" 2018-05-26 21:25:40 +00:00
libraryupgrader a47d585583 build: Updating mediawiki/mediawiki-codesniffer to 20.0.0
Change-Id: I3c15fa6f6f54a24d35697d50556024482a6b854d
2018-05-26 08:37:53 +00:00
RazeSoldier 91f285127e Use . operator instead of + operator
String concatenation should use . operator, not +, otherwise it will
report some Warning

Bug: T195645
Change-Id: Id27c981622e5ed87519324193abd2249aa1df7b6
2018-05-26 16:37:41 +08:00
Translation updater bot 57a959c483 Localisation updates from https://translatewiki.net.
Change-Id: I2c5aa7b04b84aa7221609f61bf59d4b7766a1e69
2018-05-25 21:59:39 +02:00
Translation updater bot 71e013d03e Localisation updates from https://translatewiki.net.
Change-Id: I1849199be856df8c3899cdff28db445a6a46b2e5
2018-05-24 21:56:08 +02:00
Jan Drewniak 03a7b57a20 Edit infobox style to properly position captions
Bug: T193881
Change-Id: Ie20dafc0fbf02d654cd9ac137f51ef1436ca97f1
2018-05-24 14:19:58 +02:00
Translation updater bot 773bd3173e Localisation updates from https://translatewiki.net.
Change-Id: I57a255e71cdd23145b09744414699035f3269ce9
2018-05-23 22:05:15 +02:00
Translation updater bot 22265d7483 Localisation updates from https://translatewiki.net.
Change-Id: I4278d56a5a4b3cd714b43ac6383e2cbfae047c9d
2018-05-20 22:27:24 +02:00
jenkins-bot 43a459bf5f Merge "Intercept desktop editor links" 2018-05-20 17:10:55 +00:00
David Lynch ea0ef071a2 Intercept desktop editor links
Make ?veaction=edit/editsource and ?action=edit trigger the appropriate mobile
editing mode.

Bug: T185729
Change-Id: I2275b011d2b3c03462e3c1711d3135ce672596e8
2018-05-20 12:41:21 +02:00
Translation updater bot 22022a5a3e Localisation updates from https://translatewiki.net.
Change-Id: Ie3f6db40744ed18c716c58557b439e70aef62ee9
2018-05-18 22:26:15 +02:00
Translation updater bot 72d16027de Localisation updates from https://translatewiki.net.
Change-Id: I604553a9390b8b1d7479f7add9c747ccaf2747eb
2018-05-17 22:02:59 +02:00
Translation updater bot e69310377c Localisation updates from https://translatewiki.net.
Change-Id: Iea0b3488ca0180619ad1730655eb9a5601a5e7d2
2018-05-16 22:48:52 +02:00
Translation updater bot cde5afffc5 Localisation updates from https://translatewiki.net.
Change-Id: I308461e3fdb2cfd9518d505581bf9a1073032b69
2018-05-15 22:02:58 +02:00
Translation updater bot c9423aaeb9 Localisation updates from https://translatewiki.net.
Change-Id: I566a5769c0a110bdcfb59307e67789bd27ea7e4d
2018-05-14 22:20:43 +02:00
Translation updater bot 45ae96c616 Localisation updates from https://translatewiki.net.
Change-Id: Iba7176b6a224a5dc03ca806f9e28780ee3f8e844
2018-05-13 00:33:11 +02:00
Translation updater bot 90b195af3b Localisation updates from https://translatewiki.net.
Change-Id: I8f965967bba7c3c53e4e325d264e86e58a21f16b
2018-05-11 22:04:44 +02:00
Translation updater bot ed845c44d6 Localisation updates from https://translatewiki.net.
Change-Id: Ib1562546210f1a7f0f21d3cb3a24a3cf8b79b60c
2018-05-10 22:06:17 +02:00
Translation updater bot f19b8c8420 Localisation updates from https://translatewiki.net.
Change-Id: I955fd3f9ca2b1311b839f9f8d796932ea29b8b3b
2018-05-09 22:24:46 +02:00
jdlrobson f7e8df65b2 Merge profile icon with user-avatar icon
Both are the same but different variants - so use the variants
ResourceLoader module to keep this modules consistent in color
and form.

Change-Id: Ib75e1ff741fa46ad9698e89c4433b6edbad4d376
2018-05-08 23:35:44 +00:00
jenkins-bot d32e74d46c Merge "Use a Drawer for Block Notices" 2018-05-08 21:11:47 +00:00
Translation updater bot 78bb624d7a Localisation updates from https://translatewiki.net.
Change-Id: I1b345dfa0c101e2082a91c76425be373f19059a6
2018-05-08 22:00:53 +02:00
David Barratt f51cf7db7b
Use a Drawer for Block Notices
When a user is blocked, the toast message provides insufficent information to
the user. To provide more information, as well as a better design, the block
message will be moved into a drawer.

Bug: T165535
Change-Id: Ib025db3a8a4d1fd7bd05b69f9b5326943288372f
Depends-On: I926918d0bd7f2176f188a2154dc5e99f6a8a7ad1
2018-05-08 13:20:00 -04:00
jenkins-bot 4d0474e90a Merge "Move skin metadata keys to top of skin.json" 2018-05-08 16:21:40 +00:00
Stephen Niedzielski 9ccad5a405 Hygiene: replace calledOnce / Twice w/ callCount
Replace all test assertions for calledOnce / Twice with callCount.
assert.ok( calledOnce / Twice ) only lets the dev know that a test
fails. assert.strictEqual( callCount, EXPECTATION ) starts the debugging
process when it fails since it provides the difference in the failure
output. strictEqual() was deliberately used since it's a saner default
and the codebase already favors === equivalency checks.

  find tests -name \*.js|
  xargs -rd\\n sed -ri '
    s%ok\(([^,]+)calledOnce%strictEqual(\1callCount, 1%g;
    s%ok\(([^,]+)calledTwice%strictEqual(\1callCount, 2%g;
  '

Change-Id: I5c4c595c4520cecfad46d652f639a63a1c2c00b4
2018-05-08 16:12:04 +00:00
Kunal Mehta e07e5103a4 Move skin metadata keys to top of skin.json
The keys that form the credits (name/description/url/etc.) are usually
on top, and manifest_version is typically on the bottom.

Change-Id: I1767b1e176c9cf892c1f627db4f5891fa6aade18
2018-05-07 18:19:40 -07:00
Translation updater bot dcc69d816f Localisation updates from https://translatewiki.net.
Change-Id: Ia197cc2e1789266824e55a67a539208600508a3b
2018-05-06 21:55:01 +02:00
Translation updater bot ad38ab06f7 Localisation updates from https://translatewiki.net.
Change-Id: Id9f42b7c05c82fb0666d87092ba3737001c62922
2018-05-05 21:57:27 +02:00
jdlrobson 6267ac8ca0 Override 'core' styles for Minerva
Minerva purposely does not load mediawiki.legacy.shared
This should still be the same when setupSkinUserCss is
deprecated.

Change-Id: Ib2b19ba165a9d646a770702cdf1724509156b93e
2018-05-04 23:41:56 +00:00
Translation updater bot 77e4ffed91 Localisation updates from https://translatewiki.net.
Change-Id: I5b7020c88f6133a088e90028cb7c4c7120e3a64d
2018-05-03 22:05:06 +02:00
jdlrobson ddc1e2a30d Content area needs a z-index
The content area is the sibling of the overlay.
For the overlay to overlay it and its children it
must explicitly setting a z-index

additional changes:
* Move UI styles from skins.minerva.mainMenu.styles
to their more logical place (note skins.minerva.mainMenu.styles
is loaded via JavaScript unncessarily)

Bug: T193444
Depends-On: I7c0d02f073a2fe165a6027e3c6d1455e22c1b563
Change-Id: I8be31c7daf254e22ccaed81704cbcd2b638c54f6
2018-05-03 18:01:51 +00:00
Jan Drewniak 503756822c Run npm test as a pre-commit hook
Adds the `pre-commit` npm package which automatically
handles git pre-commit hooks via package.json and runs
`npm run test` by default.

https://www.npmjs.com/package/pre-commit

Requires an `npm install`

Change-Id: Ia5950242bced753c42fc804fd686bc239c335aa3
2018-05-02 17:18:16 +02:00
jenkins-bot 142bb570c1 Merge "Dequeue render blocking styles" 2018-05-01 17:26:10 +00:00
jdlrobson cf1629aa0d Improve use of whitespace on tablets
1) Remove collapsible heading rule
Introduced for T43401 this no longer seems to be needed
now that we do not support Blackberry's and infoboxes can
be floated within articles and is now creating a reflow

This addresses issues with floating on the United States
and Taiwan page.

2) Allow table's to float in tablet.
Only disable floats on mobile resolutions.

Bug: T193418
Change-Id: I64748e08516e1be4b53af22b6897560b7fc87632
2018-04-30 13:39:03 -07:00
jenkins-bot a44370b2b0 Merge "Regression: Avoid reflows on lazy image placeholders" 2018-04-30 18:13:17 +00:00
jdlrobson e7e1aa8229 Regression: Avoid reflows on lazy image placeholders
Now we are applying width: 100% to all placeholders we are causing
significant reflows for the entire page.

Restrict altering the height on only real images which can be distorted
by dimensional changes

Bug: T191893
Change-Id: I982d928273dc3b6f30974f2401760d5d44ce4b82
2018-04-30 10:53:03 -07:00
Jan Drewniak 0374ef64a0 Display content beside infobox instead of below.
Removing CSS rules that that push content below infoboxes.

Bug: T189688
Change-Id: I59736720b36f251c49a27a2dd7f5343d58629992
2018-04-30 17:33:08 +00:00
jenkins-bot 10c672acba Merge "Removing aqua-colored tap highlight color for links on android" 2018-04-30 16:46:11 +00:00
Translation updater bot d040616bf7 Localisation updates from https://translatewiki.net.
Change-Id: I0eaff6696cba7e7a933729976b98fb9c0c810a3b
2018-04-29 22:08:12 +02:00
jenkins-bot deef073013 Merge "Change strategy for undoing '.content table' overrides" 2018-04-27 18:53:59 +00:00
Timo Tijhof 1fd6ce6db2 Change strategy for undoing '.content table' overrides
This is effectively a no-op for Minerva itself, but
automatically fixes a bunch of bugs, such as the
lack of centerring on WikiHiero elements.

Bug: T184221
Change-Id: I0af4df2391be1fab3c93fcbfea6624074fc96414
2018-04-27 18:40:14 +00:00