Commit graph

4489 commits

Author SHA1 Message Date
jenkins-bot 069b71ad55 Merge "Remove reference to mw-editButtons-pipe-separator, now removed from MW" 2018-01-11 20:55:40 +00:00
Piotr Miazga 3c4f3a0ddd Send events when user taps download icon
To track "download" button interactions we have to notify
EventLogging that button was clicked. The easiest approach is
to use mw.track() and then in WikimediaEvents subscribe to the
`minerva.downloadAsPdf` events and track page impressions.

Bug: T181297
Change-Id: Iecbebe37c165dda3f26af47906662f6e5a81321d
2018-01-11 18:50:31 +00:00
James D. Forrester c7c09daa66 Remove reference to mw-editButtons-pipe-separator, now removed from MW
Change-Id: I59d34dfdd13122db0229ce40909d66d88bdd8d65
2018-01-10 14:30:20 -08:00
jdlrobson dede844830 Minerva should use FeatureManagers class
Bug: T182362
Depends-On: I6cc4a2ebcd75c054294daf329d94d35a02e50f8e
Change-Id: I6ba5bf49b9060c31ad2224a437072b3426a45619
2018-01-09 14:38:33 -08:00
jdlrobson 09a1f98ab3 Merge remote-tracking branch 'origin/master' into HEAD
Change-Id: Ia1a520d983be096e29cfe725f619be0423f9d110
2018-01-08 16:37:44 -08:00
Translation updater bot a8470464b7 Localisation updates from https://translatewiki.net.
Change-Id: Ia177f9b964f14483000b2a99cc620f18a85ded21
2018-01-08 22:10:57 +01:00
Translation updater bot 3b8c3653be Localisation updates from https://translatewiki.net.
Change-Id: I1e27025b65599e5696ec37d49afa60b463e8f026
2018-01-07 22:24:16 +01:00
Translation updater bot e3c3c4d674 Localisation updates from https://translatewiki.net.
Change-Id: Id45627fbbd97a7738791ae21252a37f72ab4fcc2
2018-01-06 08:47:31 +01:00
jdlrobson a807fd6fed Avoid OOUI/download icon nameclash
Short term fix to ensure icon doesn't change
when oo-ui is loaded.

Prefix with 'mf-' (we do this in main menu) to avoid nameclashes

Bug: T182162
Change-Id: Ia6ceb620ed2710d97387a326b74f1a02236cd0d0
2018-01-04 20:47:42 +00:00
petarpetkovic c8195e37ef Fix notifications always appearing as unseen
After Ie92b223a48 removed $flags parameter from EchoSeenTime::getTime(),
we got 0 as $format passed to the method, which caused mismatch in
timestamp string formats when comparing to $notifLastUnreadTime timestamp,
which caused notifications to appear always as unseen (although that's
unpredictable, because of wrong format used).

Bug: T183076
Change-Id: Ia4ff0bc4c3b7ed80b5a22a9ca0052f1909469180
2018-01-03 18:21:40 +01:00
jenkins-bot 8466feb591 Merge "Revert "Fix infobox styles to work well with multiple column infobox rows"" 2018-01-02 22:07:51 +00:00
Jdlrobson fc54446a40 Revert "Fix infobox styles to work well with multiple column infobox rows"
This reverts commit b3dc650f15.

Change-Id: I18b4cfd30d0703844748a2b4fb934f5824537970
2018-01-02 22:02:12 +00:00
jdlrobson 6598c1e7c3 Merge branch 'master' into HEAD
Change-Id: I220fbc57ee20d2a6717b39dba809401de2207ce0
2018-01-02 13:21:27 -08:00
jenkins-bot 7c92351bb9 Merge "Fix infobox styles to work well with multiple column infobox rows" 2018-01-02 21:16:44 +00:00
Translation updater bot 0abbc575a0 Localisation updates from https://translatewiki.net.
Change-Id: Id2247fb0bca1d8ec35d9a1d74a68291644c0ebae
2018-01-02 10:07:39 +01:00
Translation updater bot b391302bc9 Localisation updates from https://translatewiki.net.
Change-Id: I7a049bb1e503721e3c0d7d57510d4186d1a996e3
2018-01-01 08:47:11 +01:00
libraryupgrader cc984c2f11 build: Updating mediawiki/mediawiki-codesniffer to 15.0.0
The following sniffs are failing and were disabled:
* Generic.Files.OneObjectStructurePerFile.MultipleFound

The following sniffs now pass and were enabled:
* MediaWiki.Files.OneClassPerFile.MultipleFound

Change-Id: Ib81b8adc5730d9715d767b1b5d39cc3e005a69b9
2017-12-30 04:01:12 +00:00
Umherirrender bf974861a2 Fix spacing of @covers
Change-Id: I61d2cd2cb4523433bda37f349cf5327bfb4c1b66
2017-12-29 21:26:59 +01:00
Translation updater bot 80241cc1cb Localisation updates from https://translatewiki.net.
Change-Id: Ie5a6d95c2def9ecb642cbf8db2fc13d5e127ec31
2017-12-29 09:36:17 +01:00
Translation updater bot b3f9e1db5f Localisation updates from https://translatewiki.net.
Change-Id: I9799b76e1fc46b16d5e450b4c03491e3b27b7444
2017-12-27 10:11:01 +01:00
Translation updater bot 84a7a21d41 Localisation updates from https://translatewiki.net.
Change-Id: I316479d5773d75f7abaf3bae77298b03dc7e39e5
2017-12-26 10:06:30 +01:00
David Sn b3dc650f15 Fix infobox styles to work well with multiple column infobox rows
I used the fix provided by TheDJ and tested out locally
on Firefox 57 and Chrome latest, but I couldn't test out
any grade C browser as on Linux it's really hard to find
such an outdated browser like Internet Explorer on Windows.

Also, I am unsure whether it will work in production
with the example article from the task, wasn't able
to recreate the article fully on my local devwiki.

Bug: T168716
Change-Id: Ied7c15f7a254228c23111df79da44d6167f1baac
2017-12-23 00:35:06 +00:00
Translation updater bot 19613c01bd Localisation updates from https://translatewiki.net.
Change-Id: I3d6994ea7341f9286ac7b2c61af79da72309651f
2017-12-22 22:02:19 +01:00
Translation updater bot 9599d8db7f Localisation updates from https://translatewiki.net.
Change-Id: I2a98ceaf5a46439932dcd9dc57052579708f9828
2017-12-21 21:59:39 +01:00
Translation updater bot 83eca0a53c Localisation updates from https://translatewiki.net.
Change-Id: I94b1ec612cd74b435da4c6743667bd96d8205311
2017-12-20 23:00:21 +01:00
Translation updater bot 8118fd35db Localisation updates from https://translatewiki.net.
Change-Id: I5a878a43d9b7ed4df7d92cebda0d8d050740c065
2017-12-18 22:23:14 +01:00
Translation updater bot ad56dda3e1 Localisation updates from https://translatewiki.net.
Change-Id: I5da13b02019fba4ed7db052c81d138b60b869a71
2017-12-17 22:05:31 +01:00
Rafid Aslam 88d889ab25 Add minus-x to "composer test"
Add minus-x to "composer test" and "composer fix"

Bug: T175794
Change-Id: I54088f3895ca931006c6a004a48c87f9445abf8c
2017-12-16 16:09:12 +07:00
Translation updater bot 85bb48bfcc Localisation updates from https://translatewiki.net.
Change-Id: Ie2c4427b4bdd8a5391250d9b6ff376d212a91b26
2017-12-15 22:09:01 +01:00
Translation updater bot 36151ddcb8 Localisation updates from https://translatewiki.net.
Change-Id: Ib92096e82a99c05d5661b4f6833aa875906a96df
2017-12-11 23:16:59 +01:00
jenkins-bot a9dd923651 Merge "Make svg_check.sh verbose" 2017-12-11 22:01:31 +00:00
jenkins-bot 8cc57955eb Merge "Pass svg_checks.sh via ShellCheck" 2017-12-11 22:01:20 +00:00
jenkins-bot 91454502d3 Merge "QA: Add additional steps to guard against slow test runs" 2017-12-11 21:59:41 +00:00
jenkins-bot 191f663205 Merge ".gitignore /docs/ generated by JSDuck" 2017-12-11 21:53:29 +00:00
jdlrobson e87d838466 QA: Add additional steps to guard against slow test runs
Bug: T182202
Change-Id: If46620941924b86c5403c9e928911b1aa5845d7a
2017-12-11 21:51:40 +00:00
jenkins-bot b20e1a3b25 Merge "Update RuboCop Ruby gem" 2017-12-11 21:28:28 +00:00
Antoine Musso 8a220e372c Make svg_check.sh verbose
So we know what is going on while the CPU is being busy.

Change-Id: I34a7ecadf549833025a197d72ca131888519a92a
2017-12-11 16:50:56 +01:00
Antoine Musso a38b4f8038 Pass svg_checks.sh via ShellCheck
while read svgfile; do
    SC2162: read without -r will mangle backslashes.

if [ $(wc -c < "$svgfile") -gt $(wc -c < "$outfile") ];
    SC2046: quote to prevent word splitting

found increment was done in a subshell and hence would not be properly
incremented. Instead of:

  find | while

Switch to:

  while < <( find )

Based on https://github.com/koalaman/shellcheck/wiki/SC2031 , this way
$found is kept in the same context.

Change-Id: Id8eb1027eed373161c8e7932b7745d4f53f2fc6c
2017-12-11 16:48:49 +01:00
Antoine Musso 97552204f6 .gitignore /docs/ generated by JSDuck
Change-Id: I04889b8ee6f1bfb8eb524378219c2863953f2038
2017-12-11 16:42:39 +01:00
Translation updater bot d159a99be2 Localisation updates from https://translatewiki.net.
Change-Id: I53781515ca1b99291741230381d30564d1ecfc7c
2017-12-07 22:43:18 +01:00
David Sn 90f324a5b7 Use preg_replace instead of str_replace for replacing extension
Bug: T166684
Change-Id: I233be410486276f30b08034180eb54cb08e04076
2017-12-07 16:05:48 +00:00
Translation updater bot e32d650042 Localisation updates from https://translatewiki.net.
Change-Id: Ifab041edabe85cb126ac63f9a8a12e402e30a829
2017-12-06 22:11:48 +01:00
Željko Filipin e7cad9e34c Update RuboCop Ruby gem
Bug: T180878
Change-Id: I904e947d7044b259f29f584b568ab2cb689bd5a4
2017-12-06 16:58:29 +01:00
jdlrobson 1146cef6b1 Optimise Special:MobileOptions for tablet display
Bug: T180095
Change-Id: I0ef0ce914a360848f8f66b39c40588f3fa04647c
2017-12-05 14:20:11 -08:00
Translation updater bot 63aeb4cfc5 Localisation updates from https://translatewiki.net.
Change-Id: Ibea20014746de0fcf8d3418047b9384506f7b1a9
2017-12-05 22:13:00 +01:00
jdlrobson c986db6c0e Always render taglines unconditionally and update styles
Adjust tagline margin per Nirzar:
https://phabricator.wikimedia.org/T180095#3801719

Note, this will  enable the tagline everywhere.

Change-Id: I3bce2a3472ab2e53261965c953572f35cc740eed
Bug: T180095
2017-12-05 00:27:11 +00:00
David Sn 8a19c0cb33 Use png as fallback for svg on non-supported browsers
This will use the srcset attrribute which was introduced with HTML5,
in order to load the svg image on supported browsers.

Should fix the bug after merging change 394820.

Bug: T166684
Change-Id: I2337b750c80e79c816dc817dfe230e063eed0345
2017-12-04 22:13:23 +00:00
Translation updater bot e59d001536 Localisation updates from https://translatewiki.net.
Change-Id: Iac0222d65db818996112e572f1b53faaef5d3b5f
2017-12-04 22:39:59 +01:00
Translation updater bot 03ca369776 Localisation updates from https://translatewiki.net.
Change-Id: Idde0aee303bc1d03913e7d5fa530efb97d9484e5
2017-12-02 22:03:54 +01:00
Translation updater bot 52f5e81d07 Localisation updates from https://translatewiki.net.
Change-Id: Ide3af8903b2232db8aba273d414b19bb684ec01e
2017-11-30 22:46:26 +01:00