Commit graph

277 commits

Author SHA1 Message Date
Ed Sanders d09600aa51 build: Update linters
Change-Id: Iaa1c41ab1af4802fd71896b471eda8dd8852a323
2023-06-13 13:56:14 +01:00
Jdlrobson d973a1642f Revert "Add custom styles for temporary user links"
This reverts commit 52273510fe.

Reason for revert: Web team is trying to limit the amount of differences between Minerva and Vector codebases, using shared styles
in core where-ever possible. Since this rule is already defined in core, we should load it from there. This requires a slight change to
the loading mechanism, which I've marked as a dependency.

Change-Id: Id31a6b24bdd4f745e194d77cf7b97faf6ae7e6de
Depends-On: I11c54b58873523f7b72cca67b82efdd681562508
2023-06-09 22:16:42 +00:00
Jdrewniak cc513b9e72 Revert "styles: Apply Codex z-index tokens"
This reverts commit b28b80e222.

Reason for revert: Changes broke dialogs in mobile VE.

Change-Id: I957661a882b1d8aa50cede906631d29f4a51e530
2023-05-26 15:29:03 +00:00
Volker E b28b80e222 styles: Apply Codex z-index tokens
Applying central Codex design tokens in new architecture.
This replaces all existing MN `z-index` tokens and comments on
replacement choice.

Bug: T285592
Change-Id: I23d794566898946a500c10713802d8dfaad993d1
2023-05-18 23:33:38 -07:00
jenkins-bot 9a529c3652 Merge "Improve styles for mw.notify and post-edit messages" 2023-05-05 16:14:15 +00:00
Volker E a44c3a0652 styles: Use appropriate tag marker @border-radius-pill token
Have falsely used the circle token for this, as it was using the
same height and I thought it's a circular shape. Pill is the right one.

Bug: T335932
Change-Id: I069d3a259993e01310586732829708f1a4f8b547
2023-05-05 02:37:49 -07:00
Bartosz Dziewoński 75751e5512 Improve styles for mw.notify and post-edit messages
* Allow multiple notifications to be visible at the same time without
  overlapping
* Don't allow notifications to cover the entire screen
* Fix icon placement in post-edit notifications

Bug: T336001
Change-Id: I7b76b0f97bc4b5ca85f4b47bd27ae7568bcbe353
2023-05-04 21:54:24 +02:00
Thalia d6ce599a75 Fix background for temporary user links on Watchlist and RecentChanges
Bug: T335373
Change-Id: I07df052b05aee2649dc58f00e8487447565a56cc
2023-05-02 15:53:58 +01:00
Volker E 38ca243e39 styles: Replace 'mediawiki.ui/variables' call with skin variables
Replacing 'mediawiki.ui/variables.less' @import with
new skin-aware 'mediawiki.skin.variables.less' standard.
Removing calls for 'mediawiki.skin.variables.less' in favor for
'minerva.variables.less' for consistency.
Also
- replacing several static values with new Codex design token featuring
  skin variables of `background-color`, `color`, `border-*` and
  `transition` categories
- renaming several Less variables to variable naming standard
- moving a small number of MinervaNeue specific variables into
  'minderva.variables.less' file. Those should be replaced in mid-future
  by Codex design tokens

Please note, that this patch is not replacing all values with
possible Codex tokens. It's just applying them on selected
categories for consistency for now to keep the patch easier reviewable.
Further replacements will be done in follow-up patches.

Bump MediaWiki core required version to >= v1.41.0.

Bug: T319381
Bug: T332541
Depends-On: I98c8cc27527533e2efb3b987ee34bc403e988b75
Change-Id: I86c5a35377541a784552c29456e0b8b507b3ee9c
2023-04-24 16:08:27 +00:00
Thalia 52273510fe Add custom styles for temporary user links
Bug: T334581
Change-Id: I0641bab87a8c942fb58e63c08924f5ff9f4472b0
2023-04-12 18:38:28 +01:00
Simone Cuomo ca7c9456e7
Mobile: Sister projects do not align with search results on the left margin.
- [x] Remove left padding
- [x] Add space between result and IW result

Bug: T329110
Change-Id: I8085206bd57c5d46d72f6237fe2baf5534365613
2023-04-03 11:57:46 +01:00
Umherirrender 5bd834e0c7 build: Updating npm dependencies
* stylelint-config-wikimedia: 0.13.0 → 0.14.0

Run stylelint fix to fix the new stylelint rule

Change-Id: I7738ae421e84dd3171355391ebc82dd812b39ca4
2023-03-31 21:50:36 +02:00
suecarmol dfabe839fa Remove redundant styling in Minerva
Removed redundant CSS rules in Minerva. They were duplicated from core.

Bug: T325574
Depends-On: I66682ea78c796bd587e3fa002b4176cbdd1ccd0d
Change-Id: I89d66406cea65ff94819ac70c0ee54a7aa6bf6ba
2023-03-28 13:42:05 -06:00
Arlo Breault 0cd677dcec Make figure styling more specific to thumbs
This was requested to free up figure for proposed HTML format
change to galleries.

Bug: T268250
Change-Id: Id1ceac08a46fa1faeb9ac976a53da06e4f8f8c77
2023-02-03 21:45:25 +00:00
Jon Robson e5396b34bc Revert "Fixes issue with height in slideshow"
This reverts commit 1ac1cdfd7e.
No longer needed with change in core

Depends-On: I6d916ffb1301bd2f4a258ec50990c4347f9c63e7
Bug: T326270
Change-Id: I73559c23943a25bbcaea5ba1576155a887d4ba70
2023-01-12 23:44:21 +00:00
Jon Robson 1ac1cdfd7e Fixes issue with height in slideshow
Depends-On: I5c372f8b1bbc44af9c5855baa7ee825ff42fbc96
Bug: T194887
Change-Id: I3904bb158eebe96983ce3318e1e39a6f056624fd
2023-01-09 18:49:34 +00:00
jenkins-bot 8011edcecb Merge "Always show search results at full width" 2022-12-16 08:46:59 +00:00
Jon Robson 57f86745e9 Show the thanks button on mobile special pages
Now the confirmation step code works, we can show this button.
Update styling to generalize the thanks/rollback styling.

Depends-On: Ia03038e86c6a607c8b75eefedbf0285ca1a2f8c8
Depends-On: I5286e80f9dd683ba55b03664dc31de77c19722b7
Bug: T230657
Change-Id: Iab32d8b30d4f2d946ffdaefea72ca9b43448998d
2022-12-15 22:46:33 +00:00
Matthias Mullie 4a4f8f279e Always show search results at full width
Ieebc40073eb3d0c8a56ebc8aec3f060199943ddc lowers the breakpoint
at which search will break into 2 columns (search + interwiki),
in large part because the 2nd column will also be occupied by
Extension:SearchVue's side panel.

On mobile, Extension:SearchVue presents differently (directly
below a search result), so there's not as much need for a 2nd
column this early - wider search results are prefered.

Bug: T321377
Change-Id: I22c46cfad2e054be679d79cce9b8d1ae04e3c6f1
2022-12-15 09:38:36 +01:00
Bartosz Dziewoński 433458ba98 Tweak margins/paddings of Echo icons
On desktop, the "Alert" icon had more white space around it than the
"Notice" icon, and its popup displayed with a different offset.

On mobile, the combined icon jumped around while the page was loading.

Change-Id: Icdd5bc6e8478f3453b6461a35b7fb53e8ab014e9
2022-12-14 04:36:14 +01:00
Arlo Breault c4fe708a36 Remove b/c for media typeof
Bug: T270150
Bug: T203211
Depends-On: I44b3fb432dd00120a4d5cd5556ba5ba8bc4e65d5
Change-Id: I58d8ce9e2e58916d55c8d838c3fbfb96e2a05f02
2022-11-30 13:55:32 -05:00
Jon Robson 7187ce5594 Move skinStyle from Echo to Minerva
Bug: T257143
Change-Id: I1999185d19e171900f2da5acbd39125013d3582c
2022-11-19 00:24:08 +00:00
jenkins-bot 27965530c3 Merge "Media border option applies to the media element, not the wrapper" 2022-11-02 23:02:22 +00:00
Jon Robson 5be882421d Disable new flushing rules on mobile
Don't have capacity to deal with this yet.

Follow up to  I9aba71ac4fff0d285676946acef8309b741ed1ad

Bug: T321504
Change-Id: I85ece1fa28d2c1c5967995ef7622684d73d3c23f
2022-11-02 12:28:49 -07:00
Arlo Breault b1d39a5425 Media border option applies to the media element, not the wrapper
Reported in,
https://it.wikipedia.org/w/index.php?title=Wikipedia%3ABar%2FDiscussioni%2FAggiornamento_del_parser_per_le_immagini%3A_vogliamo_testarlo%3F&type=revision&diff=130240855&oldid=130214646

The default styling in core looks like,

.mw-image-border {
	> a:first-child,
	> span:first-child {
		> *:first-child:not( .mw-broken-media ) {
			border: @border-thumbborder-screen;
		}
	}
}

The simplification here recognizes that the border option doesn't apply
to thumbs, so descendent selectors can be dispensed with, there's no
nesting in figcaptions to worry about.  That's important because
lazy-loading adds a noscript before the img tag, which would make the
selectors with first-child not apply anyways.

An img tag is used instead of the universal selector.  That seems like a
safe assumption for now and can be revisited with T314097 / T318433

Bug: T318300
Change-Id: I25f45ee794300d2ba2a38a0ab6e3741a6b1a18f2
2022-11-02 12:34:00 -04:00
jenkins-bot 2545c6b2d0 Merge "Add styling for Special:Preferences icons" 2022-10-28 16:59:28 +00:00
suecarmol 822bf0f0c3 Add styling for Special:Preferences icons
Added styles for Special:Preferences' mobile layout icons.

Bug: T317419
Depends-On: I6d5730d47e7595b1705787995fe5db2fe734d7f5
Change-Id: I40a1783a24a2d643026132038a71a027d69f178f
2022-10-28 11:39:20 -05:00
Matthias Mullie a0555ee377 Break up words to prevent thumbnails from being squished
Bug: T321362
Change-Id: I9d649873145738808fa5a8456df4272c14e42d6a
2022-10-27 12:02:16 +02:00
Matthias Mullie 4c19038074 Override padding-left for Special:Search results
Bug: T321563
Change-Id: I5fe7c85e459fbab058cb54a3aec8503c8e7ce203
2022-10-25 16:14:46 +02:00
Arlo Breault 8c87990f0b max-width only applies to thumbs
Not frameless or plain floated media.

Bug: T318300
Change-Id: Iced12531dc8fe416c493daa82c0aa8252f9226bd
2022-10-20 17:48:58 -04:00
jenkins-bot e8f369ca6e Merge "Improve Special:Preferences mobile styles" 2022-10-05 18:47:12 +00:00
suecarmol 68d763e62a Improve Special:Preferences mobile styles
Improved the Special:Preferences CSS styles for a mobile interface

Bug: T311717
Change-Id: I50f74cf45288bd261b5e9075260445df73b03333
2022-10-05 18:28:22 +00:00
Jon Robson 400126fa91 Revert back Minerva icon features not ready for production
In Ifccaadabd72a12814d3d4d01200931f7254c6cd5 we made some modifications
to the icon specification. I haven't run these by Alex yet (as focus
is on Vector 2022) and don't
want to rush them, so for now temporarily undoing those changes here.

Changes:
- Reverts icon touch areas from new 44x44 to old 46x46
- Undoes decrease in margins between labels and icons

Bug: T319071
Change-Id: I9a02191c57b7e2d24a8bc909f820ba8db942c028
2022-10-04 00:32:23 +00:00
jenkins-bot c0b79ad3c3 Merge "Don't show thumbnails for non-NS_FILE results on Special:Search" 2022-10-03 07:25:26 +00:00
jenkins-bot 5e945307b6 Merge "Remove redundant styling rules and fix center/none halign for figures" 2022-09-27 20:22:55 +00:00
Arlo Breault 1d123e02d1 Remove redundant styling rules and fix center/none halign for figures
The rules in mediawiki.skinning.content.parsoid were made redundant by
25890e3ece.  There are some more rules
there that should be audited to see if they're still necessary or can be
moved to a more general location now that wgParserEnableLegacyMediaDOM
is being disabled and they apply more broadly than just when Parsoid
styles are requested.

Missing rules for mw-halign-center and mw-halign-none are added.

Bug: T318300
Change-Id: I34fb1ce76de24eec3b136dc6dc9ab4e07e36b809
2022-09-27 17:17:48 +00:00
jenkins-bot 716e184be1 Merge "adjusted button css layou" 2022-09-26 18:52:27 +00:00
ELLENR 8b9f1b0757 adjusted button css layou
buttons are not displayed in AMC page history

Bug: T312311
Change-Id: I390551a98d671d46e4e4d5f9f601124d1ac3f176
2022-09-26 09:43:42 -06:00
suecarmol 3d61c0ed5d Mobile Preferences: Add styles for Special:Preferences mobile
Added a stylesheet for when a user views Special:Preferences in mobile

Bug: T311717
Depends-On: Ia7a730cd7f009dbb921a810f27fae4a9ee66f793
Change-Id: I83558ca5de50fa7d8c7d75572ffa1c600f660d66
2022-09-06 19:38:26 -05:00
Matthias Mullie 3a7d506381 Don't show thumbnails for non-NS_FILE results on Special:Search
Related: I2a679b51758020d3e822da01a1bde1ae632b0b0a
Bug: T306883
Change-Id: I562dea721e7dc587ced739ef5d974a82e16a1e70
2022-09-02 16:01:04 +02:00
Ed Sanders f3ba1af953 Cleanup: Use .position-sticky() mixin from core
Change-Id: I2972eb33dc5ce54fa3ad23e1b52893b52ee13526
2022-08-16 07:51:03 +00:00
Ed Sanders ac317d1146 Fix CSS selectors for Parsoid images
A Parsoid-like DOM is used in VE.

Bug: T313172
Change-Id: I29bd59ff21c920fff3dddf9d1a58a823b460a97c
2022-07-26 01:47:45 +00:00
Ed Sanders d926771bd8 Remove deprecated vendor prefixes and their mixins
Additional change:
* The animation stylesheet pulled down for the storybook instance
in dev-scripts/setup-storybook.sh is no longer referenced anywhere
in assets so can be removed.

Bug: T306486
Bug: T308351
Bug: T308360
Change-Id: Ia9f2a05cde2724486f7e449261c5d4875388f5ab
2022-05-23 23:18:43 +00:00
Ed Sanders 86caa17713 build: Update linters and linter config
* Update stylelint-config-wikimedia to 0.13.0
* Ensure eslintrc.js and root files are linted
  with server config

Change-Id: I59c49fedd5b0c4c5620f960b78e4f781a6bc5abb
2022-05-18 14:33:23 +01:00
Jon Robson 9ffc476b1d Contributions headings should be border box
On mobile devices this is adding horizontal scrolling

Bug: T301798
Change-Id: Ibee771dce4924b138d3dd3df502659b2ea17c66d
2022-03-31 10:30:11 -07:00
Jon Robson 5586526d18 Show the mw-index-pager-list-header
Note this will not go into effect until Iae32ce9eab163bcb5b5b95dfd19c03276bc0f1a9
has been merged which enables skin styling.

The order is intentional to avoid leaving master in a state where
the heading is unstyled but shown.

Bug: T301798
Change-Id: Ia7836a42bfd90379fab981cbd6c64a1c00b29399
2022-03-23 19:22:12 +00:00
Jon Robson 3f9e007745 Remove message box h2 style
Depends-On: Ia57d98d4be39028aa2dfe4ed737755fca79c0db3
Bug: T300306
Change-Id: I1a5ba80ffb219cd7c1e26ea6b18e12237bd78482
2022-02-09 17:49:51 +00:00
jdlrobson f9a8703a64 Minerva uses core page title handling
Bug: T265892
Change-Id: I2ffdedd64414ffb3c6e441391a75fd6e744847a4
2021-12-20 19:39:42 +00:00
Derk-Jan Hartman a0bb9e41ee Fix viewport overflow in RC/Watchlist editsummaries
Set a max-width on this floated element

Bug: T297045
Change-Id: Ie33d7052eb1138cb98543c53410c1f376f3e0e64
2021-12-06 22:22:22 +00:00
Volker E 9c38f7ec82 drawers: Remove outdated supported browser property
IE9 on Windows Phone workarounds are of no use any more.
The `right: 0` and `left: 0` properties below are sufficient in
currently supported browsers.

Change-Id: Ibfb29d1b009cb0ea33bc3cb9be39ee579e981b1a
2021-12-02 13:47:08 -08:00