Commit graph

3636 commits

Author SHA1 Message Date
Arlo Breault b1d39a5425 Media border option applies to the media element, not the wrapper
Reported in,
https://it.wikipedia.org/w/index.php?title=Wikipedia%3ABar%2FDiscussioni%2FAggiornamento_del_parser_per_le_immagini%3A_vogliamo_testarlo%3F&type=revision&diff=130240855&oldid=130214646

The default styling in core looks like,

.mw-image-border {
	> a:first-child,
	> span:first-child {
		> *:first-child:not( .mw-broken-media ) {
			border: @border-thumbborder-screen;
		}
	}
}

The simplification here recognizes that the border option doesn't apply
to thumbs, so descendent selectors can be dispensed with, there's no
nesting in figcaptions to worry about.  That's important because
lazy-loading adds a noscript before the img tag, which would make the
selectors with first-child not apply anyways.

An img tag is used instead of the universal selector.  That seems like a
safe assumption for now and can be revisited with T314097 / T318433

Bug: T318300
Change-Id: I25f45ee794300d2ba2a38a0ab6e3741a6b1a18f2
2022-11-02 12:34:00 -04:00
Translation updater bot 98022a5c4f Localisation updates from https://translatewiki.net.
Change-Id: I88a5538e09b30de7100e6cf26ead74a469524ad1
2022-11-01 08:59:19 +01:00
Translation updater bot d4ccc757e8 Localisation updates from https://translatewiki.net.
Change-Id: I29429e57485ddad13af82563c2de19473cd16be8
2022-10-31 09:49:00 +01:00
jenkins-bot 2545c6b2d0 Merge "Add styling for Special:Preferences icons" 2022-10-28 16:59:28 +00:00
suecarmol 822bf0f0c3 Add styling for Special:Preferences icons
Added styles for Special:Preferences' mobile layout icons.

Bug: T317419
Depends-On: I6d5730d47e7595b1705787995fe5db2fe734d7f5
Change-Id: I40a1783a24a2d643026132038a71a027d69f178f
2022-10-28 11:39:20 -05:00
Translation updater bot 6dac350cf5 Localisation updates from https://translatewiki.net.
Change-Id: Ib6b27462428657f7954363a45b00bc79ff70a80c
2022-10-28 08:42:12 +02:00
Matthias Mullie a0555ee377 Break up words to prevent thumbnails from being squished
Bug: T321362
Change-Id: I9d649873145738808fa5a8456df4272c14e42d6a
2022-10-27 12:02:16 +02:00
Translation updater bot 5f7918c14f Localisation updates from https://translatewiki.net.
Change-Id: Id461e0ee2d5591244ced623125e64bb0128f2c82
2022-10-27 08:58:20 +02:00
Translation updater bot 0ef3ae5301 Localisation updates from https://translatewiki.net.
Change-Id: I5a2c4865974a1e6e5487da28ed01274652f94bd4
2022-10-26 08:22:11 +02:00
jenkins-bot 0eb111360f Merge "Override padding-left for Special:Search results" 2022-10-25 18:31:23 +00:00
jenkins-bot 77db2094eb Merge "Disable "page issues" feature when DiscussionTools is handling talk page" 2022-10-25 17:51:55 +00:00
jenkins-bot 7f3cba5df4 Merge "SkinMinerva.php: Improving naming and documentation of talk page overlay checks" 2022-10-25 17:15:33 +00:00
Ed Sanders f876accf9a Disable "page issues" feature when DiscussionTools is handling talk page
Bug: T312309
Change-Id: I9c3035c9dbe7545a05efb2286dffe0145d3557b4
2022-10-25 16:36:15 +01:00
Matthias Mullie 4c19038074 Override padding-left for Special:Search results
Bug: T321563
Change-Id: I5fe7c85e459fbab058cb54a3aec8503c8e7ce203
2022-10-25 16:14:46 +02:00
Translation updater bot 4c34240a9d Localisation updates from https://translatewiki.net.
Change-Id: I92e0aa3d396b21fd9b6dad2801427a4b83600479
2022-10-25 08:26:31 +02:00
Translation updater bot 698879e681 Localisation updates from https://translatewiki.net.
Change-Id: I02836face797281ba34f99048279967ec4452d0f
2022-10-24 08:25:57 +02:00
Ed Sanders c5976996d9 SkinMinerva.php: Improving naming and documentation of talk page overlay checks
Change-Id: Ie8bd5f591523f6eb0e1ef24cc2f61cc626fc478a
2022-10-24 00:00:42 +01:00
jenkins-bot 6d9be806a8 Merge "Fix a11y logged in test case on beta" 2022-10-21 17:52:16 +00:00
bwang 43d32233d1 Fix a11y logged in test case on beta
Change-Id: I2baa60a512522525163758b454d8826e5f0fa63d
2022-10-21 17:35:40 +00:00
Translation updater bot 17368240d1 Localisation updates from https://translatewiki.net.
Change-Id: I78239c5c9471bc6dd46525fd6881fed4d0e7e835
2022-10-21 08:47:45 +02:00
jenkins-bot cde9bda163 Merge "max-width only applies to thumbs" 2022-10-20 23:54:25 +00:00
Arlo Breault 8c87990f0b max-width only applies to thumbs
Not frameless or plain floated media.

Bug: T318300
Change-Id: Iced12531dc8fe416c493daa82c0aa8252f9226bd
2022-10-20 17:48:58 -04:00
jsn 73d9281e75 hooks: reference PreferencesGetLayout docs
Bug: T320843
Change-Id: I74f089d2e44ecfb5a0ba6a3b34db8abd0ec9a24f
2022-10-20 12:04:26 -05:00
James D. Forrester 83b959fc8f MinervaPagePermissions: Don't assume that indirectly editable contents don't have an edit action
Bug: T315336
Change-Id: I178cc408750172cd9e0cdc61717aba291698936e
2022-10-19 13:21:23 -04:00
Translation updater bot a84916b4bc Localisation updates from https://translatewiki.net.
Change-Id: I914fb9b16577f8b49344556f195cc372e555675a
2022-10-19 08:22:51 +02:00
jenkins-bot 9675bbb9a7 Merge "Bump nvmrc to 14.17.5 to match Wikimedia CI infrastructure." 2022-10-18 17:06:14 +00:00
bwang 29631e85c5 Bump nvmrc to 14.17.5 to match Wikimedia CI infrastructure.
Change-Id: If6e267fde3af3efc4ca24230dcd2ad8ebc6c290b
2022-10-18 16:49:00 +00:00
Translation updater bot 6512f646fa Localisation updates from https://translatewiki.net.
Change-Id: I84644c3464ff2060266c202895ba7130f44d576e
2022-10-18 08:25:08 +02:00
Translation updater bot a78c6315c0 Localisation updates from https://translatewiki.net.
Change-Id: Ica521902b531db4d0af9c6025a09be85efb43080
2022-10-14 08:45:33 +02:00
jenkins-bot 5f5764d7ab Merge "hooks: implement PreferencesGetLayout" 2022-10-13 16:18:36 +00:00
Translation updater bot 8ecfed8ff2 Localisation updates from https://translatewiki.net.
Change-Id: Iaea1bfb36d759e1e4e54174a0d4016981462fb36
2022-10-13 08:11:41 +02:00
jsn 48cdc5a33d hooks: implement PreferencesGetLayout
Use mobile layout in Special:Preferences

Bug: T320586
Depends-On: I468481b66bf96880d1779cd11a46e18745e2c894
Change-Id: Ic6aa01e6e8806d1f2be8e07ca6c83decd62bc641
2022-10-12 20:54:55 -05:00
Translation updater bot 8417343351 Localisation updates from https://translatewiki.net.
Change-Id: Ib9f912b6bec80532a5ef2e5dc3df2fee3b6019fa
2022-10-12 08:22:41 +02:00
Translation updater bot 8d167bc4b4 Localisation updates from https://translatewiki.net.
Change-Id: I6fb542362b3fbed73cfdea6d807225c97cd20aa7
2022-10-11 09:19:06 +02:00
Translation updater bot 7c774d8ac2 Localisation updates from https://translatewiki.net.
Change-Id: I0858084528e48d07de899f6d663540281006d622
2022-10-10 10:23:52 +02:00
bwang 130ca9c54d Disable headless puppeteer for a11y testing
Change-Id: I33b0fcb1f132ae62824b48511c3a02a3d95e9c55
2022-10-07 14:59:14 -05:00
jenkins-bot 401683288d Merge "Add automated a11y test coverage to Minerva" 2022-10-06 16:37:18 +00:00
Jon Robson 9867b052e1 Mark menus as supported in Minerva
Follow up to 44a93ed39
Currently the Skin menu code is forgiving, but it is important
to list menus in skin.json so that Skin::supportsMenu works as
expected. Without this, other extensions/skins cannot tell if Minerva
supports this menu and therefore cannot act accordingly

Bug: T319396
Change-Id: I314df011b0c88e9f10842fb445cd7c015dbe5f8a
2022-10-05 20:51:06 +00:00
jenkins-bot e8f369ca6e Merge "Improve Special:Preferences mobile styles" 2022-10-05 18:47:12 +00:00
suecarmol 68d763e62a Improve Special:Preferences mobile styles
Improved the Special:Preferences CSS styles for a mobile interface

Bug: T311717
Change-Id: I50f74cf45288bd261b5e9075260445df73b03333
2022-10-05 18:28:22 +00:00
Reedy 9dd8065d4d Switch to MW core hooks to HookHandlers
Bug: T315823
Change-Id: I0d1eb1e2ea584904ee3a130b938bd372048a47eb
2022-10-04 23:05:38 +00:00
Translation updater bot 15c5c2b48c Localisation updates from https://translatewiki.net.
Change-Id: I20eb826395145cb83654bd9d013d6f53ad7c2d1b
2022-10-04 08:31:40 +02:00
jenkins-bot 766a3fe767 Merge "Revert back Minerva icon features not ready for production" 2022-10-04 01:07:31 +00:00
Jon Robson 400126fa91 Revert back Minerva icon features not ready for production
In Ifccaadabd72a12814d3d4d01200931f7254c6cd5 we made some modifications
to the icon specification. I haven't run these by Alex yet (as focus
is on Vector 2022) and don't
want to rush them, so for now temporarily undoing those changes here.

Changes:
- Reverts icon touch areas from new 44x44 to old 46x46
- Undoes decrease in margins between labels and icons

Bug: T319071
Change-Id: I9a02191c57b7e2d24a8bc909f820ba8db942c028
2022-10-04 00:32:23 +00:00
jenkins-bot ea6fd775f2 Merge "mediawiki.skin.variables: Add border-style and border-width vars" 2022-10-04 00:29:04 +00:00
Translation updater bot 92837da6b2 Localisation updates from https://translatewiki.net.
Change-Id: I2b2723f2492cc41a29e1339fd58ccacb51d56b9d
2022-10-03 09:48:31 +02:00
jenkins-bot c0b79ad3c3 Merge "Don't show thumbnails for non-NS_FILE results on Special:Search" 2022-10-03 07:25:26 +00:00
bwang a5f9dfd1d4 Add automated a11y test coverage to Minerva
Bug: T319080
Change-Id: I156fd765f02a3deb01722770de68ebbd4f076d5b
2022-09-30 20:26:05 +00:00
jenkins-bot bf72d032f9 Merge "Remove Minerva talk pages Selenium tests" 2022-09-30 19:46:34 +00:00
Translation updater bot 3745ea086e Localisation updates from https://translatewiki.net.
Change-Id: I93a4ea096fc5e4df7d6d628a8d7faf35cdf2046e
2022-09-30 08:57:11 +02:00