This restores the previously reverted patchset
If5b76245bf60bfa9cf977cdbf37ee0d6bb65f9d9
Changes since original:
* Added Depends-On to MobileFrontend
* Uses OOUI classes for page issues rather than es6 classes - ES6
classes do not support modifications to class prior to running
super so MobileFrontend's View class is not compatible without
significant refactors.
Depends-On: I24ad75adf8519102ca356d64d99d765ab69180cc
Bug: T348807
Change-Id: I4ff82af0251254c846f2caee330af5af738f6029
Mobile page doesn't traditionally show the full revision under
the diff. If we want to continue to do this it would be better
to find a solution on the server then resort to this CSS hack.
Bug: T350454
Bug: T350650
Change-Id: Ic26c577ca4bcf8793f8678e30d91b0315da4df99
The mediawiki.diff.styles can be loaded on pages other than the diff
page itself, so it is better to move this logic into SkinMinerva and
avoid outputting it for diff pages full stop.
Note this module is loaded on Special:MobileDiff and desktop
Minerva history page (without redirect) so we need to cater
for both cases.
Bug: T350515
Change-Id: If2d908b7cbe257184e0c899f78a04d4d5935ea8c
This reverts commit 19ea6328b0.
Reason for revert: Breaks page issues and image overlay. I
will break this up into smaller less risky patches.
Change-Id: If5b76245bf60bfa9cf977cdbf37ee0d6bb65f9d9
All other occurrences in this stylesheet already use the new token.
Seems like this one was missed.
Bug: T331403
Change-Id: I1d385275bd2b679d130eb3180ef2fc63a0f37a6b
When the editor is loading a loading overlay is shown and its not
possible to escape it via the back button. Make sure that the test
waits for this to disappear before continuing.
Bug: T348539
Change-Id: Ib53f9129d2cc89c23142c447e25d727592521ae0
When $wgReadOnly = true; in LocalSettings.php the edit icons
appear locked and when clicked should show a warning.
This also addresses deprecation warnings in the code and
tidies up the ES6 code.
Note to reviewer: Please use git diff HEAD^ -w
when reviewing this diff. Mostly whitespace changes.
Change-Id: I3fa83cc1dc4da62260fd0ef50ac14805c3e1282b
Please see T338261#9291438 for a longer explanation. The .mw-editTools
section is a multi-purpose field that can hold a lot of different
things, most notably a special characters toolbar. It's confusing if
the toolbar looks like it's disabled.
Bug: T338261
Change-Id: I6ad58dbdcc754c832e03184c2e69a7803c333c07
At least for wikis that have AdvancedSearch installed it does not
seem to make sense to hide the interface. It should be usefull in
any case. Also there's a huge gap that should be avoided I guess.
I'm not to sure for cases where AdvancedSearch is not installed.
There this patch will lead to a situation where there are two
search fields visible. The one at the top and the one in the main
content. - Although the latter has the advantage to show the
current search term.
IMO this is overall still an improvement and further streamlining
could be done in a follow up ( like hiding the header search field
generally on the Special:Search page ).
Bug: T308845
Change-Id: I477825e9d738e9934f6c6845a1ff8962f12987a9
The line-height value for headings in MinervaNeue was 1.3,
while in Codex and Vector it changed to 1.375.
This patch brings the value in MinervaNeue in line with Codex and
the corresponding change in Vector a while ago.
This also makes future typographic changes more easily handlable.
Bug: T331403
Change-Id: I4320035708d6005388428dfbc90da2ef613841b5
Additional change:
* Remove unused import on mediawiki.special.changeslist module
* Increase touch area of undo link for mobile devices
Bug: T345768
Change-Id: I8ded245cf15ca58f91ca1b71beffd91da02cfd92
Why:
Minerva uses watchstar both as a client to action=watch
and as a CTA prompting users to create a new account.
To prevent error messages about permissions from being
displayed when logged in as a temp account (or not logged in
at all), the API requests should be only sent when users
actually has watchlist permissions.
This patch fixes that by only passing data-mw=interface when
the watchstar is actually used as part of MW watchlist interface,
ie. when user is logged in. That means the `mediawiki.page.watch.ajax`
module in core can avoid the watchstar element when it is not meant
as a watchstar, but as a "sign up" CTA button.
What:
* Make it possible to change (or omit) data-mw in SingleMenuEntry
by a new constructor parameter.
* Make ToolbarBuilder::createWatchPageAction omit data-mw when
user does not have watchlist permissions.
Notes: Based on coversation with Krinkle in
Ia0acdaf4dea5aa6788f89fdd73c5dba9af9f1ed7.
Bug: T344925
Change-Id: Id9d6d9e7394b52d11ac6ce0b7d33319b3a761789
empty() should only be used to suppress errors
When the type of the variable is array,
a falsy check is the same (checks for null, false and empty array)
Found by a new phan plugin (T234237)
Change-Id: If24015795219f6ff4f155c0d667472dc52a04d43
