Commit graph

2118 commits

Author SHA1 Message Date
jdlrobson b7aaf0c3d8 Icon background should disappear on touch devices after click
A simple fix. Extensive documentation!

Bug: T233046
Change-Id: I378943a663a8947c8a03f807974829c66236a7ff
2019-11-04 21:27:06 +00:00
Translation updater bot c2aca28052 Localisation updates from https://translatewiki.net.
Change-Id: I3d5d14530522b30ba4ab0b12a44d67925c905eaf
2019-11-04 08:41:15 +01:00
Umherirrender 9096c53f92 build: Updating mediawiki/mediawiki-phan-config to 0.8.0
Bug: T235049
Change-Id: Ia7a2a77c6c918f4d0ed41836a7eff9eb5660c60f
2019-11-03 18:42:16 +01:00
Ed Sanders 49dd1fd71a build: Update eslint-config-wikimedia
Change-Id: Ic2148121161b804c3f6f41b9446fcea066f3de0d
2019-10-31 23:08:57 +00:00
Translation updater bot c99bf2c7f9 Localisation updates from https://translatewiki.net.
Change-Id: Ic50c5ca3567a083370cc8253680753f62ed855a6
2019-10-31 08:43:13 +01:00
Translation updater bot 6a22575656 Localisation updates from https://translatewiki.net.
Change-Id: Id903f6bd9d1ab879118518e067635fa2ba0de68c
2019-10-30 08:38:51 +01:00
jdlrobson 7f68c3d3ad MainMenu is a controller not a View and server rendered (take 2)
There should be no caching implications for this change, as the main menu
has been server side rendered on all wikis since 10th October.

As Stephen pointed out somewhere, this is a bit of a micro-optimisation
Let's simplify this code by always rendering it in the HTML. MainMenu.js
as a result becomes a controller that just decides when to show it.

The geolocation check for Nearby is removed given the fact that all
grade A browsers for mediawiki have Geolocation support.

ev.preventDefault in onSkinClick is dropped since the link to the '#'
(the default behaviour) is wanted

Additional changes
* Browser support suggests "animations" class is redundant now
* `open` event no longer filed - not being used anywhere
* Transparent shield is now managed by the MainMenu controller not
the skin (which was confusing)
* Test geolocation using a simple feature tests
rather than abstracting it away inside Browser
* The main menu button is always hidden under either a translucent shield
and/or the main menu itself when it has been opened
so so it's not possible to ever click it while the menu is open
 - the click handler is thus simplified
removing a check for the class of the button

Bug: T234650
Change-Id: If101eebbdbda1519af922745917237648722820e
2019-10-29 16:37:04 -07:00
jenkins-bot 7caa22e2cf Merge "QA: Update watchstar browser test selector" 2019-10-29 20:02:04 +00:00
jdlrobson 916fe079b6 QA: Update watchstar browser test selector
Follow up to I1141d570cf17d659a943659e8f44ebcdd166ca3c
Change-Id: I2728c0eeb0c68c29fa786bec2d00d72ba5d2dfbd
2019-10-29 12:49:28 -07:00
Jan Drewniak 3014a6b8d1 Fix page-action menu labels for non-amc mode
Followup to 77a1424e4e

Bug: T226562
Change-Id: I85257e3e0dc32cbc0d04b31486b65743d073e7a3
2019-10-29 17:51:33 +00:00
Translation updater bot 2151b6093e Localisation updates from https://translatewiki.net.
Change-Id: I998d882098d7659993831b2e8b49c606e06fa0c3
2019-10-29 08:46:09 +01:00
Piotr Miazga f9c055e7f5 Remove Share feature
The feature got into Beta in over a year ago and never made into
the beta mode. For most of the time it was disabled for all users.
There is no need to keep this code as it is dead code now.

Change-Id: I9037f58b97373195e9d1b9f57789a6c531f42831
2019-10-28 12:54:14 -07:00
Jan Drewniak 77a1424e4e Show labels in page-actions menu on desktop widths
Adds labels to page-actions menu via a new
`.mw-ui-icon-with-label-desktop` class that shows labels at the
desktop break-point.

Bug: T226562
Change-Id: If57ab44660e0dc2a58c04fbf22dee6c27dd1f45f
2019-10-28 12:53:38 -07:00
Jan Drewniak 575a835e66 Shorten labels for page-actions menu items
Updates the labels for: language, history, dropdown menu
buttons in the page-actions menu

Bug: T226562
Change-Id: I1141d570cf17d659a943659e8f44ebcdd166ca3c
2019-10-28 19:53:16 +00:00
jenkins-bot 94c1378f0f Merge "Make add talk button show on talk page in AMC mode" 2019-10-28 19:21:29 +00:00
jenkins-bot b962afe157 Merge "mainMenu: Document result of 0.7em padding-top of footer link" 2019-10-28 19:19:00 +00:00
jenkins-bot 91243b1691 Merge "Menu groups have identifiers" 2019-10-28 13:50:30 +00:00
jenkins-bot 0e521e507e Merge "Remove obsolete mw-mobile-mode classes" 2019-10-28 08:20:14 +00:00
Translation updater bot 2c74451c91 Localisation updates from https://translatewiki.net.
Change-Id: I42357c854716b6aca997df23cca60d5da0dafad1
2019-10-28 08:58:13 +01:00
Nicholas Ray 259f24523a Make add talk button show on talk page in AMC mode
There is currently no way for AMC users to see the "Add discussion"
button on the Talk page (non-overlay version). This will be needed in
I243f1193bce0da9fa710fc3b5379f90b2d079680 when we remove the talkBoard
in favor of the server rendered page.

Bug: T230695
Change-Id: Ica63fed1fdfbd1c02018bea8215bfed5b20e5771
2019-10-25 14:22:50 -06:00
jdlrobson bfc7540f7f Menu groups have identifiers
For compatibility and consistency/convergence with Vector, Minerva's
menus are linked to their Vector counterparts.

This allows us to get mw.util.addPortletLink to work inside Minerva

Bug: T231925
Change-Id: I121f12497eac6fcf0b63b9ccce561320eb8b3e62
2019-10-25 19:00:54 +00:00
Umherirrender 64e7f9b04a Split line with many values in skin.json
Makes it easier to read when there one value on each line

Change-Id: Ib6e8231f718cb6bf17935e45dff696db850569b9
2019-10-25 18:30:37 +02:00
Translation updater bot 83c6c6a894 Localisation updates from https://translatewiki.net.
Change-Id: I94b6d5f857b76f9aad3ee2ab510e23912c699c34
2019-10-25 08:40:17 +02:00
Volker E 3da637156f Use default duration LESS variable and align timing function one
Bug: T236224
Change-Id: I5c709a0989ab22839453e64bcefab201c666bf3c
2019-10-24 14:50:38 -07:00
Timo Tijhof 574650e8f3 mainMenu: Document result of 0.7em padding-top of footer link
Change-Id: I179b418b177971b022c9e543519517a543c86c0d
2019-10-24 20:44:02 +01:00
Volker E 19b1ea2297 Unify transition values across board
Using newly introduced variables instead of fixed values.
Also adding `transition` to property blacklist to ensure using
mediawiki.mixin.

Bug: T236224
Change-Id: I3d2d05f4e50e7b6bba0fe84fae1dde5de5b75492
2019-10-24 12:11:52 -07:00
jenkins-bot 6dd4142113 Merge "Add standard transition to icon elements" 2019-10-24 18:13:53 +00:00
jenkins-bot 39e8d2cc45 Merge "Remove unneeded vertical-alignment property" 2019-10-24 17:10:39 +00:00
Volker E 60e67abcc2 Remove obsolete mw-mobile-mode classes
Originally I intended to reduce specificity, seeing that
`mw-mobile-mode` class does seem obsolete in the meantime -
actually ever since I20e46165fb76956cb 3y & 5m ago.

Change-Id: I4e4d291c72864c868d99d87c4f96108b5eeea0f0
2019-10-24 16:51:18 +00:00
Volker E 3d6b2b29bd Add standard transition to icon elements
While working on I05c4e5f7a8b18a3 I've noticed the missing transition.
Also adding standard WikimediaUI variables in support of this.

Change-Id: I30c75ed306bf826ae40db3703ef423dfad85fa74
2019-10-24 16:51:05 +00:00
Translation updater bot 3e8856be79 Localisation updates from https://translatewiki.net.
Change-Id: I3d787c33661cb0ef268e530b54a4d058232349d3
2019-10-24 09:49:45 +02:00
Volker E 22d4d095f1 Remove unneeded vertical-alignment property
It's ignored as `float: left` is also set on the same selector.
Resulting from I06422cbe27afeab.

Change-Id: Ibb755c7b71ea5f3006abd178cdeaa540862f862d
2019-10-23 14:29:13 -07:00
Translation updater bot eae91b5261 Localisation updates from https://translatewiki.net.
Change-Id: I9a8297de1a574e4177a87b44acb5ba4763c26e54
2019-10-23 08:57:10 +02:00
jenkins-bot df44e53b2d Merge "Remove Echo phan config as MobileFrontend doesn't depend upon Echo" 2019-10-22 21:35:07 +00:00
jenkins-bot 328e9bb376 Merge "Remove unused test class" 2019-10-22 21:35:04 +00:00
Piotr Miazga 59a5154731 Remove Echo phan config as MobileFrontend doesn't depend upon Echo
Bug: T221007
Change-Id: I3cc52492dae1d2ce38b5bcec7ebff95efcf24fcd
2019-10-22 23:08:50 +02:00
jdlrobson c0d5889da8 Remove unused test class
Not needed since I09c27a084100b223662f84de6cbe01bebe1fe774

Bug: T221007
Change-Id: I909acac40a3fc732b10d0e66f8d430a0148734cf
2019-10-22 19:16:36 +00:00
Daimona Eaytoy 3e3cafe6b0 tests: Stop using getMock()
Bug: T192167
Change-Id: I34fc9bc5520e04a123642305ae0ca5d4f80d706c
2019-10-22 17:32:47 +00:00
Translation updater bot 9bda41e972 Localisation updates from https://translatewiki.net.
Change-Id: Icf3d520150d11259be4526c5f208e76efd43955d
2019-10-22 08:32:51 +02:00
jenkins-bot 1845d2c43e Merge "Replace color with WikimediaUI palette color" 2019-10-21 15:39:06 +00:00
Max Semenik 40f483b074 tests: @expectedException is deprecated
Bug: T234597
Change-Id: I5e0906a58add32b4d28449e8e59f1d32dc77c771
2019-10-19 19:27:30 -07:00
Volker E 02ac4be0fa Replace color with WikimediaUI palette color
Leftover from our color changes a while ago. Use blue shade for
background like in most other products.

Change-Id: Ic6e7e7a50d5698dfcd302f5988df1327f7435976
2019-10-19 11:56:54 -07:00
jdlrobson 59493f06b9 Selenium: Fix reference to watchstar
Selector recently changed in I11bbe976412b50dba76a55f37887e4c9235d0be1
This is causing browser tests for Minerva to fail.

Change-Id: I2c08b6e2dc924b3a7138d9ab6e8c9793c0da5c04
2019-10-18 17:00:35 +00:00
Translation updater bot f43e381080 Localisation updates from https://translatewiki.net.
Change-Id: Ic3fc55e2db8d4d3867728a5a24d7441ae0cec64e
2019-10-18 08:49:12 +02:00
Translation updater bot 3894a5effc Localisation updates from https://translatewiki.net.
Change-Id: I81853e3c7cdd891b689989ffd085619f48b33980
2019-10-17 09:12:35 +02:00
Translation updater bot cf4fd43e41 Localisation updates from https://translatewiki.net.
Change-Id: I06eb435e27a0d374802a70811709ea0976f33385
2019-10-16 20:46:54 +02:00
Translation updater bot 85da15e8a4 Localisation updates from https://translatewiki.net.
Change-Id: Ib6c61d5d2b9624a107646fbfaab18fb3924660f3
2019-10-16 09:29:39 +02:00
jenkins-bot 0c3f7bc52d Merge "Use core watchstar code" 2019-10-15 22:56:25 +00:00
jdlrobson bf8d325388 Use core watchstar code
Apply the mediawiki core watchstar to the
Minerva skin. Note, watchstars in search and other locations will
continue to be provided by the MobileFrontend library (see
follow up patch I7b748dc87089389400b0035c62a3b9a00c2e43f9)

Bug: T234970
Change-Id: I11bbe976412b50dba76a55f37887e4c9235d0be1
2019-10-15 15:33:25 -07:00
jenkins-bot 43b6c80461 Merge "Hardcode page issues vertically alignment" 2019-10-14 14:46:23 +00:00