Commit graph

4439 commits

Author SHA1 Message Date
Piotr Miazga f86cfc6fc4 Do not show warning box when LoginForm was posted
Because there is no easy way to detect failed user login/account
creation, do not show warning box during POST request. This should
do the trick as there shouldn't be possible to display valid
login/usercreate form during POST request.

Bug: T149413
Change-Id: Ieb7a34068aaad99616ad6c43de48f70a6775882e
Depends-On: I6ba28ddaeb0f9af17fa875bd9d1265509db4b927
2017-07-19 17:21:09 +00:00
Kunal Mehta f7509adfbb Simplify onResourceLoaderGetLessVars hook
* Get ConfigFactory via its accessor, not getService()
* Avoid array_merge, use simpler syntax
* Don't use string interpolation when one variable is the entire string

Change-Id: Ic4c138fb3b83e6e9c6ff9a001dd39e03ca5029b1
2017-07-17 23:40:31 +00:00
Piotr Miazga 7536ca089a Enable PHPCS and lint checks via composer test
Sniffs that are currently failing are disabled in phpcs.xml.

Additional changes:
* Fix problem in test file

Change-Id: I53642e9d7bc1ef96e359cfe04a8f93dabbc977eb
2017-07-17 22:20:29 +00:00
Piotr Miazga d5461f55a1 Fix failing SkinMinerva unit test
Bug: T170624
Change-Id: I13fff8eba06abad43291e481f32d9eb30c0f031b
2017-07-17 23:39:53 +02:00
Piotr Miazga 9d90df7b0b SkinMinerva testGetContextSpecificModule test might use undefined title
Test scenario for getContextSpecificModules() mocks only Skin->getTitle()
behavior, but while executing isAllowedPageAction() Skin will create a
UserPageHelper with default RequestContext. As RequestContext is not mocked,
$context->getTitle() will return undefined what could lead to tests crash

Changes:
 - instead of mocking SkinMinerva::getTitle() pass test context with injected
title. Other tests will work properly as MediaWikiTestCase::tearDown() always
restes RequestContext to default

Bug: T170624
Change-Id: I872fddf8d9c52a6875bb6c69a12407a8125fba4c
2017-07-17 21:40:34 +02:00
jenkins-bot 8653b8b4b1 Merge "Add tooling for svg size checking" 2017-07-14 18:29:38 +00:00
jdlrobson 59a17fd0af Add tooling for svg size checking
also add pre-commit hook to ensure svgs are
compressed on commit

since extensions are accessible via http an .htaccess
is added to the dev-scripts folder for safety.

Bug: T170639
Change-Id: Ibcd5c29340d16c9cffc6e2eb90d33ee89b69874f
2017-07-14 11:07:08 -07:00
jdlrobson a81c87b897 Add missing Minerva skin description message key
Change-Id: I61457e709caa0bfa94a627236f1d04a16f94a166
2017-07-13 14:03:00 -07:00
jdlrobson 69306b0b68 QA: Fix a flakey test
This copies the approach taken in
I3161c64d68c09a9a8f7d00a27eddfbe37830fabd

Change-Id: Ifd62db9bf5862e0a524186de12f50d05f41b4799
2017-07-13 16:47:28 +00:00
jenkins-bot 171d536138 Merge "Migrate 3 messages from MobileFrontend" 2017-07-13 16:07:34 +00:00
jdlrobson 2bb0fc5113 Migrate 3 messages from MobileFrontend
These were missed in the migration.
Putting them where they belong.

Change-Id: Ifb6a2f20b43d05610845c06e4c92035a5d3327a9
2017-07-13 09:02:47 -07:00
jdlrobson f60ca174f1 minerva-neue valid skin name should not be necessary
Change-Id: I3c42424f332ff29aa0c6f14487bc150d15c520e2
2017-07-13 01:11:44 +00:00
jdlrobson b0df6367c2 Give MinervaNeue control of the minerva skin name
Change-Id: I7f004b43e11d88492b205a3584c29f72d26bad57
Depends-On: I985c4e3a88b59461d471945ccf74cd291db45a61
Bug: T166748
2017-07-12 14:49:52 -07:00
jdlrobson 2cc9516cde Minerva is its own skin
This is programmatic output from python3 scripts/migrate.py

This will result in a Minerva skin dependent on MobileFrontend.

Post merge we will rename message keys to have minerva- prefix

Bug: T166748
Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 08:12:40 -07:00
jdlrobson 4d6555621f Fixes to migrate script with regards to i18n
* Make sure metadata field is present
* Make sure not to copy entire messages file

Change-Id: I9525f1cb35e6194de6594634c52d9f6c0587286d
2017-07-12 04:23:38 +00:00
jenkins-bot 7607a0a214 Merge "Add .gitignore file" 2017-07-12 04:19:07 +00:00
jdlrobson 687a10540a Add .gitignore file
Change-Id: Ie5112a5eef02fba9b70ef7483008b27090cc3f81
2017-07-11 21:14:48 -07:00
jdlrobson 7e1e5c85df QA: Add note about git history of browser tests in this repo
Bug: T168758
Change-Id: I8363eb3270f8660c0057fa42803577c9cdff400a
2017-07-11 14:57:27 -07:00
jdlrobson c0c90234d0 Port browser tests from MobileFrontend to Minerva
This moves all browser tests from MobileFrontend to the Minerva repo
in preparation for separating the two.

Note, this means browser tests will exist in both repositories for a
period of time. This is important and necessary to ensure we do not
break anything.

See:
https://lists.wikimedia.org/pipermail/mobile-l/2017-July/010536.html

Bug: T168758
Change-Id: I84ae3ea14191f672cabcd52020e80b0a40a72ce1
2017-07-11 14:11:03 -07:00
jdlrobson b1c80e7e3e Avoid using Minerva name until it has been removed from MobileFrontend
Without this desktop Minerva will throw a fatal exception.
This will be remedied later.

Change-Id: Iaa15dbb3180de95a7a79a5cac3909c9f0b98843b
2017-06-30 14:19:32 -07:00
jdlrobson 3e8e0e4843 Add migration script
Bug: T166744
Change-Id: I6466a72bc32916a7e3092b24e61961f8d422ed88
2017-06-30 14:06:29 -07:00
jdlrobson b4c7cd11e9 Placeholder to avoid failing browser tests
Change-Id: I694a28b364a6baadc948d0465db5f4ee91cebb61
2017-06-23 16:26:13 -07:00
Translation updater bot 7c804a42c4 Localisation updates from https://translatewiki.net.
Change-Id: I82af59a75ad2175f44b93a76c89d15fa85b4fd54
2017-06-18 22:02:51 +02:00
Translation updater bot bd120f8db8 Localisation updates from https://translatewiki.net.
Change-Id: I982c414af21e3cfccc13f0697793fb90b5e85d29
2017-06-16 22:07:44 +02:00
Translation updater bot 98e91ddc26 Localisation updates from https://translatewiki.net.
Change-Id: I1cc56057dad5f4daeefbbcc9cc7f49d21664caad
2017-06-15 22:00:56 +02:00
jenkins-bot b22ba49518 Merge "Punctuation in the description message" 2017-06-14 18:25:53 +00:00
Translation updater bot 7ef41fbd6e Localisation updates from https://translatewiki.net.
Change-Id: I834c7977f4bb80e221708ccd4c70be652a67e4a3
2017-06-13 21:59:35 +02:00
Amire80 a39f28ed3d Punctuation in the description message
Change-Id: I87d75dd3754520b54b374d2e90539e435b35511c
2017-06-13 13:20:53 +03:00
jdlrobson 9916c21ae1 MinervaHooks does not exist yet..
Change-Id: I436b70132a78f861542a0d28240ab40d5c655a61
2017-06-12 10:52:00 -07:00
Translation updater bot af78276fb3 Localisation updates from https://translatewiki.net.
Change-Id: Ifc2a360e0cfa984985d9779a401bf6aa66516301
2017-06-10 23:40:37 +02:00
Umherirrender ade9e8314d Use tabs in skin.json
Change-Id: I8fb66fe2f99786bfbdc598d460c18928dbb0faa0
2017-06-10 00:09:22 +02:00
Translation updater bot ef3c10d867 Localisation updates from https://translatewiki.net.
Change-Id: I191f75b9be17e1c8e5abd06f9fca54e4b0287ede
2017-06-08 21:56:18 +02:00
Translation updater bot cb1c5ed840 Localisation updates from https://translatewiki.net.
Change-Id: I626b4dd7904523aa9bf38bd384b90a6dc71c4644
2017-06-07 22:03:46 +02:00
Amir Sarabadani 16abe4f606 Add CODE_OF_CONDUCT.md
Bug: T165540
Change-Id: Ia71b13770ee6bf56d7d3bec09539ded028225c05
2017-06-07 13:47:45 +04:30
Translation updater bot 8d1f8971b5 Localisation updates from https://translatewiki.net.
Change-Id: Id62333c9441409a38fb84c59427aa3152ae3792e
2017-06-06 22:04:18 +02:00
jenkins-bot e722a1daf1 Merge "Add scaffolding for skin" 2017-06-01 17:37:31 +00:00
jdlrobson 2a70a13b69 Add scaffolding for skin
Change-Id: Ie9420dc85f658fa21a1524dca9374cb1e14fcad7
2017-06-01 10:17:24 -07:00
Chad Horohoe dbfc7f6717 Use track=1 instead of defaultbranch=master in .gitreview
Change-Id: I13d0c9f4bf7018558dab0247d6b8f684c283522b
2016-10-24 17:30:30 -07:00
Christian Aistleitner e6a51f136d Add .gitreview 2015-12-20 23:49:57 +01:00