Commit graph

2265 commits

Author SHA1 Message Date
jenkins-bot be177d0b9d Merge "Reduce selector specificity to necessary minimum" 2020-03-11 22:55:32 +00:00
Umherirrender 53fab7c03d Always enable stylelint rules after disable
Change-Id: I3c677fb6e3ff9666e8e50f3a2ad9cd9ac57c29b8
2020-03-11 15:50:14 -07:00
Željko Filipin 9d0ffdd867 Selenium: record videos of all tests
Works only on Linux. It works in our CI, since it uses Linux.
For instructions on how to test it on a Linux machine see:
https://www.mediawiki.org/wiki/Selenium/Node.js/Inside_MediaWiki-Vagrant

Bug: T245250
Change-Id: Ic4d909304b498c56f155bcade40a99f95ed72bcb
2020-03-11 21:03:56 +00:00
jenkins-bot 96c971ca77 Merge "Remove usage of deprecated Revision::newFromTitle" 2020-03-11 16:04:51 +00:00
James D. Forrester 0892d190b6 Drop support for $wgMinervaCustomLogos being set
Bug: T232140
Change-Id: I56dc8ac8d394ad7561ea09e67da6c51db2bc90f9
2020-03-10 20:40:32 +00:00
jenkins-bot 356338ba34 Merge "Remove usage of deprecated Revision::getTimestampFromId" 2020-03-09 13:49:08 +00:00
jenkins-bot 2a04aea819 Merge "build: Add 'sortAttrs' convention rule to 'svgo' & re-run" 2020-03-09 11:42:43 +00:00
Translation updater bot 1218b13a6e Localisation updates from https://translatewiki.net.
Change-Id: Idcf4c169bf8fa6ed4384e67848510c24f1e5bf41
2020-03-09 08:10:10 +01:00
Volker E 8d463a80b3 build: Add 'sortAttrs' convention rule to 'svgo' & re-run
Following SVG optimization & coding conventions.

Change-Id: I0ab8c59a42cfbc4d7c8d600a9eee155c0cb37fa8
2020-03-07 20:09:42 -08:00
Translation updater bot b08bc1d77c Localisation updates from https://translatewiki.net.
Change-Id: I58e1dc5acfd55b0f6a7c10f5b3eb588526095a0b
2020-03-06 07:55:40 +01:00
Volker E d92fffb4a1 build: Update svgo to latest v1.3.2
* svgo: 0.7.2 → 1.3.2

Bug: T246544
Change-Id: I1a1ea9c1c90a4676384ae8aae8a846d09ca13637
2020-03-05 16:25:02 -08:00
Volker E 30fbd44efd Reduce selector specificity to necessary minimum
Further reducing selector specificity. `.action-history` does
a sufficient job.

Change-Id: I9393316b28aa86d99797a03ca164a589f5a942a9
2020-03-05 14:00:43 -08:00
Volker E f955bda480 Word-break overlong usernames
Also de-specify styles, we're already in `.action-history`, specificity
resulted from form elements below.

Bug: T237230
Change-Id: I82d9ab071084624025f1c723d2772a409750dbc9
2020-03-05 13:28:35 -08:00
Translation updater bot a24040f0c8 Localisation updates from https://translatewiki.net.
Change-Id: I59ef03fe9769578684ec63411dc024a775235c9a
2020-03-04 07:59:24 +01:00
Petr Pchelko d9db54120d Remove usage of deprecated Revision::newFromTitle
Bug: T246284
Change-Id: Icd1d7ae5324ab83d0ec2f5ffd6e1f846fab3ca60
2020-03-03 18:53:53 -08:00
Petr Pchelko 583ac2305d Remove usage of deprecated Revision::getTimestampFromId
Bug: T246284
Change-Id: I852af2f19cbd1df0f9137e0f75ed7a272a54a169
2020-03-03 18:19:44 -08:00
jdlrobson 1200cb5279 Storybook added to MinervaNeue
For now just adding story entries for footer element and last modified.

Bug: T244106
Change-Id: Ib36f22f9b9d805f87fc074d12473497cfaf91b79
2020-03-03 15:22:34 +00:00
Translation updater bot c445c2bbfb Localisation updates from https://translatewiki.net.
Change-Id: I1344a79c31114b8246b21f8bc43f20164cbb7027
2020-03-03 07:57:49 +01:00
jdlrobson fb36687fc3 setAttribute takes a string not an array
Since we are dealing with arrays here with the value of classes
but using native DOMElement we need to convert the array to a string

Follow up to  I331912a1cd6cd4293c22a1a48bb32cdec48bd37d

Change-Id: If08d68af8cebecaea02cc29bf779d25d58c0c6c3
2020-03-02 12:05:42 -08:00
Translation updater bot ce3681a48e Localisation updates from https://translatewiki.net.
Change-Id: I5ec34969d07c256bbe3902b0873ff7c89a8ee965
2020-03-02 08:38:55 +01:00
jdlrobson 6b6c6b8d6e Menu items added via addPortletLinks should look like other menu items
Requires `I4c477c88ce48484960e40609cd243e63639175bc` to function.

Bug: T236711
Change-Id: I331912a1cd6cd4293c22a1a48bb32cdec48bd37d
2020-02-29 00:11:28 +00:00
Translation updater bot 3fab70f8bc Localisation updates from https://translatewiki.net.
Change-Id: I5b52fcc1718fa491ede216c4835b610abf0e90f4
2020-02-28 07:57:33 +01:00
James D. Forrester e56349f7a7 Hard-deprecate $wgMinervaCustomLogos being set
Bug: T232140
Depends-On: I2463fecfafbb4c08d80f624adf4cd47a6fb4e660
Change-Id: Ibb70f97c889edf8ffc21737e87949b0294044f9c
2020-02-27 22:04:09 +00:00
Translation updater bot 0f599f49ed Localisation updates from https://translatewiki.net.
Change-Id: I587ac898fc455fa5de0b1522e30ca69d6786f3e7
2020-02-27 08:12:24 +01:00
jenkins-bot 00f515cce5 Merge "Reduce margin in icon and label combination" 2020-02-26 18:50:27 +00:00
jenkins-bot c81c1432d0 Merge "PageActionsMenu: Reduce spacing between icons and text in tablet mode" 2020-02-26 18:50:25 +00:00
Translation updater bot b7ccd6413b Localisation updates from https://translatewiki.net.
Change-Id: I2070c71f50d38a9a128f2f5f69620fdb03eb79b0
2020-02-26 07:59:08 +01:00
jenkins-bot d3a1220dfc Merge "Remove unused 'warning' icon" 2020-02-25 23:36:59 +00:00
jenkins-bot 793cc13a4a Merge "Unify messages for skin specific CSS/JS overrides" 2020-02-25 21:20:24 +00:00
Volker E 62f6b8a17a Unify messages for skin specific CSS/JS overrides
This should probably be following the same logic as other skins.
Similar to Ib40a38dba553bf10.

Change-Id: I881e46478b754a1322357493bea597e754fef63b
2020-02-25 11:47:54 -08:00
Volker E c2bed81acd Remove unused 'warning' icon
Has been introduced in I8d11e655cc and after removal of
cleanuptemplates.js left behind.

Bug: T244444
Change-Id: I47ba73bc528241d98e8f593dcaec3948273fc819
2020-02-25 11:29:40 -08:00
jenkins-bot c583930c0c Merge "Remove 'new' indicator styles on mobile options" 2020-02-24 21:52:17 +00:00
Translation updater bot 65aba24ee3 Localisation updates from https://translatewiki.net.
Change-Id: I2fee56238e4944767b3de807a8faceb109fb3bcc
2020-02-24 08:33:07 +01:00
jenkins-bot cca24fa0cd Merge "Follow-up 51a34809: Don't hard-deprecate something still set in config, you'll break prod" 2020-02-21 18:42:44 +00:00
jenkins-bot 525c9d70c9 Merge "Remove hover background on clear indicator" 2020-02-21 18:00:17 +00:00
Translation updater bot fb0076a52e Localisation updates from https://translatewiki.net.
Change-Id: I84c5d9ea9152044a13796c3e245e13aa8ec4afca
2020-02-21 09:18:31 +01:00
James D. Forrester 278c18057e Follow-up 51a34809: Don't hard-deprecate something still set in config, you'll break prod
Bug: T232140
Change-Id: Icd5b045c3ebc3234fa0e3bcaffb2172209fa0408
2020-02-20 15:20:29 -08:00
Volker E 328f46379d Remove hover background on clear indicator
Align to standard component design. Clear indicator doesn't receive
background hover in an input.

Change-Id: Ibf329b450c6dd1c9913744ab1f6f4af13ec6a35f
2020-02-20 08:25:28 -08:00
Translation updater bot 6c629abbb4 Localisation updates from https://translatewiki.net.
Change-Id: Ic61d3ee79b2e3cc8f2ac9a8626290d524e9996c2
2020-02-20 09:05:48 +01:00
jenkins-bot e838fcec22 Merge "Deprecate wgMinervaCustomLogos in favor of $wgLogos" 2020-02-20 00:29:22 +00:00
jdlrobson 51a348097d Deprecate wgMinervaCustomLogos in favor of $wgLogos
Testing:
```
// Start with no Minerva config and no wgLogos defined in LocalSettings.php

// Set $wgMinervaCustomLogos
// Should trigger deprecation warning.
$wgMinervaCustomLogos = [
	'copyright' => 'https://en.m.wikipedia.org/static/images/mobile/copyright/wikipedia-wordmark-fr.svg',
	'copyright-height' => 40,
	'copyright-width' => 120,
];

// Set wgLogos without wordmark
// Should trigger deprecation warning as $wgMinervaCustomLogos is still
// defined.
$wgLogos = [
	'1x' => 'https://en.wikipedia.beta.wmflabs.org/static/images/project-logos/enwiki.png'
];


// Set wgLogos['wordmark']
// No deprecation warning. $wgMinervaCustomLogos will now be ignored
// in favor of the new wordmark key.
$wgLogos = [
	'1x' => 'https://en.wikipedia.beta.wmflabs.org/static/images/project-logos/enwiki.png',
	'wordmark' => [
		'src' => 'https://en.m.wikipedia.org/static/images/mobile/copyright/wikipedia-wordmark-fr.svg',
		'height' => 40,
		'width' => 120,
	],
];

// You can now safely drop $wgMinervaCustomLogos.

```
Depends-On: I66a971631c623cc94b58eb0e5e5bad804789bf1c
Bug: T232140
Change-Id: I013bd0904fe8c55efa49d14e84cf06ec1412896f
2020-02-19 23:59:28 +00:00
Volker E d7039ab8ac Remove 'new' indicator styles on mobile options
These have been only in use for AMC, in case we need them again, we
will bring them back.

Bug: T245654
Depends-On: I0bfcbd9378b3fea4d532b78b250ce05a13f71edb
Change-Id: Ibdb69e92de5a0cf20413b0fb576a6797f7bf1771
2020-02-19 19:50:01 +00:00
Translation updater bot 47732ee8d8 Localisation updates from https://translatewiki.net.
Change-Id: I3fa5983cc1156947e8648ca27ccd1f27f2f430af
2020-02-19 07:57:13 +01:00
jenkins-bot 30fac0ca85 Merge "Do not allow raw HTML in talk page overlay header" 2020-02-18 23:48:37 +00:00
jenkins-bot dc688ad85f Merge "Check title value before proceeding to check if user page" 2020-02-18 21:31:25 +00:00
jenkins-bot 27642e94e7 Merge "Fix Minerva print mode to correctly show top of document" 2020-02-18 18:06:43 +00:00
jdlrobson b3b50ce854 Fix Minerva print mode to correctly show top of document
When we built the new main menu we started using a `nav` element.
Update selectors to hide the `nav` element when printing from
mobile.

When printing from tablet or desktop make sure the header is displayed.

Bug: T244181
Change-Id: I7f60fd11d969a48e1c7926ad8acc4213f9affed4
2020-02-18 17:50:30 +00:00
Translation updater bot 1180765f92 Localisation updates from https://translatewiki.net.
Change-Id: I96bb79c8fdcc02e32484fd467c34cee382974542
2020-02-18 08:04:50 +01:00
Volker E d9306ee74d Unify SVGO rules to Wikimedia coding conventions and re-crush SVGs
Remove disabling 'collapseGroups' and 'mergePaths' rules, as they have been
successfully been part of wide SVG optimizations in various different products
and are part of the exemplified safe configuration of Wikimedia SVG coding
convention.
Bring standard 'editLocked' icon with correct size to MN.

Bug: T245296
Change-Id: I385e176a647a799176a6f59e364d165387137224
2020-02-18 00:41:06 +00:00
jdlrobson 7f47dff5e5 Use icons in skins.minerva.mainMenu.icons from OOUI
For all mainMenu icons pull from OOUI icon packs.

We make the necessary changes to Definitions.php, ToolbarBuilder
and LogoutMenuEntry to ensure to update icon glyph names.

There are caching implications for icons that show to anonymous users -
these have been fixed for grade A browsers running JS by appending the
new class to impacted elements.

Grade C browsers being served cached HTML will not benefit from this
emporary fix as available solutions are costly.
As a result these users will not see icons until the cache
expires (maximum of 4 weeks but likely 1 week) or is flushed via
action=purge.

This is acceptable given the amount of impacted users and the fact that
icons are not essential for using the main menu.

Note: The communityportal.svg icon while in the resources folder was
not referenced anywhere in the codebase so its removal is safe.
Please note the same icon in skins.minerva.mainMenu.advanced.icons which
is used for the community portal menu item.

Bug: T244444
Change-Id: I0f929f2f3b11362e02f0d02f57b90b34b5c93d24
2020-02-17 20:36:28 +00:00