Commit graph

16 commits

Author SHA1 Message Date
Fomafix 2b5e3b1b80 Update Apache config syntax in .htaccess files
"Deny from all" is deprecated; the replacement syntax has been
available since Apache 2.4 (originally released in 2012).

See <https://httpd.apache.org/docs/2.4/howto/access.html>.

Bug: T360850
Change-Id: I6b641c76f3229b70b07422295623deb5612b8030
2024-11-17 21:53:55 +00:00
Jon Robson 0dbe68f974 Remove storybook and update nvm version
The Minerva storybook only has 2 stories which look broken.
Given we never actively began using it, I suggest we remove it
from the repo.

Bug: T310004
Change-Id: I42ce4248f376c683ddbbf3f1ec0e275906f6ab45
2023-03-31 09:39:56 -07:00
jdlrobson 9fa0f3a64d Use MediaWiki UI version 2 from core in Minerva
Depends-on: Ibc136a17662ae839f90babb21e0f7e8f27b7a7d5
Bug: T191021
Change-Id: Ifdc3a3273aa93129177a11814651ec811c20f49c
2021-07-20 11:59:23 -07:00
Volker E a0a69d2d85 build: Unify 'svg_check.sh'
Simplify readability and reduce output to errors only on terminal.
Also includes suppression for consecutive errors as added in Popups
in I5ef7843c9de122c8dce61fbb98737c8acdd0c22c.

Change-Id: Ib4705667815cf690e327fdc5f9048c6d6ce779a6
2021-04-30 04:39:11 -07:00
Volker E 28394a1367 build: Upgrade 'svgo' to latest and re-crush SVGs
Upgrading to SVGO v2.3.0 and changing over to new JS config.
Also amending svg check shell script and re-crushing
all SVGs.

Bug: T278656
Change-Id: Ic52d7eb595073e5bde166e5cf5767772c5eb60ce
2021-04-20 17:45:18 +00:00
Volker E 32724f8183 styles: Implement mediawiki.skin.variables.less for MinervaNeue
For now, only define:

- @font-family-sans (unused in MinervaNeue, but for possible future use)
- @border-radius-base

With current implementation before this patch, MinervaNeue is relying on core's default
`@border-radius` which is set to `0` to be close to HTML default. 
MinervaNeue is currently not applying correct skin's `border-radius`.

Bug: T263270
Change-Id: I9a149eefd15efede27416ada4db07072e53628ec
2020-11-02 17:56:40 +00:00
Volker E 9d1db05e7b Fix storybook dev-script imports
* Correctly pull down mediawiki.skin.variables.less
* Update source of clock icon in last modified bar
* Update query selectors
* Push to docs.wikimedia.org so things do not break so easily
again

Bug: T263270
Change-Id: I93cb7e53fb78d3a03019583b3b0c69a057088044
2020-09-25 11:47:09 -07:00
jdlrobson 7408d87465 Run bundlesize tests on every commit
It was added in 7340485014
but for some reason never enabled.

This was supposed to be protecting us from performance regressions
by monitoring the size of modules in the repo. It appears to be
broken both locally and on Jenkins when run on the due to some changes
in Phabricator.

Since then we've added bundle size tests to Vector using a different
more foolproof method. I think that method is more preferable as it
also provides coverage for JS and icons so the
associated script is copied over and used in Minerva
and activated on all commits.

Bug: T259080
Change-Id: I9ba2dcc060ec09d91814c947d5be3f71b055a66e
2020-07-28 23:43:38 +00:00
Volker E bb6827122c Naming convention using 'skin' as entrance point
Similar to Ief1c469724d4ffe238d307407c3ddb46f2e1abfa

Change-Id: Ibca2473b14ef258f92e71524489298e2f53ed873
2020-05-29 14:32:12 -07:00
jdlrobson 1200cb5279 Storybook added to MinervaNeue
For now just adding story entries for footer element and last modified.

Bug: T244106
Change-Id: Ib36f22f9b9d805f87fc074d12473497cfaf91b79
2020-03-03 15:22:34 +00:00
jdlrobson 7340485014 Monitor render blocking css bundle sizes
Add a script that builds CSS for Minerva using lessc than measures
their bundlesize.

This will give us added protection to large increases in bundlesize
that can lead to performance regressions.

Change-Id: I2e5e55ad10fac7ecb5a8c19ccdf3cc54de59b75d
2020-01-29 11:03:59 +00:00
Stephen Niedzielski 8ac5b9c663 Hygiene: remove unused pre-commit script
dev-scripts/pre-commit is unused since 5037568 which added the
pre-commit NPM package. Remove the script.

Change-Id: I7b7e11415dc6ada17a5fe6bc1a390cc5de80851a
2018-09-18 17:01:31 +00:00
Antoine Musso 8a220e372c Make svg_check.sh verbose
So we know what is going on while the CPU is being busy.

Change-Id: I34a7ecadf549833025a197d72ca131888519a92a
2017-12-11 16:50:56 +01:00
Antoine Musso a38b4f8038 Pass svg_checks.sh via ShellCheck
while read svgfile; do
    SC2162: read without -r will mangle backslashes.

if [ $(wc -c < "$svgfile") -gt $(wc -c < "$outfile") ];
    SC2046: quote to prevent word splitting

found increment was done in a subshell and hence would not be properly
incremented. Instead of:

  find | while

Switch to:

  while < <( find )

Based on https://github.com/koalaman/shellcheck/wiki/SC2031 , this way
$found is kept in the same context.

Change-Id: Id8eb1027eed373161c8e7932b7745d4f53f2fc6c
2017-12-11 16:48:49 +01:00
Fomafix db97b4e202 Make shell script robust against spaces in file names
Also
* Simplify wc.
* Add period at end of sentences.
* Use tabs instead of spaces for indenting.
* Add newline at end of file.

Change-Id: I50a9d31acecc32bcf693cba5022152aa9abcbaab
2017-08-30 12:27:19 +02:00
jdlrobson 59a17fd0af Add tooling for svg size checking
also add pre-commit hook to ensure svgs are
compressed on commit

since extensions are accessible via http an .htaccess
is added to the dev-scripts folder for safety.

Bug: T170639
Change-Id: Ibcd5c29340d16c9cffc6e2eb90d33ee89b69874f
2017-07-14 11:07:08 -07:00