wikimedia/mediawiki-skins-MinervaNeue
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/skins/MinervaNeue synced 2024-11-13 17:37:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix external icon specificity

Browse source 
We've changed the selector in MW core to `.mw-parser-output a.external`
a while ago. In order to show the correct image, selector needs to be
amended.

Change-Id: I83d7b4c8be2eda1876959d000e0fb2d493e12cbc
This commit is contained in:
Volker E 2021-11-08 23:13:02 -08:00
parent 0a9598ec97
commit ff24bbe030
2 changed files with 14 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
resources/skins.minerva.base.styles/content/links.less
View file

@ -40,15 +40,19 @@ a {
&:hover { &:hover {
text-decoration: underline; text-decoration: underline;
} }
}
&.external { // External links
// background-image is specified by ResourceLoader. // Use of `a` element selector due to its widespread usage and for limiting generic class scope.
// Force the image size to be 10px. // `a.external` is for footer's “Creative Commons” license link only.
background-size: 10px; a.external,
background-repeat: no-repeat; .mw-parser-output a.external {
background-position: center right; // background-image is specified by ResourceLoader via skin.json.
padding-right: 13px; background-position: center right;
} background-repeat: no-repeat;
// Force the image size to be 10px.
background-size: 10px;
padding-right: 13px;
} }
// Generic class name needed // Generic class name needed

4
skin.json
View file

@ -290,9 +290,9 @@
} }
}, },
"images": { "images": {
"toast.mw-notification-type-error,.mw-notification.mw-notification-type-error": "toast.mw-notification-type-error, .mw-notification.mw-notification-type-error":
"resources/skins.minerva.content.styles.images/error.svg", "resources/skins.minerva.content.styles.images/error.svg",
"a.external": { "a.external, .mw-parser-output a.external": {
"file": { "file": {
"ltr": "resources/skins.minerva.content.styles.images/link-external-ltr.svg", "ltr": "resources/skins.minerva.content.styles.images/link-external-ltr.svg",
"rtl": "resources/skins.minerva.content.styles.images/link-external-rtl.svg" "rtl": "resources/skins.minerva.content.styles.images/link-external-rtl.svg"