From db96b68d817da18f0e5b96f389c7d1e59d30ce63 Mon Sep 17 00:00:00 2001 From: jdlrobson Date: Tue, 22 Jan 2019 11:44:54 -0800 Subject: [PATCH] QA: Cleanup page issues browser test * The check for whether the page issues code has been loaded should be run just before clicking the banner. It's in the wrong place. * Now page issues is live across all wikis, no need for "in beta" check * Seledctor can be simplified now no need to worry about beta Change-Id: Ie24a9d9fc1966ca5db2cd0a6a37c1aa6d719924a --- tests/browser/features/issues.feature | 1 - tests/browser/features/step_definitions/issues_steps.rb | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/browser/features/issues.feature b/tests/browser/features/issues.feature index 073252d52..e6522f72b 100644 --- a/tests/browser/features/issues.feature +++ b/tests/browser/features/issues.feature @@ -3,7 +3,6 @@ Feature: Issues Background: Given I am using the mobile site - And I am in beta mode And I am on a page which has cleanup templates And this page has issues diff --git a/tests/browser/features/step_definitions/issues_steps.rb b/tests/browser/features/step_definitions/issues_steps.rb index e9ac6b0e1..c16e56c19 100644 --- a/tests/browser/features/step_definitions/issues_steps.rb +++ b/tests/browser/features/step_definitions/issues_steps.rb @@ -11,11 +11,11 @@ When(/^I see the issues overlay$/) do end When(/^this page has issues$/) do + on(ArticlePage).wait_until_rl_module_ready('skins.minerva.scripts') on(ArticlePage).issues_stamp_element.when_present end Then(/^I should not see the issues overlay$/) do - on(ArticlePage).wait_until_rl_module_ready('skins.minerva.scripts') expect(on(ArticlePage).overlay_element).not_to be_visible end