wikimedia/mediawiki-skins-MinervaNeue
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/skins/MinervaNeue synced 2024-11-27 23:50:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

QA: Relax toast notification QA steps

Browse source 
It seems trying to test both the steps can cause
false positives. Relaxing these checks seems to make
our Jenkins job happy without breaking the tests themselves

Change-Id: I119111e97f23d2f0dac7cbb0e5b86c1df0562598
This commit is contained in:
jdlrobson 2017-08-08 11:56:04 -05:00
parent c2cad50d50
commit f6df202786
1 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
tests/browser/features/step_definitions/common_article_steps.rb
View file

@ -32,14 +32,13 @@ Then(/^I should see a toast notification$/) do
# Minerva loads mediawiki.notify at startup which defers the loading of this module
# We must wait until the lazy loading has happened before checking for the toast (T170890)
page.wait_until_rl_module_ready('mediawiki.notification')
expect(page.notification_area_element.when_visible).to be_visible
end
expect(on(ArticlePage).notification_area_element.when_visible).to be_visible
expect(on(ArticlePage).toast_element.when_visible).to be_visible
end
Then(/^I should see a toast with message "(.+)"$/) do |msg|
step "I should see a toast notification"
on(ArticlePage) do |page|
page.wait_until_rl_module_ready('mediawiki.notification')
page.wait_until do
page.toast_element.when_present.text.include? msg
end