wikimedia/mediawiki-skins-MinervaNeue
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/skins/MinervaNeue synced 2024-11-12 08:58:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

Hygiene: Do not insert Random menu entry if message do not exists

Browse source 
The `randompage-url` message might not be defined, or be set to
'-' which means - this text do not exist. Minerva should respect
that, instead of showing a link that points nowhere/to a '-' page

Bug: T188697
Change-Id: If97d29b0e25f3635e94bf3b80b051355ea49cf7d
This commit is contained in:
Piotr Miazga 2019-07-09 13:05:00 +02:00
parent d2e723daf9
commit f190f7492a
1 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
includes/menu/Definitions.php
View file

@ -142,11 +142,13 @@ final class Definitions {
* @throws MWException * @throws MWException
*/ */
public function insertRandomItem( Group $group ) { public function insertRandomItem( Group $group ) {
$page = $this->context->msg( 'randompage-url' )->escaped(); $pageMsg = new Message( 'randompage-url' );
// Random link if ( !$pageMsg->exists() ) {
return;
}
$group->insert( 'random' ) $group->insert( 'random' )
->addComponent( $this->context->msg( 'mobile-frontend-random-button' )->escaped(), ->addComponent( $this->context->msg( 'mobile-frontend-random-button' )->escaped(),
Title::newFromText( $page )->getLocalURL() . '#/random', Title::newFromText( $pageMsg->escaped() )->getLocalURL() . '#/random',
MinervaUI::iconClass( 'random', 'before' ), [ MinervaUI::iconClass( 'random', 'before' ), [
'id' => 'randomButton', 'id' => 'randomButton',
'data-event-name' => 'random', 'data-event-name' => 'random',