From ee9ec002340f8a93da155a87de2cc98a54c8c3b3 Mon Sep 17 00:00:00 2001 From: Baha Date: Fri, 11 May 2018 12:51:50 -0400 Subject: [PATCH] Don't turn off listening to reference clicks For event logging purposes we need to be able to listen to reference and backlink clicks. Clicks on these elements were disabled before this patch. Although clicking on backlinks was disabled, it wasn't working properly as the user could click on those links and be taken to the reference. Thus this piece of code has been removed. Bug: T191086 Change-Id: Idbaa39523a35f3b649f521be05c83255aa2b1396 --- resources/skins.minerva.scripts/references.js | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/resources/skins.minerva.scripts/references.js b/resources/skins.minerva.scripts/references.js index 70c41d97a..0f520d867 100644 --- a/resources/skins.minerva.scripts/references.js +++ b/resources/skins.minerva.scripts/references.js @@ -102,12 +102,10 @@ if ( $refs.length ) { $refs - .off( 'click' ) - .on( 'click', { + .off( 'click.references' ) + .on( 'click.references', { page: page }, onClickReference ); - page.$( '.mw-cite-backlink a' ) - .off( 'click' ); } }