wikimedia/mediawiki-skins-MinervaNeue
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/skins/MinervaNeue synced 2024-11-23 22:03:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

build: Upgrade mediawiki-codesniffer to v28.0.0

Browse source 
Change-Id: I8ce5f16f496f048f6bcf587c545745193dbfe151
This commit is contained in:
James D. Forrester 2019-10-11 12:04:00 -07:00
parent 72d4a103fd
commit e8d227b78e
6 changed files with 11 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
.phpcs.xml
View file

@ -2,8 +2,11 @@
<ruleset>
<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
<exclude name="Generic.Files.OneObjectStructurePerFile.MultipleFound" />
<exclude name="MediaWiki.Commenting.PhpunitAnnotations.ForbiddenExpectedException" />
<exclude name="MediaWiki.Commenting.PhpunitAnnotations.ForbiddenExpectedExceptionMessage" />
<exclude name="MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName"/>
<exclude name="MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment"/>
<exclude name="PSR12.Properties.ConstantVisibility.NotFound" />
</rule>
<file>.</file>
<arg name="extensions" value="php,php5,inc"/>

2
composer.json
View file

@ -1,7 +1,7 @@
{
"require-dev": {
"jakub-onderka/php-parallel-lint": "1.0.0",
"mediawiki/mediawiki-codesniffer": "24.0.0",
"mediawiki/mediawiki-codesniffer": "28.0.0",
"jakub-onderka/php-console-highlighter": "0.3.2",
"mediawiki/minus-x": "0.3.1",
"mediawiki/mediawiki-phan-config": "0.6.1"

2
includes/menu/Main/MainMenuDirector.php
View file

@ -23,7 +23,7 @@ use Html;
use MessageLocalizer;
use MinervaUI;
use SpecialPage;
use \MediaWiki\Special\SpecialPageFactory;
use MediaWiki\Special\SpecialPageFactory;
/**
* Director responsible for building Main Menu

1
includes/menu/PageActions/ToolbarBuilder.php
View file

@ -71,6 +71,7 @@ class ToolbarBuilder {
* @var LanguagesHelper
*/
private $languagesHelper;
/**
* Build Group containing icons for toolbar
* @param Title $title Article title user is currently browsing

2
includes/skins/SkinMinerva.php
View file

@ -333,6 +333,7 @@ class SkinMinerva extends SkinTemplate {
$tpl->set( 'userNotificationsHTML', $badge );
}
}
/**
* Rewrites the language list so that it cannot be contaminated by other extensions with things
* other than languages
@ -481,6 +482,7 @@ class SkinMinerva extends SkinTemplate {
$attrs[ 'class' ] = 'tagline';
return Html::element( 'div', $attrs, $tagline );
}
/**
* Returns the HTML representing the heading.
* @return string HTML for header

3
tests/phpunit/skins/SkinMinervaTest.php
View file

@ -19,12 +19,15 @@ class EchoNotifUser {
$this->lastUnreadMessageTime = $lastUnreadMessageTime;
$this->echoNotificationCount = $echoNotificationCount;
}
public function getLastUnreadAlertTime() {
return $this->lastUnreadAlertTime;
}
public function getLastUnreadMessageTime() {
return $this->lastUnreadMessageTime;
}
public function getNotificationCount() {
return $this->echoNotificationCount;
}