diff --git a/resources/skins.minerva.scripts/errorLogging.js b/resources/skins.minerva.scripts/errorLogging.js index b236cebbc..efc65e0a4 100644 --- a/resources/skins.minerva.scripts/errorLogging.js +++ b/resources/skins.minerva.scripts/errorLogging.js @@ -1,10 +1,5 @@ ( function ( M, requestIdleCallback, track, config, trackSubscribe, user, experiments ) { requestIdleCallback( function () { - /** - * Errors count in the current pageview - * @type {number} - */ - var errorsCount = 0; /** * Handle an error and log it if necessary * @param {string} errorMessage to be logged @@ -35,7 +30,7 @@ isAnon: user.isAnon(), revision: page.getRevisionId() }; - errorsCount++; + if ( isErrorLoggingEnabled ) { track( EVENT_CLIENT_ERROR_LOG, util.extend( { @@ -50,10 +45,8 @@ }, DEFAULT_ERROR_DATA ) ); } - } - function logErrorsCount() { - if ( errorsCount > 0 ) { - mw.track( 'counter.MediaWiki.minerva.WebClientError', errorsCount ); + if ( config.get( 'wgMinervaCountErrors' ) ) { + mw.track( 'counter.MediaWiki.minerva.WebClientError', 1 ); } } // track RL exceptions @@ -65,9 +58,6 @@ trackSubscribe( 'global.error', function ( topic, error ) { handleError( error.errorMessage, error.lineNumber, error.columnNumber, error.url ); } ); - if ( config.get( 'wgMinervaCountErrors' ) ) { - $( window ).on( 'beforeunload', logErrorsCount ); - } } ); }( mw.mobileFrontend,