From d87eed1c6bfb355b8b083a0315918532c7eba606 Mon Sep 17 00:00:00 2001 From: Nicholas Ray Date: Mon, 3 Feb 2020 15:15:36 -0700 Subject: [PATCH] =?UTF-8?q?=F0=9F=9A=BF=20Hygiene:=20Remove=20unused=20$me?= =?UTF-8?q?nuData=20variable=20from=20`getSkinConfigVariables`=20method?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit As far as I can tell, this is unused and the invoked method doesn't cause any side effects. Therefore, I think it can be safely removed. Change-Id: I8b507b4bf38a8a0e70684165d8a48c2d284cdd11 --- includes/skins/SkinMinerva.php | 1 - 1 file changed, 1 deletion(-) diff --git a/includes/skins/SkinMinerva.php b/includes/skins/SkinMinerva.php index a12e8c88c..612604f20 100644 --- a/includes/skins/SkinMinerva.php +++ b/includes/skins/SkinMinerva.php @@ -730,7 +730,6 @@ class SkinMinerva extends SkinTemplate { public function getSkinConfigVariables() { $title = $this->getTitle(); - $menuData = $this->getMainMenu()->getMenuData(); $vars = [ 'wgMinervaPermissions' => [ 'watch' => $this->getPermissions()->isAllowed( IMinervaPagePermissions::WATCH ),