wikimedia/mediawiki-skins-MinervaNeue
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/skins/MinervaNeue synced 2024-09-24 10:48:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

Adding a static width/height for mw-ui-icon background images.

Browse source 
Adds a static width/height for icon background images as well
as min width/height for situation where flexbox layout
is at play.

Bug: T233521
Change-Id: I3a4ced61dac78df7a3411a5d8510949b491c8591
This commit is contained in:
Jan Drewniak 2019-10-02 22:21:42 +02:00
parent 783e391bb9
commit c703e94fd3
1 changed files with 14 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
skinStyles/mediawiki.ui.icon/mediawiki.ui.icon.less
View file

@ -19,16 +19,21 @@
/**
* Mixin for a pseudo-element with a background image.
*/
.mixin-background-square() {
// sizing
.mixin-background-square( @size ) {
// Sizing properties
content: '';
display: block;
width: 100%;
height: 100%;
// In case display: block is overridden and display gets set to `flex`
// because of inheritance T233521.
min-width: @size;
min-height: @size;
// background
// Background properties.
background-repeat: no-repeat;
background-size: contain;
// Using static value instead of `background-size: contain` because of T233521#5545513.
background-size: @size @size;
background-position: center;
}
@ -67,7 +72,7 @@
padding: 0;
&:before {
.mixin-background-square();
.mixin-background-square( @icon-size-md );
}
}
@ -111,6 +116,10 @@
height: @icon-size-sm;
flex-basis: @icon-size-sm;
line-height: @icon-size-sm;
&:before {
.mixin-background-square( @icon-size-sm );
}
}
.mw-ui-icon-small.mw-ui-icon-element {
@ -136,7 +145,6 @@
max-width: 100%;
&:before {
.mixin-background-square();
// sizing
display: inline-block;
font-size: initial;