wikimedia/mediawiki-skins-MinervaNeue
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/skins/MinervaNeue synced 2024-11-24 22:25:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

Issues instrumentation: issuesClicked events should always send 1 sectionNumber

Browse source 
Erroneously in I6fd55c35b9e2ce35894259f36d1a50fb5dca5e43 for the old treatment
 we sent sectionNumbers for all issues in the page.

This is inconsistent with the issuesSeverity field above it
Add a clarifying inline comment.

Bug: T203050
Change-Id: Ib1fcda0c49a162cd7aca8ee8b3221236f724e1d7
This commit is contained in:
jdlrobson 2018-09-06 17:37:33 -07:00
parent fd517597aa
commit c68f7ba09f
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
resources/skins.minerva.scripts/pageIssues.js
View file

@ -198,7 +198,11 @@
.map( function ( issue ) { return issue.severity; } )
)
],
sectionNumbers: getAllIssuesSections( allIssues )
// In the old treatment, an issuesClicked event will always be '0'
// as the old treatment is always associated with the lead section and we
// are only sending one maximum severity for all of them.
// An issuesClicked event should only ever be associated with one issue box.
sectionNumbers: [ '0' ]
} );
} );
if ( $metadata.length ) {