wikimedia/mediawiki-skins-MinervaNeue
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/skins/MinervaNeue synced 2024-09-23 18:28:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Use document.body and document.documentElement as jQuery selector"

Browse source
This commit is contained in:
jenkins-bot 2020-01-06 22:25:14 +00:00 committed by Gerrit Code Review
parent ce687f1261 f482ee198e
commit c5fc4d05df
3 changed files with 5 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
resources/skins.minerva.scripts/TabScroll.js
View file

@ -13,7 +13,7 @@ function testScrollLeftStyle() {
dir: 'rtl',
style: 'font-size: 14px; width: 4px; height: 1px; position: absolute; top: -1000px; overflow: scroll;'
} ).text( 'ABCD' );
$definer.appendTo( 'body' );
$definer.appendTo( document.body );
definer = $definer[ 0 ];
if ( definer.scrollLeft > 0 ) {
// Safari, Chrome

3
resources/skins.minerva.scripts/page-issues/index.js
View file

@ -135,8 +135,7 @@
// set A-B test class.
// When wgMinervaPageIssuesNewTreatment is the default this can be removed.
if ( newTreatmentEnabled ) {
// eslint-disable-next-line no-jquery/no-global-selector
$( 'html' ).addClass( 'issues-group-B' );
$( document.documentElement ).addClass( 'issues-group-B' );
}
if ( CURRENT_NS === NS_TALK || CURRENT_NS === NS_CATEGORY ) {

7
resources/skins.minerva.scripts/talk.js
View file

@ -149,8 +149,7 @@ module.exports = function ( mobile ) {
.text( mw.message( 'minerva-talk-full-page' ).text() )
.on( 'click', function () {
restoreSectionHeadings();
// eslint-disable-next-line no-jquery/no-global-selector
$( 'body' ).removeClass( 'skin-minerva--talk-simplified' );
$( document.body ).removeClass( 'skin-minerva--talk-simplified' );
$( this ).remove();
// send user back up to top of page so they don't land awkwardly in
// middle of page when it expands
@ -233,8 +232,8 @@ module.exports = function ( mobile ) {
* @return {boolean}
*/
function isSimplifiedViewEnabled() {
// eslint-disable-next-line no-jquery/no-class-state, no-jquery/no-global-selector
return $( 'body' ).hasClass( SKIN_MINERVA_TALK_SIMPLIFIED_CLASS );
// eslint-disable-next-line no-jquery/no-class-state
return $( document.body ).hasClass( SKIN_MINERVA_TALK_SIMPLIFIED_CLASS );
}
/**