Prepare for new mw-ui-icon spec for Minerva

Includes icon fixes and removal of some CSS overrides.

This causes the following temporary defects to the skin:
* Last modified bar will temporarily be squashed
* clear search  icon will be misaligned vertically

Depends-On:  Ie811d25595d041c35e6c214190101821f3a5d466
Bug: T229440
Change-Id: I0a3a73421791ad353bbcebaeb8241ad062f67ae4
This commit is contained in:
Jan Drewniak 2019-09-11 14:19:47 +02:00 committed by Jdlrobson
parent f3e516e30f
commit be76f05ebb
12 changed files with 41 additions and 59 deletions

View file

@ -1,11 +1,11 @@
<div class="last-modified-bar view-border-box footer-element">
<div class="content">
<div class="last-modifier-tagline truncated-text {{clockIconClass}}">
<span class="{{arrowIconClass}}"></span><a href="{{href}}"
data-user-name="{{data-user-name}}"
data-user-gender="{{data-user-gender}}"
data-timestamp="{{data-timestamp}}"><span>{{text}}</span>
</a>
</div>
<div class="content last-modified-bar view-border-box footer-element">
<div class="last-modifier-tagline truncated-text {{clockIconClass}}">
<span class="{{arrowIconClass}}"></span>
<a href="{{href}}"
data-user-name="{{data-user-name}}"
data-user-gender="{{data-user-gender}}"
data-timestamp="{{data-timestamp}}">
<span>{{text}}</span>
</a>
</div>
</div>
</div>

View file

@ -63,4 +63,4 @@
</div>
</div>
<div class="mw-notification-area" data-mw="interface"></div>
<!-- v:8.1.10 -->
<!-- v:8.1.11 -->

View file

@ -28,8 +28,6 @@ footer {
.last-modifier-tagline {
@end-padding: @iconGutterWidth + @iconGutterWidth + @iconSize;
display: block;
width: 100%;
padding: 7px @end-padding 7px 0;
.truncated-text();
> a,
@ -42,7 +40,8 @@ footer {
.indicator {
position: absolute;
right: -1em;
top: 0;
right: 0;
.client-nojs & {
// Certain browsers e.g. Opera Mini do not support css transforms

View file

@ -42,7 +42,7 @@
.page-actions-menu__list-item {
display: flex;
flex-basis: 4em;
justify-content: flex-start;
justify-content: flex-end;
align-items: center;
li > *:hover {

View file

@ -189,11 +189,6 @@ input.search {
clear: left;
}
.edit-page {
display: block;
font-size: initial;
}
.collapsible-heading .edit-page {
visibility: hidden;
}
@ -211,8 +206,11 @@ input.search {
margin-bottom: @headingMargin;
.indicator {
font-size: initial;
margin-left: -@iconGutterWidth;
// FIXME: Can be removed when https://gerrit.wikimedia.org/r/535835 is merged
font-size: initial;
// FIXME: Can be removed when https://gerrit.wikimedia.org/r/535835 is merged
vertical-align: initial;
}
}

View file

@ -3,7 +3,7 @@
// The top level user account button in the upper right near the notifications button.
.minerva-user-navigation {
display: flex;
height: @siteHeaderHeight;
height: 100%;
// Fill empty space left / start so the buttons can stay right / end.
width: 100%;
// Keep space for at least two buttons.
@ -15,10 +15,6 @@
// Show the list relative the button.
position: relative;
.mw-ui-icon-element {
display: block;
}
.toggle-list {
width: @menuButtonIconSize;
display: inline-block;

View file

@ -12,6 +12,7 @@
display: none;
position: relative;
margin: 1em 0;
padding: 0.2em 0.5em;
background-color: @colorGray15;
border: solid 1px @grayLightest;
box-sizing: border-box;
@ -42,11 +43,12 @@
background-position: right center;
font-weight: bold;
border-bottom: 0;
padding: @toctitle-vertical-padding 3.5em @toctitle-vertical-padding 3.5em;
h2 {
display: inline-block;
font-family: @fontFamilyBase;
font-size: unit( 18/16, em );
vertical-align: middle;
}
}

View file

@ -14,7 +14,6 @@
right: 0;
top: 0;
bottom: 0;
padding-right: 0;
border-left: 1px solid @grayMediumLight;
}

View file

@ -4,22 +4,6 @@
@animationDuration: 0.3s;
// Table of contents icons
.toctitle {
.mw-ui-icon {
position: absolute;
top: 1.2em;
&:first-child {
left: 0;
}
&:last-child {
right: 0;
}
}
}
// Flip the arrow in table of contents when toggled
.toctogglecheckbox:checked ~ .toctitle .mw-ui-icon:last-child {
&:before {

View file

@ -1,5 +1,11 @@
// IN RTL languages in Chrome, a failure to set top: 0 will make the icon disappear
// more context: https://phabricator.wikimedia.org/T232260#5476625
.mw-ui-icon {
display: inline-block;
font-size: initial;
vertical-align: middle;
}
.mw-ui-icon:before {
top: 0;
bottom: 0;

View file

@ -17,26 +17,24 @@
}
}
.overlay-header.header {
.overlay-header {
height: @overlayHeaderHeight;
}
.overlay-header .header-action {
> a,
> button {
.mw-ui-anchor,
.mw-ui-button {
height: @overlayHeaderHeight;
}
}
.overlay-header .overlay-title {
padding: @headerVerticalPadding 0;
.overlay-title {
padding: @headerVerticalPadding 0;
&:last-child {
// Reserve space to the right in case the search form in the header or
// overlay title in the overlay header is the last element. Use @iconGutterWidth
// because there is a hamburger or close/back icon next to this element and
// the space between them is exactly that.
padding-right: @iconGutterWidth;
&:last-child {
// Reserve space to the right in case the search form in the header or
// overlay title in the overlay header is the last element. Use @iconGutterWidth
// because there is a hamburger or close/back icon next to this element and
// the space between them is exactly that.
padding-right: @iconGutterWidth;
}
}
}

View file

@ -15,7 +15,7 @@
.clear {
position: absolute;
top: 0.9em;
top: 0.5em;
right: 0;
}
}