wikimedia/mediawiki-skins-MinervaNeue
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/skins/MinervaNeue synced 2024-09-24 18:58:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

Dev: Access OverlayManager via singleton method not M.define

Browse source 
Change-Id: Icb152f21bfd3a091676980a025dc651e49f49312
This commit is contained in:
jdlrobson 2019-09-05 16:52:27 -07:00 committed by Jdlrobson
parent 4d24e068eb
commit 96cee263fb
3 changed files with 3 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
resources/skins.minerva.options/categories.js
View file

@ -4,7 +4,8 @@ module.exports = function () {
mobile = M.require( 'mobile.startup' ),
loader = mobile.rlModuleLoader,
features = mw.config.get( 'wgMinervaFeatures', {} ),
overlayManager = require( 'skins.minerva.scripts' ).overlayManager,
OverlayManager = mobile.OverlayManager,
overlayManager = OverlayManager.getSingleton(),
eventBus = mobile.eventBusSingleton,
isAnon = mw.user.isAnon();

3
resources/skins.minerva.scripts/init.js
View file

@ -357,7 +357,4 @@
isSmall: true
} ).$el.appendTo( '.toctitle' );
} );
module.exports = {
overlayManager: overlayManager
};
}( mw.mobileFrontend ) );

2
resources/skins.minerva.talk/init.js
View file

@ -11,7 +11,7 @@
$talk = $( '.talk, [rel="discussion"]' ),
// use the plain return value here - T128273
title = $talk.attr( 'data-title' ),
overlayManager = require( 'skins.minerva.scripts' ).overlayManager,
overlayManager = mobile.OverlayManager.getSingleton(),
// FIXME: This dependency shouldn't exist
skin = mobile.Skin.getSingleton(),
inTalkNamespace = false,