From e565347cd4384972a75498bca88cbcf171297bed Mon Sep 17 00:00:00 2001 From: Thiemo Kreuz Date: Fri, 17 Dec 2021 11:29:11 +0100 Subject: [PATCH] Remove some comments that literally repeat the code Change-Id: I3960735fa59f7d607659acd31167802ee769a519 --- includes/Menu/Entries/SingleMenuEntry.php | 4 ++-- includes/Menu/PageActions/PageActionsDirector.php | 2 +- includes/Menu/PageActions/ToolbarBuilder.php | 2 +- includes/Permissions/MinervaPagePermissions.php | 6 +++--- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/includes/Menu/Entries/SingleMenuEntry.php b/includes/Menu/Entries/SingleMenuEntry.php index 61e669f90..9ab4e0d45 100644 --- a/includes/Menu/Entries/SingleMenuEntry.php +++ b/includes/Menu/Entries/SingleMenuEntry.php @@ -109,8 +109,8 @@ class SingleMenuEntry implements IMenuEntry { /** * Set the Menu entry icon - * @param string|null $iconName Icon name - * @param string $iconType Icon type + * @param string|null $iconName + * @param string $iconType * @param string $additionalClassNames Additional classes * @param string $iconPrefix either `wikimedia` or `minerva` * @return $this diff --git a/includes/Menu/PageActions/PageActionsDirector.php b/includes/Menu/PageActions/PageActionsDirector.php index a77d06561..77912af0d 100644 --- a/includes/Menu/PageActions/PageActionsDirector.php +++ b/includes/Menu/PageActions/PageActionsDirector.php @@ -47,7 +47,7 @@ final class PageActionsDirector { /** * Director responsible for Page Actions menu building * - * @param ToolbarBuilder $toolbarBuilder The toolbar builder + * @param ToolbarBuilder $toolbarBuilder * @param IOverflowBuilder $overflowBuilder The overflow menu builder * @param MessageLocalizer $messageLocalizer Message localizer used to translate texts */ diff --git a/includes/Menu/PageActions/ToolbarBuilder.php b/includes/Menu/PageActions/ToolbarBuilder.php index 84bf1fa4c..a33b0c118 100644 --- a/includes/Menu/PageActions/ToolbarBuilder.php +++ b/includes/Menu/PageActions/ToolbarBuilder.php @@ -99,7 +99,7 @@ class ToolbarBuilder { * @param User $user Currently logged in user * @param MessageLocalizer $msgLocalizer Message localizer to generate localized texts * @param IMinervaPagePermissions $permissions Minerva permissions system - * @param SkinOptions $skinOptions Skin options + * @param SkinOptions $skinOptions * @param SkinUserPageHelper $relevantUserPageHelper User Page helper. The * UserPageHelper passed should always be specific to the user page Title. If on a * user talk page, UserPageHelper should be instantiated with the user page diff --git a/includes/Permissions/MinervaPagePermissions.php b/includes/Permissions/MinervaPagePermissions.php index 43ed60300..5ef0c392f 100644 --- a/includes/Permissions/MinervaPagePermissions.php +++ b/includes/Permissions/MinervaPagePermissions.php @@ -45,7 +45,7 @@ final class MinervaPagePermissions implements IMinervaPagePermissions { private $config; /** - * @var User user object + * @var User */ private $user; @@ -65,7 +65,7 @@ final class MinervaPagePermissions implements IMinervaPagePermissions { private $languagesHelper; /** - * @var PermissionManager MediaWiki Core PermissionManager + * @var PermissionManager */ private $permissionManager; @@ -76,7 +76,7 @@ final class MinervaPagePermissions implements IMinervaPagePermissions { /** * Initialize internal Minerva Permissions system - * @param SkinOptions $skinOptions Skin options` + * @param SkinOptions $skinOptions * @param LanguagesHelper $languagesHelper * @param PermissionManager $permissionManager * @param IContentHandlerFactory $contentHandlerFactory