From 8eb65b264d639d186c05fa6175d900a58253f833 Mon Sep 17 00:00:00 2001 From: jdlrobson Date: Thu, 16 Nov 2017 15:21:05 -0800 Subject: [PATCH] If timestamp is null load revision time Passing null to wfTimestamp will result in the current time. Protect against that happening Bug: T180103 Change-Id: I6ef9577bf52609bf387b0146f1d8a4a53be58cd7 --- includes/skins/SkinMinerva.php | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/includes/skins/SkinMinerva.php b/includes/skins/SkinMinerva.php index 344bc06ab..fa2ede2fc 100644 --- a/includes/skins/SkinMinerva.php +++ b/includes/skins/SkinMinerva.php @@ -729,6 +729,11 @@ class SkinMinerva extends SkinTemplate implements ICustomizableSkin { $isMainPage = $title->isMainPage(); // Get rev_timestamp of current revision (preloaded by MediaWiki core) $timestamp = $this->getOutput()->getRevisionTimestamp(); + # No cached timestamp, load it from the database + if ( $timestamp === null ) { + $timestamp = Revision::getTimestampFromId( $this->getTitle(), $this->getRevisionId() ); + } + // Main pages tend to include transclusions (see bug 51924) if ( $isMainPage ) { $lastModified = $this->msg( 'mobile-frontend-history' )->plain();