wikimedia/mediawiki-skins-MinervaNeue
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/skins/MinervaNeue synced 2024-11-24 14:23:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove double setIcon() call for Contributions element on Toolbar

Browse source 
Fix Contributions element classes by not using ::create named
constructor. The constructor was provided for easier object creation
when both icon and click tracking is the same as element name.
The Contributions icon is not that case, as both tracking code and
icon are definited differently than the name, therefore we need
to initailize class, and set required attributes manually.

Change-Id: Ia91bbdcfd737a443a05fd4f61853fe8bd200e56c
This commit is contained in:
Piotr Miazga 2019-12-09 20:46:20 +01:00 committed by Pmiazga
parent acfa96e8e0
commit 7e2403c5ad
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
includes/menu/PageActions/ToolbarBuilder.php
View file

@ -153,7 +153,7 @@ class ToolbarBuilder {
$pageUser = $this->userPageHelper->getPageUser();
$label = $this->messageLocalizer->msg( 'mobile-frontend-user-page-contributions' );
$entry = SingleMenuEntry::create(
$entry = new SingleMenuEntry(
'page-actions-contributions',
$label,
SpecialPage::getTitleFor( 'Contributions', $pageUser )->getLocalURL() );