From 77646a40c3692ddaac8b5506cde4922b3ef92f29 Mon Sep 17 00:00:00 2001 From: Stephen Niedzielski Date: Mon, 1 Oct 2018 12:54:52 -0600 Subject: [PATCH] Hygiene: inline util.noop Replace mobile.startup/util.noop with inlined implementation, `function() {}`, to reduce indirect dependencies on jQuery (.noop). Change-Id: I48368ef6cf03fd67e117c9bf8612bbddb7d250c5 --- resources/skins.minerva.scripts/references.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/resources/skins.minerva.scripts/references.js b/resources/skins.minerva.scripts/references.js index 447ce8dc1..5652fedcf 100644 --- a/resources/skins.minerva.scripts/references.js +++ b/resources/skins.minerva.scripts/references.js @@ -3,7 +3,6 @@ skin = M.require( 'skins.minerva.scripts/skin' ), page = M.getCurrentPage(), router = require( 'mediawiki.router' ), - util = M.require( 'mobile.startup/util' ), ReferencesGateway = M.require( 'mobile.references.gateway/ReferencesGateway' ), ReferencesMobileViewGateway = M.require( 'mobile.references.gateway/ReferencesMobileViewGateway' @@ -59,7 +58,7 @@ // Previously showReference method returns nothing so we check its truthy // Can be removed when I5a7b23f60722eb5017a85c68f38844dd460f8b63 is merged. if ( result ) { - result.then( util.noop, function ( err ) { + result.then( function () {}, function ( err ) { if ( err === ReferencesGateway.ERROR_NOT_EXIST ) { router.navigate( href ); }