wikimedia/mediawiki-skins-MinervaNeue
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/skins/MinervaNeue synced 2024-12-18 00:30:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "LanguagesHelperTest: Use @dataProvider to configure test cases"

Browse source
This commit is contained in:
jenkins-bot 2024-03-11 07:18:51 +00:00 committed by Gerrit Code Review
parent 88b78b247c 2f5b6f7c02
commit 6954616670
1 changed files with 15 additions and 31 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

46
tests/phpunit/LanguagesHelperTest.php
View file

@ -58,44 +58,28 @@ class LanguagesHelperTest extends MediaWikiIntegrationTestCase {
} }
/** /**
* @dataProvider provideDoesTitleHasLanguagesOrVariants
* @param bool $hasVariants
* @param array $langLinks
* @param bool $expected
* @covers ::__construct * @covers ::__construct
* @covers ::doesTitleHasLanguagesOrVariants * @covers ::doesTitleHasLanguagesOrVariants
*/ */
public function testReturnsWhenOutputPageHasLangLinks() { public function testDoesTitleHasLanguagesOrVariants( bool $hasVariants, array $langLinks, bool $expected ) {
$helper = new LanguagesHelper( $helper = new LanguagesHelper(
$this->getLanguageConverterFactory( false ), $this->getLanguageConverterFactory( $hasVariants ),
$this->getOutput( [ 'pl:StronaTestowa', 'en:TestPage' ] ) $this->getOutput( $langLinks )
); );
$this->assertTrue( $helper->doesTitleHasLanguagesOrVariants( $this->getTitle() ) ); $this->assertSame( $expected, $helper->doesTitleHasLanguagesOrVariants( $this->getTitle() ) );
$helper = new LanguagesHelper(
$this->getLanguageConverterFactory( true ),
$this->getOutput( [ 'pl:StronaTestowa', 'en:TestPage' ] )
);
$this->assertTrue( $helper->doesTitleHasLanguagesOrVariants( $this->getTitle() ) );
} }
/** public static function provideDoesTitleHasLanguagesOrVariants() {
* @covers ::__construct return [
* @covers ::doesTitleHasLanguagesOrVariants [ false, [ 'pl:StronaTestowa', 'en:TestPage' ], true ],
*/ [ true, [ 'pl:StronaTestowa', 'en:TestPage' ], true ],
public function testReturnsWhenOutputDoesNotHaveLangLinks() { [ false, [], false ],
$helper = new LanguagesHelper( [ true, [], true ],
$this->getLanguageConverterFactory( false ), ];
$this->getOutput( [] )
);
$this->assertFalse( $helper->doesTitleHasLanguagesOrVariants(
$this->getTitle() ) );
$helper = new LanguagesHelper(
$this->getLanguageConverterFactory( true ),
$this->getOutput( [] )
);
$this->assertTrue( $helper->doesTitleHasLanguagesOrVariants(
$this->getTitle() ) );
} }
} }