From 692309090dea405144a9e224524a5fec52e51700 Mon Sep 17 00:00:00 2001
From: Piotr Miazga <piotr@polishdeveloper.pl>
Date: Thu, 18 Apr 2019 20:32:23 +0200
Subject: [PATCH] Remove Recent Changes from Main Menu

We decided to remove the Recent Changes menu entry from Advanced
menu for now, we might come back to it later.
For more info: https://phabricator.wikimedia.org/T216152#5123296

Bug: T216152
Change-Id: I6342e273fdc5f483692de6e1ac238c38d06f3e5f
---
 includes/menu/Definitions.php                   | 17 -----------------
 includes/menu/Main/AdvancedBuilder.php          |  1 -
 .../recentchanges.svg                           |  1 -
 skin.json                                       |  1 -
 4 files changed, 20 deletions(-)
 delete mode 100644 resources/skins.minerva.mainMenu.icons/recentchanges.svg

diff --git a/includes/menu/Definitions.php b/includes/menu/Definitions.php
index ab583a00d..b8a4b2810 100644
--- a/includes/menu/Definitions.php
+++ b/includes/menu/Definitions.php
@@ -277,23 +277,6 @@ final class Definitions {
 		}
 	}
 
-	/**
-	 * Build and insert the RecentChanges link
-	 * @param Group $group
-	 * @throws MWException
-	 */
-	public function insertRecentChanges( Group $group ) {
-		$title = SpecialPage::getTitleFor( 'Recentchanges' );
-
-		$group->insert( 'recentchanges' )
-			->addComponent(
-				$this->context->msg( 'recentchanges' )->escaped(),
-				$title->getLocalURL(),
-				MinervaUI::iconClass( 'recentchanges', 'before' ),
-				[ 'data-event-name' => 'recentchanges' ]
-			);
-	}
-
 	/**
 	 * Build and insert the SpecialPages link
 	 * @param Group $group
diff --git a/includes/menu/Main/AdvancedBuilder.php b/includes/menu/Main/AdvancedBuilder.php
index bbdcecefe..7214cf51d 100644
--- a/includes/menu/Main/AdvancedBuilder.php
+++ b/includes/menu/Main/AdvancedBuilder.php
@@ -57,7 +57,6 @@ class AdvancedBuilder extends DefaultBuilder {
 	public function getSiteTools() {
 		$group = new Group();
 
-		$this->definitions->insertRecentChanges( $group );
 		$this->definitions->insertSpecialPages( $group );
 		$this->definitions->insertCommunityPortal( $group );
 
diff --git a/resources/skins.minerva.mainMenu.icons/recentchanges.svg b/resources/skins.minerva.mainMenu.icons/recentchanges.svg
deleted file mode 100644
index cb357ba77..000000000
--- a/resources/skins.minerva.mainMenu.icons/recentchanges.svg
+++ /dev/null
@@ -1 +0,0 @@
-<svg width="21" height="17" xmlns="http://www.w3.org/2000/svg"><path d="M0 16.625h21v-4.156H0v4.156zm2.1-3.117h2.1v2.078H2.1v-2.078zM0 0v4.156h21V0H0zm4.2 3.117H2.1V1.04h2.1v2.078zM0 10.391h21V6.234H0v4.157zm2.1-3.118h2.1v2.079H2.1V7.273z" fill="#4A4F53"/></svg>
\ No newline at end of file
diff --git a/skin.json b/skin.json
index dc23c36f6..0fbd8b1db 100644
--- a/skin.json
+++ b/skin.json
@@ -345,7 +345,6 @@
 				"settings": "resources/skins.minerva.mainMenu.icons/settings.svg",
 				"watchlist": "resources/skins.minerva.mainMenu.icons/watchlist.svg",
 				"contributions": "resources/skins.minerva.mainMenu.icons/contributions.svg",
-				"recentchanges": "resources/skins.minerva.mainMenu.icons/recentchanges.svg",
 				"specialpages": "resources/skins.minerva.mainMenu.icons/specialpages.svg",
 				"communityportal": "resources/skins.minerva.mainMenu.icons/communityportal.svg"
 			}