diff --git a/resources/skins.minerva.notifications.badge/NotificationBadge.js b/resources/skins.minerva.notifications.badge/NotificationBadge.js index f3b228199..819ec88a9 100644 --- a/resources/skins.minerva.notifications.badge/NotificationBadge.js +++ b/resources/skins.minerva.notifications.badge/NotificationBadge.js @@ -1,5 +1,6 @@ ( function ( M ) { var View = M.require( 'mobile.startup/View' ), + util = M.require( 'mobile.startup/util' ), Icon = M.require( 'mobile.startup/Icon' ), notificationIcon = new Icon( { name: 'notifications', @@ -30,7 +31,11 @@ window.location.href = this.getNotificationURL(); }.bind( this ); } - View.call( this, options ); + View.call( this, + util.extend( options, { + isBorderBox: false + } ) + ); this.url = options.url; this._bindOverlayManager(); this.setCount( count ); @@ -53,7 +58,6 @@ hasUnseenNotifications: false, notificationCountRaw: 0 }, - isBorderBox: false, /** * Loads a ResourceLoader module script. Shows ajax loader whilst loading. * @method diff --git a/resources/skins.minerva.options/BackToTopOverlay.js b/resources/skins.minerva.options/BackToTopOverlay.js index a08a69504..b043be350 100644 --- a/resources/skins.minerva.options/BackToTopOverlay.js +++ b/resources/skins.minerva.options/BackToTopOverlay.js @@ -1,18 +1,23 @@ ( function ( M ) { - var View = M.require( 'mobile.startup/View' ); + var View = M.require( 'mobile.startup/View' ), + util = M.require( 'mobile.startup/util' ); /** * Displays a little arrow at the bottom right of the viewport. * @class BackToTopOverlay * @extends View + * @param {Object} props */ - function BackToTopOverlay() { - View.apply( this, arguments ); + function BackToTopOverlay( props ) { + View.call( this, + util.extend( {}, props, { + className: 'backtotop' + } ) + ); } OO.mfExtend( BackToTopOverlay, View, { - className: 'backtotop', template: mw.template.get( 'skins.minerva.options', 'BackToTopOverlay.hogan' ), events: $.extend( {}, View.prototype.events, { click: 'onBackToTopClick' diff --git a/resources/skins.minerva.scripts/PageIssuesOverlay.js b/resources/skins.minerva.scripts/PageIssuesOverlay.js index 9d47f495e..e8f736515 100644 --- a/resources/skins.minerva.scripts/PageIssuesOverlay.js +++ b/resources/skins.minerva.scripts/PageIssuesOverlay.js @@ -27,17 +27,12 @@ Overlay.call( this, { issues: issues, + className: 'overlay overlay-issues', heading: '' + headingText + '' } ); } OO.mfExtend( PageIssuesOverlay, Overlay, { - /** - * @memberof PageIssuesOverlay - * @instance - */ - className: 'overlay overlay-issues', - /** * @memberof PageIssuesOverlay * @instance