Always enable stylelint rules after disable

Change-Id: I3c677fb6e3ff9666e8e50f3a2ad9cd9ac57c29b8
This commit is contained in:
Umherirrender 2020-02-28 21:28:59 +01:00 committed by jdlrobson
parent 30fbd44efd
commit 53fab7c03d
8 changed files with 10 additions and 73 deletions

View file

@ -15,7 +15,7 @@
} }
/* TODO: Fix specificity */ /* TODO: Fix specificity */
/* stylelint-disable no-descending-specificity */ /* stylelint-disable-next-line no-descending-specificity */
.client-js .jsonly { .client-js .jsonly {
display: inherit; display: inherit;
} }

View file

@ -309,3 +309,4 @@ input.search {
padding-right: @contentPaddingTablet; padding-right: @contentPaddingTablet;
} }
} }
/* stylelint-enable no-descending-specificity */

View file

@ -8,7 +8,6 @@
* links can be differentiated from other links. Thus we only apply the linkColor to links with href * links can be differentiated from other links. Thus we only apply the linkColor to links with href
* attributes. * attributes.
*/ */
/* stylelint-disable no-descending-specificity */
a:not( [ href ] ) { a:not( [ href ] ) {
color: @colorGray2; color: @colorGray2;
@ -16,6 +15,7 @@ a:not( [ href ] ) {
cursor: pointer; cursor: pointer;
} }
/* stylelint-disable-next-line no-descending-specificity */
a { a {
text-decoration: none; text-decoration: none;
color: @linkColor; color: @linkColor;

View file

@ -39,6 +39,7 @@
align-items: center; align-items: center;
-webkit-box-pack: center; -webkit-box-pack: center;
justify-content: center; justify-content: center;
/* stylelint-enable declaration-block-no-duplicate-properties */
span { span {
font-weight: bold; font-weight: bold;

View file

@ -90,3 +90,4 @@
.transform( none ); .transform( none );
} }
} }
// stylelint-enable no-descending-specificity, selector-max-id

View file

@ -1,8 +1,6 @@
@import '../../minerva.less/minerva.variables.less'; @import '../../minerva.less/minerva.variables.less';
@import '../../minerva.less/minerva.mixins.less'; @import '../../minerva.less/minerva.mixins.less';
/* stylelint-disable no-descending-specificity */
.notifications-overlay { .notifications-overlay {
visibility: visible; visibility: visible;
} }

View file

@ -4,7 +4,8 @@
@import 'mediawiki.ui/mixins.buttons.less'; @import 'mediawiki.ui/mixins.buttons.less';
.action-history { .action-history {
#mw-content-text > form { // stylelint-disable-line selector-max-id // stylelint-disable-next-line selector-max-id
#mw-content-text > form {
margin: 0; margin: 0;
} }
@ -14,7 +15,8 @@
// form element wrapping history page content. Overrides #mw-content-text > form // form element wrapping history page content. Overrides #mw-content-text > form
// for tablet widths. // for tablet widths.
#mw-history-compare { // stylelint-disable-line selector-max-id // stylelint-disable-next-line selector-max-id
#mw-history-compare {
width: 100%; width: 100%;
max-width: 100%; max-width: 100%;
} }
@ -68,74 +70,7 @@
margin-bottom: 1em; margin-bottom: 1em;
} }
// (cur|prev) links
.mw-history-histlinks {
float: right;
}
// Date
.mw-changeslist-date {
float: left;
font-weight: bold;
clear: none;
}
// User name
.history-user {
float: left;
// margin separates the entire username (talk | contrib) block
// from the (cur|prev) links on the right. Approximates a  
margin-right: 0.5em;
.mw-userlink {
// margin separates the username
// from the (talk | contrib) links. Approximates a  
margin-right: 0.5em;
// Word-break overlong usernames, see T237230.
.hyphens( auto );
}
}
// Container for rollback, undo buttons
.mw-changeslist-links:not( .mw-usertoollinks ):not( .mw-history-histlinks ) {
// removing parentheses around undo button
& > span:before {
content: '';
}
& > span:after {
content: '';
}
}
// edit summary
.comment {
// meant to give space for the undo button to the right of
// the revision description.
width: 65%;
}
// edit summary, +/- bytes changed, tags
.comment,
.updatedmarker,
.mw-diff-bytes,
.mw-tag-markers {
float: left;
clear: left;
}
// add left margin to create a faux column after the radio buttons
.history-user,
.comment,
.updatedmarker,
.mw-diff-bytes,
.mw-history-tools,
.mw-tag-markers {
margin-left: @revision-selectors-width;
}
// stylelint-disable selector-max-id // stylelint-disable selector-max-id
// `#pagehistory` needs to come last due to id specificity best-practice.
#pagehistory { #pagehistory {
margin-bottom: 24px; margin-bottom: 24px;
padding: 0; padding: 0;

View file

@ -26,3 +26,4 @@
margin: 0; margin: 0;
} }
} }
// stylelint-enable selector-max-id