wikimedia/mediawiki-skins-MinervaNeue
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/skins/MinervaNeue synced 2024-11-24 22:25:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

Hygiene: remove window.location use from overlays

Browse source 
Bug: T173539
Depends-On: I158dd7883be2846cf0d48bbd7e89fe2cd64a57d3
Change-Id: I87741667ca06cc701e5265aff13ba0492501de26
This commit is contained in:
Stephen Niedzielski 2018-03-06 21:30:56 -06:00
parent ce2b87e1c6
commit 41a43c5ce1
1 changed files with 4 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
resources/skins.minerva.scripts/init.js
View file

@ -112,15 +112,10 @@
thumbnails: thumbs, thumbnails: thumbs,
title: decodeURIComponent( title ) title: decodeURIComponent( title )
} ); } );
imageOverlay.on( ImageOverlay.EVENT_EXIT, function ( ev ) { imageOverlay.on( ImageOverlay.EVENT_EXIT, function () {
// Prevent going back in browser's history. // Actually dismiss the overlay whenever the cross is closed.
// See T94188 & T94363. window.location.hash = '';
ev.preventDefault(); // Clear the hash.
ev.stopPropagation();
// Manually close the overlay (OverlayManager does not expose a method
// to hide the active overlay).
imageOverlay.hide();
// Update the URL by clearing fragment.
router.navigate( '' ); router.navigate( '' );
} ); } );
imageOverlay.on( ImageOverlay.EVENT_SLIDE, function ( nextThumbnail ) { imageOverlay.on( ImageOverlay.EVENT_SLIDE, function ( nextThumbnail ) {