wikimedia/mediawiki-skins-MinervaNeue
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/skins/MinervaNeue synced 2024-09-23 10:19:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Replace WebRequest::getText and ::getVal by ::getRawVal or ::getCheck"

Browse source
This commit is contained in:
jenkins-bot 2024-04-09 22:36:34 +00:00 committed by Gerrit Code Review
parent 68002d2d69 6f30044448
commit 1f0a94241c
2 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
includes/Hooks.php
View file

@ -196,7 +196,7 @@ class Hooks implements
// Add default warning message to Special:UserLogin and Special:UserCreate
// if no warning message set.
if (
!$request->getVal( 'warning' ) &&
!$request->getCheck( 'warning' ) &&
!$special->getUser()->isRegistered() &&
!$request->wasPosted()
) {

10
includes/Skins/SkinMinerva.php
View file

@ -479,7 +479,7 @@ class SkinMinerva extends SkinMustache {
* @return bool
*/
private function isHistoryPage() {
return $this->getRequest()->getText( 'action' ) === 'history';
return $this->getRequest()->getRawVal( 'action' ) === 'history';
}
/**
@ -687,7 +687,7 @@ class SkinMinerva extends SkinMustache {
// check to see if night mode is enabled via query params or by config
$webRequest = $this->getContext()->getRequest();
$forceNightMode = $webRequest->getText( 'minervanightmode' );
$forceNightMode = $webRequest->getRawVal( 'minervanightmode' );
// get skin config of night mode to check what is execluded
$nightModeConfig = $this->getConfig()->get( 'MinervaNightModeOptions' );
@ -698,7 +698,7 @@ class SkinMinerva extends SkinMustache {
);
if (
$this->skinOptions->get( SkinOptions::NIGHT_MODE ) || $forceNightMode !== ''
$this->skinOptions->get( SkinOptions::NIGHT_MODE ) || $forceNightMode !== null
) {
$user = $this->getUser();
$value = $this->userOptionsManager->getOption( $user, 'minerva-theme' );
@ -812,7 +812,7 @@ class SkinMinerva extends SkinMustache {
}
// Do not show the last modified bar on diff pages [T350515]
$request = $this->getRequest();
if ( $request->getText( 'diff' ) ) {
if ( $request->getCheck( 'diff' ) ) {
return null;
}
@ -1094,7 +1094,7 @@ class SkinMinerva extends SkinMustache {
// and inside the fallback editor styles to action=edit page.
if (
$title->getNamespace() !== NS_MAIN ||
$request->getText( 'oldid' ) ||
$request->getCheck( 'oldid' ) ||
!$viewAction
) {
$styles[] = 'skins.minerva.messageBox.styles';