From 1b38bfbfc6f3da26178f98b09d151371800988c8 Mon Sep 17 00:00:00 2001 From: Jon Robson Date: Thu, 3 Oct 2024 13:06:12 -0400 Subject: [PATCH] Disable unused icon variants By default this module was inheriting variants and since it doesnt declare a property selectorWithVariant it was using the default selectorWithVariant rule which impacts OOUI icons. Explicitly disable the variants for this module as they are unused. This reduces the size of the modules. Follow up to: I87b060cf98194d81679da2610944f58e8d941389 Bug: T374145 Bug: T376226 Change-Id: Icc008449ee498a946066c4ce5d46adcac194bd3b --- bundlesize.config.json | 4 ++-- skin.json | 4 ++++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/bundlesize.config.json b/bundlesize.config.json index 6819ad463..cc6675a8d 100644 --- a/bundlesize.config.json +++ b/bundlesize.config.json @@ -13,11 +13,11 @@ }, { "resourceModule": "skins.minerva.icons.wikimedia", - "maxSize": "0.95KB" + "maxSize": "0.5KB" }, { "resourceModule": "skins.minerva.mainMenu.icons", - "maxSize": "0.8KB" + "maxSize": "0.4KB" }, { "resourceModule": "skins.minerva.mainMenu.styles", diff --git a/skin.json b/skin.json index 1ef878dff..1cf4aefdc 100644 --- a/skin.json +++ b/skin.json @@ -372,6 +372,7 @@ "useDataURI": false, "defaultColor": "#54595d", "class": "MediaWiki\\ResourceLoader\\OOUIIconPackModule", + "variants": [], "useMaskImage": true, "icons": [ "block", @@ -400,6 +401,7 @@ "useDataURI": false, "defaultColor": "#54595d", "class": "MediaWiki\\ResourceLoader\\OOUIIconPackModule", + "variants": [], "useMaskImage": true, "icons": [ "edit", @@ -428,6 +430,7 @@ }, "skins.minerva.personalMenu.icons": { "class": "MediaWiki\\ResourceLoader\\OOUIIconPackModule", + "variants": [], "useMaskImage": true, "selectorWithoutVariant": ".minerva-icon--{name}", "defaultColor": "#54595d", @@ -451,6 +454,7 @@ }, "skins.minerva.mainMenu.icons": { "class": "MediaWiki\\ResourceLoader\\OOUIIconPackModule", + "variants": [], "useMaskImage": true, "selectorWithoutVariant": ".minerva-icon--{name}", "defaultColor": "#54595d",