wikimedia/mediawiki-skins-MinervaNeue
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/skins/MinervaNeue synced 2024-11-27 23:50:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "MinervaPagePermissions: Don't assume that indirectly editable contents don't have an edit action"

Browse source
This commit is contained in:
jenkins-bot 2022-11-08 13:55:59 +00:00 committed by Gerrit Code Review
parent 65457be99d 83b959fc8f
commit 15eaff1a5a
1 changed files with 17 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
includes/Permissions/MinervaPagePermissions.php
View file

@ -213,9 +213,23 @@ final class MinervaPagePermissions implements IMinervaPagePermissions {
* @return bool
*/
protected function isCurrentPageContentModelEditable() {
return $this->contentHandler
&& $this->contentHandler->supportsDirectEditing()
&& $this->contentHandler->supportsDirectApiEditing();
if ( !$this->contentHandler ) {
return false;
}
if (
$this->contentHandler->supportsDirectEditing() &&
$this->contentHandler->supportsDirectApiEditing()
) {
return true;
}
// For content types with custom action=edit handlers, let them do their thing
if ( array_key_exists( 'edit', $this->contentHandler->getActionOverrides() ?? [] ) ) {
return true;
}
return false;
}
/**