From 145db7028684d9ca559a1bc03818a77b6e1f6c27 Mon Sep 17 00:00:00 2001
From: Jon Robson <jdlrobson@gmail.com>
Date: Tue, 13 Feb 2024 18:55:25 -0800
Subject: [PATCH] Reset: Drop p and div inside overlays

Required for proper presentation of page issues overlay
and multimedia viewer.

The div rules were unnecessary.

Bug: T205341
Change-Id: I6fea0f2013a11e5248b71619b795d794c8ed18ad
---
 resources/skins.minerva.base.styles/reset.less           | 1 -
 .../page-issues/overlay/pageIssuesOverlay.less           | 4 ++++
 skin.json                                                | 3 +++
 skinStyles/mobile.mediaViewer.less                       | 9 +++++++++
 skinStyles/mobile.startup/search/SearchOverlay.less      | 5 +++++
 5 files changed, 21 insertions(+), 1 deletion(-)
 create mode 100644 skinStyles/mobile.mediaViewer.less

diff --git a/resources/skins.minerva.base.styles/reset.less b/resources/skins.minerva.base.styles/reset.less
index b8cc60171..ef8395125 100644
--- a/resources/skins.minerva.base.styles/reset.less
+++ b/resources/skins.minerva.base.styles/reset.less
@@ -1,4 +1,3 @@
-div, p,
 /* needed for navigation elements and content */
 ul, li, ol {
 	margin: 0;
diff --git a/resources/skins.minerva.scripts/page-issues/overlay/pageIssuesOverlay.less b/resources/skins.minerva.scripts/page-issues/overlay/pageIssuesOverlay.less
index 44f3653c1..5563b43c2 100644
--- a/resources/skins.minerva.scripts/page-issues/overlay/pageIssuesOverlay.less
+++ b/resources/skins.minerva.scripts/page-issues/overlay/pageIssuesOverlay.less
@@ -50,6 +50,10 @@
 			line-height: 1;
 		}
 
+		p {
+			margin: 0;
+		}
+
 		// assume date
 		small i {
 			color: var( --color-subtle );
diff --git a/skin.json b/skin.json
index 372434ff7..7daad86de 100644
--- a/skin.json
+++ b/skin.json
@@ -196,6 +196,9 @@
 			"mobile.init.styles": [
 				"skinStyles/mobile.init.styles/mobile.less"
 			],
+			"mobile.mediaViewer": [
+				"skinStyles/mobile.mediaViewer.less"
+			],
 			"mobile.special.nearby.styles": [
 				"skinStyles/mobile.special.nearby.styles.less"
 			],
diff --git a/skinStyles/mobile.mediaViewer.less b/skinStyles/mobile.mediaViewer.less
new file mode 100644
index 000000000..32a91ca0e
--- /dev/null
+++ b/skinStyles/mobile.mediaViewer.less
@@ -0,0 +1,9 @@
+.overlay.media-viewer {
+	.image-details .truncated-text {
+		margin: 0;
+	}
+
+	.license {
+		margin-bottom: 0;
+	}
+}
diff --git a/skinStyles/mobile.startup/search/SearchOverlay.less b/skinStyles/mobile.startup/search/SearchOverlay.less
index 9d93bec70..72d912f05 100644
--- a/skinStyles/mobile.startup/search/SearchOverlay.less
+++ b/skinStyles/mobile.startup/search/SearchOverlay.less
@@ -9,6 +9,11 @@
 		top: @height-site-header;
 	}
 
+	.with-results,
+	.without-results {
+		margin: 0;
+	}
+
 	.clear {
 		background: none;
 		position: absolute;