wikimedia/mediawiki-skins-MinervaNeue
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/skins/MinervaNeue synced 2024-11-24 06:13:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

LanguagesHelperTest: Remove unused parameter from method getTitle

Browse source 
The remaining
  ->expects( $this->any() )
is also removed, because it doesn't check anything.

Change-Id: I7651fa7f04fb314ff998cd9d68fd2a6099e4aadb
This commit is contained in:
Fomafix 2024-03-02 20:07:16 +00:00
parent 707d9340a5
commit 0e82eb5d40
1 changed files with 3 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
tests/phpunit/LanguagesHelperTest.php
View file

@ -8,7 +8,6 @@ use MediaWiki\Languages\LanguageConverterFactory;
use MediaWiki\Output\OutputPage; use MediaWiki\Output\OutputPage;
use MediaWiki\Title\Title; use MediaWiki\Title\Title;
use MediaWikiIntegrationTestCase; use MediaWikiIntegrationTestCase;
use PHPUnit\Framework\MockObject\Invocation;
/** /**
* @package Tests\MediaWiki\Minerva * @package Tests\MediaWiki\Minerva
@ -34,20 +33,18 @@ class LanguagesHelperTest extends MediaWikiIntegrationTestCase {
/** /**
* Build test Title object * Build test Title object
* @param bool $hasVariants * @param bool $hasVariants
* @param Invocation|null $matcher
* @return Title * @return Title
*/ */
private function getTitle( $hasVariants, Invocation $matcher = null ) { private function getTitle( $hasVariants ) {
$languageMock = $this->createMock( Language::class ); $languageMock = $this->createMock( Language::class );
$langConv = $this->createMock( ILanguageConverter::class ); $langConv = $this->createMock( ILanguageConverter::class );
$langConv->expects( $matcher ?? $this->any() )->method( 'hasVariants' )->willReturn( $hasVariants ); $langConv->method( 'hasVariants' )->willReturn( $hasVariants );
$langConvFactory = $this->createMock( LanguageConverterFactory::class ); $langConvFactory = $this->createMock( LanguageConverterFactory::class );
$langConvFactory->method( 'getLanguageConverter' )->with( $languageMock )->willReturn( $langConv ); $langConvFactory->method( 'getLanguageConverter' )->with( $languageMock )->willReturn( $langConv );
$this->setService( 'LanguageConverterFactory', $langConvFactory ); $this->setService( 'LanguageConverterFactory', $langConvFactory );
$title = $this->createMock( Title::class ); $title = $this->createMock( Title::class );
$title->expects( $matcher ?? $this->any() ) $title->method( 'getPageLanguage' )
->method( 'getPageLanguage' )
->willReturn( $languageMock ); ->willReturn( $languageMock );
return $title; return $title;