wikimedia/mediawiki-skins-MinervaNeue
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/skins/MinervaNeue synced 2024-12-01 01:06:31 +00:00
Code Issues Packages Projects Releases Wiki Activity
mediawiki-skins-MinervaNeue/skin.json

633 lines
19 KiB
JSON
Raw Normal View History

Add scaffolding for skin Change-Id: Ie9420dc85f658fa21a1524dca9374cb1e14fcad7
2017-04-11 02:30:17 +00:00
{
Move skin metadata keys to top of skin.json The keys that form the credits (name/description/url/etc.) are usually on top, and manifest_version is typically on the bottom. Change-Id: I1767b1e176c9cf892c1f627db4f5891fa6aade18
2018-05-08 01:19:40 +00:00
"name": "MinervaNeue",
"namemsg": "skinname-minerva",
"descriptionmsg": "minerva-skin-desc",
Set some authors inside Minerva Apologies in advance if any unintentional hurt feelings! This is based on a git blame of the skins directory in I985c4e3a88b59461d471945ccf74cd291db45a61 before the Minerva move and consulting the extension.json of MobileFrontend. I've listed anyone with over 100 commits to the MobileFrontend resources/ skins folder as an author. The Readers Web Team as the current maintainers are listed first. If you feel you should be listed as an author of this skin as someone who has contributed more than 100 commits to the skin code (not MobileFrontend code), apologies and please add yourself. Change-Id: Ifffb07d1decb47a5e08b9c45c88ccf106f0797a1
2018-07-24 11:26:36 +00:00
"author": [
"[https://www.mediawiki.org/wiki/Reading/Web/Team Readers Web Team]",
"Bahodir Mansurov",
"Joaquin Hernandez",
"Jon Robson",
"Juliusz Gonera",
"Ryan Kaldari",
"Florian Schmidt",
"Sam Smith"
],
Move skin metadata keys to top of skin.json The keys that form the credits (name/description/url/etc.) are usually on top, and manifest_version is typically on the bottom. Change-Id: I1767b1e176c9cf892c1f627db4f5891fa6aade18
2018-05-08 01:19:40 +00:00
"type": "skin",
"url": "https://www.mediawiki.org/wiki/Skin:MinervaNeue",
"license-name": "GPL-2.0-or-later",
"requires": {
Force type Language for $lang of doEditSectionLink wfGetLangObj() is not necessary anymore. This change increases the requirement to MediaWiki 1.32 or higher. Depends-On: Id49201957e716ef8a2ea930b3616ca4fe6e35633 Change-Id: I18adeebe476b321546ceda43eb12b6cf7e8081b3
2018-05-30 04:38:14 +00:00
"MediaWiki": ">= 1.32.0",
Move skin metadata keys to top of skin.json The keys that form the credits (name/description/url/etc.) are usually on top, and manifest_version is typically on the bottom. Change-Id: I1767b1e176c9cf892c1f627db4f5891fa6aade18
2018-05-08 01:19:40 +00:00
"extensions": {
"MobileFrontend": ">= 2.1.0"
}
},
"config": {
Errors can be counted in statsv Bug: T205582 Change-Id: I8f67b8356ac271872cac39a416ffefce47959177
2018-10-04 21:31:30 +00:00
"MinervaCountErrors": false,
Client side error reporting for Minerva+MobileFrontend This adds a client side error logger that will store errors in EventLogging. We will use it to get a sense of the number of errors inside mobile. To enable make use of the new configuration variable wgMinervaErrorLogSamplingRate = 1 Notes: * the optional `meta` field will not be utilised by the generic error handler. * URI length is not trimmed for title. We will consider whether we need to make any adjustments to the schema values during roll out. ** For stack trace, we limit the length by removing errorUrl (which is logged separately) Testing: Add throw new Error('asasasa'); anywhere in your code and make sure the code executes. It should trigger an Error event provided that configuration has been updated. Bug: T202026 Change-Id: I07f01b4c025b2e5e4cbf88ec05e7c536442c62cc
2018-08-24 00:34:37 +00:00
"MinervaErrorLogSamplingRate": 0,
Move skin metadata keys to top of skin.json The keys that form the credits (name/description/url/etc.) are usually on top, and manifest_version is typically on the bottom. Change-Id: I1767b1e176c9cf892c1f627db4f5891fa6aade18
2018-05-08 01:19:40 +00:00
"MinervaDownloadNamespaces": [ 0 ],
"MinervaEnableSiteNotice": false,
"MinervaCustomLogos": [],
"MinervaApplyKnownTemplateHacks": false,
"MinervaPageActions": [
"edit",
"talk",
"watch",
"switch-language"
],
"MinervaAlwaysShowLanguageButton": true,
Talk tabs in AMC mode A new feature/skin option is added that is enabled safely inside a MobileFrontend available/unavailable hook that changes the skin to place talk tabs at the top of the page. These new talk tabs purposely show on the main page, user page and standard pages and do not show on special pages. Depends-On: Ie1a583657176acc6f7046c569c2e94fa2f72ff93 Bug: T212216 Change-Id: I57b70cd325666a287678dc897159b5bf9d089b78
2019-01-10 22:59:56 +00:00
"MinervaTalkAtTop": {
"base": false,
"beta": false,
"amc": true
},
Add config option for showing history link in page actions menu Bug: T213352 Change-Id: I6a53a7303434b0fd374bc5b6ea2dbc8e760807e6
2019-03-07 20:50:57 +00:00
"MinervaHistoryInPageActions": {
"base": false,
"beta": false,
"amc": true
},
Update: add secondary page actions submenu in AMC mode When advanced mobile contributions mode is enabled and `$wgMinervaOverflowInPageActions` is set, show a secondary overflow menu on main namespace articles and user namespace pages. The menu content varies for each namespace. The new submenu is *disabled* by default, even when AMC is active. This feature should not be deployed until instrumentation is available. The secondary menu is rendered in PHP using the existing menu system with some changes to the template. The checkbox hack is needed for no- JavaScript keyboard navigation until :focus-within is supported. CSS additions are documented in the source. All client side toolbar execution occurs in Toolbar.js. Enhancements are documented in the source. Minor changes to the existing download button: - Move download and edit button initialization to Toolbar. - Update copy (not visible) from "Download" to "Download PDF". - When the overflow menu is present, use the "hasText" / label style. Wikimedia UI icons are copied from OOUI at d00a0ac and seem useful to expose as HTTP URIs (not data URIs). The overflow menu does not show for pages provided by the content proxy since its entries depend on $tpl->data['nav_urls'] being populated. Bug: T216418 Depends-On: I0781151a8232b6a7b52f79a34298afcecb8e4271 Change-Id: I4b50a0e519024a7ab91dae6ab40b23cf14a03861
2019-04-04 21:20:39 +00:00
"MinervaOverflowInPageActions": {
"base": false,
"beta": false,
[AMC] [dev] enable page actions overflow menu in AMC by default The AMC overflow menu is now being deployed everywhere AMC is. Default it to true in AMC mode like all the other AMC features. Change-Id: I671cc5d2bfc046026c83d077e78cb57b87c55246
2019-07-30 16:22:39 +00:00
"amc": true
Update: add secondary page actions submenu in AMC mode When advanced mobile contributions mode is enabled and `$wgMinervaOverflowInPageActions` is set, show a secondary overflow menu on main namespace articles and user namespace pages. The menu content varies for each namespace. The new submenu is *disabled* by default, even when AMC is active. This feature should not be deployed until instrumentation is available. The secondary menu is rendered in PHP using the existing menu system with some changes to the template. The checkbox hack is needed for no- JavaScript keyboard navigation until :focus-within is supported. CSS additions are documented in the source. All client side toolbar execution occurs in Toolbar.js. Enhancements are documented in the source. Minor changes to the existing download button: - Move download and edit button initialization to Toolbar. - Update copy (not visible) from "Download" to "Download PDF". - When the overflow menu is present, use the "hasText" / label style. Wikimedia UI icons are copied from OOUI at d00a0ac and seem useful to expose as HTTP URIs (not data URIs). The overflow menu does not show for pages provided by the content proxy since its entries depend on $tpl->data['nav_urls'] being populated. Bug: T216418 Depends-On: I0781151a8232b6a7b52f79a34298afcecb8e4271 Change-Id: I4b50a0e519024a7ab91dae6ab40b23cf14a03861
2019-04-04 21:20:39 +00:00
},
Move skin metadata keys to top of skin.json The keys that form the credits (name/description/url/etc.) are usually on top, and manifest_version is typically on the bottom. Change-Id: I1767b1e176c9cf892c1f627db4f5891fa6aade18
2018-05-08 01:19:40 +00:00
"MinervaShowCategoriesButton": {
"base": false,
"beta": true
},
page issues is feature flagged * New feature/skin option is added and value is read inside the pageIssues setup code * issues-group-a class is added to page on server side to remove the flash of unstyled content * issues-group-A class is dropped (it's not doing anything!) * The minerva-issues flag will now accept any value to avoid confusion. It is used to override the default setting of wgMinervaPageIssuesNewTreatment A note has been added that this can be removed in future. Bug: T206179 Change-Id: I3d98fd8f8e1adc818ea03589d2c8f68fe991e861
2018-11-12 20:32:28 +00:00
"MinervaPageIssuesNewTreatment": {
"base": false,
"beta": true
},
Add share icon as mobile web beta feature Add a new beta feature - share icon. When user opts into beta the share icon will be visible on supported devices (Android OS and Chrome browser). Bug: T181195 Change-Id: Ie4b9dd05eea9b63422bd174048d8b1251cb02bf4
2018-09-17 23:37:57 +00:00
"MinervaShowShareButton": {
"base": false,
Disable share button The share button should go though proper testing before it hits production. First, it should be enabled only for beta cluster, and then when everything works properly we can enable it as a beta feature on production. Bug: T181195 Change-Id: I1c5330edd8b5dfe00179bf7d9c6660887208a2e6
2018-10-15 17:42:58 +00:00
"beta": false
Add share icon as mobile web beta feature Add a new beta feature - share icon. When user opts into beta the share icon will be visible on supported devices (Android OS and Chrome browser). Bug: T181195 Change-Id: Ie4b9dd05eea9b63422bd174048d8b1251cb02bf4
2018-09-17 23:37:57 +00:00
},
Move skin metadata keys to top of skin.json The keys that form the credits (name/description/url/etc.) are usually on top, and manifest_version is typically on the bottom. Change-Id: I1767b1e176c9cf892c1f627db4f5891fa6aade18
2018-05-08 01:19:40 +00:00
"MinervaEnableBackToTop": {
"base": false,
"beta": true
Mobile page issues - visual styling changes Changes: * Introduce Jan's beautifully documented $wgMinervaABSamplingRate Set to 1 to A/B test 50% of the population * Split out ambox template styles into a separate file referenced by hacks.less * Update cleanuptemplates setup script to consider two buckets Test pages: * Shqiponja_Partizane * World_War_II_in_Albania * Liberation_of_Tirana * French_Consulate * Abd_ar-Rahman_IV * M109_howitzer * Aimoin * Transport_in_Brazil * Transport_in_Cape_Verde Bug: T191303 Change-Id: I8d11e655ccb847b7999e64dda57b225ad8b1c23a
2018-05-08 22:03:52 +00:00
},
"MinervaABSamplingRate": 0
Move skin metadata keys to top of skin.json The keys that form the credits (name/description/url/etc.) are usually on top, and manifest_version is typically on the bottom. Change-Id: I1767b1e176c9cf892c1f627db4f5891fa6aade18
2018-05-08 01:19:40 +00:00
},
"ValidSkinNames": {
"minerva": "MinervaNeue"
},
Provide a code structure for menus handling and add Advanced menu Changes: - moved all menu elements definitions from SkinMinerva into a separate Definitions.php file - moved menu building from SkinMinerva into includes/menu/Main folder - introduced Builder pattern for easy menu building Minerva/Menu/Main/Director takes an Minerva/Menu/Main/IBuilder and builds the menu. The IBuilders use definitions from Minerva/Menu/Definitions file, so all definitions can be shared across different menus - used ServiceWiring file to register MainMenu Director as Service - left class_alias for old MenuBuilder as some extensions still use it - The hooks system have to stay like that as some extensions are using it (BlueSpiceMultiUpload and GrowthExperiments). - introduced AdvancedMenu builder for the AMC mode Bug: T216152 Change-Id: I210c3f1fa36bbd2f9108d728b12cbb21ee210354
2019-04-08 17:08:57 +00:00
"AutoloadNamespaces": {
Hygiene: Extract isAllowedPageAction into MinervaPagePermissions The isAllowedPageAction is used in multiple places (SkinMinerva and in PageActions toolbar builder). This logic should be defined in separate service, easy accessible for different parts of the Minerva skin. Changes: - Introduced MinervaPagePermissions as a centralized place to manage user permissions - Introduced MinervaNoTitlePermissions, an NullObject pattern to handle situations when we do not have Title object (like in CLI) - removed Minerva.ContentHandler service as it's not required any more - moved all permission names into constants - moved isTalkAllowed() into MinervaPermissions - renamed isAllowedPageAction() it `isAllowed()` to not mix it with PageActions. Those checks are used in many places, not only on PageActions menu - made isAllowed( watch ) more robust - now it checks that Title is watchable Bug: T221792 Change-Id: I87d44a9c717b5f752b8d1fd2f146d7f5eef3c53f
2019-05-24 00:07:27 +00:00
"MediaWiki\\Minerva\\Menu\\": "includes/menu/",
"MediaWiki\\Minerva\\Permissions\\": "includes/permissions/"
Provide a code structure for menus handling and add Advanced menu Changes: - moved all menu elements definitions from SkinMinerva into a separate Definitions.php file - moved menu building from SkinMinerva into includes/menu/Main folder - introduced Builder pattern for easy menu building Minerva/Menu/Main/Director takes an Minerva/Menu/Main/IBuilder and builds the menu. The IBuilders use definitions from Minerva/Menu/Definitions file, so all definitions can be shared across different menus - used ServiceWiring file to register MainMenu Director as Service - left class_alias for old MenuBuilder as some extensions still use it - The hooks system have to stay like that as some extensions are using it (BlueSpiceMultiUpload and GrowthExperiments). - introduced AdvancedMenu builder for the AMC mode Bug: T216152 Change-Id: I210c3f1fa36bbd2f9108d728b12cbb21ee210354
2019-04-08 17:08:57 +00:00
},
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"AutoloadClasses": {
Prepare to break the server side MobileFrontend dependency on Minerva Changes: * Minerva now maintains a MinervaUI - a simplified version of MobileUI that provides iconClass and buttonClass helpers. * Minerva now maintains its own ResourceLoaderParserMessageModule Remaining issues: * Main menu links to '#' * Unknown dependency errors are thrown due to the missing JS libraries e.g. mobile.watchstar thus JS based UI components are unusable e.g. search autocomplete, and edit button * Language button navigates to a missing special page without MobileFrontend (see T104660) Bug: T169569 Change-Id: I89e2e15faabab73b0cba91afc2f2c5e785edef29
2017-08-16 19:18:08 +00:00
"MinervaUI": "includes/MinervaUI.php",
Fix some file names to match their class names Change-Id: Ib1a12f8073a2d737c40c0b4d1dd64f9e55738019
2018-04-15 23:12:19 +00:00
"MinervaHooks": "includes/MinervaHooks.php",
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"MinervaTemplate": "includes/skins/MinervaTemplate.php",
"SkinMinerva": "includes/skins/SkinMinerva.php",
Move class_alias out of skin initialization Use the standard way of doing it by adding an autoloader entry, and putting the class_alias() call into the same file as the class. Change-Id: I93e19ebcf3dd7d9815623de5e24861949fd0269a
2017-11-08 00:05:20 +00:00
"SkinMinervaNeue": "includes/skins/SkinMinerva.php",
Provide a code structure for menus handling and add Advanced menu Changes: - moved all menu elements definitions from SkinMinerva into a separate Definitions.php file - moved menu building from SkinMinerva into includes/menu/Main folder - introduced Builder pattern for easy menu building Minerva/Menu/Main/Director takes an Minerva/Menu/Main/IBuilder and builds the menu. The IBuilders use definitions from Minerva/Menu/Definitions file, so all definitions can be shared across different menus - used ServiceWiring file to register MainMenu Director as Service - left class_alias for old MenuBuilder as some extensions still use it - The hooks system have to stay like that as some extensions are using it (BlueSpiceMultiUpload and GrowthExperiments). - introduced AdvancedMenu builder for the AMC mode Bug: T216152 Change-Id: I210c3f1fa36bbd2f9108d728b12cbb21ee210354
2019-04-08 17:08:57 +00:00
"MediaWiki\\Minerva\\Menu\\Group": "includes/menu/Group.php",
"MediaWiki\\Minerva\\MenuBuilder": "includes/menu/Group.php",
Convert custom LESS var from global to local Avoid the 'ResourceLoaderGetLessVars' hook, which registers a global LESS variable exposed to all modules (inc. core/extensions). Instead, use a FileModule subclass to provide the variable only to the modules that need it. Using this approach, also has the benefit of being tracked by the version hasher, so that changes to the configuration actually result in timely invalidation of module caches. Bug: T171367 Change-Id: I7c7d13c83004edfc852a9b7dbfc4169617ab9f64
2018-04-02 23:16:39 +00:00
"MediaWiki\\Minerva\\ResourceLoaderLessVarFileModule": "includes/ResourceLoaderLessVarFileModule.php",
Extract SkinOptions to separate class SkinOptions array was used to determine which options are available for current session. Once we started extracting things from SkinMinerva class, we found out that lots of things depend on SkinOptions. For example MainMenu/PageActionsMenu depend on skinsOptions var. We could pass $skin object as dependency to a menu builder, but this would cause a circural dependency (Skin depends on menu builder, menu builder depends on skin) which is an anti-pattern. In order to avoid such situations lets prepare first, and extract the SkinOptions to a separate class, register it as a service so different parts of Skin Minerva can freely use a single instance of SkinOptions object. Bug: T216152 Bug: T221012 Change-Id: Icd5da546e1bfaf8d9bfe86dab3b659a88eae19e4
2019-04-10 21:43:50 +00:00
"MediaWiki\\Minerva\\SkinOptions": "includes/SkinOptions.php",
Extract language/variants check to a service The $hasLangauges and $hasVariants checks were used in couple places, which lead to the same code used in many places. Following the DRY rule, let's implement a Service that can do that check, and use that service everywhere in code. Bug: T224735 Change-Id: I46d58758356e870c408a74b2c087a42d6ad0ddea
2019-07-09 16:10:31 +00:00
"MediaWiki\\Minerva\\LanguagesHelper": "includes/LanguagesHelper.php",
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"MediaWiki\\Minerva\\SkinUserPageHelper": "includes/skins/SkinUserPageHelper.php"
},
Use tabs in skin.json Change-Id: I8fb66fe2f99786bfbdc598d460c18928dbb0faa0
2017-06-09 22:09:22 +00:00
"ConfigRegistry": {
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"minerva": "GlobalVarConfig::newInstance"
},
"Hooks": {
Reset SkinOptions after logging out Bug: T221137 Change-Id: I36ada157327b649900dbcee3917883fe8ee7687a
2019-08-01 20:15:19 +00:00
"UserLogoutComplete": [
"MinervaHooks::onUserLogoutComplete"
],
Disable the recent changes table-based layout on Minerva See Ib68ff8fa782ac12479ef02247cdf78e405b64bad Bug: T228280 Change-Id: I4169bcb93eb6680c0e9251873afb5637014c0e1b
2019-07-17 21:01:29 +00:00
"FetchChangesList": [
"MinervaHooks::onFetchChangesList"
],
Minerva should use FeatureManagers class Bug: T182362 Depends-On: I6cc4a2ebcd75c054294daf329d94d35a02e50f8e Change-Id: I6ba5bf49b9060c31ad2224a437072b3426a45619
2018-01-08 22:18:16 +00:00
"MobileFrontendFeaturesRegistration": [
"MinervaHooks::onMobileFrontendFeaturesRegistration"
],
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"RequestContextCreateSkinMobile": [
"MinervaHooks::onRequestContextCreateSkinMobile"
],
"ResourceLoaderTestModules": [
"MinervaHooks::onResourceLoaderTestModules"
],
"SpecialPageBeforeExecute": [
"MinervaHooks::onSpecialPageBeforeExecute"
Disable edit icon in read-only mode When a wiki is in read-only mode, the edit icon on articles should not open an editor. Instead, it should be in a "disabled" state and inform the user that the wiki is in read-only mode ( i.e. show the "apierror-readonly" message). Bug: T197497 Change-Id: Iee1414c20bea3ca936fb807820e58e5ed566d008
2018-08-13 14:29:05 +00:00
],
"ResourceLoaderGetConfigVars": [
"MinervaHooks::onResourceLoaderGetConfigVars"
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
]
Disable edit icon in read-only mode When a wiki is in read-only mode, the edit icon on articles should not open an editor. Instead, it should be in a "disabled" state and inform the user that the wiki is in read-only mode ( i.e. show the "apierror-readonly" message). Bug: T197497 Change-Id: Iee1414c20bea3ca936fb807820e58e5ed566d008
2018-08-13 14:29:05 +00:00
Use tabs in skin.json Change-Id: I8fb66fe2f99786bfbdc598d460c18928dbb0faa0
2017-06-09 22:09:22 +00:00
},
"MessagesDirs": {
"MinervaNeue": [
"i18n"
]
},
"ResourceFileModulePaths": {
"localBasePath": "",
"remoteSkinPath": "MinervaNeue"
},
"ResourceModuleSkinStyles": {
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"minerva": {
Reset history page styles for Minerva This provides us with a blank canvas for styling Minerva's history page in AMC mode. I have also provided styles for a non-AMC mode (test by changing the class on body tag to minerva--amc-disabled). This will allow us to remove the SpecialMobileHistory page in mobile if we choose to do so. Change-Id: Ic57cb79903e90ce1bbfa6d87ab0499f09373e732
2019-03-29 21:43:19 +00:00
"mediawiki.action.history.styles": [
"skinStyles/mediawiki.action.history.styles.less"
],
Add Minerva specific mediawiki.interface.helpers.styles.less file This SkinStyle file adds paranthases around the (diff|hist) links and username(talk|contrib|block) links on special pages. Bug: T222394 Change-Id: Ic291cb795ccad556a5049d970c0282b2d4c65a11
2019-05-07 13:17:04 +00:00
"mediawiki.interface.helpers.styles": [
"skinStyles/mediawiki.interface.helpers.styles.less"
],
Reset history page styles for Minerva This provides us with a blank canvas for styling Minerva's history page in AMC mode. I have also provided styles for a non-AMC mode (test by changing the class on body tag to minerva--amc-disabled). This will allow us to remove the SpecialMobileHistory page in mobile if we choose to do so. Change-Id: Ic57cb79903e90ce1bbfa6d87ab0499f09373e732
2019-03-29 21:43:19 +00:00
"mediawiki.rcfilters.highlightCircles.seenunseen.styles": [],
Separate ConfirmEdit styles from Login styles ConfirmEdit styles are migrated from mediawiki.special.userlogin.common.styles to ext.confirmEdit.fancyCaptcha.styles The text of the reload itself mirrors the progressive blue icon by being progressive itself A couple of tweaks to the form (padding) are made to preserve the form to its previous glorious status, other than that the file remains the same. Bug: T213775 Change-Id: I2322194481e4d6b7662c0f075768d5941afa98b8
2019-01-16 19:18:52 +00:00
"ext.confirmEdit.fancyCaptcha.styles": [
"skinStyles/ext.confirmEdit.fancyCaptcha.styles/minerva.less"
],
Optimise Special:MobileOptions for tablet display Bug: T180095 Change-Id: I0ef0ce914a360848f8f66b39c40588f3fa04647c
2017-12-01 18:52:02 +00:00
"mobile.special.mobileoptions.styles": [
"skinStyles/mobile.special.mobileoptions.styles/minerva.less"
],
Restrict gallery styles to only pages which need it The mediawiki.page.gallery.styles module is only loaded when needed, yet inside hacks.less we load gallery styles unconditionally. The hacks.less file is also only meant for css that overrides template styles, so it didn't belong there anyway. Change-Id: I4afc91ad7f67ae66544708d25541b3e8dd247873
2017-12-13 02:03:28 +00:00
"mediawiki.page.gallery.styles": [
"skinStyles/mediawiki.page.gallery.styles/tablet.less"
],
Remove special page resource module handling This is handled by MobileFrontend now, just as it should do. We rely on skinStyles where possible. Depends-On: I665f6fe60939475249786fdc951149c38473fda6 Bug: T173597 Change-Id: I0fe9efcf98bbd8e188d91a29d4cfda897d47808d
2017-08-18 18:45:41 +00:00
"mediawiki.special.userlogin.common.styles": [
"skinStyles/mediawiki.special.userlogin.common.styles/minerva.less"
],
"mediawiki.special.search.styles": [
"skinStyles/mediawiki.special.search.styles/minerva.less"
],
Move Parsoid output overrides to 'mediawiki.skinning.content.parsoid' skinStyles We need to load these only when VisualEditor is loaded. This is the best way to ensure that. They have been haphazardly placed in different files. The goal of this change is to move content styling for Minerva out of mobile.editor.ve/minerva.less, and thus to be able to move this file to mediawiki/extensions/MobileFrontend (T202978). But I spotted the other places while working on that. Moved as-is: * skins.minerva.content.styles/links.less * mobile.editor.ve/minerva.less No longer needed: * skins.minerva.content.styles/text.less Parsoid now uses <sup> tags for references rather than <span>, so the existing rules for <sup> tags are enough. See T45094, <https://www.mediawiki.org/wiki/Specs/HTML/1.6.0/Extensions/Cite>. Was never needed: * skins.minerva.content.styles/thumbnails.less The styles from the core module 'mediawiki.skinning.content.parsoid' are never loaded, so we don't need to override them. Bug: T202978 Change-Id: I45e1cb89b65a41a29d2b1a361a79199745ccec14
2018-09-17 20:56:57 +00:00
"mediawiki.skinning.content.parsoid": [
"skinStyles/mediawiki.skinning.content.parsoid/minerva.less"
],
Minerva should use mediawiki.hlist Override provided styles Bug: T42062 Depends-On: I9305af5d30c8c24b44f4a0c6a466581c45fa3028 Change-Id: I7adda8ef99e5eee3df5bd7dc4da5081c1225f815
2017-06-01 23:09:24 +00:00
"mediawiki.hlist": [
"skinStyles/mediawiki.hlist/minerva.less"
],
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"mobile.languages.structured": [
Refactor LanguageOverlay styles In I629245100f4ca430a88e450939b90d075e7021f1, languageOverlay styles and LanguageSearcher styles were split into two different files. This commit mimics that change in skinStyles. All languageOverlay specific styles were moved to languageOverlay.less, while all LanguageSearcher styles were moved to LanguageSearcher.less. Other chagnes: * Changed a reference in init.js Bug: T215657 Change-Id: I395a61cd6051ad5c6b6601205f112b55f5ab8273
2019-02-22 17:59:56 +00:00
"skinStyles/mobile.languages.structured/LanguageSearcher.less"
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
],
"mobile.startup": [
Import all skinStyles/mobile.startup into mobile.startup.less This mimics the structure we follow in MobileFrontend's mobile.startup folder where we have a mobile.startup.js that imports all the mobile.startup files. Bug: T215657 Change-Id: Id7faa45adce7c5aa870d0f7c92f70d39995adac0
2019-02-22 18:15:34 +00:00
"skinStyles/mobile.startup/mobile.startup.less"
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
],
Remove special page resource module handling This is handled by MobileFrontend now, just as it should do. We rely on skinStyles where possible. Depends-On: I665f6fe60939475249786fdc951149c38473fda6 Bug: T173597 Change-Id: I0fe9efcf98bbd8e188d91a29d4cfda897d47808d
2017-08-18 18:45:41 +00:00
"mediawiki.special": [
"skinStyles/mobile.special.styles/minerva.less"
],
"mobile.special.styles": [
"skinStyles/mobile.special.styles/minerva.less"
],
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"ext.echo.styles.special": [
"skinStyles/ext.echo.styles.special/SpecialNotificationsOverlay.less"
],
Set editfont size to 16px (100%) Change-Id: I9bff880de792da756f14726042df0a0df4139d1b
2018-04-02 20:06:27 +00:00
"mediawiki.editfont.styles": [
"skinStyles/mediawiki.editfont.styles/minerva.css"
],
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"mediawiki.notification": [
"skinStyles/mobile.startup/toast.less"
],
"mediawiki.action.edit.styles": [
"skinStyles/mediawiki.action.edit.styles/minerva.less"
],
"mobile.special.mobilemenu.styles": [
"skinStyles/mobile.special.mobilemenu.styles/minerva.less"
Move remaining Minerva skinStyles from MobileFrontend To be removed in MobileFrontend by If3edac9a35b346a. Bug: T140807 Change-Id: Ifb073d1e67602b80e0e9b45f338806f5b9cb675b
2018-05-20 11:25:56 +00:00
],
"mobile.notifications.overlay": [
"skinStyles/mobile.notifications.overlay/minerva.less"
JSON content: Fix table margins Change-Id: I50a2203adb66e634f9d995225075dc29a34ab4dd
2019-05-03 15:27:33 +00:00
],
"mediawiki.content.json": [
"skinStyles/mediawiki.content-json/minerva.less"
Adding skin styles for the changeslist module. The changeslist module is the list of results on special pages such as recent changes, watchlist, and parts of action history. Adds a skin style to special.changeslist module. Bug: T228419 Change-Id: I324b1f136f5314cb6acdba3155b07136bbde363a
2019-07-29 09:50:05 +00:00
],
"mediawiki.special.changeslist": [
"skinStyles/mediawiki.special.changeslist.less"
],
"mediawiki.special.changeslist.legend": [
"skinStyles/mediawiki.special.changeslist.legend.less"
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
]
}
},
Page Issues AB test event-logging instrumentation Uses `mw.trackSubscribe` to create an intermediary data handler named `wikimedia.PageIssuesAB` which extends event-logging data before passing it to the eventLogging through `wikimedia.event.PageIssues`. Event hooks are placed where appropriate and the `CleanupOverlay` class is extended to capture events from within the page issues modal. Additional changes: * Merge two identical on click event handlers for .edit-page, .edit-link elements * change pageIssueParser.maxSeverity to accept an array of severity levels instead of an array of pageIssues objects Depends-On: Ic84e4a3286220407863167e0f57cef1b13a72964 Bug: T191532 Change-Id: I67fb6e448f6ecc97c89c1187e491ee05f7a312ef
2018-07-11 15:16:21 +00:00
"EventLoggingSchemas": {
Track share button usage Use MobileWebShareButton schema to track interactions with Additional changes: Fix how button is injected into page actions bar as last AMC changes broke it. Bug: T207280 Change-Id: Ie7d7ab6bc66df5ab30aaec77e2ee8583c69b8f48
2019-03-15 22:37:11 +00:00
"WebClientError": 18340282,
Remove all main_menu tracking related code."" This reverts commit de353c06c916d8fe0b3f3601c2867a0e446835e1. Bug: T228681 Change-Id: Idfd964c31e09e271dca9ac39f7932df49cdcb5f6
2019-07-22 20:05:46 +00:00
"MobileWebShareButton": 18923688
Page Issues AB test event-logging instrumentation Uses `mw.trackSubscribe` to create an intermediary data handler named `wikimedia.PageIssuesAB` which extends event-logging data before passing it to the eventLogging through `wikimedia.event.PageIssues`. Event hooks are placed where appropriate and the `CleanupOverlay` class is extended to capture events from within the page issues modal. Additional changes: * Merge two identical on click event handlers for .edit-page, .edit-link elements * change pageIssueParser.maxSeverity to accept an array of severity levels instead of an array of pageIssues objects Depends-On: Ic84e4a3286220407863167e0f57cef1b13a72964 Bug: T191532 Change-Id: I67fb6e448f6ecc97c89c1187e491ee05f7a312ef
2018-07-11 15:16:21 +00:00
},
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"ResourceModules": {
"skins.minerva.base.styles": {
"targets": [
"mobile",
"desktop"
],
"styles": [
Hygiene: Merge skins.minerva.base.reset into skins.minerva.base.styles No need for 2 modules that are both loaded on every page load Provided consumers are loading skins.minerva.base.styles they will continue to get the same CSS. If any consumers exist that load skins.minerva.base.reset but not skins.minerva.base.styles they will need to use their own css reset file (e.g. https://meyerweb.com/eric/tools/css/reset/) Change-Id: I599e6d5a84b311cb3bb2da197da1b688e0e6b9d4
2019-01-11 00:35:18 +00:00
"resources/skins.minerva.base.styles/reset.less",
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"resources/skins.minerva.base.styles/ui.less",
"resources/skins.minerva.base.styles/pageactions.less",
[UI] [new] add user menu Add new user menu. The changes required include: - Break up AuthMenuEntry into reusable components. They're now simple, independent, static functions in AuthUtil that are easy to reason about and compose. There's lots of verbose code because of the builder and director patterns. That is, most of the code is for building the thing we actually want to build instead of just building it. It's easy to write but no fun to read--even simple configurations are extremely verbose expressions that must be threaded through the system. These builders are also single purpose and unlikely to be reusable unlike a URI builder, for example. As objects, they're not especially composable either. - Similarly, break up Menu/DefaultBuilder into BuilderUtil and ban inheritance. Inheritance has not worked well on the frontend of MobileFrontend. I don't think it's going to work well here. E.g., I could have made changes to the base class' getPersonalTools() method such that the client passes a parameter for the advanced config or maybe I just override it in the subclass. In either case, I think it makes the whole hierarchy nuanced and harder to reason about for something that should be simple. - Add ProfileMenuEntry and LogOutMenuEntry for the user menu. - Rename insertLogInOutMenuItem() to insertAuthMenuItem() which matches the entry name, AuthMenuEntry. - Extension:SandboxLink is needed to display the sandbox link in the user menu. - Performance note: the toolbar is now processed in MinervaTemplate, which corresponds to removing the buildPersonalUrls() override. - To mimic the design of main menu, the following steps would be necessary: 1. Create a user/Default and user/Advanced user menu builder and also a user/IBuilder interface. 2. Create a user/Director. 3. Create a service entry for Minerva.Menu.UserDirector in ServiceWiring. The Director is actually powerless and doesn't get to make any decisions--the appropriate builder is passed in from ServiceWiring which checks the mode. 4. Access the service in SkinMinerva to set a userMenuHTML data member on the Minerva QuickTemplate. 5. In MinervaTemplate, access the userMenuHTML QuickTemplate member and do the usual song and dance of inflating a Mustache template. This patch does everything except add a service, which was agreed to be unnecessary, so that logic is now in SkinMinerva. - Wrap the existing echo user notifications button and new user menu button in a nav element. This seems like a semantic improvement. - The existing styling and logic for the search bar and search overlay are pretty messy and delicate. Changes made to that LESS endeavored to be surgical. There's lots of room for improvement in the toolbar but it's out of scope. - Rename logout icon to logOut. Bug: T214540 Change-Id: Ib517864fcf4e4d611e05525a6358ee6662fe4e05
2019-06-25 20:12:58 +00:00
"resources/skins.minerva.base.styles/userMenu.less",
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"resources/skins.minerva.base.styles/common.less",
"resources/skins.minerva.base.styles/images.less",
"resources/skins.minerva.base.styles/footer.less",
Hygiene: Merge skins.minerva.print.styles with skins.minerva.base.styles We no longer need to keep this as a separate entry point now we do not feature flag our print styles Please enter the commit message for your changes. Lines starting Change-Id: I6bf12980aa929e84f239931beb0a505809231830
2017-08-28 20:51:20 +00:00
"resources/skins.minerva.base.styles/print/styles.less"
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
]
},
"skins.minerva.content.styles": {
Convert custom LESS var from global to local Avoid the 'ResourceLoaderGetLessVars' hook, which registers a global LESS variable exposed to all modules (inc. core/extensions). Instead, use a FileModule subclass to provide the variable only to the modules that need it. Using this approach, also has the benefit of being tracked by the version hasher, so that changes to the configuration actually result in timely invalidation of module caches. Bug: T171367 Change-Id: I7c7d13c83004edfc852a9b7dbfc4169617ab9f64
2018-04-02 23:16:39 +00:00
"class": "MediaWiki\\Minerva\\ResourceLoaderLessVarFileModule",
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"targets": [
"mobile",
"desktop"
],
"styles": [
skins.minerva.tablet.styles can be merged This module is unnecessary - it's loaded unconditionally on a page. Instead bundle the related CSS inside skins.minerva.content.styles Change-Id: Ieb37d63332ff5b0cf39835b64cc9f0dcaf62c34f
2019-01-11 00:28:25 +00:00
"resources/skins.minerva.content.styles/styles.less",
"resources/skins.minerva.content.styles/tablet/styles.less"
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
]
},
Update: add internal and revise external link icons Bug: T190549 Change-Id: Iad7fdc2f2a730fa8874487c0d83355f21a0bf7ea
2018-06-14 16:51:50 +00:00
"skins.minerva.content.styles.images": {
"class": "ResourceLoaderImageModule",
Adds a light-blue variant to the external link icon The light-blue variant is used in reference drawers on a dark background. Bug: T216961 Change-Id: Ic8fdf8f4a08ea7c8d7ae57ae8ce02a7d9a1e1dad
2019-04-25 14:06:08 +00:00
"selectorWithoutVariant": "{name}",
"selectorWithVariant": "{name}--{variant}",
External link icons should use defaultColor Depends-On: I0745e112d11026ed59d8daca990b313305cd094a Bug: T197909 Change-Id: Ic00b77e789b487d626f497d99197649c04bd6427
2018-06-26 23:25:31 +00:00
"defaultColor": "#36c",
Reduce render blocking styles by deferring loading of icons Change-Id: I8fb3b03833a49ade1d62fe4ded1a0c723cbe8f28 Depends-On: Iee77655d4868a7d921be8cc23776a7859d9acf0c Bug: T198930
2018-07-05 23:52:21 +00:00
"useDataURI": false,
Adds a light-blue variant to the external link icon The light-blue variant is used in reference drawers on a dark background. Bug: T216961 Change-Id: Ic8fdf8f4a08ea7c8d7ae57ae8ce02a7d9a1e1dad
2019-04-25 14:06:08 +00:00
"variants": {
"reference": {
"color": "#69f",
"global": true
}
},
Update: add internal and revise external link icons Bug: T190549 Change-Id: Iad7fdc2f2a730fa8874487c0d83355f21a0bf7ea
2018-06-14 16:51:50 +00:00
"images": {
Don't ship 2 magnifying glass icons We already make use of the images 'name' key inside skins.minerva.content.styles.images to define the full CSS selector. We can use this approach to ship a single version of the magnifying glass icon, rather than having 2 defined in both skins.minerva.base.styles and skins.minerva.icons.images Change-Id: Ie5ec06152c418c4aa1b620b3d0a904cc9517e5d0
2018-07-05 23:34:31 +00:00
"input.search,.mw-ui-icon-minerva-magnifying-glass:before": "resources/skins.minerva.content.styles.images/magnifying-glass.svg",
"a.external": {
Update: add internal and revise external link icons Bug: T190549 Change-Id: Iad7fdc2f2a730fa8874487c0d83355f21a0bf7ea
2018-06-14 16:51:50 +00:00
"file": {
"ltr": "resources/skins.minerva.content.styles.images/link-external-ltr.svg",
"rtl": "resources/skins.minerva.content.styles.images/link-external-rtl.svg"
}
}
}
},
Only load notification icon (bell) CSS for logged in users * The notification-count style is only needed if you are logged in. Given a small percentage of our users are logged in, we load a lot of render blocking css unnecessarily. * The bell icon is not needed for anonymous users so pull that out from skins.minerva.icons.images which is loaded for all users into a module only used by logged in users (skins.minerva.icons.loggedin) * Simplify the user-button rule - it is overly specific - probably for historic reasons. Additional changes: * Simplify isAuthenticated helper Change-Id: Ia72e7e45d276e8aac1ff5471bf6158705c7b5f99
2017-12-13 01:25:10 +00:00
"skins.minerva.icons.loggedin": {
Refresh the user, bell and search icon * New module skins.minerva.icons.wikimedia provides icons from Wikimedia UI in Minerva * search selector in skins.minerva.content.styles.images is retained for cached HTML * skins.minerva.icons.loggedin now a ResourceLoaderOOUIIconPackModule and bell removed from repo. * userAvatar replaced with userAvatarOutline Bug: T224070 Change-Id: Ibed609371060acc4b69e5cd4cd4f20edc871b3ba
2019-07-09 19:12:51 +00:00
"class": "ResourceLoaderOOUIIconPackModule",
"targets": [
"mobile",
"desktop"
],
Reduce render blocking styles by deferring loading of icons Change-Id: I8fb3b03833a49ade1d62fe4ded1a0c723cbe8f28 Depends-On: Iee77655d4868a7d921be8cc23776a7859d9acf0c Bug: T198930
2018-07-05 23:52:21 +00:00
"useDataURI": false,
Refresh the user, bell and search icon * New module skins.minerva.icons.wikimedia provides icons from Wikimedia UI in Minerva * search selector in skins.minerva.content.styles.images is retained for cached HTML * skins.minerva.icons.loggedin now a ResourceLoaderOOUIIconPackModule and bell removed from repo. * userAvatar replaced with userAvatarOutline Bug: T224070 Change-Id: Ibed609371060acc4b69e5cd4cd4f20edc871b3ba
2019-07-09 19:12:51 +00:00
"defaultColor": "#54595d",
"variants": [],
"selectorWithoutVariant": ".mw-ui-icon-wikimedia-{name}-base20:before",
"icons": [ "bellOutline" ]
Only load notification icon (bell) CSS for logged in users * The notification-count style is only needed if you are logged in. Given a small percentage of our users are logged in, we load a lot of render blocking css unnecessarily. * The bell icon is not needed for anonymous users so pull that out from skins.minerva.icons.images which is loaded for all users into a module only used by logged in users (skins.minerva.icons.loggedin) * Simplify the user-button rule - it is overly specific - probably for historic reasons. Additional changes: * Simplify isAuthenticated helper Change-Id: Ia72e7e45d276e8aac1ff5471bf6158705c7b5f99
2017-12-13 01:25:10 +00:00
},
Talk tabs in AMC mode A new feature/skin option is added that is enabled safely inside a MobileFrontend available/unavailable hook that changes the skin to place talk tabs at the top of the page. These new talk tabs purposely show on the main page, user page and standard pages and do not show on special pages. Depends-On: Ie1a583657176acc6f7046c569c2e94fa2f72ff93 Bug: T212216 Change-Id: I57b70cd325666a287678dc897159b5bf9d089b78
2019-01-10 22:59:56 +00:00
"skins.minerva.amc.styles": {
"targets": [
"mobile",
"desktop"
],
"styles": [
Restrict AMC scripts and styles to AMC mode These have leaked into all users experience. The CSS appears to be unused outside AMC. Also remove a reference to skins.minerva.share which does not exist. See I171831469a6733c458bc5c7ba249a5096ca975b8 which introduced these styles. Bug: T227929 Change-Id: I6af6b026e68e11327b7c4e3edfc4f812c7309e2e
2019-07-13 00:33:44 +00:00
"resources/skins.minerva.amc.styles/index.less",
"components/ToggleList/ToggleList.less",
"components/ToggleList/DropDownList.less",
[UI] [new] add user menu Add new user menu. The changes required include: - Break up AuthMenuEntry into reusable components. They're now simple, independent, static functions in AuthUtil that are easy to reason about and compose. There's lots of verbose code because of the builder and director patterns. That is, most of the code is for building the thing we actually want to build instead of just building it. It's easy to write but no fun to read--even simple configurations are extremely verbose expressions that must be threaded through the system. These builders are also single purpose and unlikely to be reusable unlike a URI builder, for example. As objects, they're not especially composable either. - Similarly, break up Menu/DefaultBuilder into BuilderUtil and ban inheritance. Inheritance has not worked well on the frontend of MobileFrontend. I don't think it's going to work well here. E.g., I could have made changes to the base class' getPersonalTools() method such that the client passes a parameter for the advanced config or maybe I just override it in the subclass. In either case, I think it makes the whole hierarchy nuanced and harder to reason about for something that should be simple. - Add ProfileMenuEntry and LogOutMenuEntry for the user menu. - Rename insertLogInOutMenuItem() to insertAuthMenuItem() which matches the entry name, AuthMenuEntry. - Extension:SandboxLink is needed to display the sandbox link in the user menu. - Performance note: the toolbar is now processed in MinervaTemplate, which corresponds to removing the buildPersonalUrls() override. - To mimic the design of main menu, the following steps would be necessary: 1. Create a user/Default and user/Advanced user menu builder and also a user/IBuilder interface. 2. Create a user/Director. 3. Create a service entry for Minerva.Menu.UserDirector in ServiceWiring. The Director is actually powerless and doesn't get to make any decisions--the appropriate builder is passed in from ServiceWiring which checks the mode. 4. Access the service in SkinMinerva to set a userMenuHTML data member on the Minerva QuickTemplate. 5. In MinervaTemplate, access the userMenuHTML QuickTemplate member and do the usual song and dance of inflating a Mustache template. This patch does everything except add a service, which was agreed to be unnecessary, so that logic is now in SkinMinerva. - Wrap the existing echo user notifications button and new user menu button in a nav element. This seems like a semantic improvement. - The existing styling and logic for the search bar and search overlay are pretty messy and delicate. Changes made to that LESS endeavored to be surgical. There's lots of room for improvement in the toolbar but it's out of scope. - Rename logout icon to logOut. Bug: T214540 Change-Id: Ib517864fcf4e4d611e05525a6358ee6662fe4e05
2019-06-25 20:12:58 +00:00
"components/ToggleList/MenuListItem.less",
"resources/skins.minerva.amc.styles/userMenu.less"
Talk tabs in AMC mode A new feature/skin option is added that is enabled safely inside a MobileFrontend available/unavailable hook that changes the skin to place talk tabs at the top of the page. These new talk tabs purposely show on the main page, user page and standard pages and do not show on special pages. Depends-On: Ie1a583657176acc6f7046c569c2e94fa2f72ff93 Bug: T212216 Change-Id: I57b70cd325666a287678dc897159b5bf9d089b78
2019-01-10 22:59:56 +00:00
]
},
Update: add secondary page actions submenu in AMC mode When advanced mobile contributions mode is enabled and `$wgMinervaOverflowInPageActions` is set, show a secondary overflow menu on main namespace articles and user namespace pages. The menu content varies for each namespace. The new submenu is *disabled* by default, even when AMC is active. This feature should not be deployed until instrumentation is available. The secondary menu is rendered in PHP using the existing menu system with some changes to the template. The checkbox hack is needed for no- JavaScript keyboard navigation until :focus-within is supported. CSS additions are documented in the source. All client side toolbar execution occurs in Toolbar.js. Enhancements are documented in the source. Minor changes to the existing download button: - Move download and edit button initialization to Toolbar. - Update copy (not visible) from "Download" to "Download PDF". - When the overflow menu is present, use the "hasText" / label style. Wikimedia UI icons are copied from OOUI at d00a0ac and seem useful to expose as HTTP URIs (not data URIs). The overflow menu does not show for pages provided by the content proxy since its entries depend on $tpl->data['nav_urls'] being populated. Bug: T216418 Depends-On: I0781151a8232b6a7b52f79a34298afcecb8e4271 Change-Id: I4b50a0e519024a7ab91dae6ab40b23cf14a03861
2019-04-04 21:20:39 +00:00
"wikimedia.ui": {
Use wikimedia.ui from core directly There's no reason to copy and paste all this here. These icons can be imported directly from core using ResourceLoaderOOUIIconPackModule Depends-On: I7800da87a6a10399f705b43e05c8592c766bae6f Change-Id: I1f25aaca9b7313cd95cefc7f5629b8a7e65c887f
2019-07-12 15:38:41 +00:00
"selectorWithoutVariant": ".wikimedia-ui-{name}-base20:before",
Update: add secondary page actions submenu in AMC mode When advanced mobile contributions mode is enabled and `$wgMinervaOverflowInPageActions` is set, show a secondary overflow menu on main namespace articles and user namespace pages. The menu content varies for each namespace. The new submenu is *disabled* by default, even when AMC is active. This feature should not be deployed until instrumentation is available. The secondary menu is rendered in PHP using the existing menu system with some changes to the template. The checkbox hack is needed for no- JavaScript keyboard navigation until :focus-within is supported. CSS additions are documented in the source. All client side toolbar execution occurs in Toolbar.js. Enhancements are documented in the source. Minor changes to the existing download button: - Move download and edit button initialization to Toolbar. - Update copy (not visible) from "Download" to "Download PDF". - When the overflow menu is present, use the "hasText" / label style. Wikimedia UI icons are copied from OOUI at d00a0ac and seem useful to expose as HTTP URIs (not data URIs). The overflow menu does not show for pages provided by the content proxy since its entries depend on $tpl->data['nav_urls'] being populated. Bug: T216418 Depends-On: I0781151a8232b6a7b52f79a34298afcecb8e4271 Change-Id: I4b50a0e519024a7ab91dae6ab40b23cf14a03861
2019-04-04 21:20:39 +00:00
"useDataURI": false,
Use wikimedia.ui from core directly There's no reason to copy and paste all this here. These icons can be imported directly from core using ResourceLoaderOOUIIconPackModule Depends-On: I7800da87a6a10399f705b43e05c8592c766bae6f Change-Id: I1f25aaca9b7313cd95cefc7f5629b8a7e65c887f
2019-07-12 15:38:41 +00:00
"defaultColor": "#54595d",
"class": "ResourceLoaderOOUIIconPackModule",
"icons": [ "articleRedirect", "info", "link", "listBullet",
Refresh the user, bell and search icon * New module skins.minerva.icons.wikimedia provides icons from Wikimedia UI in Minerva * search selector in skins.minerva.content.styles.images is retained for cached HTML * skins.minerva.icons.loggedin now a ResourceLoaderOOUIIconPackModule and bell removed from repo. * userAvatar replaced with userAvatarOutline Bug: T224070 Change-Id: Ibed609371060acc4b69e5cd4cd4f20edc871b3ba
2019-07-09 19:12:51 +00:00
"logoWikidata", "logoWikimedia", "quotes", "upload", "userAvatarOutline", "userTalk" ]
},
"skins.minerva.icons.wikimedia": {
"selectorWithoutVariant": ".mw-ui-icon-wikimedia-{name}-base20:before, .mw-ui-background-icon-{name}",
"useDataURI": false,
"defaultColor": "#54595d",
"class": "ResourceLoaderOOUIIconPackModule",
"icons": [ "search" ]
Update: add secondary page actions submenu in AMC mode When advanced mobile contributions mode is enabled and `$wgMinervaOverflowInPageActions` is set, show a secondary overflow menu on main namespace articles and user namespace pages. The menu content varies for each namespace. The new submenu is *disabled* by default, even when AMC is active. This feature should not be deployed until instrumentation is available. The secondary menu is rendered in PHP using the existing menu system with some changes to the template. The checkbox hack is needed for no- JavaScript keyboard navigation until :focus-within is supported. CSS additions are documented in the source. All client side toolbar execution occurs in Toolbar.js. Enhancements are documented in the source. Minor changes to the existing download button: - Move download and edit button initialization to Toolbar. - Update copy (not visible) from "Download" to "Download PDF". - When the overflow menu is present, use the "hasText" / label style. Wikimedia UI icons are copied from OOUI at d00a0ac and seem useful to expose as HTTP URIs (not data URIs). The overflow menu does not show for pages provided by the content proxy since its entries depend on $tpl->data['nav_urls'] being populated. Bug: T216418 Depends-On: I0781151a8232b6a7b52f79a34298afcecb8e4271 Change-Id: I4b50a0e519024a7ab91dae6ab40b23cf14a03861
2019-04-04 21:20:39 +00:00
},
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"skins.minerva.icons.images": {
"class": "ResourceLoaderImageModule",
Remove skins.minerva.icons.images.variants module This module produces 6 icons: ["clock", "profile"] * ["black", "gray", "white"] of which only 3 are needed: clock-gray, clock-white, profile-gray. This patch removes the module and moves the "clock" and "profile" icons into `skins.minerva.icons.images`. Since that module does not inline SVG's, the additional cost of adding these icons, which are loaded at startup, is minimal. The editLocked.svg icon has also been edited to correct its color. Bug: T218807 Change-Id: Ib54960eb556dfe0c1ae06d2f73d4f350e519e20f
2019-03-21 14:50:23 +00:00
"selectorWithoutVariant": ".mw-ui-icon-minerva-{name}:before",
"selectorWithVariant": ".mw-ui-icon-minerva-{name}-{variant}:before",
Reduce render blocking styles by deferring loading of icons Change-Id: I8fb3b03833a49ade1d62fe4ded1a0c723cbe8f28 Depends-On: Iee77655d4868a7d921be8cc23776a7859d9acf0c Bug: T198930
2018-07-05 23:52:21 +00:00
"useDataURI": false,
Remove skins.minerva.icons.images.variants module This module produces 6 icons: ["clock", "profile"] * ["black", "gray", "white"] of which only 3 are needed: clock-gray, clock-white, profile-gray. This patch removes the module and moves the "clock" and "profile" icons into `skins.minerva.icons.images`. Since that module does not inline SVG's, the additional cost of adding these icons, which are loaded at startup, is minimal. The editLocked.svg icon has also been edited to correct its color. Bug: T218807 Change-Id: Ib54960eb556dfe0c1ae06d2f73d4f350e519e20f
2019-03-21 14:50:23 +00:00
"defaultColor": "#54595d",
"variants": {
"invert": {
"color": "#fff",
"global": false
On user pages, move language icon from Toolbar to Overflow menu The Language icon is not useful on user pages as most probably there are no translated user pages, thus there is no need to show all-time disabled Language icon. If overflow menu is available, don't show Language switcher icon in toolbar, show it as first item in the overflow menu. Bug: T224735 Follow-Up: I46d58758356e870c408a74b2c087a42d6ad0ddea Change-Id: I05be9e6457257a1f2eb224ca9ec5808814bc9ed7
2019-06-24 17:59:11 +00:00
},
"base20": {
"color": "#54595d",
"global": false
Remove skins.minerva.icons.images.variants module This module produces 6 icons: ["clock", "profile"] * ["black", "gray", "white"] of which only 3 are needed: clock-gray, clock-white, profile-gray. This patch removes the module and moves the "clock" and "profile" icons into `skins.minerva.icons.images`. Since that module does not inline SVG's, the additional cost of adding these icons, which are loaded at startup, is minimal. The editLocked.svg icon has also been edited to correct its color. Bug: T218807 Change-Id: Ib54960eb556dfe0c1ae06d2f73d4f350e519e20f
2019-03-21 14:50:23 +00:00
}
},
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"images": {
Watchstar is accessible to non-js users Bug: T196893 Change-Id: I5dbd164ba68e6c74e80f8bcf90819a526cda5a5e
2018-10-10 21:19:55 +00:00
"watch": "resources/skins.minerva.icons.images/watch.svg",
"watched": "resources/skins.minerva.icons.images/watched.svg",
Mobile page issues - visual styling changes Changes: * Introduce Jan's beautifully documented $wgMinervaABSamplingRate Set to 1 to A/B test 50% of the population * Split out ambox template styles into a separate file referenced by hacks.less * Update cleanuptemplates setup script to consider two buckets Test pages: * Shqiponja_Partizane * World_War_II_in_Albania * Liberation_of_Tirana * French_Consulate * Abd_ar-Rahman_IV * M109_howitzer * Aimoin * Transport_in_Brazil * Transport_in_Cape_Verde Bug: T191303 Change-Id: I8d11e655ccb847b7999e64dda57b225ad8b1c23a
2018-05-08 22:03:52 +00:00
"warning": "resources/skins.minerva.icons.images/warning.svg",
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"mainmenu": "resources/skins.minerva.icons.images/hamburger.svg",
"edit": "resources/skins.minerva.icons.images/editLocked.svg",
"edit-enabled": "resources/skins.minerva.icons.images/edit.svg",
On user pages, move language icon from Toolbar to Overflow menu The Language icon is not useful on user pages as most probably there are no translated user pages, thus there is no need to show all-time disabled Language icon. If overflow menu is available, don't show Language switcher icon in toolbar, show it as first item in the overflow menu. Bug: T224735 Follow-Up: I46d58758356e870c408a74b2c087a42d6ad0ddea Change-Id: I05be9e6457257a1f2eb224ca9ec5808814bc9ed7
2019-06-24 17:59:11 +00:00
"language-switcher": {
"file": "resources/skins.minerva.icons.images/languageSwitcher.svg",
"variants": [ "base20" ]
},
Remove skins.minerva.icons.images.variants module This module produces 6 icons: ["clock", "profile"] * ["black", "gray", "white"] of which only 3 are needed: clock-gray, clock-white, profile-gray. This patch removes the module and moves the "clock" and "profile" icons into `skins.minerva.icons.images`. Since that module does not inline SVG's, the additional cost of adding these icons, which are loaded at startup, is minimal. The editLocked.svg icon has also been edited to correct its color. Bug: T218807 Change-Id: Ib54960eb556dfe0c1ae06d2f73d4f350e519e20f
2019-03-21 14:50:23 +00:00
"profile": "resources/skins.minerva.icons.images/profile.svg",
"clock": {
"file": "resources/skins.minerva.icons.images/clock.svg",
"variants": [ "invert" ]
Update: add secondary page actions submenu in AMC mode When advanced mobile contributions mode is enabled and `$wgMinervaOverflowInPageActions` is set, show a secondary overflow menu on main namespace articles and user namespace pages. The menu content varies for each namespace. The new submenu is *disabled* by default, even when AMC is active. This feature should not be deployed until instrumentation is available. The secondary menu is rendered in PHP using the existing menu system with some changes to the template. The checkbox hack is needed for no- JavaScript keyboard navigation until :focus-within is supported. CSS additions are documented in the source. All client side toolbar execution occurs in Toolbar.js. Enhancements are documented in the source. Minor changes to the existing download button: - Move download and edit button initialization to Toolbar. - Update copy (not visible) from "Download" to "Download PDF". - When the overflow menu is present, use the "hasText" / label style. Wikimedia UI icons are copied from OOUI at d00a0ac and seem useful to expose as HTTP URIs (not data URIs). The overflow menu does not show for pages provided by the content proxy since its entries depend on $tpl->data['nav_urls'] being populated. Bug: T216418 Depends-On: I0781151a8232b6a7b52f79a34298afcecb8e4271 Change-Id: I4b50a0e519024a7ab91dae6ab40b23cf14a03861
2019-04-04 21:20:39 +00:00
},
"page-actions-overflow": "resources/skins.minerva.icons.images/page-actions-overflow.svg"
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
}
},
"skins.minerva.icons.images.scripts": {
Update: page issue icons - Fix a bug where the all issues endpoint would incorrectly collect issues from all sections. - Update the page issue iconography. This increases the size of the delivered code and images by 1743 B minified uncompressed according to mw.inspect() (from 16.4 KiB to 18.1 KiB). - Add support for identifying page issue severity based on template CSS classes. - For multiple issues templates, show the highest priority icon. Bug: T191528 Change-Id: Ie0a4c83ec7cfb856ec581d058797109746e3cb99
2018-07-10 20:06:51 +00:00
"targets": [
"mobile",
"desktop"
],
"dependencies": [
"skins.minerva.icons.images.scripts.misc",
"skins.minerva.icons.page.issues.uncolored",
"skins.minerva.icons.page.issues.default.color",
"skins.minerva.icons.page.issues.medium.color"
]
},
"skins.minerva.icons.images.scripts.misc": {
"class": "ResourceLoaderImageModule",
"selector": ".mw-ui-icon-minerva-{name}:before",
"images": {
Remove fancy block info popups (move to MobileFrontend) We only used them for registered users, but MobileFrontend's EditorOverlay code can use them for anonymous users as well. Remove code for looking up block details in wgMinervaUserBlockInfo, now we only care whether the user is blocked at all to display a different icon. MobileFrontend looks up the same information via API already. Remove unused message 'mobile-frontend-editor-blocked-info-loggedin', it was only used by non-fancy popups, which were removed in favor of the new ones in f51cf7db7b01b3fa14abb397e6b48ce32c15a40f. Bug: T193754 Bug: T198765 Depends-On: I80564c3e6e2d0f4d7eae754f206780fb4054f254 Change-Id: I64be24845b4fee76d6b4a8e481a218f2160fced6
2018-07-10 02:45:15 +00:00
"download": "resources/skins.minerva.icons.images.scripts.misc/download.svg"
Update: page issue icons - Fix a bug where the all issues endpoint would incorrectly collect issues from all sections. - Update the page issue iconography. This increases the size of the delivered code and images by 1743 B minified uncompressed according to mw.inspect() (from 16.4 KiB to 18.1 KiB). - Add support for identifying page issue severity based on template CSS classes. - For multiple issues templates, show the highest priority icon. Bug: T191528 Change-Id: Ie0a4c83ec7cfb856ec581d058797109746e3cb99
2018-07-10 20:06:51 +00:00
}
},
"skins.minerva.icons.page.issues.uncolored": {
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"class": "ResourceLoaderImageModule",
Prefix icons in Minerva Changes: * MinervaUI will now prefix any icons with `minerva` * Update definitions in skin.json, retaining selectors for cached HTML for icons that are rendered via PHP. * In I9021c53c2c04bdd7ce395eed33d89986acbfea6d watch and watched and arrow are moved to MobileFrontend so are removed from the RL module skins.minerva.icons.images.scripts as they are not used directly in this repo. user and anonymous are no longer used so also removed. * Presentation of userpage now belongs to MobileFrontend. Icons are styles were moved there in depends on. They are retained in skin.json to support cached HTML as user pages are subject to cache. They can be removed in a week. * In code review we noticed the anonymous icon was badly named. We rename to login. No caching implications. * Main menu icons are now prefixed with minerva rather than mf to reflect where they come from. Depends-On: I9021c53c2c04bdd7ce395eed33d89986acbfea6d Bug: T182162 Change-Id: I93264024f4915fc910c792b1905b89cdc6b8b546
2018-01-05 18:52:17 +00:00
"selector": ".mw-ui-icon-minerva-{name}:before",
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"images": {
Update: page issue icons - Fix a bug where the all issues endpoint would incorrectly collect issues from all sections. - Update the page issue iconography. This increases the size of the delivered code and images by 1743 B minified uncompressed according to mw.inspect() (from 16.4 KiB to 18.1 KiB). - Add support for identifying page issue severity based on template CSS classes. - For multiple issues templates, show the highest priority icon. Bug: T191528 Change-Id: Ie0a4c83ec7cfb856ec581d058797109746e3cb99
2018-07-10 20:06:51 +00:00
"issue-severity-low-lowColor": "resources/skins.minerva.icons.page.issues.uncolored/issue-severity-low.svg",
"issue-type-move-defaultColor": "resources/skins.minerva.icons.page.issues.uncolored/issue-type-move.svg"
}
},
"skins.minerva.icons.page.issues.default.color": {
"class": "ResourceLoaderImageModule",
"selectorWithoutVariant": ".mw-ui-icon-minerva-{name}-defaultColor:before",
"selectorWithVariant": ".mw-ui-icon-minerva-{name}-{variant}:before",
"defaultColor": "#54595d",
"variants": {
"lowColor": { "color": "#fc3", "global": true },
"mediumColor": { "color": "#ff5d01", "global": true },
"highColor": { "color": "#d33", "global": true }
},
"images": {
"issue-generic": "resources/skins.minerva.icons.page.issues.default.color/issue-generic.svg"
}
},
"skins.minerva.icons.page.issues.medium.color": {
"class": "ResourceLoaderImageModule",
"selector": ".mw-ui-icon-minerva-{name}-mediumColor:before",
"defaultColor": "#ff5d01",
"images": {
"issue-severity-medium": "resources/skins.minerva.icons.page.issues.medium.color/issue-severity-medium.svg",
"issue-type-point-of-view": "resources/skins.minerva.icons.page.issues.medium.color/issue-type-point-of-view.svg"
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
}
},
"skins.minerva.mainPage.styles": {
"targets": [
"mobile",
"desktop"
],
"styles": [
"resources/skins.minerva.mainPage.styles/common.less"
]
},
"skins.minerva.userpage.icons": {
"class": "ResourceLoaderImageModule",
Hygiene: No need for un-prefixed icons any more These were added in I93264024f4915fc910c792b1905b89cdc6b8b546 for cached HTML but are no longer needed. Change-Id: I008856c0c5e26270ed82d02a5413576495920bac
2018-04-11 21:08:24 +00:00
"selector": ".mw-ui-icon-mf-{name}:before",
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"images": {
Restore Minerva specific userpage styles for all user pages In T182162 these were removed incorrectly. They should only have been partially removed. Bug: T187222 Change-Id: Ia3fb34250714fe4ccb10c32a7027fda167e06a16
2018-02-14 00:14:54 +00:00
"talk": "resources/skins.minerva.userpage.icons/talk.svg"
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
}
},
"skins.minerva.userpage.styles": {
"targets": [
"mobile",
"desktop"
],
"styles": [
"resources/skins.minerva.userpage.styles/userpage.less"
]
},
"skins.minerva.mainMenu.icons": {
"class": "ResourceLoaderImageModule",
Prefix icons in Minerva Changes: * MinervaUI will now prefix any icons with `minerva` * Update definitions in skin.json, retaining selectors for cached HTML for icons that are rendered via PHP. * In I9021c53c2c04bdd7ce395eed33d89986acbfea6d watch and watched and arrow are moved to MobileFrontend so are removed from the RL module skins.minerva.icons.images.scripts as they are not used directly in this repo. user and anonymous are no longer used so also removed. * Presentation of userpage now belongs to MobileFrontend. Icons are styles were moved there in depends on. They are retained in skin.json to support cached HTML as user pages are subject to cache. They can be removed in a week. * In code review we noticed the anonymous icon was badly named. We rename to login. No caching implications. * Main menu icons are now prefixed with minerva rather than mf to reflect where they come from. Depends-On: I9021c53c2c04bdd7ce395eed33d89986acbfea6d Bug: T182162 Change-Id: I93264024f4915fc910c792b1905b89cdc6b8b546
2018-01-05 18:52:17 +00:00
"selector": ".mw-ui-icon-minerva-{name}:before",
Updating icons for AMC mode Replaced the following icons: - communityportal.svg - specialpages.svg - info.svg - contributions.svg Bug: T222228 Change-Id: Id7889aeb99abe39bc0efae0a1c6457826015302b
2019-06-06 12:39:52 +00:00
"defaultColor": "#4A4F53",
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"images": {
Prefix icons in Minerva Changes: * MinervaUI will now prefix any icons with `minerva` * Update definitions in skin.json, retaining selectors for cached HTML for icons that are rendered via PHP. * In I9021c53c2c04bdd7ce395eed33d89986acbfea6d watch and watched and arrow are moved to MobileFrontend so are removed from the RL module skins.minerva.icons.images.scripts as they are not used directly in this repo. user and anonymous are no longer used so also removed. * Presentation of userpage now belongs to MobileFrontend. Icons are styles were moved there in depends on. They are retained in skin.json to support cached HTML as user pages are subject to cache. They can be removed in a week. * In code review we noticed the anonymous icon was badly named. We rename to login. No caching implications. * Main menu icons are now prefixed with minerva rather than mf to reflect where they come from. Depends-On: I9021c53c2c04bdd7ce395eed33d89986acbfea6d Bug: T182162 Change-Id: I93264024f4915fc910c792b1905b89cdc6b8b546
2018-01-05 18:52:17 +00:00
"login": "resources/skins.minerva.mainMenu.icons/login.svg",
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"home": "resources/skins.minerva.mainMenu.icons/home.svg",
[UI] [new] add user menu Add new user menu. The changes required include: - Break up AuthMenuEntry into reusable components. They're now simple, independent, static functions in AuthUtil that are easy to reason about and compose. There's lots of verbose code because of the builder and director patterns. That is, most of the code is for building the thing we actually want to build instead of just building it. It's easy to write but no fun to read--even simple configurations are extremely verbose expressions that must be threaded through the system. These builders are also single purpose and unlikely to be reusable unlike a URI builder, for example. As objects, they're not especially composable either. - Similarly, break up Menu/DefaultBuilder into BuilderUtil and ban inheritance. Inheritance has not worked well on the frontend of MobileFrontend. I don't think it's going to work well here. E.g., I could have made changes to the base class' getPersonalTools() method such that the client passes a parameter for the advanced config or maybe I just override it in the subclass. In either case, I think it makes the whole hierarchy nuanced and harder to reason about for something that should be simple. - Add ProfileMenuEntry and LogOutMenuEntry for the user menu. - Rename insertLogInOutMenuItem() to insertAuthMenuItem() which matches the entry name, AuthMenuEntry. - Extension:SandboxLink is needed to display the sandbox link in the user menu. - Performance note: the toolbar is now processed in MinervaTemplate, which corresponds to removing the buildPersonalUrls() override. - To mimic the design of main menu, the following steps would be necessary: 1. Create a user/Default and user/Advanced user menu builder and also a user/IBuilder interface. 2. Create a user/Director. 3. Create a service entry for Minerva.Menu.UserDirector in ServiceWiring. The Director is actually powerless and doesn't get to make any decisions--the appropriate builder is passed in from ServiceWiring which checks the mode. 4. Access the service in SkinMinerva to set a userMenuHTML data member on the Minerva QuickTemplate. 5. In MinervaTemplate, access the userMenuHTML QuickTemplate member and do the usual song and dance of inflating a Mustache template. This patch does everything except add a service, which was agreed to be unnecessary, so that logic is now in SkinMinerva. - Wrap the existing echo user notifications button and new user menu button in a nav element. This seems like a semantic improvement. - The existing styling and logic for the search bar and search overlay are pretty messy and delicate. Changes made to that LESS endeavored to be surgical. There's lots of room for improvement in the toolbar but it's out of scope. - Rename logout icon to logOut. Bug: T214540 Change-Id: Ib517864fcf4e4d611e05525a6358ee6662fe4e05
2019-06-25 20:12:58 +00:00
"logout": {
"file": {
"ltr": "resources/skins.minerva.mainMenu.icons/logOut-ltr.svg",
"rtl": "resources/skins.minerva.mainMenu.icons/logOut-rtl.svg"
}
},
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"nearby": "resources/skins.minerva.mainMenu.icons/nearby.svg",
"random": "resources/skins.minerva.mainMenu.icons/random.svg",
"settings": "resources/skins.minerva.mainMenu.icons/settings.svg",
"watchlist": "resources/skins.minerva.mainMenu.icons/watchlist.svg",
Updating icons for AMC mode Replaced the following icons: - communityportal.svg - specialpages.svg - info.svg - contributions.svg Bug: T222228 Change-Id: Id7889aeb99abe39bc0efae0a1c6457826015302b
2019-06-06 12:39:52 +00:00
"contributions": {
"file": {
"ltr": "resources/skins.minerva.mainMenu.icons/contributions-ltr.svg",
"rtl": "resources/skins.minerva.mainMenu.icons/contributions-rtl.svg"
}
},
[UI] [AMC] add recent changes to the AMC menu This mostly reverts commit 692309090dea405144a9e224524a5fec52e51700 and updates the icon. Bug: T224216 Change-Id: I7200aaef5a15479afb4bc99f5195e900351a055a
2019-07-30 17:27:34 +00:00
"recentchanges": {
"file": {
"ltr":"resources/skins.minerva.mainMenu.icons/recentChanges-ltr.svg",
"rtl": "resources/skins.minerva.mainMenu.icons/recentChanges-rtl.svg"
}
},
Updating icons for AMC mode Replaced the following icons: - communityportal.svg - specialpages.svg - info.svg - contributions.svg Bug: T222228 Change-Id: Id7889aeb99abe39bc0efae0a1c6457826015302b
2019-06-06 12:39:52 +00:00
"specialpages": {
"file": {
"ltr":"resources/skins.minerva.mainMenu.icons/specialpages-ltr.svg",
"rtl": "resources/skins.minerva.mainMenu.icons/specialpages-rtl.svg"
}
},
"communityportal": {
"file": {
"ltr": "resources/skins.minerva.mainMenu.icons/communityportal-ltr.svg",
"rtl": "resources/skins.minerva.mainMenu.icons/communityportal-rtl.svg"
}
[UI] [new] add user menu Add new user menu. The changes required include: - Break up AuthMenuEntry into reusable components. They're now simple, independent, static functions in AuthUtil that are easy to reason about and compose. There's lots of verbose code because of the builder and director patterns. That is, most of the code is for building the thing we actually want to build instead of just building it. It's easy to write but no fun to read--even simple configurations are extremely verbose expressions that must be threaded through the system. These builders are also single purpose and unlikely to be reusable unlike a URI builder, for example. As objects, they're not especially composable either. - Similarly, break up Menu/DefaultBuilder into BuilderUtil and ban inheritance. Inheritance has not worked well on the frontend of MobileFrontend. I don't think it's going to work well here. E.g., I could have made changes to the base class' getPersonalTools() method such that the client passes a parameter for the advanced config or maybe I just override it in the subclass. In either case, I think it makes the whole hierarchy nuanced and harder to reason about for something that should be simple. - Add ProfileMenuEntry and LogOutMenuEntry for the user menu. - Rename insertLogInOutMenuItem() to insertAuthMenuItem() which matches the entry name, AuthMenuEntry. - Extension:SandboxLink is needed to display the sandbox link in the user menu. - Performance note: the toolbar is now processed in MinervaTemplate, which corresponds to removing the buildPersonalUrls() override. - To mimic the design of main menu, the following steps would be necessary: 1. Create a user/Default and user/Advanced user menu builder and also a user/IBuilder interface. 2. Create a user/Director. 3. Create a service entry for Minerva.Menu.UserDirector in ServiceWiring. The Director is actually powerless and doesn't get to make any decisions--the appropriate builder is passed in from ServiceWiring which checks the mode. 4. Access the service in SkinMinerva to set a userMenuHTML data member on the Minerva QuickTemplate. 5. In MinervaTemplate, access the userMenuHTML QuickTemplate member and do the usual song and dance of inflating a Mustache template. This patch does everything except add a service, which was agreed to be unnecessary, so that logic is now in SkinMinerva. - Wrap the existing echo user notifications button and new user menu button in a nav element. This seems like a semantic improvement. - The existing styling and logic for the search bar and search overlay are pretty messy and delicate. Changes made to that LESS endeavored to be surgical. There's lots of room for improvement in the toolbar but it's out of scope. - Rename logout icon to logOut. Bug: T214540 Change-Id: Ib517864fcf4e4d611e05525a6358ee6662fe4e05
2019-06-25 20:12:58 +00:00
},
"userSandbox": "resources/skins.minerva.mainMenu.icons/userSandbox.svg"
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
}
},
"skins.minerva.mainMenu.styles": {
"targets": [
"mobile",
"desktop"
],
"styles": [
[dev] divide main menu LESS Split apart the extensive mainmenu.less file into a few component-like files: MainMenu, MainMenuFooter, MainMenuItem, and NotificationsOverlay. Two variables, @duration and @easing, were moved to minerva.variables. The separation is imperfect as some overlap still exists but is far better than before. This patch is focused on division without regression. Please limit any refactor requests. No user visible changes intended. The only selector that was cognizantly changed was to duplicate the drawer visibility on main menu and notifications overlay: // Old: mainmenu.less .navigation-drawer, .transparent-shield { visibility: visible; } // --- // New: MainMenu.less #mw-mf-page-left, .transparent-shield { visibility: visible; } // New: NotifcationsOverlay.less .navigation-enabled { .notifications-overlay { visibility: visible; } } The is unfortunately useless. It is best to reproduce these changes locally by renaming mainmenu.less to MainMenu.less and extract parts to MainMenuFooter, MainMenuItem, and NotificationsOverlay LESS files until the result matches. Bug: T206354 Change-Id: I8d37c5346efcf39a4d76322fd6e6af3fff96ac53
2019-08-01 20:35:10 +00:00
"resources/skins.minerva.mainMenu.styles/MainMenu.less",
"resources/skins.minerva.mainMenu.styles/MainMenuItem.less",
"resources/skins.minerva.mainMenu.styles/MainMenuFooter.less",
"resources/skins.minerva.mainMenu.styles/NotificationsOverlay.less"
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
]
},
Only load notification icon (bell) CSS for logged in users * The notification-count style is only needed if you are logged in. Given a small percentage of our users are logged in, we load a lot of render blocking css unnecessarily. * The bell icon is not needed for anonymous users so pull that out from skins.minerva.icons.images which is loaded for all users into a module only used by logged in users (skins.minerva.icons.loggedin) * Simplify the user-button rule - it is overly specific - probably for historic reasons. Additional changes: * Simplify isAuthenticated helper Change-Id: Ia72e7e45d276e8aac1ff5471bf6158705c7b5f99
2017-12-13 01:25:10 +00:00
"skins.minerva.loggedin.styles": {
"targets": [
"mobile",
"desktop"
],
"styles": [
"resources/skins.minerva.loggedin.styles/styles.less"
]
},
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"skins.minerva.scripts": {
"targets": [
"mobile",
"desktop"
],
"dependencies": [
Refresh the user, bell and search icon * New module skins.minerva.icons.wikimedia provides icons from Wikimedia UI in Minerva * search selector in skins.minerva.content.styles.images is retained for cached HTML * skins.minerva.icons.loggedin now a ResourceLoaderOOUIIconPackModule and bell removed from repo. * userAvatar replaced with userAvatarOutline Bug: T224070 Change-Id: Ibed609371060acc4b69e5cd4cd4f20edc871b3ba
2019-07-09 19:12:51 +00:00
"skins.minerva.icons.wikimedia",
Embrace packageFiles Help with readability by using module.exports and require rather than the MobileFrontend provided mw.mobileFrontend module manager (and avoid adopting webpack at this time) Replace usages of mw.mobileFrontend.require with local require and module.exports (compatible with RL or Node implementation) Changes: * Notifications modules are merged into skins.minerva.scripts and initialised via a client side check. * new file overlayManager for exporting an overlayManager singleton rather than being hidden inside resources/skins.minerva.scripts/init.js * All M.define/M.requires swapped out for require where possible The `define` method is now forbidden in the repo. Bug: T212944 Change-Id: I44790dd3fc6fe42bb502d79c39c4081c223bf2b1
2019-07-02 21:10:10 +00:00
"mediawiki.ui.anchor",
Update: add secondary page actions submenu in AMC mode When advanced mobile contributions mode is enabled and `$wgMinervaOverflowInPageActions` is set, show a secondary overflow menu on main namespace articles and user namespace pages. The menu content varies for each namespace. The new submenu is *disabled* by default, even when AMC is active. This feature should not be deployed until instrumentation is available. The secondary menu is rendered in PHP using the existing menu system with some changes to the template. The checkbox hack is needed for no- JavaScript keyboard navigation until :focus-within is supported. CSS additions are documented in the source. All client side toolbar execution occurs in Toolbar.js. Enhancements are documented in the source. Minor changes to the existing download button: - Move download and edit button initialization to Toolbar. - Update copy (not visible) from "Download" to "Download PDF". - When the overflow menu is present, use the "hasText" / label style. Wikimedia UI icons are copied from OOUI at d00a0ac and seem useful to expose as HTTP URIs (not data URIs). The overflow menu does not show for pages provided by the content proxy since its entries depend on $tpl->data['nav_urls'] being populated. Bug: T216418 Depends-On: I0781151a8232b6a7b52f79a34298afcecb8e4271 Change-Id: I4b50a0e519024a7ab91dae6ab40b23cf14a03861
2019-04-04 21:20:39 +00:00
"wikimedia.ui",
Merge skins.minerva.scripts.top and skins.minerva.mainMenu into scripts These modules can safely be merged. Since skins.minerva.scripts.top is added via addModules to the HTML it must be marked as deprecated and remain temporarily as a redirection to skins.minerva.scripts All modules have been renamed to be in there new home - no deprecation notices are needed as they are not used outside Minerva. I leave skins.minerva.mainMenu.styles as it is used by Special:MobileMenu and needs to continue to do so. Change-Id: Ie919151630f4389f8e84e808bec003a6d3d07bd9
2019-02-07 16:09:20 +00:00
"skins.minerva.mainMenu.icons",
"skins.minerva.mainMenu.styles",
Make dependency to jquery.cookie explicit for mobileRedirect code Change-Id: I9ecdf9b507df6a9ec04933981ec5960c524e2323
2018-03-02 00:27:00 +00:00
"jquery.cookie",
Add feature flagged DownloadIcon Shortcut for print. Disabled by default and controlled by wgMinervaDownloadIcon Note that with lazy images enabled, images will not appear in the printed article. This can be easily addressed inside the onClick function in a later patchset with a few modifications to the Skin class. Currently the flag when enabled will show on all browsers. There are some open questions on the ticket about how we want to limit the feature. This shouldn't block review or merging. Bug: T177215 Change-Id: I49f1736870c743990b3fb9916247e07a597b2f59
2017-10-18 21:03:51 +00:00
"skins.minerva.icons.images.scripts",
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"mediawiki.util",
"mediawiki.router",
Update: don't prompt to create User pages Suppress the redlink drawer for User namespace pages. The redlink drawer prompts the user to create a missing page but this hinders the usual workflow for User page visits specifically. A User page is connection to an account's contributions, age, and other activities and encouraging the creation of a missing User page when trying to view these connections is a hindrance, especially if the missing User page is not associated with the current user. Bug: T201339 Change-Id: I784493a8ecf28176b5a393cb52d7bfa9fa9b1309
2019-03-04 22:19:33 +00:00
"mediawiki.RegExp",
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"mediawiki.Title",
Update: don't prompt to create User pages Suppress the redlink drawer for User namespace pages. The redlink drawer prompts the user to create a missing page but this hinders the usual workflow for User page visits specifically. A User page is connection to an account's contributions, age, and other activities and encouraging the creation of a missing User page when trying to view these connections is a hindrance, especially if the missing User page is not associated with the current user. Bug: T201339 Change-Id: I784493a8ecf28176b5a393cb52d7bfa9fa9b1309
2019-03-04 22:19:33 +00:00
"mediawiki.Uri",
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"mobile.startup",
A/B test bucketing wrapper for page issues AB. Provides a class that initiates AB-test bucketing and registers as a MF module. Activates the reading depth test for users who are bucketed in either buckets "A" or "B". Does not add event-logging or visual style changes for page issues AB test. Bug: T193584 Change-Id: If8504a35059c6d1b056cef063a595b1c2ffd351a
2018-05-09 15:14:44 +00:00
"mediawiki.user",
"mediawiki.storage",
"mediawiki.experiments"
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
],
"messages": [
Embrace packageFiles Help with readability by using module.exports and require rather than the MobileFrontend provided mw.mobileFrontend module manager (and avoid adopting webpack at this time) Replace usages of mw.mobileFrontend.require with local require and module.exports (compatible with RL or Node implementation) Changes: * Notifications modules are merged into skins.minerva.scripts and initialised via a client side check. * new file overlayManager for exporting an overlayManager singleton rather than being hidden inside resources/skins.minerva.scripts/init.js * All M.define/M.requires swapped out for require where possible The `define` method is now forbidden in the repo. Bug: T212944 Change-Id: I44790dd3fc6fe42bb502d79c39c4081c223bf2b1
2019-07-02 21:10:10 +00:00
"echo-badge-count",
"mobile-frontend-notifications-filter",
Mobile page issues - visual styling changes Changes: * Introduce Jan's beautifully documented $wgMinervaABSamplingRate Set to 1 to A/B test 50% of the population * Split out ambox template styles into a separate file referenced by hacks.less * Update cleanuptemplates setup script to consider two buckets Test pages: * Shqiponja_Partizane * World_War_II_in_Albania * Liberation_of_Tirana * French_Consulate * Abd_ar-Rahman_IV * M109_howitzer * Aimoin * Transport_in_Brazil * Transport_in_Cape_Verde Bug: T191303 Change-Id: I8d11e655ccb847b7999e64dda57b225ad8b1c23a
2018-05-08 22:03:52 +00:00
"skin-minerva-issue-learn-more",
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"mobile-frontend-meta-data-issues",
Section issues overlay has different heading Per https://phabricator.wikimedia.org/T197932#4417319 Note that given talk/category overlay does not use or display section issues, to simplify things any section other than 0 or all will use this heading. Bug: T197932 Change-Id: I737fb07aaadcea7772d0b08f8b0652dcf2f4623d
2018-07-11 21:13:19 +00:00
"minerva-meta-data-issues-section-header",
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"mobile-frontend-meta-data-issues-talk",
"mobile-frontend-meta-data-issues-categories",
"mobile-frontend-meta-data-issues-header",
"mobile-frontend-meta-data-issues-header-talk",
"mobile-frontend-languages-not-available",
"mobile-frontend-cookies-required",
Move redlink CTA out of skins.minerva.editor It is not part of the editor. Redlinks are part of page content. Bug: T198765 Change-Id: Iee77a228b6f2db1c5f2e85226d6cc1c6a73a89be
2018-09-20 22:52:35 +00:00
"mobile-frontend-editor-redlink-create",
"mobile-frontend-editor-redlink-leave",
"mobile-frontend-editor-redlink-explain",
Add feature flagged DownloadIcon Shortcut for print. Disabled by default and controlled by wgMinervaDownloadIcon Note that with lazy images enabled, images will not appear in the printed article. This can be easily addressed inside the onClick function in a later patchset with a few modifications to the Skin class. Currently the flag when enabled will show on all browsers. There are some open questions on the ticket about how we want to limit the feature. This shouldn't block review or merging. Bug: T177215 Change-Id: I49f1736870c743990b3fb9916247e07a597b2f59
2017-10-18 21:03:51 +00:00
"minerva-download",
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"mobile-frontend-redirected-from"
],
Restore last modified active link color In I7abdbac4d2d16b931e2b110fcebf0dfc82146753 I accidentally removed the active link color (I meant to /move/ it from the critical path since it requires JavaScript) Change-Id: Ie86c3c9d03a0ed130a86c50bb548c9b47db6def6
2018-04-13 17:17:36 +00:00
"styles": [
Hygiene: IssuesOverlay moved from MobileFrontend to Minerva The CleanupOverlay is moved to Minerva and renamed the IssuesOverlay to be consistent with current terminology The new IssuesOverlay is defined inside the module skins.minerva.scripts to which it now belongs. Additional changes: * various file renames * overlay-cleanup renames overlay-issues * cleanuptemplates renamed issues.js * Add a test stub file to avoid the need to load templates inside the test environment After this change, I75f47622d94e504688e04dfb2892540473817053 should be merged to avoid confusion. Change-Id: I08945a324a6b878abe56efed1e988466085b3018
2018-08-16 19:00:38 +00:00
"resources/skins.minerva.scripts/styles.less",
[dev] match page issues LESS filename to JS naming Bug: T212944 Change-Id: I0fa44cdb26b24fff87a7c4dfd424fe4400ceee22
2019-07-10 20:10:43 +00:00
"resources/skins.minerva.scripts/page-issues/overlay/pageIssuesOverlay.less"
Restore last modified active link color In I7abdbac4d2d16b931e2b110fcebf0dfc82146753 I accidentally removed the active link color (I meant to /move/ it from the critical path since it requires JavaScript) Change-Id: Ie86c3c9d03a0ed130a86c50bb548c9b47db6def6
2018-04-13 17:17:36 +00:00
],
Hygiene: IssuesOverlay moved from MobileFrontend to Minerva The CleanupOverlay is moved to Minerva and renamed the IssuesOverlay to be consistent with current terminology The new IssuesOverlay is defined inside the module skins.minerva.scripts to which it now belongs. Additional changes: * various file renames * overlay-cleanup renames overlay-issues * cleanuptemplates renamed issues.js * Add a test stub file to avoid the need to load templates inside the test environment After this change, I75f47622d94e504688e04dfb2892540473817053 should be merged to avoid confusion. Change-Id: I08945a324a6b878abe56efed1e988466085b3018
2018-08-16 19:00:38 +00:00
"templates": {
Embrace packageFiles Help with readability by using module.exports and require rather than the MobileFrontend provided mw.mobileFrontend module manager (and avoid adopting webpack at this time) Replace usages of mw.mobileFrontend.require with local require and module.exports (compatible with RL or Node implementation) Changes: * Notifications modules are merged into skins.minerva.scripts and initialised via a client side check. * new file overlayManager for exporting an overlayManager singleton rather than being hidden inside resources/skins.minerva.scripts/init.js * All M.define/M.requires swapped out for require where possible The `define` method is now forbidden in the repo. Bug: T212944 Change-Id: I44790dd3fc6fe42bb502d79c39c4081c223bf2b1
2019-07-02 21:10:10 +00:00
"badge.mustache": "includes/skins/userNotifications.mustache",
Minerva is Hogan free All hail Mustache! Change-Id: Iaf83dc27addd00ffd65d003bd5d84441965124e8 Depends-On: If00010e092e3766f9812f9a69ce0dfe22298689a Bug: T220620
2019-04-25 02:34:01 +00:00
"IssueNotice.mustache": "resources/skins.minerva.scripts/page-issues/overlay/IssueNotice.mustache",
"menu.mustache": "resources/skins.minerva.scripts/menu/menu.mustache",
"menuGroup.mustache": "resources/skins.minerva.scripts/menu/menuGroup.mustache"
Hygiene: IssuesOverlay moved from MobileFrontend to Minerva The CleanupOverlay is moved to Minerva and renamed the IssuesOverlay to be consistent with current terminology The new IssuesOverlay is defined inside the module skins.minerva.scripts to which it now belongs. Additional changes: * various file renames * overlay-cleanup renames overlay-issues * cleanuptemplates renamed issues.js * Add a test stub file to avoid the need to load templates inside the test environment After this change, I75f47622d94e504688e04dfb2892540473817053 should be merged to avoid confusion. Change-Id: I08945a324a6b878abe56efed1e988466085b3018
2018-08-16 19:00:38 +00:00
},
Embrace packageFiles Help with readability by using module.exports and require rather than the MobileFrontend provided mw.mobileFrontend module manager (and avoid adopting webpack at this time) Replace usages of mw.mobileFrontend.require with local require and module.exports (compatible with RL or Node implementation) Changes: * Notifications modules are merged into skins.minerva.scripts and initialised via a client side check. * new file overlayManager for exporting an overlayManager singleton rather than being hidden inside resources/skins.minerva.scripts/init.js * All M.define/M.requires swapped out for require where possible The `define` method is now forbidden in the repo. Bug: T212944 Change-Id: I44790dd3fc6fe42bb502d79c39c4081c223bf2b1
2019-07-02 21:10:10 +00:00
"packageFiles": [
"resources/skins.minerva.scripts/init.js",
"resources/skins.minerva.scripts/NotificationBadge.js",
"resources/skins.minerva.scripts/notifications.js",
"resources/skins.minerva.scripts/overlayManager.js",
Merge skins.minerva.scripts.top and skins.minerva.mainMenu into scripts These modules can safely be merged. Since skins.minerva.scripts.top is added via addModules to the HTML it must be marked as deprecated and remain temporarily as a redirection to skins.minerva.scripts All modules have been renamed to be in there new home - no deprecation notices are needed as they are not used outside Minerva. I leave skins.minerva.mainMenu.styles as it is used by Special:MobileMenu and needs to continue to do so. Change-Id: Ie919151630f4389f8e84e808bec003a6d3d07bd9
2019-02-07 16:09:20 +00:00
"resources/skins.minerva.scripts/menu/MainMenu.js",
"resources/skins.minerva.scripts/menu.js",
Hygiene: Load errorLogger earlier in stack Follow up to I07f01b4c025b2e5e4cbf88ec05e7c536442c62cc Bug: T202026 Change-Id: I190417e90fd27b21844a20f96ec1237416c57079
2018-09-06 20:47:13 +00:00
"resources/skins.minerva.scripts/errorLogging.js",
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"resources/skins.minerva.scripts/preInit.js",
Composition: DownloadIcon The DownloadIcon is reduced to a factory function that returns an instance of Icon Depends-On: I4d703eef68d51bbe0b03579c5cca0845e17b8c9d Depends-On: I4a4129b2cac7c7c49559beef0b8780f3211edf9c Bug: T205592 Change-Id: Ib87390d17bef6f50842f52cd84c9ce2b162aaff0
2018-11-08 00:06:54 +00:00
"resources/skins.minerva.scripts/downloadPageAction.js",
Update page issues folder structure Tests are untouched as these will be moved to headless node-qunit in a follow up. Bug: T212944 Change-Id: I3d9b43387e34fd49827e3ab62420f3555ff4b3cd
2019-07-02 20:34:03 +00:00
"resources/skins.minerva.scripts/page-issues/parser.js",
Hygiene: Separate cleanups library from initialisation In order to write tests, we'd like to separate code without side effects from code that executes it as part of setup. This shuffles dependencies and makes page and overlayManager parameters to the init function (injected dependencies) Change-Id: I96808541d48be7869fed3bc30babb80866e139ec
2018-07-30 14:45:44 +00:00
"resources/skins.minerva.scripts/AB.js",
pageIssuesOverlay is a factory function that returns an Overlay This experiments with making PageIssuesOverlay an Overlay with various options. The appending of children is a little messy and points at a need to standardise this some way (see https://phabricator.wikimedia.org/T209647) TODO: * Remove the iconString property on PageIssueSummary which is no longer needed Bug: T209647 Change-Id: Iadd798a820dca6bbb31edc9a8570b6db7aac237a
2018-11-24 01:49:47 +00:00
"resources/skins.minerva.scripts/page-issues/overlay/IssueNotice.js",
"resources/skins.minerva.scripts/page-issues/overlay/IssueList.js",
"resources/skins.minerva.scripts/page-issues/overlay/pageIssuesOverlay.js",
Hygiene: separate page issue view logic - Move page issue view components that do not modify the DOM during during construction to PageIssueLearnMoreLink.js and PageIssueLink.js. PascalCase is used optimistically for filenaming in the hopes that these functions can become something like a JSX component. A "new" function prefix is used in the meantime. - Move page issue view logic that munges the existing DOM to pageIssueFormatter.js. Substitute "create" prefixes for insert so that clients won't forget that calling the function is a modify operation. Alternative naming welcome but it shouldn't be confused with more idealistic components that do not depend on DOM state for construction. - Consolidate createPageIssueBanner() and createPageIssueBannerMultiple() into insertPageIssueBanner() as the code was quite similar and were it a true component, it would probably be a single component. All new files appear under page/ to keep their distinction from the overlay code clear. Some view logic remains in pageIssues.js but it shall be difficult to isolate. Bug: T212376 Change-Id: Iccce709c34fa8de5a28a5a00098add5775e3dc9a
2019-01-23 20:16:11 +00:00
"resources/skins.minerva.scripts/page-issues/page/PageIssueLearnMoreLink.js",
"resources/skins.minerva.scripts/page-issues/page/PageIssueLink.js",
"resources/skins.minerva.scripts/page-issues/page/pageIssueFormatter.js",
Update page issues folder structure Tests are untouched as these will be moved to headless node-qunit in a follow up. Bug: T212944 Change-Id: I3d9b43387e34fd49827e3ab62420f3555ff4b3cd
2019-07-02 20:34:03 +00:00
"resources/skins.minerva.scripts/page-issues/index.js",
Update: don't prompt to create User pages Suppress the redlink drawer for User namespace pages. The redlink drawer prompts the user to create a missing page but this hinders the usual workflow for User page visits specifically. A User page is connection to an account's contributions, age, and other activities and encouraging the creation of a missing User page when trying to view these connections is a hindrance, especially if the missing User page is not associated with the current user. Bug: T201339 Change-Id: I784493a8ecf28176b5a393cb52d7bfa9fa9b1309
2019-03-04 22:19:33 +00:00
"resources/skins.minerva.scripts/UriUtil.js",
"resources/skins.minerva.scripts/TitleUtil.js",
Hygiene: extract ToggleList to a reusable component A list that toggles visibility via the checkbox hack is needed in at least two spots: the page actions overflow menu and the user menu. This patch makes several refactors to turn what was previously hardcoded into page actions a reusable component: - Start a new components directory. Components are reusable and composable. The subdirectories are organized by function, not ResourceLoader module bundling which greatly improves the ability to see a component's full functionality in one directory instead of examining the entire codebase. See updates to README. - Extract pageactions.less into: - ToggleList.less: LESS for any checkbox hack list. - DropDownList.less: LESS for lists that open downwards. - MenuListItem.less: LESS for list items of menus. The division makes it easier to see concerns, dependencies, and change code. - Move pageActionMenu.mustache to a component and extract ToggleList template. - Extract ToggleList.js from Toolbar.js. Bug: T214540 Change-Id: I171831469a6733c458bc5c7ba249a5096ca975b8
2019-06-20 19:17:50 +00:00
"components/ToggleList/ToggleList.js",
Improve tab scrolling logic * If the leftmost tab is selected, scroll all the way to the left * If the rightmost tab is selected, scroll all the way to the right * If a tab in the middle is selected, scroll to center it * If the selected tab is wider than the tab container, make sure its start (left edge in LTR, right edge in RTL) is always made visible. As Bartosz reminded me, .scrollLeft in RTL is a cross-browser nightmare (see https://github.com/othree/jquery.rtl-scroll-type), so add a bunch of code working around this. Some of this logic is in OOUI already, but what's there is not enough for what we need here, and we also don't want to load OOUI for this. Bug: T223142 Change-Id: Ica298954b42f9daa4819043ec24bc0266290a927
2019-06-25 01:10:51 +00:00
"resources/skins.minerva.scripts/TabScroll.js",
Update: add secondary page actions submenu in AMC mode When advanced mobile contributions mode is enabled and `$wgMinervaOverflowInPageActions` is set, show a secondary overflow menu on main namespace articles and user namespace pages. The menu content varies for each namespace. The new submenu is *disabled* by default, even when AMC is active. This feature should not be deployed until instrumentation is available. The secondary menu is rendered in PHP using the existing menu system with some changes to the template. The checkbox hack is needed for no- JavaScript keyboard navigation until :focus-within is supported. CSS additions are documented in the source. All client side toolbar execution occurs in Toolbar.js. Enhancements are documented in the source. Minor changes to the existing download button: - Move download and edit button initialization to Toolbar. - Update copy (not visible) from "Download" to "Download PDF". - When the overflow menu is present, use the "hasText" / label style. Wikimedia UI icons are copied from OOUI at d00a0ac and seem useful to expose as HTTP URIs (not data URIs). The overflow menu does not show for pages provided by the content proxy since its entries depend on $tpl->data['nav_urls'] being populated. Bug: T216418 Depends-On: I0781151a8232b6a7b52f79a34298afcecb8e4271 Change-Id: I4b50a0e519024a7ab91dae6ab40b23cf14a03861
2019-04-04 21:20:39 +00:00
"resources/skins.minerva.scripts/Toolbar.js",
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"resources/skins.minerva.scripts/mobileRedirect.js",
"resources/skins.minerva.scripts/search.js",
Tablet code no longer needs to be conditional The TableOfContents component is now inside mobile.startup so is readily available. Thus skins.minerva.tablet.scripts is removed and its code moved inside skins.minerva.scripts The check to whether the user is in tablet mode now happens inside toc.js The resize handler is dropped on the basis that this is an edge case that is not worth supporting at the cost of an eventBus. Depends-On: I353d6d7a6884dae03b55364150c6bb95cd4cc57f Change-Id: Id16a64573e020b4606fc9b11456163a4cd290e0b
2019-01-11 00:18:45 +00:00
"resources/skins.minerva.scripts/references.js",
"resources/skins.minerva.scripts/toc.js"
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
]
},
Add share icon as mobile web beta feature Add a new beta feature - share icon. When user opts into beta the share icon will be visible on supported devices (Android OS and Chrome browser). Bug: T181195 Change-Id: Ie4b9dd05eea9b63422bd174048d8b1251cb02bf4
2018-09-17 23:37:57 +00:00
"skins.minerva.options.share.icon": {
"class": "ResourceLoaderImageModule",
"selector": ".mw-ui-icon-minerva-{name}:before",
"images": {
"share": "resources/skins.minerva.options/share.svg"
}
},
Merge skin option modules into a single ResourceLoader module and move enabled logic to client It's presumed that skin options will eventually become the default or be removed from the skin. While they are not the default, it would be helpful to package them in one single module - as ResourceLoader modules are costly bloating the dependency graph in the MediaWiki startup module. In T167713 we talked about grouping our entry points by page rather than feature, which this seems consistent with. A page with special options enabled is different from a page without. Change-Id: Id948f913d4743532ba3442d2059a03c122419ff2
2018-09-26 23:03:20 +00:00
"skins.minerva.options": {
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"targets": [
"mobile",
"desktop"
],
"dependencies": [
Merge skin option modules into a single ResourceLoader module and move enabled logic to client It's presumed that skin options will eventually become the default or be removed from the skin. While they are not the default, it would be helpful to package them in one single module - as ResourceLoader modules are costly bloating the dependency graph in the MediaWiki startup module. In T167713 we talked about grouping our entry points by page rather than feature, which this seems consistent with. A page with special options enabled is different from a page without. Change-Id: Id948f913d4743532ba3442d2059a03c122419ff2
2018-09-26 23:03:20 +00:00
"skins.minerva.scripts",
Add share icon as mobile web beta feature Add a new beta feature - share icon. When user opts into beta the share icon will be visible on supported devices (Android OS and Chrome browser). Bug: T181195 Change-Id: Ie4b9dd05eea9b63422bd174048d8b1251cb02bf4
2018-09-17 23:37:57 +00:00
"mediawiki.language",
"mobile.startup",
"skins.minerva.options.share.icon"
],
"messages": [
"skin-minerva-share"
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
],
Minerva owns BacktoTopOverlay Not used in MobileFrontend so it is moved here from that repo. t r Change-Id: I97e6010026daf4c6610bcfbedf140fb2a45b1130
2017-10-23 16:37:32 +00:00
"templates": {
Minerva is Hogan free All hail Mustache! Change-Id: Iaf83dc27addd00ffd65d003bd5d84441965124e8 Depends-On: If00010e092e3766f9812f9a69ce0dfe22298689a Bug: T220620
2019-04-25 02:34:01 +00:00
"BackToTopOverlay.mustache": "resources/skins.minerva.options/BackToTopOverlay.mustache"
Minerva owns BacktoTopOverlay Not used in MobileFrontend so it is moved here from that repo. t r Change-Id: I97e6010026daf4c6610bcfbedf140fb2a45b1130
2017-10-23 16:37:32 +00:00
},
"styles": [
Merge skin option modules into a single ResourceLoader module and move enabled logic to client It's presumed that skin options will eventually become the default or be removed from the skin. While they are not the default, it would be helpful to package them in one single module - as ResourceLoader modules are costly bloating the dependency graph in the MediaWiki startup module. In T167713 we talked about grouping our entry points by page rather than feature, which this seems consistent with. A page with special options enabled is different from a page without. Change-Id: Id948f913d4743532ba3442d2059a03c122419ff2
2018-09-26 23:03:20 +00:00
"resources/skins.minerva.options/backtotop.less"
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
],
skins.minerva.options uses packageFiles I want to remove the need for M.define in the Minerva repository. It's no longer necessary with packageFiles and will help tame a lot of the code we have here! Change-Id: If6a35a23e84a44adb965fd9c41265ba37eb8368e
2019-07-05 22:21:34 +00:00
"packageFiles": [
"resources/skins.minerva.options/index.js",
Merge skin option modules into a single ResourceLoader module and move enabled logic to client It's presumed that skin options will eventually become the default or be removed from the skin. While they are not the default, it would be helpful to package them in one single module - as ResourceLoader modules are costly bloating the dependency graph in the MediaWiki startup module. In T167713 we talked about grouping our entry points by page rather than feature, which this seems consistent with. A page with special options enabled is different from a page without. Change-Id: Id948f913d4743532ba3442d2059a03c122419ff2
2018-09-26 23:03:20 +00:00
"resources/skins.minerva.options/BackToTopOverlay.js",
"resources/skins.minerva.options/backtotop.js",
Add share icon as mobile web beta feature Add a new beta feature - share icon. When user opts into beta the share icon will be visible on supported devices (Android OS and Chrome browser). Bug: T181195 Change-Id: Ie4b9dd05eea9b63422bd174048d8b1251cb02bf4
2018-09-17 23:37:57 +00:00
"resources/skins.minerva.options/categories.js",
Track share button usage Use MobileWebShareButton schema to track interactions with Additional changes: Fix how button is injected into page actions bar as last AMC changes broke it. Bug: T207280 Change-Id: Ie7d7ab6bc66df5ab30aaec77e2ee8583c69b8f48
2019-03-15 22:37:11 +00:00
"resources/skins.minerva.options/trackShare.js",
Generate a shareIcon via composition Bug: T205592 Change-Id: Ia107b13d4f658ce7cc077ca7337530f3e448c522
2019-01-03 23:26:54 +00:00
"resources/skins.minerva.options/shareIcon.js",
Add share icon as mobile web beta feature Add a new beta feature - share icon. When user opts into beta the share icon will be visible on supported devices (Android OS and Chrome browser). Bug: T181195 Change-Id: Ie4b9dd05eea9b63422bd174048d8b1251cb02bf4
2018-09-17 23:37:57 +00:00
"resources/skins.minerva.options/share.js"
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
]
},
"skins.minerva.talk": {
"targets": [
"mobile",
"desktop"
],
"dependencies": [
"skins.minerva.icons.images.scripts",
"skins.minerva.scripts",
"mobile.startup",
"mediawiki.Title"
],
"scripts": [
"resources/skins.minerva.talk/init.js"
]
},
"skins.minerva.toggling": {
Remove unnecessary MinervaResourceLoaderParsedMessageModule All of the uses are unnecessary or harmful: * 'skins.minerva.toggling' This module has no messages, parsed or otherwise. * 'skins.minerva.editor' * 'mobile-frontend-editor-redlink-explain' This message has no formatting to be parsed. In the past, it included the '{{SITENAME}}' magic word, which is still present in some translations, but it is supported by the client-side jqueryMsg parser anyway. * 'mobile-frontend-editor-blocked-info-loggedin' This message only uses '{{GENDER}}', which is supported by the client-side jqueryMsg parser. More importantly, it uses a parameter for it, which is actually not supported by MinervaResourceLoaderParsedMessageModule. The message would always use the default gender, regardless of the parameter. Change-Id: I0c597febf9051670228dd144b53521a121f3a220
2018-07-10 00:24:53 +00:00
"targets": [
"mobile",
"desktop"
],
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"dependencies": [
Remove references to "mobile.toggle" module. mobile.toggle was folded into mobile.startup in mobileFrontend, so moving references to that instead. - Changing require statements - moving skinStyles/mobile.toggle/minerva.less to skinStyles/mobile.startup/toggle.less - Replacing references to mobile.toggle in skin.json Depends-On: Iecc1870f08532e8c7893861afdd54f069da54be2 Bug: T210208 Change-Id: Ie67cd50a2d042fbbaaef348b9b62d64193900d78
2018-12-13 23:45:34 +00:00
"mobile.startup",
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"skins.minerva.scripts"
],
"scripts": [
"resources/skins.minerva.toggling/init.js"
]
},
"skins.minerva.watchstar": {
"targets": [
"mobile",
"desktop"
],
"dependencies": [
"skins.minerva.icons.images.scripts",
mobile.watchstar is a deprecated module Referencing it triggers deprecation warnings so should be updated Bug: T208921 Change-Id: I7266a067a14bfa38a998f426e18f096515b7bfa7
2018-11-30 23:26:22 +00:00
"mobile.startup",
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"skins.minerva.scripts"
],
"scripts": [
"resources/skins.minerva.watchstar/init.js"
]
}
Use tabs in skin.json Change-Id: I8fb66fe2f99786bfbdc598d460c18928dbb0faa0
2017-06-09 22:09:22 +00:00
},
Use MediaWikiServices to cache commonly used helpers SkinMinerva cached the ContentHandler object for better performance. In the future the ContentHandler will be also used in the Menu, for better readability, store ContentHandler as Service. MediaWikiServices will initialize service on first access and cache it for future needs. Same applies to SkinUserPageHelper, Bug: T216152 Change-Id: Ia98dc860862360a68556272714669f0c3a13eb1e
2019-04-10 12:52:34 +00:00
"ServiceWiringFiles": [
"includes/ServiceWiring.php"
],
Move skin metadata keys to top of skin.json The keys that form the credits (name/description/url/etc.) are usually on top, and manifest_version is typically on the bottom. Change-Id: I1767b1e176c9cf892c1f627db4f5891fa6aade18
2018-05-08 01:19:40 +00:00
"manifest_version": 1
Use a Drawer for Block Notices When a user is blocked, the toast message provides insufficent information to the user. To provide more information, as well as a better design, the block message will be moved into a drawer. Bug: T165535 Change-Id: Ib025db3a8a4d1fd7bd05b69f9b5326943288372f Depends-On: I926918d0bd7f2176f188a2154dc5e99f6a8a7ad1
2018-04-14 17:54:25 +00:00
}
Reference in a new issue Copy permalink