wikimedia/mediawiki-skins-MinervaNeue
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/skins/MinervaNeue synced 2024-12-03 10:16:22 +00:00
Code Issues Packages Projects Releases Wiki Activity
mediawiki-skins-MinervaNeue/resources/skins.minerva.amc.styles/pageactions.less

23 lines
500 B
Plaintext
Raw Normal View History

styles: Replace 'mediawiki.ui/variables' call with skin variables Replacing 'mediawiki.ui/variables.less' @import with new skin-aware 'mediawiki.skin.variables.less' standard. Removing calls for 'mediawiki.skin.variables.less' in favor for 'minerva.variables.less' for consistency. Also - replacing several static values with new Codex design token featuring skin variables of `background-color`, `color`, `border-*` and `transition` categories - renaming several Less variables to variable naming standard - moving a small number of MinervaNeue specific variables into 'minderva.variables.less' file. Those should be replaced in mid-future by Codex design tokens Please note, that this patch is not replacing all values with possible Codex tokens. It's just applying them on selected categories for consistency for now to keep the patch easier reviewable. Further replacements will be done in follow-up patches. Bump MediaWiki core required version to >= v1.41.0. Bug: T319381 Bug: T332541 Depends-On: I98c8cc27527533e2efb3b987ee34bc403e988b75 Change-Id: I86c5a35377541a784552c29456e0b8b507b3ee9c
2023-04-09 13:49:29 +00:00
@import '../../minerva.less/minerva.variables.less';
Remove the mw-ui-icon hacks and overrides Note: this agitates T230232 again - when merging this please make sure a merge for I929090848f3e04647a97f4979ec78682623fa070 is pending. In various places we try to override the default mw-ui-icon behaviours The hacks need to be removed as part of addressing the core problem. Changes: * Wherever we use mw-ui-icon-before in PHP - wrap the label with a span so that label font-size is altered where needed - not the icon * Where a small icon is needed us isSmall parameter for the Icon component * Apply font-size to labels of mw-ui-icon-before elements * The browser tests need a slight update to access the span element inside a menu item - in the case of the logout button the label is always hidden, so we need to check the visibility of the parent element (secondary_action) Bug: T229440 Depends-On: I3f803ec4c9068b30aa93b803391aa4d65d8310ff Change-Id: I07e4ae233979636b739f1117dd7703571e0a9366
2019-08-30 17:23:55 +00:00
Feature flag overhaul Two new feature flags: 1) MinervaPersonalMenu 2) MinervaAdvancedMainMenu Changes: * AMC defaults to false on desktop - desktop doesn't have AMC mode it just enables several skin options. * WHen inserting a link at the bottom of the page check whether the talk at top of the page (tabs) is enabled.. not AMC * Update ServiceWiring to construct menu based on MinervaAdvancedMainMenu and MinervaPersonalMenu - note when former is enabled but not latter there is no way to logout. Noted in README. * Use one entry point for skins.minerva.amc.styles/index.less * Document files inside skins.minerva.amc.styles to make it clear which features they are associated with * Drop history page styles when AMC is disabled - it's not possible to ever get to these as the history page redirects in non-AMC mode * Rename the class .minerva--amc-enabled to minerva--history-page-action-enabled to reflect its real purpose and move styles from skins.minerva.base.styles to skins.minerva.amc.styles No need to worry about cached HTML as AMC runs without cache... * Remove isAnyAMCOptionEnabled - it's an antipattern and should be discouraged as it discourages the art of feature flagging. Nothing is using it after these changes. * The AMC_MODE flag is disabled. There is no need for this - AMC is not a feature and therefore not a skin option. It is a mechanism for turning on other skin options. Tests are updated. Testing: It should now be possible to enable any feature in `beta` and see it in the beta of the site. Bug: T229295 Change-Id: I48959905f5c09721b14a27aa1a5ad82849ac6263
2019-08-22 20:31:31 +00:00
.minerva--history-page-action-enabled {
.page-actions-menu__list-item {
flex-basis: auto;
// When AMC is enabled, space all items equally.
&:first-child {
flex-grow: 0;
}
}
}
Replace skins.minerva.mainMenu.advanced.icons with OOUI icons Additional changes: * Address a fixme relating to the overflow icon and move some AMC styles out of the critical path for non-AMC pages Note about ellipsis: The class mf-mw-ui-icon-rotate-clockwise cannot be used as it's part of MobileFrontend and loaded via JS. Minerva must work without MobileFrontend and this rotation is needed without JS. Bug: T244444 Change-Id: Ifd02c50305cf036dd6df640d778678668507e5eb
2020-04-29 04:13:55 +00:00
.page-actions-overflow-list {
// The top of the menu is flush with the bottom of the page actions toolbar.
top: 100%;
right: -@icon-padding-md;
border-radius: @border-radius-base;
}
build: Updating npm dependencies * stylelint-config-wikimedia: 0.13.0 → 0.14.0 Run stylelint fix to fix the new stylelint rule Change-Id: I7738ae421e84dd3171355391ebc82dd812b39ca4
2023-03-31 19:50:36 +00:00
.mw-ui-icon-minerva-ellipsis::before {
Remove deprecated vendor prefixes and their mixins Additional change: * The animation stylesheet pulled down for the storybook instance in dev-scripts/setup-storybook.sh is no longer referenced anywhere in assets so can be removed. Bug: T306486 Bug: T308351 Bug: T308360 Change-Id: Ia9f2a05cde2724486f7e449261c5d4875388f5ab
2022-05-16 16:55:54 +00:00
transform: rotate( 90deg );
Replace skins.minerva.mainMenu.advanced.icons with OOUI icons Additional changes: * Address a fixme relating to the overflow icon and move some AMC styles out of the critical path for non-AMC pages Note about ellipsis: The class mf-mw-ui-icon-rotate-clockwise cannot be used as it's part of MobileFrontend and loaded via JS. Minerva must work without MobileFrontend and this rotation is needed without JS. Bug: T244444 Change-Id: Ifd02c50305cf036dd6df640d778678668507e5eb
2020-04-29 04:13:55 +00:00
}
Reference in a new issue Copy permalink