wikimedia/mediawiki-skins-MinervaNeue
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/skins/MinervaNeue synced 2024-12-01 09:16:34 +00:00
Code Issues Packages Projects Releases Wiki Activity
mediawiki-skins-MinervaNeue/skin.json

707 lines
20 KiB
JSON
Raw Normal View History

Add scaffolding for skin Change-Id: Ie9420dc85f658fa21a1524dca9374cb1e14fcad7
2017-04-11 02:30:17 +00:00
{
Move skin metadata keys to top of skin.json The keys that form the credits (name/description/url/etc.) are usually on top, and manifest_version is typically on the bottom. Change-Id: I1767b1e176c9cf892c1f627db4f5891fa6aade18
2018-05-08 01:19:40 +00:00
"name": "MinervaNeue",
"namemsg": "skinname-minerva",
"descriptionmsg": "minerva-skin-desc",
Set some authors inside Minerva Apologies in advance if any unintentional hurt feelings! This is based on a git blame of the skins directory in I985c4e3a88b59461d471945ccf74cd291db45a61 before the Minerva move and consulting the extension.json of MobileFrontend. I've listed anyone with over 100 commits to the MobileFrontend resources/ skins folder as an author. The Readers Web Team as the current maintainers are listed first. If you feel you should be listed as an author of this skin as someone who has contributed more than 100 commits to the skin code (not MobileFrontend code), apologies and please add yourself. Change-Id: Ifffb07d1decb47a5e08b9c45c88ccf106f0797a1
2018-07-24 11:26:36 +00:00
"author": [
"[https://www.mediawiki.org/wiki/Reading/Web/Team Readers Web Team]",
"Bahodir Mansurov",
"Joaquin Hernandez",
"Jon Robson",
"Juliusz Gonera",
"Ryan Kaldari",
"Florian Schmidt",
"Sam Smith"
],
Move skin metadata keys to top of skin.json The keys that form the credits (name/description/url/etc.) are usually on top, and manifest_version is typically on the bottom. Change-Id: I1767b1e176c9cf892c1f627db4f5891fa6aade18
2018-05-08 01:19:40 +00:00
"type": "skin",
"url": "https://www.mediawiki.org/wiki/Skin:MinervaNeue",
"license-name": "GPL-2.0-or-later",
"requires": {
Make MobileFrontend dependency a soft one This extends the work in Ie29a1eb7746d56f7d8c99b74e5e3c213c30fdcf2 Bug: T171000 Change-Id: Ib125e1bdaace1893804892909c27a9f328445835
2019-12-18 21:15:26 +00:00
"MediaWiki": ">= 1.34.0"
Move skin metadata keys to top of skin.json The keys that form the credits (name/description/url/etc.) are usually on top, and manifest_version is typically on the bottom. Change-Id: I1767b1e176c9cf892c1f627db4f5891fa6aade18
2018-05-08 01:19:40 +00:00
},
"config": {
Upgrade skin.json schema to manifest_version 2 Bug: T242505 Change-Id: Iccc217fe695270c5a04811fdca5bd65c26ae6609
2020-01-11 04:31:33 +00:00
"MinervaCountErrors": {
"value": false
},
"MinervaDownloadNamespaces": {
"value": [
0
]
},
"MinervaEnableSiteNotice": {
"value": false
},
"MinervaCustomLogos": {
"value": []
},
"MinervaApplyKnownTemplateHacks": {
"value": false
},
"MinervaPageActions": {
"value": [
"edit",
"talk",
"watch",
"switch-language"
]
},
"MinervaAlwaysShowLanguageButton": {
"value": true
},
Talk tabs in AMC mode A new feature/skin option is added that is enabled safely inside a MobileFrontend available/unavailable hook that changes the skin to place talk tabs at the top of the page. These new talk tabs purposely show on the main page, user page and standard pages and do not show on special pages. Depends-On: Ie1a583657176acc6f7046c569c2e94fa2f72ff93 Bug: T212216 Change-Id: I57b70cd325666a287678dc897159b5bf9d089b78
2019-01-10 22:59:56 +00:00
"MinervaTalkAtTop": {
Upgrade skin.json schema to manifest_version 2 Bug: T242505 Change-Id: Iccc217fe695270c5a04811fdca5bd65c26ae6609
2020-01-11 04:31:33 +00:00
"value": {
"base": false,
"beta": false,
"loggedin": true
}
Talk tabs in AMC mode A new feature/skin option is added that is enabled safely inside a MobileFrontend available/unavailable hook that changes the skin to place talk tabs at the top of the page. These new talk tabs purposely show on the main page, user page and standard pages and do not show on special pages. Depends-On: Ie1a583657176acc6f7046c569c2e94fa2f72ff93 Bug: T212216 Change-Id: I57b70cd325666a287678dc897159b5bf9d089b78
2019-01-10 22:59:56 +00:00
},
Feature flag overhaul Two new feature flags: 1) MinervaPersonalMenu 2) MinervaAdvancedMainMenu Changes: * AMC defaults to false on desktop - desktop doesn't have AMC mode it just enables several skin options. * WHen inserting a link at the bottom of the page check whether the talk at top of the page (tabs) is enabled.. not AMC * Update ServiceWiring to construct menu based on MinervaAdvancedMainMenu and MinervaPersonalMenu - note when former is enabled but not latter there is no way to logout. Noted in README. * Use one entry point for skins.minerva.amc.styles/index.less * Document files inside skins.minerva.amc.styles to make it clear which features they are associated with * Drop history page styles when AMC is disabled - it's not possible to ever get to these as the history page redirects in non-AMC mode * Rename the class .minerva--amc-enabled to minerva--history-page-action-enabled to reflect its real purpose and move styles from skins.minerva.base.styles to skins.minerva.amc.styles No need to worry about cached HTML as AMC runs without cache... * Remove isAnyAMCOptionEnabled - it's an antipattern and should be discouraged as it discourages the art of feature flagging. Nothing is using it after these changes. * The AMC_MODE flag is disabled. There is no need for this - AMC is not a feature and therefore not a skin option. It is a mechanism for turning on other skin options. Tests are updated. Testing: It should now be possible to enable any feature in `beta` and see it in the beta of the site. Bug: T229295 Change-Id: I48959905f5c09721b14a27aa1a5ad82849ac6263
2019-08-22 20:31:31 +00:00
"MinervaAdvancedMainMenu": {
Upgrade skin.json schema to manifest_version 2 Bug: T242505 Change-Id: Iccc217fe695270c5a04811fdca5bd65c26ae6609
2020-01-11 04:31:33 +00:00
"value": {
"base": false,
"beta": false,
"amc": true
}
Feature flag overhaul Two new feature flags: 1) MinervaPersonalMenu 2) MinervaAdvancedMainMenu Changes: * AMC defaults to false on desktop - desktop doesn't have AMC mode it just enables several skin options. * WHen inserting a link at the bottom of the page check whether the talk at top of the page (tabs) is enabled.. not AMC * Update ServiceWiring to construct menu based on MinervaAdvancedMainMenu and MinervaPersonalMenu - note when former is enabled but not latter there is no way to logout. Noted in README. * Use one entry point for skins.minerva.amc.styles/index.less * Document files inside skins.minerva.amc.styles to make it clear which features they are associated with * Drop history page styles when AMC is disabled - it's not possible to ever get to these as the history page redirects in non-AMC mode * Rename the class .minerva--amc-enabled to minerva--history-page-action-enabled to reflect its real purpose and move styles from skins.minerva.base.styles to skins.minerva.amc.styles No need to worry about cached HTML as AMC runs without cache... * Remove isAnyAMCOptionEnabled - it's an antipattern and should be discouraged as it discourages the art of feature flagging. Nothing is using it after these changes. * The AMC_MODE flag is disabled. There is no need for this - AMC is not a feature and therefore not a skin option. It is a mechanism for turning on other skin options. Tests are updated. Testing: It should now be possible to enable any feature in `beta` and see it in the beta of the site. Bug: T229295 Change-Id: I48959905f5c09721b14a27aa1a5ad82849ac6263
2019-08-22 20:31:31 +00:00
},
"MinervaPersonalMenu": {
Upgrade skin.json schema to manifest_version 2 Bug: T242505 Change-Id: Iccc217fe695270c5a04811fdca5bd65c26ae6609
2020-01-11 04:31:33 +00:00
"value": {
"base": false,
"beta": false,
"amc": true
}
Feature flag overhaul Two new feature flags: 1) MinervaPersonalMenu 2) MinervaAdvancedMainMenu Changes: * AMC defaults to false on desktop - desktop doesn't have AMC mode it just enables several skin options. * WHen inserting a link at the bottom of the page check whether the talk at top of the page (tabs) is enabled.. not AMC * Update ServiceWiring to construct menu based on MinervaAdvancedMainMenu and MinervaPersonalMenu - note when former is enabled but not latter there is no way to logout. Noted in README. * Use one entry point for skins.minerva.amc.styles/index.less * Document files inside skins.minerva.amc.styles to make it clear which features they are associated with * Drop history page styles when AMC is disabled - it's not possible to ever get to these as the history page redirects in non-AMC mode * Rename the class .minerva--amc-enabled to minerva--history-page-action-enabled to reflect its real purpose and move styles from skins.minerva.base.styles to skins.minerva.amc.styles No need to worry about cached HTML as AMC runs without cache... * Remove isAnyAMCOptionEnabled - it's an antipattern and should be discouraged as it discourages the art of feature flagging. Nothing is using it after these changes. * The AMC_MODE flag is disabled. There is no need for this - AMC is not a feature and therefore not a skin option. It is a mechanism for turning on other skin options. Tests are updated. Testing: It should now be possible to enable any feature in `beta` and see it in the beta of the site. Bug: T229295 Change-Id: I48959905f5c09721b14a27aa1a5ad82849ac6263
2019-08-22 20:31:31 +00:00
},
Add config option for showing history link in page actions menu Bug: T213352 Change-Id: I6a53a7303434b0fd374bc5b6ea2dbc8e760807e6
2019-03-07 20:50:57 +00:00
"MinervaHistoryInPageActions": {
Upgrade skin.json schema to manifest_version 2 Bug: T242505 Change-Id: Iccc217fe695270c5a04811fdca5bd65c26ae6609
2020-01-11 04:31:33 +00:00
"value": {
"base": false,
"beta": false,
"loggedin": true
}
Add config option for showing history link in page actions menu Bug: T213352 Change-Id: I6a53a7303434b0fd374bc5b6ea2dbc8e760807e6
2019-03-07 20:50:57 +00:00
},
Update: add secondary page actions submenu in AMC mode When advanced mobile contributions mode is enabled and `$wgMinervaOverflowInPageActions` is set, show a secondary overflow menu on main namespace articles and user namespace pages. The menu content varies for each namespace. The new submenu is *disabled* by default, even when AMC is active. This feature should not be deployed until instrumentation is available. The secondary menu is rendered in PHP using the existing menu system with some changes to the template. The checkbox hack is needed for no- JavaScript keyboard navigation until :focus-within is supported. CSS additions are documented in the source. All client side toolbar execution occurs in Toolbar.js. Enhancements are documented in the source. Minor changes to the existing download button: - Move download and edit button initialization to Toolbar. - Update copy (not visible) from "Download" to "Download PDF". - When the overflow menu is present, use the "hasText" / label style. Wikimedia UI icons are copied from OOUI at d00a0ac and seem useful to expose as HTTP URIs (not data URIs). The overflow menu does not show for pages provided by the content proxy since its entries depend on $tpl->data['nav_urls'] being populated. Bug: T216418 Depends-On: I0781151a8232b6a7b52f79a34298afcecb8e4271 Change-Id: I4b50a0e519024a7ab91dae6ab40b23cf14a03861
2019-04-04 21:20:39 +00:00
"MinervaOverflowInPageActions": {
Upgrade skin.json schema to manifest_version 2 Bug: T242505 Change-Id: Iccc217fe695270c5a04811fdca5bd65c26ae6609
2020-01-11 04:31:33 +00:00
"value": {
"base": false,
"beta": false,
"amc": true
}
Update: add secondary page actions submenu in AMC mode When advanced mobile contributions mode is enabled and `$wgMinervaOverflowInPageActions` is set, show a secondary overflow menu on main namespace articles and user namespace pages. The menu content varies for each namespace. The new submenu is *disabled* by default, even when AMC is active. This feature should not be deployed until instrumentation is available. The secondary menu is rendered in PHP using the existing menu system with some changes to the template. The checkbox hack is needed for no- JavaScript keyboard navigation until :focus-within is supported. CSS additions are documented in the source. All client side toolbar execution occurs in Toolbar.js. Enhancements are documented in the source. Minor changes to the existing download button: - Move download and edit button initialization to Toolbar. - Update copy (not visible) from "Download" to "Download PDF". - When the overflow menu is present, use the "hasText" / label style. Wikimedia UI icons are copied from OOUI at d00a0ac and seem useful to expose as HTTP URIs (not data URIs). The overflow menu does not show for pages provided by the content proxy since its entries depend on $tpl->data['nav_urls'] being populated. Bug: T216418 Depends-On: I0781151a8232b6a7b52f79a34298afcecb8e4271 Change-Id: I4b50a0e519024a7ab91dae6ab40b23cf14a03861
2019-04-04 21:20:39 +00:00
},
Move skin metadata keys to top of skin.json The keys that form the credits (name/description/url/etc.) are usually on top, and manifest_version is typically on the bottom. Change-Id: I1767b1e176c9cf892c1f627db4f5891fa6aade18
2018-05-08 01:19:40 +00:00
"MinervaShowCategoriesButton": {
Upgrade skin.json schema to manifest_version 2 Bug: T242505 Change-Id: Iccc217fe695270c5a04811fdca5bd65c26ae6609
2020-01-11 04:31:33 +00:00
"value": {
"base": false,
"beta": true,
"amc": true
}
Move skin metadata keys to top of skin.json The keys that form the credits (name/description/url/etc.) are usually on top, and manifest_version is typically on the bottom. Change-Id: I1767b1e176c9cf892c1f627db4f5891fa6aade18
2018-05-08 01:19:40 +00:00
},
page issues is feature flagged * New feature/skin option is added and value is read inside the pageIssues setup code * issues-group-a class is added to page on server side to remove the flash of unstyled content * issues-group-A class is dropped (it's not doing anything!) * The minerva-issues flag will now accept any value to avoid confusion. It is used to override the default setting of wgMinervaPageIssuesNewTreatment A note has been added that this can be removed in future. Bug: T206179 Change-Id: I3d98fd8f8e1adc818ea03589d2c8f68fe991e861
2018-11-12 20:32:28 +00:00
"MinervaPageIssuesNewTreatment": {
Upgrade skin.json schema to manifest_version 2 Bug: T242505 Change-Id: Iccc217fe695270c5a04811fdca5bd65c26ae6609
2020-01-11 04:31:33 +00:00
"value": {
"base": true,
"beta": true
}
page issues is feature flagged * New feature/skin option is added and value is read inside the pageIssues setup code * issues-group-a class is added to page on server side to remove the flash of unstyled content * issues-group-A class is dropped (it's not doing anything!) * The minerva-issues flag will now accept any value to avoid confusion. It is used to override the default setting of wgMinervaPageIssuesNewTreatment A note has been added that this can be removed in future. Bug: T206179 Change-Id: I3d98fd8f8e1adc818ea03589d2c8f68fe991e861
2018-11-12 20:32:28 +00:00
},
Upgrade skin.json schema to manifest_version 2 Bug: T242505 Change-Id: Iccc217fe695270c5a04811fdca5bd65c26ae6609
2020-01-11 04:31:33 +00:00
"MinervaABSamplingRate": {
"value": 0
}
Move skin metadata keys to top of skin.json The keys that form the credits (name/description/url/etc.) are usually on top, and manifest_version is typically on the bottom. Change-Id: I1767b1e176c9cf892c1f627db4f5891fa6aade18
2018-05-08 01:19:40 +00:00
},
"ValidSkinNames": {
"minerva": "MinervaNeue"
},
Provide a code structure for menus handling and add Advanced menu Changes: - moved all menu elements definitions from SkinMinerva into a separate Definitions.php file - moved menu building from SkinMinerva into includes/menu/Main folder - introduced Builder pattern for easy menu building Minerva/Menu/Main/Director takes an Minerva/Menu/Main/IBuilder and builds the menu. The IBuilders use definitions from Minerva/Menu/Definitions file, so all definitions can be shared across different menus - used ServiceWiring file to register MainMenu Director as Service - left class_alias for old MenuBuilder as some extensions still use it - The hooks system have to stay like that as some extensions are using it (BlueSpiceMultiUpload and GrowthExperiments). - introduced AdvancedMenu builder for the AMC mode Bug: T216152 Change-Id: I210c3f1fa36bbd2f9108d728b12cbb21ee210354
2019-04-08 17:08:57 +00:00
"AutoloadNamespaces": {
Hygiene: Extract isAllowedPageAction into MinervaPagePermissions The isAllowedPageAction is used in multiple places (SkinMinerva and in PageActions toolbar builder). This logic should be defined in separate service, easy accessible for different parts of the Minerva skin. Changes: - Introduced MinervaPagePermissions as a centralized place to manage user permissions - Introduced MinervaNoTitlePermissions, an NullObject pattern to handle situations when we do not have Title object (like in CLI) - removed Minerva.ContentHandler service as it's not required any more - moved all permission names into constants - moved isTalkAllowed() into MinervaPermissions - renamed isAllowedPageAction() it `isAllowed()` to not mix it with PageActions. Those checks are used in many places, not only on PageActions menu - made isAllowed( watch ) more robust - now it checks that Title is watchable Bug: T221792 Change-Id: I87d44a9c717b5f752b8d1fd2f146d7f5eef3c53f
2019-05-24 00:07:27 +00:00
"MediaWiki\\Minerva\\Menu\\": "includes/menu/",
"MediaWiki\\Minerva\\Permissions\\": "includes/permissions/"
Provide a code structure for menus handling and add Advanced menu Changes: - moved all menu elements definitions from SkinMinerva into a separate Definitions.php file - moved menu building from SkinMinerva into includes/menu/Main folder - introduced Builder pattern for easy menu building Minerva/Menu/Main/Director takes an Minerva/Menu/Main/IBuilder and builds the menu. The IBuilders use definitions from Minerva/Menu/Definitions file, so all definitions can be shared across different menus - used ServiceWiring file to register MainMenu Director as Service - left class_alias for old MenuBuilder as some extensions still use it - The hooks system have to stay like that as some extensions are using it (BlueSpiceMultiUpload and GrowthExperiments). - introduced AdvancedMenu builder for the AMC mode Bug: T216152 Change-Id: I210c3f1fa36bbd2f9108d728b12cbb21ee210354
2019-04-08 17:08:57 +00:00
},
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"AutoloadClasses": {
Prepare to break the server side MobileFrontend dependency on Minerva Changes: * Minerva now maintains a MinervaUI - a simplified version of MobileUI that provides iconClass and buttonClass helpers. * Minerva now maintains its own ResourceLoaderParserMessageModule Remaining issues: * Main menu links to '#' * Unknown dependency errors are thrown due to the missing JS libraries e.g. mobile.watchstar thus JS based UI components are unusable e.g. search autocomplete, and edit button * Language button navigates to a missing special page without MobileFrontend (see T104660) Bug: T169569 Change-Id: I89e2e15faabab73b0cba91afc2f2c5e785edef29
2017-08-16 19:18:08 +00:00
"MinervaUI": "includes/MinervaUI.php",
Fix some file names to match their class names Change-Id: Ib1a12f8073a2d737c40c0b4d1dd64f9e55738019
2018-04-15 23:12:19 +00:00
"MinervaHooks": "includes/MinervaHooks.php",
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"MinervaTemplate": "includes/skins/MinervaTemplate.php",
"SkinMinerva": "includes/skins/SkinMinerva.php",
Move class_alias out of skin initialization Use the standard way of doing it by adding an autoloader entry, and putting the class_alias() call into the same file as the class. Change-Id: I93e19ebcf3dd7d9815623de5e24861949fd0269a
2017-11-08 00:05:20 +00:00
"SkinMinervaNeue": "includes/skins/SkinMinerva.php",
Provide a code structure for menus handling and add Advanced menu Changes: - moved all menu elements definitions from SkinMinerva into a separate Definitions.php file - moved menu building from SkinMinerva into includes/menu/Main folder - introduced Builder pattern for easy menu building Minerva/Menu/Main/Director takes an Minerva/Menu/Main/IBuilder and builds the menu. The IBuilders use definitions from Minerva/Menu/Definitions file, so all definitions can be shared across different menus - used ServiceWiring file to register MainMenu Director as Service - left class_alias for old MenuBuilder as some extensions still use it - The hooks system have to stay like that as some extensions are using it (BlueSpiceMultiUpload and GrowthExperiments). - introduced AdvancedMenu builder for the AMC mode Bug: T216152 Change-Id: I210c3f1fa36bbd2f9108d728b12cbb21ee210354
2019-04-08 17:08:57 +00:00
"MediaWiki\\Minerva\\Menu\\Group": "includes/menu/Group.php",
"MediaWiki\\Minerva\\MenuBuilder": "includes/menu/Group.php",
Convert custom LESS var from global to local Avoid the 'ResourceLoaderGetLessVars' hook, which registers a global LESS variable exposed to all modules (inc. core/extensions). Instead, use a FileModule subclass to provide the variable only to the modules that need it. Using this approach, also has the benefit of being tracked by the version hasher, so that changes to the configuration actually result in timely invalidation of module caches. Bug: T171367 Change-Id: I7c7d13c83004edfc852a9b7dbfc4169617ab9f64
2018-04-02 23:16:39 +00:00
"MediaWiki\\Minerva\\ResourceLoaderLessVarFileModule": "includes/ResourceLoaderLessVarFileModule.php",
Extract SkinOptions to separate class SkinOptions array was used to determine which options are available for current session. Once we started extracting things from SkinMinerva class, we found out that lots of things depend on SkinOptions. For example MainMenu/PageActionsMenu depend on skinsOptions var. We could pass $skin object as dependency to a menu builder, but this would cause a circural dependency (Skin depends on menu builder, menu builder depends on skin) which is an anti-pattern. In order to avoid such situations lets prepare first, and extract the SkinOptions to a separate class, register it as a service so different parts of Skin Minerva can freely use a single instance of SkinOptions object. Bug: T216152 Bug: T221012 Change-Id: Icd5da546e1bfaf8d9bfe86dab3b659a88eae19e4
2019-04-10 21:43:50 +00:00
"MediaWiki\\Minerva\\SkinOptions": "includes/SkinOptions.php",
Extract language/variants check to a service The $hasLangauges and $hasVariants checks were used in couple places, which lead to the same code used in many places. Following the DRY rule, let's implement a Service that can do that check, and use that service everywhere in code. Bug: T224735 Change-Id: I46d58758356e870c408a74b2c087a42d6ad0ddea
2019-07-09 16:10:31 +00:00
"MediaWiki\\Minerva\\LanguagesHelper": "includes/LanguagesHelper.php",
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"MediaWiki\\Minerva\\SkinUserPageHelper": "includes/skins/SkinUserPageHelper.php"
},
Use tabs in skin.json Change-Id: I8fb66fe2f99786bfbdc598d460c18928dbb0faa0
2017-06-09 22:09:22 +00:00
"ConfigRegistry": {
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"minerva": "GlobalVarConfig::newInstance"
},
"Hooks": {
Make MobileFrontend dependency a soft one This extends the work in Ie29a1eb7746d56f7d8c99b74e5e3c213c30fdcf2 Bug: T171000 Change-Id: Ib125e1bdaace1893804892909c27a9f328445835
2019-12-18 21:15:26 +00:00
"ResourceLoaderRegisterModules": [
"MinervaHooks::onResourceLoaderRegisterModules"
],
Reset SkinOptions after logging out Bug: T221137 Change-Id: I36ada157327b649900dbcee3917883fe8ee7687a
2019-08-01 20:15:19 +00:00
"UserLogoutComplete": [
"MinervaHooks::onUserLogoutComplete"
],
Disable the recent changes table-based layout on Minerva See Ib68ff8fa782ac12479ef02247cdf78e405b64bad Bug: T228280 Change-Id: I4169bcb93eb6680c0e9251873afb5637014c0e1b
2019-07-17 21:01:29 +00:00
"FetchChangesList": [
"MinervaHooks::onFetchChangesList"
],
Enable Simplified Talk Page only on Pages With Expandable Sections This patch should knock out two bugs we were seeing with the simplified talk page: 1) Removes the "Add discussion" button and "There are no discussions" message from appearing on Flow enabled talk pages. 2) Removes the "Read as wiki page" and "Active Discussions"/"There are no discussions" message we were seeing on Minerva desktop talk pages. To address when the "There are no dicussions"/"Active Discussions" message and "Read as wikipage" button are displayed, Minerva now listens to MobileFrontend's `MobileFrontendBeforeDOM` hook and turns on the simplified talk page (via a skin option) when this hook runs. To address when the "Add discussion" button is added, a check was added to SkinMinerva which only adds it to a talk page if the content model is wikipage. Unfortunately, we can't just check the skin option because we also want to display the button on desktop minerva. Other changes: * Moves around the logic in `getTalkPagePostHeadingHTML` for improved readability Bug: T237589 Bug: T237597 Change-Id: I83fd5cab174d90b24a5335f2b30c912c3b68040a
2019-11-13 01:48:59 +00:00
"MobileFrontendBeforeDOM": [
"MinervaHooks::onMobileFrontendBeforeDOM"
],
Minerva should use FeatureManagers class Bug: T182362 Depends-On: I6cc4a2ebcd75c054294daf329d94d35a02e50f8e Change-Id: I6ba5bf49b9060c31ad2224a437072b3426a45619
2018-01-08 22:18:16 +00:00
"MobileFrontendFeaturesRegistration": [
"MinervaHooks::onMobileFrontendFeaturesRegistration"
],
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"RequestContextCreateSkinMobile": [
"MinervaHooks::onRequestContextCreateSkinMobile"
],
"SpecialPageBeforeExecute": [
"MinervaHooks::onSpecialPageBeforeExecute"
Disable edit icon in read-only mode When a wiki is in read-only mode, the edit icon on articles should not open an editor. Instead, it should be in a "disabled" state and inform the user that the wiki is in read-only mode ( i.e. show the "apierror-readonly" message). Bug: T197497 Change-Id: Iee1414c20bea3ca936fb807820e58e5ed566d008
2018-08-13 14:29:05 +00:00
],
"ResourceLoaderGetConfigVars": [
"MinervaHooks::onResourceLoaderGetConfigVars"
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
]
Use tabs in skin.json Change-Id: I8fb66fe2f99786bfbdc598d460c18928dbb0faa0
2017-06-09 22:09:22 +00:00
},
"MessagesDirs": {
"MinervaNeue": [
"i18n"
]
},
"ResourceFileModulePaths": {
"localBasePath": "",
"remoteSkinPath": "MinervaNeue"
},
"ResourceModuleSkinStyles": {
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"minerva": {
Diff styles for moving paragraphs and empty lines * Fix styling of empty lines - cover full width * Disable the pseudo element shipped in core * Move styles from mobile.special.mobilediff.styles into mediawiki.diff.styles since the latter is always present, the former isn't if MobileFrontend is not available. Bug: T242310 Bug: T243235 Change-Id: Ic7d12fe890622e7b3ccc7bc56765f505ac0ab651
2020-01-20 21:47:19 +00:00
"mediawiki.diff.styles": [
"skinStyles/mediawiki.diff.styles.less"
],
Make MobileFrontend dependency a soft one This extends the work in Ie29a1eb7746d56f7d8c99b74e5e3c213c30fdcf2 Bug: T171000 Change-Id: Ib125e1bdaace1893804892909c27a9f328445835
2019-12-18 21:15:26 +00:00
"mediawiki.searchSuggest": [
"skinStyles/mediawiki.searchSuggest/index.less"
],
🐛 Bug: Fix iOS input text zoom bug on rcfilters input On iOS Safari, the screen zooms in when the user focused on the text input of the rcfilters overlay. This commit adds a quickfix to address this problem by setting the font-size to its initial value (assumed to be 16px). Bug: T231049 Change-Id: I98d28115e570a11d08ba2bd189c0b9151f834e7d
2019-09-02 15:58:33 +00:00
"mediawiki.rcfilters.filters.ui": [
"skinStyles/mediawiki.rcfilters.filters.ui.less"
],
Reset history page styles for Minerva This provides us with a blank canvas for styling Minerva's history page in AMC mode. I have also provided styles for a non-AMC mode (test by changing the class on body tag to minerva--amc-disabled). This will allow us to remove the SpecialMobileHistory page in mobile if we choose to do so. Change-Id: Ic57cb79903e90ce1bbfa6d87ab0499f09373e732
2019-03-29 21:43:19 +00:00
"mediawiki.action.history.styles": [
"skinStyles/mediawiki.action.history.styles.less"
],
Add Minerva specific mediawiki.interface.helpers.styles.less file This SkinStyle file adds paranthases around the (diff|hist) links and username(talk|contrib|block) links on special pages. Bug: T222394 Change-Id: Ic291cb795ccad556a5049d970c0282b2d4c65a11
2019-05-07 13:17:04 +00:00
"mediawiki.interface.helpers.styles": [
"skinStyles/mediawiki.interface.helpers.styles.less"
],
Reset history page styles for Minerva This provides us with a blank canvas for styling Minerva's history page in AMC mode. I have also provided styles for a non-AMC mode (test by changing the class on body tag to minerva--amc-disabled). This will allow us to remove the SpecialMobileHistory page in mobile if we choose to do so. Change-Id: Ic57cb79903e90ce1bbfa6d87ab0499f09373e732
2019-03-29 21:43:19 +00:00
"mediawiki.rcfilters.highlightCircles.seenunseen.styles": [],
Separate ConfirmEdit styles from Login styles ConfirmEdit styles are migrated from mediawiki.special.userlogin.common.styles to ext.confirmEdit.fancyCaptcha.styles The text of the reload itself mirrors the progressive blue icon by being progressive itself A couple of tweaks to the form (padding) are made to preserve the form to its previous glorious status, other than that the file remains the same. Bug: T213775 Change-Id: I2322194481e4d6b7662c0f075768d5941afa98b8
2019-01-16 19:18:52 +00:00
"ext.confirmEdit.fancyCaptcha.styles": [
"skinStyles/ext.confirmEdit.fancyCaptcha.styles/minerva.less"
],
Optimise Special:MobileOptions for tablet display Bug: T180095 Change-Id: I0ef0ce914a360848f8f66b39c40588f3fa04647c
2017-12-01 18:52:02 +00:00
"mobile.special.mobileoptions.styles": [
"skinStyles/mobile.special.mobileoptions.styles/minerva.less"
],
Restrict gallery styles to only pages which need it The mediawiki.page.gallery.styles module is only loaded when needed, yet inside hacks.less we load gallery styles unconditionally. The hacks.less file is also only meant for css that overrides template styles, so it didn't belong there anyway. Change-Id: I4afc91ad7f67ae66544708d25541b3e8dd247873
2017-12-13 02:03:28 +00:00
"mediawiki.page.gallery.styles": [
"skinStyles/mediawiki.page.gallery.styles/tablet.less"
],
Remove special page resource module handling This is handled by MobileFrontend now, just as it should do. We rely on skinStyles where possible. Depends-On: I665f6fe60939475249786fdc951149c38473fda6 Bug: T173597 Change-Id: I0fe9efcf98bbd8e188d91a29d4cfda897d47808d
2017-08-18 18:45:41 +00:00
"mediawiki.special.userlogin.common.styles": [
"skinStyles/mediawiki.special.userlogin.common.styles/minerva.less"
],
"mediawiki.special.search.styles": [
"skinStyles/mediawiki.special.search.styles/minerva.less"
],
Move Parsoid output overrides to 'mediawiki.skinning.content.parsoid' skinStyles We need to load these only when VisualEditor is loaded. This is the best way to ensure that. They have been haphazardly placed in different files. The goal of this change is to move content styling for Minerva out of mobile.editor.ve/minerva.less, and thus to be able to move this file to mediawiki/extensions/MobileFrontend (T202978). But I spotted the other places while working on that. Moved as-is: * skins.minerva.content.styles/links.less * mobile.editor.ve/minerva.less No longer needed: * skins.minerva.content.styles/text.less Parsoid now uses <sup> tags for references rather than <span>, so the existing rules for <sup> tags are enough. See T45094, <https://www.mediawiki.org/wiki/Specs/HTML/1.6.0/Extensions/Cite>. Was never needed: * skins.minerva.content.styles/thumbnails.less The styles from the core module 'mediawiki.skinning.content.parsoid' are never loaded, so we don't need to override them. Bug: T202978 Change-Id: I45e1cb89b65a41a29d2b1a361a79199745ccec14
2018-09-17 20:56:57 +00:00
"mediawiki.skinning.content.parsoid": [
"skinStyles/mediawiki.skinning.content.parsoid/minerva.less"
],
Minerva should use mediawiki.hlist Override provided styles Bug: T42062 Depends-On: I9305af5d30c8c24b44f4a0c6a466581c45fa3028 Change-Id: I7adda8ef99e5eee3df5bd7dc4da5081c1225f815
2017-06-01 23:09:24 +00:00
"mediawiki.hlist": [
"skinStyles/mediawiki.hlist/minerva.less"
Icon pseudo elements need top: 0 for RTL languages Document why so it doesn't get removed next time. Bug: T232260 Change-Id: I09cac0403c913e5ff10dfede9355a08f226f395d
2019-09-09 20:42:56 +00:00
],
New mw-ui-icon spec for Minerva Redefines the mw-ui-icon module from MediaWiki-core for better mobile support. The new spec maintains the same interface and class names as core (mw-ui-icon, mw-ui-icon-element, mw-ui-icon-before etc,) but ensures that icon sizing is more consistent and provides larger and more flexible touch-areas to the `.mw-ui-icon-element` class, which in practice is used to make icon buttons. This introduces a temporary defect in which the hamburger and user menu icons are a little too close to the edges. This will be fixed in I5587855d0d9ecf2fac20ce16845e6749c26ab7c2 Bug: T229440 Change-Id: I929090848f3e04647a97f4979ec78682623fa070
2019-09-11 12:19:47 +00:00
"mediawiki.ui.icon": [
Icon pseudo elements need top: 0 for RTL languages Document why so it doesn't get removed next time. Bug: T232260 Change-Id: I09cac0403c913e5ff10dfede9355a08f226f395d
2019-09-09 20:42:56 +00:00
"skinStyles/mediawiki.ui.icon/mediawiki.ui.icon.less"
Minerva should use mediawiki.hlist Override provided styles Bug: T42062 Depends-On: I9305af5d30c8c24b44f4a0c6a466581c45fa3028 Change-Id: I7adda8ef99e5eee3df5bd7dc4da5081c1225f815
2017-06-01 23:09:24 +00:00
],
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"mobile.languages.structured": [
Refactor LanguageOverlay styles In I629245100f4ca430a88e450939b90d075e7021f1, languageOverlay styles and LanguageSearcher styles were split into two different files. This commit mimics that change in skinStyles. All languageOverlay specific styles were moved to languageOverlay.less, while all LanguageSearcher styles were moved to LanguageSearcher.less. Other chagnes: * Changed a reference in init.js Bug: T215657 Change-Id: I395a61cd6051ad5c6b6601205f112b55f5ab8273
2019-02-22 17:59:56 +00:00
"skinStyles/mobile.languages.structured/LanguageSearcher.less"
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
],
"mobile.startup": [
Import all skinStyles/mobile.startup into mobile.startup.less This mimics the structure we follow in MobileFrontend's mobile.startup folder where we have a mobile.startup.js that imports all the mobile.startup files. Bug: T215657 Change-Id: Id7faa45adce7c5aa870d0f7c92f70d39995adac0
2019-02-22 18:15:34 +00:00
"skinStyles/mobile.startup/mobile.startup.less"
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
],
Remove special page resource module handling This is handled by MobileFrontend now, just as it should do. We rely on skinStyles where possible. Depends-On: I665f6fe60939475249786fdc951149c38473fda6 Bug: T173597 Change-Id: I0fe9efcf98bbd8e188d91a29d4cfda897d47808d
2017-08-18 18:45:41 +00:00
"mediawiki.special": [
"skinStyles/mobile.special.styles/minerva.less"
],
"mobile.special.styles": [
"skinStyles/mobile.special.styles/minerva.less"
],
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"ext.echo.styles.special": [
"skinStyles/ext.echo.styles.special/SpecialNotificationsOverlay.less"
],
Set editfont size to 16px (100%) Change-Id: I9bff880de792da756f14726042df0a0df4139d1b
2018-04-02 20:06:27 +00:00
"mediawiki.editfont.styles": [
"skinStyles/mediawiki.editfont.styles/minerva.css"
],
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"mediawiki.notification": [
Dev: Prep for storybook * Remove ambiguity in imports - say the file extension 'less' for all instances of variables and mixins. * Separate toast styles from drawer styles so they can be imported separately * associate header-action selector with its parent (.overlay-header) not parent's parent (.overlay) so it can be imported and rendered without the Overlay. Change-Id: Ib7e19a440ba095d6424d35305fb41d643ca9764c
2019-08-08 20:01:03 +00:00
"skinStyles/mobile.startup/drawers.less",
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"skinStyles/mobile.startup/toast.less"
],
"mediawiki.action.edit.styles": [
"skinStyles/mediawiki.action.edit.styles/minerva.less"
],
"mobile.special.mobilemenu.styles": [
"skinStyles/mobile.special.mobilemenu.styles/minerva.less"
Move remaining Minerva skinStyles from MobileFrontend To be removed in MobileFrontend by If3edac9a35b346a. Bug: T140807 Change-Id: Ifb073d1e67602b80e0e9b45f338806f5b9cb675b
2018-05-20 11:25:56 +00:00
],
Echo is removed from Minerva Managing the transition from old implementation to new: * A version number is exported from skins.minerva.scripts to tell dormant code added to Echo in I09c27a084100b223662f84de6cbe01bebe1fe774 to begin running. * A skinStyle is added for the new `ext.echo.mobile` module. `mobile.notifications.overlay` will soon cease to exist but is kept registered for backwards compatibility reasons - Drop ev.preventDefault call from onSkinClick - it is no longer necessary and will ensure notifications overlay closes when shield is clicked while it is open. Integration: * A server side hook SkinMinervaReplaceNotificationsBadge allows Echo to replace the current Minerva notification badge * A to-be-created client side hook is subscribed to to deal with the navigations drawer like functionality using the mainMenu code * id and class names are added to the container for the NotificationBadge for compatibility with ext.echo.init in Minerva's desktop mode (it will work like Vector) See I09c27a084100b223662f84de6cbe01bebe1fe774 for understanding the bigger picture. Depends-On: I09c27a084100b223662f84de6cbe01bebe1fe774 Bug: T221007 Change-Id: I4c11f1b241d629e1b294ebaec17472fbf944f8c7
2019-10-01 21:40:49 +00:00
"ext.echo.mobile": [
"skinStyles/ext.echo.mobile/minerva.less"
],
Move remaining Minerva skinStyles from MobileFrontend To be removed in MobileFrontend by If3edac9a35b346a. Bug: T140807 Change-Id: Ifb073d1e67602b80e0e9b45f338806f5b9cb675b
2018-05-20 11:25:56 +00:00
"mobile.notifications.overlay": [
Echo is removed from Minerva Managing the transition from old implementation to new: * A version number is exported from skins.minerva.scripts to tell dormant code added to Echo in I09c27a084100b223662f84de6cbe01bebe1fe774 to begin running. * A skinStyle is added for the new `ext.echo.mobile` module. `mobile.notifications.overlay` will soon cease to exist but is kept registered for backwards compatibility reasons - Drop ev.preventDefault call from onSkinClick - it is no longer necessary and will ensure notifications overlay closes when shield is clicked while it is open. Integration: * A server side hook SkinMinervaReplaceNotificationsBadge allows Echo to replace the current Minerva notification badge * A to-be-created client side hook is subscribed to to deal with the navigations drawer like functionality using the mainMenu code * id and class names are added to the container for the NotificationBadge for compatibility with ext.echo.init in Minerva's desktop mode (it will work like Vector) See I09c27a084100b223662f84de6cbe01bebe1fe774 for understanding the bigger picture. Depends-On: I09c27a084100b223662f84de6cbe01bebe1fe774 Bug: T221007 Change-Id: I4c11f1b241d629e1b294ebaec17472fbf944f8c7
2019-10-01 21:40:49 +00:00
"skinStyles/ext.echo.mobile/minerva.less"
JSON content: Fix table margins Change-Id: I50a2203adb66e634f9d995225075dc29a34ab4dd
2019-05-03 15:27:33 +00:00
],
"mediawiki.content.json": [
"skinStyles/mediawiki.content-json/minerva.less"
Adding skin styles for the changeslist module. The changeslist module is the list of results on special pages such as recent changes, watchlist, and parts of action history. Adds a skin style to special.changeslist module. Bug: T228419 Change-Id: I324b1f136f5314cb6acdba3155b07136bbde363a
2019-07-29 09:50:05 +00:00
],
"mediawiki.special.changeslist": [
"skinStyles/mediawiki.special.changeslist.less"
],
"mediawiki.special.changeslist.legend": [
"skinStyles/mediawiki.special.changeslist.legend.less"
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
]
}
},
Upgrade skin.json schema to manifest_version 2 Bug: T242505 Change-Id: Iccc217fe695270c5a04811fdca5bd65c26ae6609
2020-01-11 04:31:33 +00:00
"attributes": {
"EventLogging": {
"Schemas": {
"WebClientError": 18340282
}
}
Page Issues AB test event-logging instrumentation Uses `mw.trackSubscribe` to create an intermediary data handler named `wikimedia.PageIssuesAB` which extends event-logging data before passing it to the eventLogging through `wikimedia.event.PageIssues`. Event hooks are placed where appropriate and the `CleanupOverlay` class is extended to capture events from within the page issues modal. Additional changes: * Merge two identical on click event handlers for .edit-page, .edit-link elements * change pageIssueParser.maxSeverity to accept an array of severity levels instead of an array of pageIssues objects Depends-On: Ic84e4a3286220407863167e0f57cef1b13a72964 Bug: T191532 Change-Id: I67fb6e448f6ecc97c89c1187e491ee05f7a312ef
2018-07-11 15:16:21 +00:00
},
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"ResourceModules": {
"skins.minerva.base.styles": {
Ordered lists per default receive correct numerals (finally) This makes use of the ResourceLoader change in I1c1e2b912a41d29565e45e9e536c68ac46deb0e1 Bug: T217616 Change-Id: I30632a8c12abf634fc8031ac588c36a412c7abbd
2020-01-14 19:11:06 +00:00
"class": "ResourceLoaderSkinModule",
"features": [ "i18n-ordered-lists" ],
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"targets": [
"mobile",
"desktop"
],
"styles": [
Reorganise stylesheets All stylesheet-only ResourceLoader modules now have a single entry point rather than multiple files. This eases compilation of the content of those modules by all toolchains, which will be useful when introducing the bundlesize tool. Change-Id: Ic38a3e51db2f419fe68efd23a2c48ee69218a526
2020-01-20 21:19:12 +00:00
"resources/skins.minerva.base.styles/index.less"
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
]
},
"skins.minerva.content.styles": {
Convert custom LESS var from global to local Avoid the 'ResourceLoaderGetLessVars' hook, which registers a global LESS variable exposed to all modules (inc. core/extensions). Instead, use a FileModule subclass to provide the variable only to the modules that need it. Using this approach, also has the benefit of being tracked by the version hasher, so that changes to the configuration actually result in timely invalidation of module caches. Bug: T171367 Change-Id: I7c7d13c83004edfc852a9b7dbfc4169617ab9f64
2018-04-02 23:16:39 +00:00
"class": "MediaWiki\\Minerva\\ResourceLoaderLessVarFileModule",
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"targets": [
"mobile",
"desktop"
],
"styles": [
Reorganise stylesheets All stylesheet-only ResourceLoader modules now have a single entry point rather than multiple files. This eases compilation of the content of those modules by all toolchains, which will be useful when introducing the bundlesize tool. Change-Id: Ic38a3e51db2f419fe68efd23a2c48ee69218a526
2020-01-20 21:19:12 +00:00
"resources/skins.minerva.content.styles/index.less"
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
]
},
Update: add internal and revise external link icons Bug: T190549 Change-Id: Iad7fdc2f2a730fa8874487c0d83355f21a0bf7ea
2018-06-14 16:51:50 +00:00
"skins.minerva.content.styles.images": {
"class": "ResourceLoaderImageModule",
Adds a light-blue variant to the external link icon The light-blue variant is used in reference drawers on a dark background. Bug: T216961 Change-Id: Ic8fdf8f4a08ea7c8d7ae57ae8ce02a7d9a1e1dad
2019-04-25 14:06:08 +00:00
"selectorWithoutVariant": "{name}",
"selectorWithVariant": "{name}--{variant}",
External link icons should use defaultColor Depends-On: I0745e112d11026ed59d8daca990b313305cd094a Bug: T197909 Change-Id: Ic00b77e789b487d626f497d99197649c04bd6427
2018-06-26 23:25:31 +00:00
"defaultColor": "#36c",
Reduce render blocking styles by deferring loading of icons Change-Id: I8fb3b03833a49ade1d62fe4ded1a0c723cbe8f28 Depends-On: Iee77655d4868a7d921be8cc23776a7859d9acf0c Bug: T198930
2018-07-05 23:52:21 +00:00
"useDataURI": false,
Adds a light-blue variant to the external link icon The light-blue variant is used in reference drawers on a dark background. Bug: T216961 Change-Id: Ic8fdf8f4a08ea7c8d7ae57ae8ce02a7d9a1e1dad
2019-04-25 14:06:08 +00:00
"variants": {
"reference": {
"color": "#69f",
"global": true
}
},
Update: add internal and revise external link icons Bug: T190549 Change-Id: Iad7fdc2f2a730fa8874487c0d83355f21a0bf7ea
2018-06-14 16:51:50 +00:00
"images": {
Dev: Address some FIXMEs * Drop non-existent pointer-overlay selector * Drop redundant icon class for arrow * Drop unnecessary !important * Drop transparent-shield class * Reword an existing FIXME about a contensious decision and add a new FIXME for moving some code to a more appropriate place. * Move an image into a ResourceLoaderImage module (test with `mw.notify('error', { type: 'error'} )`) Change-Id: I6e38f07772afae6f13c4851ca17a67d52ca7d331
2020-02-03 08:15:44 +00:00
"toast.mw-notification-type-error,.mw-notification.mw-notification-type-error":
"resources/skins.minerva.content.styles.images/error.svg",
Don't ship 2 magnifying glass icons We already make use of the images 'name' key inside skins.minerva.content.styles.images to define the full CSS selector. We can use this approach to ship a single version of the magnifying glass icon, rather than having 2 defined in both skins.minerva.base.styles and skins.minerva.icons.images Change-Id: Ie5ec06152c418c4aa1b620b3d0a904cc9517e5d0
2018-07-05 23:34:31 +00:00
"input.search,.mw-ui-icon-minerva-magnifying-glass:before": "resources/skins.minerva.content.styles.images/magnifying-glass.svg",
"a.external": {
Update: add internal and revise external link icons Bug: T190549 Change-Id: Iad7fdc2f2a730fa8874487c0d83355f21a0bf7ea
2018-06-14 16:51:50 +00:00
"file": {
"ltr": "resources/skins.minerva.content.styles.images/link-external-ltr.svg",
"rtl": "resources/skins.minerva.content.styles.images/link-external-rtl.svg"
}
}
}
},
Only load notification icon (bell) CSS for logged in users * The notification-count style is only needed if you are logged in. Given a small percentage of our users are logged in, we load a lot of render blocking css unnecessarily. * The bell icon is not needed for anonymous users so pull that out from skins.minerva.icons.images which is loaded for all users into a module only used by logged in users (skins.minerva.icons.loggedin) * Simplify the user-button rule - it is overly specific - probably for historic reasons. Additional changes: * Simplify isAuthenticated helper Change-Id: Ia72e7e45d276e8aac1ff5471bf6158705c7b5f99
2017-12-13 01:25:10 +00:00
"skins.minerva.icons.loggedin": {
Refresh the user, bell and search icon * New module skins.minerva.icons.wikimedia provides icons from Wikimedia UI in Minerva * search selector in skins.minerva.content.styles.images is retained for cached HTML * skins.minerva.icons.loggedin now a ResourceLoaderOOUIIconPackModule and bell removed from repo. * userAvatar replaced with userAvatarOutline Bug: T224070 Change-Id: Ibed609371060acc4b69e5cd4cd4f20edc871b3ba
2019-07-09 19:12:51 +00:00
"class": "ResourceLoaderOOUIIconPackModule",
"targets": [
"mobile",
"desktop"
],
Reduce render blocking styles by deferring loading of icons Change-Id: I8fb3b03833a49ade1d62fe4ded1a0c723cbe8f28 Depends-On: Iee77655d4868a7d921be8cc23776a7859d9acf0c Bug: T198930
2018-07-05 23:52:21 +00:00
"useDataURI": false,
Refresh the user, bell and search icon * New module skins.minerva.icons.wikimedia provides icons from Wikimedia UI in Minerva * search selector in skins.minerva.content.styles.images is retained for cached HTML * skins.minerva.icons.loggedin now a ResourceLoaderOOUIIconPackModule and bell removed from repo. * userAvatar replaced with userAvatarOutline Bug: T224070 Change-Id: Ibed609371060acc4b69e5cd4cd4f20edc871b3ba
2019-07-09 19:12:51 +00:00
"defaultColor": "#54595d",
"variants": [],
"selectorWithoutVariant": ".mw-ui-icon-wikimedia-{name}-base20:before",
Split line with many values in skin.json Makes it easier to read when there one value on each line Change-Id: Ib6e8231f718cb6bf17935e45dff696db850569b9
2019-10-25 16:30:37 +00:00
"icons": [
"bellOutline"
]
Only load notification icon (bell) CSS for logged in users * The notification-count style is only needed if you are logged in. Given a small percentage of our users are logged in, we load a lot of render blocking css unnecessarily. * The bell icon is not needed for anonymous users so pull that out from skins.minerva.icons.images which is loaded for all users into a module only used by logged in users (skins.minerva.icons.loggedin) * Simplify the user-button rule - it is overly specific - probably for historic reasons. Additional changes: * Simplify isAuthenticated helper Change-Id: Ia72e7e45d276e8aac1ff5471bf6158705c7b5f99
2017-12-13 01:25:10 +00:00
},
Talk tabs in AMC mode A new feature/skin option is added that is enabled safely inside a MobileFrontend available/unavailable hook that changes the skin to place talk tabs at the top of the page. These new talk tabs purposely show on the main page, user page and standard pages and do not show on special pages. Depends-On: Ie1a583657176acc6f7046c569c2e94fa2f72ff93 Bug: T212216 Change-Id: I57b70cd325666a287678dc897159b5bf9d089b78
2019-01-10 22:59:56 +00:00
"skins.minerva.amc.styles": {
"targets": [
"mobile",
"desktop"
],
"styles": [
Feature flag overhaul Two new feature flags: 1) MinervaPersonalMenu 2) MinervaAdvancedMainMenu Changes: * AMC defaults to false on desktop - desktop doesn't have AMC mode it just enables several skin options. * WHen inserting a link at the bottom of the page check whether the talk at top of the page (tabs) is enabled.. not AMC * Update ServiceWiring to construct menu based on MinervaAdvancedMainMenu and MinervaPersonalMenu - note when former is enabled but not latter there is no way to logout. Noted in README. * Use one entry point for skins.minerva.amc.styles/index.less * Document files inside skins.minerva.amc.styles to make it clear which features they are associated with * Drop history page styles when AMC is disabled - it's not possible to ever get to these as the history page redirects in non-AMC mode * Rename the class .minerva--amc-enabled to minerva--history-page-action-enabled to reflect its real purpose and move styles from skins.minerva.base.styles to skins.minerva.amc.styles No need to worry about cached HTML as AMC runs without cache... * Remove isAnyAMCOptionEnabled - it's an antipattern and should be discouraged as it discourages the art of feature flagging. Nothing is using it after these changes. * The AMC_MODE flag is disabled. There is no need for this - AMC is not a feature and therefore not a skin option. It is a mechanism for turning on other skin options. Tests are updated. Testing: It should now be possible to enable any feature in `beta` and see it in the beta of the site. Bug: T229295 Change-Id: I48959905f5c09721b14a27aa1a5ad82849ac6263
2019-08-22 20:31:31 +00:00
"resources/skins.minerva.amc.styles/index.less"
Talk tabs in AMC mode A new feature/skin option is added that is enabled safely inside a MobileFrontend available/unavailable hook that changes the skin to place talk tabs at the top of the page. These new talk tabs purposely show on the main page, user page and standard pages and do not show on special pages. Depends-On: Ie1a583657176acc6f7046c569c2e94fa2f72ff93 Bug: T212216 Change-Id: I57b70cd325666a287678dc897159b5bf9d089b78
2019-01-10 22:59:56 +00:00
]
},
Update: add secondary page actions submenu in AMC mode When advanced mobile contributions mode is enabled and `$wgMinervaOverflowInPageActions` is set, show a secondary overflow menu on main namespace articles and user namespace pages. The menu content varies for each namespace. The new submenu is *disabled* by default, even when AMC is active. This feature should not be deployed until instrumentation is available. The secondary menu is rendered in PHP using the existing menu system with some changes to the template. The checkbox hack is needed for no- JavaScript keyboard navigation until :focus-within is supported. CSS additions are documented in the source. All client side toolbar execution occurs in Toolbar.js. Enhancements are documented in the source. Minor changes to the existing download button: - Move download and edit button initialization to Toolbar. - Update copy (not visible) from "Download" to "Download PDF". - When the overflow menu is present, use the "hasText" / label style. Wikimedia UI icons are copied from OOUI at d00a0ac and seem useful to expose as HTTP URIs (not data URIs). The overflow menu does not show for pages provided by the content proxy since its entries depend on $tpl->data['nav_urls'] being populated. Bug: T216418 Depends-On: I0781151a8232b6a7b52f79a34298afcecb8e4271 Change-Id: I4b50a0e519024a7ab91dae6ab40b23cf14a03861
2019-04-04 21:20:39 +00:00
"wikimedia.ui": {
Use wikimedia.ui from core directly There's no reason to copy and paste all this here. These icons can be imported directly from core using ResourceLoaderOOUIIconPackModule Depends-On: I7800da87a6a10399f705b43e05c8592c766bae6f Change-Id: I1f25aaca9b7313cd95cefc7f5629b8a7e65c887f
2019-07-12 15:38:41 +00:00
"selectorWithoutVariant": ".wikimedia-ui-{name}-base20:before",
Update: add secondary page actions submenu in AMC mode When advanced mobile contributions mode is enabled and `$wgMinervaOverflowInPageActions` is set, show a secondary overflow menu on main namespace articles and user namespace pages. The menu content varies for each namespace. The new submenu is *disabled* by default, even when AMC is active. This feature should not be deployed until instrumentation is available. The secondary menu is rendered in PHP using the existing menu system with some changes to the template. The checkbox hack is needed for no- JavaScript keyboard navigation until :focus-within is supported. CSS additions are documented in the source. All client side toolbar execution occurs in Toolbar.js. Enhancements are documented in the source. Minor changes to the existing download button: - Move download and edit button initialization to Toolbar. - Update copy (not visible) from "Download" to "Download PDF". - When the overflow menu is present, use the "hasText" / label style. Wikimedia UI icons are copied from OOUI at d00a0ac and seem useful to expose as HTTP URIs (not data URIs). The overflow menu does not show for pages provided by the content proxy since its entries depend on $tpl->data['nav_urls'] being populated. Bug: T216418 Depends-On: I0781151a8232b6a7b52f79a34298afcecb8e4271 Change-Id: I4b50a0e519024a7ab91dae6ab40b23cf14a03861
2019-04-04 21:20:39 +00:00
"useDataURI": false,
Use wikimedia.ui from core directly There's no reason to copy and paste all this here. These icons can be imported directly from core using ResourceLoaderOOUIIconPackModule Depends-On: I7800da87a6a10399f705b43e05c8592c766bae6f Change-Id: I1f25aaca9b7313cd95cefc7f5629b8a7e65c887f
2019-07-12 15:38:41 +00:00
"defaultColor": "#54595d",
"class": "ResourceLoaderOOUIIconPackModule",
Split line with many values in skin.json Makes it easier to read when there one value on each line Change-Id: Ib6e8231f718cb6bf17935e45dff696db850569b9
2019-10-25 16:30:37 +00:00
"icons": [
"articleRedirect",
"infoFilled",
"link",
"listBullet",
Rename UserRights to UserGroups The "User Rights" is called "User groups" on desktop. The Mobile site should not provide it's onw naming but use the same names as desktop. Bug: T230694 Depends-On: Ic9b7033e3f52f415ec8aec845a65a8452d0e5d8f Change-Id: Iaf116a5cc54cc400451550d9fa958adbbccc35c5
2019-09-05 10:10:58 +00:00
"logoWikidata",
"logoWikimedia",
"quotes",
"upload",
"userAvatarOutline",
"userTalk",
"userAvatar",
"userGroup"
]
Refresh the user, bell and search icon * New module skins.minerva.icons.wikimedia provides icons from Wikimedia UI in Minerva * search selector in skins.minerva.content.styles.images is retained for cached HTML * skins.minerva.icons.loggedin now a ResourceLoaderOOUIIconPackModule and bell removed from repo. * userAvatar replaced with userAvatarOutline Bug: T224070 Change-Id: Ibed609371060acc4b69e5cd4cd4f20edc871b3ba
2019-07-09 19:12:51 +00:00
},
"skins.minerva.icons.wikimedia": {
Remove watch and watched icons from repository in favor of Wikimedia UI Note, because of the two versions of the watch icon, this will temporarily make the watchstar not display for JavaScript users. The accompanying patch Ic974b4d6dff14b0d72b8ca71b02c5ef73b1b1d93 will restore this. Bug: T231613 Change-Id: I16ca70f2892d7418ff245e15f838dfc2b092f3aa
2019-09-17 21:30:33 +00:00
"selectorWithVariant": ".mw-ui-icon-wikimedia-{name}-{variant}:before",
Refresh the user, bell and search icon * New module skins.minerva.icons.wikimedia provides icons from Wikimedia UI in Minerva * search selector in skins.minerva.content.styles.images is retained for cached HTML * skins.minerva.icons.loggedin now a ResourceLoaderOOUIIconPackModule and bell removed from repo. * userAvatar replaced with userAvatarOutline Bug: T224070 Change-Id: Ibed609371060acc4b69e5cd4cd4f20edc871b3ba
2019-07-09 19:12:51 +00:00
"selectorWithoutVariant": ".mw-ui-icon-wikimedia-{name}-base20:before, .mw-ui-background-icon-{name}",
"useDataURI": false,
"defaultColor": "#54595d",
"class": "ResourceLoaderOOUIIconPackModule",
Split line with many values in skin.json Makes it easier to read when there one value on each line Change-Id: Ib6e8231f718cb6bf17935e45dff696db850569b9
2019-10-25 16:30:37 +00:00
"icons": [
"search",
"userAvatar",
"star",
"unStar"
]
Update: add secondary page actions submenu in AMC mode When advanced mobile contributions mode is enabled and `$wgMinervaOverflowInPageActions` is set, show a secondary overflow menu on main namespace articles and user namespace pages. The menu content varies for each namespace. The new submenu is *disabled* by default, even when AMC is active. This feature should not be deployed until instrumentation is available. The secondary menu is rendered in PHP using the existing menu system with some changes to the template. The checkbox hack is needed for no- JavaScript keyboard navigation until :focus-within is supported. CSS additions are documented in the source. All client side toolbar execution occurs in Toolbar.js. Enhancements are documented in the source. Minor changes to the existing download button: - Move download and edit button initialization to Toolbar. - Update copy (not visible) from "Download" to "Download PDF". - When the overflow menu is present, use the "hasText" / label style. Wikimedia UI icons are copied from OOUI at d00a0ac and seem useful to expose as HTTP URIs (not data URIs). The overflow menu does not show for pages provided by the content proxy since its entries depend on $tpl->data['nav_urls'] being populated. Bug: T216418 Depends-On: I0781151a8232b6a7b52f79a34298afcecb8e4271 Change-Id: I4b50a0e519024a7ab91dae6ab40b23cf14a03861
2019-04-04 21:20:39 +00:00
},
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"skins.minerva.icons.images": {
"class": "ResourceLoaderImageModule",
Remove skins.minerva.icons.images.variants module This module produces 6 icons: ["clock", "profile"] * ["black", "gray", "white"] of which only 3 are needed: clock-gray, clock-white, profile-gray. This patch removes the module and moves the "clock" and "profile" icons into `skins.minerva.icons.images`. Since that module does not inline SVG's, the additional cost of adding these icons, which are loaded at startup, is minimal. The editLocked.svg icon has also been edited to correct its color. Bug: T218807 Change-Id: Ib54960eb556dfe0c1ae06d2f73d4f350e519e20f
2019-03-21 14:50:23 +00:00
"selectorWithoutVariant": ".mw-ui-icon-minerva-{name}:before",
"selectorWithVariant": ".mw-ui-icon-minerva-{name}-{variant}:before",
Reduce render blocking styles by deferring loading of icons Change-Id: I8fb3b03833a49ade1d62fe4ded1a0c723cbe8f28 Depends-On: Iee77655d4868a7d921be8cc23776a7859d9acf0c Bug: T198930
2018-07-05 23:52:21 +00:00
"useDataURI": false,
Remove skins.minerva.icons.images.variants module This module produces 6 icons: ["clock", "profile"] * ["black", "gray", "white"] of which only 3 are needed: clock-gray, clock-white, profile-gray. This patch removes the module and moves the "clock" and "profile" icons into `skins.minerva.icons.images`. Since that module does not inline SVG's, the additional cost of adding these icons, which are loaded at startup, is minimal. The editLocked.svg icon has also been edited to correct its color. Bug: T218807 Change-Id: Ib54960eb556dfe0c1ae06d2f73d4f350e519e20f
2019-03-21 14:50:23 +00:00
"defaultColor": "#54595d",
"variants": {
"invert": {
"color": "#fff",
"global": false
On user pages, move language icon from Toolbar to Overflow menu The Language icon is not useful on user pages as most probably there are no translated user pages, thus there is no need to show all-time disabled Language icon. If overflow menu is available, don't show Language switcher icon in toolbar, show it as first item in the overflow menu. Bug: T224735 Follow-Up: I46d58758356e870c408a74b2c087a42d6ad0ddea Change-Id: I05be9e6457257a1f2eb224ca9ec5808814bc9ed7
2019-06-24 17:59:11 +00:00
},
"base20": {
"color": "#54595d",
"global": false
Remove skins.minerva.icons.images.variants module This module produces 6 icons: ["clock", "profile"] * ["black", "gray", "white"] of which only 3 are needed: clock-gray, clock-white, profile-gray. This patch removes the module and moves the "clock" and "profile" icons into `skins.minerva.icons.images`. Since that module does not inline SVG's, the additional cost of adding these icons, which are loaded at startup, is minimal. The editLocked.svg icon has also been edited to correct its color. Bug: T218807 Change-Id: Ib54960eb556dfe0c1ae06d2f73d4f350e519e20f
2019-03-21 14:50:23 +00:00
}
},
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"images": {
New table of contents icon, prepare for arrow->expand rename Bug: T231613 Change-Id: I86a4bdac83e1d6caef025ad025962127d74556dd
2019-09-06 19:13:20 +00:00
"toc": {
"file": {
"ltr": "resources/skins.minerva.icons.images/toc-ltr.svg",
"rtl": "resources/skins.minerva.icons.images/toc-rtl.svg"
}
},
Mobile page issues - visual styling changes Changes: * Introduce Jan's beautifully documented $wgMinervaABSamplingRate Set to 1 to A/B test 50% of the population * Split out ambox template styles into a separate file referenced by hacks.less * Update cleanuptemplates setup script to consider two buckets Test pages: * Shqiponja_Partizane * World_War_II_in_Albania * Liberation_of_Tirana * French_Consulate * Abd_ar-Rahman_IV * M109_howitzer * Aimoin * Transport_in_Brazil * Transport_in_Cape_Verde Bug: T191303 Change-Id: I8d11e655ccb847b7999e64dda57b225ad8b1c23a
2018-05-08 22:03:52 +00:00
"warning": "resources/skins.minerva.icons.images/warning.svg",
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"mainmenu": "resources/skins.minerva.icons.images/hamburger.svg",
"edit": "resources/skins.minerva.icons.images/editLocked.svg",
"edit-enabled": "resources/skins.minerva.icons.images/edit.svg",
On user pages, move language icon from Toolbar to Overflow menu The Language icon is not useful on user pages as most probably there are no translated user pages, thus there is no need to show all-time disabled Language icon. If overflow menu is available, don't show Language switcher icon in toolbar, show it as first item in the overflow menu. Bug: T224735 Follow-Up: I46d58758356e870c408a74b2c087a42d6ad0ddea Change-Id: I05be9e6457257a1f2eb224ca9ec5808814bc9ed7
2019-06-24 17:59:11 +00:00
"language-switcher": {
"file": "resources/skins.minerva.icons.images/languageSwitcher.svg",
Split line with many values in skin.json Makes it easier to read when there one value on each line Change-Id: Ib6e8231f718cb6bf17935e45dff696db850569b9
2019-10-25 16:30:37 +00:00
"variants": [
"base20"
]
On user pages, move language icon from Toolbar to Overflow menu The Language icon is not useful on user pages as most probably there are no translated user pages, thus there is no need to show all-time disabled Language icon. If overflow menu is available, don't show Language switcher icon in toolbar, show it as first item in the overflow menu. Bug: T224735 Follow-Up: I46d58758356e870c408a74b2c087a42d6ad0ddea Change-Id: I05be9e6457257a1f2eb224ca9ec5808814bc9ed7
2019-06-24 17:59:11 +00:00
},
Remove skins.minerva.icons.images.variants module This module produces 6 icons: ["clock", "profile"] * ["black", "gray", "white"] of which only 3 are needed: clock-gray, clock-white, profile-gray. This patch removes the module and moves the "clock" and "profile" icons into `skins.minerva.icons.images`. Since that module does not inline SVG's, the additional cost of adding these icons, which are loaded at startup, is minimal. The editLocked.svg icon has also been edited to correct its color. Bug: T218807 Change-Id: Ib54960eb556dfe0c1ae06d2f73d4f350e519e20f
2019-03-21 14:50:23 +00:00
"clock": {
"file": "resources/skins.minerva.icons.images/clock.svg",
Split line with many values in skin.json Makes it easier to read when there one value on each line Change-Id: Ib6e8231f718cb6bf17935e45dff696db850569b9
2019-10-25 16:30:37 +00:00
"variants": [
"invert"
]
Update: add secondary page actions submenu in AMC mode When advanced mobile contributions mode is enabled and `$wgMinervaOverflowInPageActions` is set, show a secondary overflow menu on main namespace articles and user namespace pages. The menu content varies for each namespace. The new submenu is *disabled* by default, even when AMC is active. This feature should not be deployed until instrumentation is available. The secondary menu is rendered in PHP using the existing menu system with some changes to the template. The checkbox hack is needed for no- JavaScript keyboard navigation until :focus-within is supported. CSS additions are documented in the source. All client side toolbar execution occurs in Toolbar.js. Enhancements are documented in the source. Minor changes to the existing download button: - Move download and edit button initialization to Toolbar. - Update copy (not visible) from "Download" to "Download PDF". - When the overflow menu is present, use the "hasText" / label style. Wikimedia UI icons are copied from OOUI at d00a0ac and seem useful to expose as HTTP URIs (not data URIs). The overflow menu does not show for pages provided by the content proxy since its entries depend on $tpl->data['nav_urls'] being populated. Bug: T216418 Depends-On: I0781151a8232b6a7b52f79a34298afcecb8e4271 Change-Id: I4b50a0e519024a7ab91dae6ab40b23cf14a03861
2019-04-04 21:20:39 +00:00
},
"page-actions-overflow": "resources/skins.minerva.icons.images/page-actions-overflow.svg"
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
}
},
"skins.minerva.icons.images.scripts": {
Update: page issue icons - Fix a bug where the all issues endpoint would incorrectly collect issues from all sections. - Update the page issue iconography. This increases the size of the delivered code and images by 1743 B minified uncompressed according to mw.inspect() (from 16.4 KiB to 18.1 KiB). - Add support for identifying page issue severity based on template CSS classes. - For multiple issues templates, show the highest priority icon. Bug: T191528 Change-Id: Ie0a4c83ec7cfb856ec581d058797109746e3cb99
2018-07-10 20:06:51 +00:00
"targets": [
"mobile",
"desktop"
],
"dependencies": [
"skins.minerva.icons.images.scripts.misc",
"skins.minerva.icons.page.issues.uncolored",
"skins.minerva.icons.page.issues.default.color",
"skins.minerva.icons.page.issues.medium.color"
]
},
"skins.minerva.icons.images.scripts.misc": {
"class": "ResourceLoaderImageModule",
"selector": ".mw-ui-icon-minerva-{name}:before",
"images": {
Remove fancy block info popups (move to MobileFrontend) We only used them for registered users, but MobileFrontend's EditorOverlay code can use them for anonymous users as well. Remove code for looking up block details in wgMinervaUserBlockInfo, now we only care whether the user is blocked at all to display a different icon. MobileFrontend looks up the same information via API already. Remove unused message 'mobile-frontend-editor-blocked-info-loggedin', it was only used by non-fancy popups, which were removed in favor of the new ones in f51cf7db7b01b3fa14abb397e6b48ce32c15a40f. Bug: T193754 Bug: T198765 Depends-On: I80564c3e6e2d0f4d7eae754f206780fb4054f254 Change-Id: I64be24845b4fee76d6b4a8e481a218f2160fced6
2018-07-10 02:45:15 +00:00
"download": "resources/skins.minerva.icons.images.scripts.misc/download.svg"
Update: page issue icons - Fix a bug where the all issues endpoint would incorrectly collect issues from all sections. - Update the page issue iconography. This increases the size of the delivered code and images by 1743 B minified uncompressed according to mw.inspect() (from 16.4 KiB to 18.1 KiB). - Add support for identifying page issue severity based on template CSS classes. - For multiple issues templates, show the highest priority icon. Bug: T191528 Change-Id: Ie0a4c83ec7cfb856ec581d058797109746e3cb99
2018-07-10 20:06:51 +00:00
}
},
"skins.minerva.icons.page.issues.uncolored": {
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"class": "ResourceLoaderImageModule",
Prefix icons in Minerva Changes: * MinervaUI will now prefix any icons with `minerva` * Update definitions in skin.json, retaining selectors for cached HTML for icons that are rendered via PHP. * In I9021c53c2c04bdd7ce395eed33d89986acbfea6d watch and watched and arrow are moved to MobileFrontend so are removed from the RL module skins.minerva.icons.images.scripts as they are not used directly in this repo. user and anonymous are no longer used so also removed. * Presentation of userpage now belongs to MobileFrontend. Icons are styles were moved there in depends on. They are retained in skin.json to support cached HTML as user pages are subject to cache. They can be removed in a week. * In code review we noticed the anonymous icon was badly named. We rename to login. No caching implications. * Main menu icons are now prefixed with minerva rather than mf to reflect where they come from. Depends-On: I9021c53c2c04bdd7ce395eed33d89986acbfea6d Bug: T182162 Change-Id: I93264024f4915fc910c792b1905b89cdc6b8b546
2018-01-05 18:52:17 +00:00
"selector": ".mw-ui-icon-minerva-{name}:before",
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"images": {
Update: page issue icons - Fix a bug where the all issues endpoint would incorrectly collect issues from all sections. - Update the page issue iconography. This increases the size of the delivered code and images by 1743 B minified uncompressed according to mw.inspect() (from 16.4 KiB to 18.1 KiB). - Add support for identifying page issue severity based on template CSS classes. - For multiple issues templates, show the highest priority icon. Bug: T191528 Change-Id: Ie0a4c83ec7cfb856ec581d058797109746e3cb99
2018-07-10 20:06:51 +00:00
"issue-severity-low-lowColor": "resources/skins.minerva.icons.page.issues.uncolored/issue-severity-low.svg",
"issue-type-move-defaultColor": "resources/skins.minerva.icons.page.issues.uncolored/issue-type-move.svg"
}
},
"skins.minerva.icons.page.issues.default.color": {
"class": "ResourceLoaderImageModule",
"selectorWithoutVariant": ".mw-ui-icon-minerva-{name}-defaultColor:before",
"selectorWithVariant": ".mw-ui-icon-minerva-{name}-{variant}:before",
"defaultColor": "#54595d",
"variants": {
Upgrade skin.json schema to manifest_version 2 Bug: T242505 Change-Id: Iccc217fe695270c5a04811fdca5bd65c26ae6609
2020-01-11 04:31:33 +00:00
"lowColor": {
"color": "#fc3",
"global": true
},
"mediumColor": {
"color": "#ff5d01",
"global": true
},
"highColor": {
"color": "#d33",
"global": true
}
Update: page issue icons - Fix a bug where the all issues endpoint would incorrectly collect issues from all sections. - Update the page issue iconography. This increases the size of the delivered code and images by 1743 B minified uncompressed according to mw.inspect() (from 16.4 KiB to 18.1 KiB). - Add support for identifying page issue severity based on template CSS classes. - For multiple issues templates, show the highest priority icon. Bug: T191528 Change-Id: Ie0a4c83ec7cfb856ec581d058797109746e3cb99
2018-07-10 20:06:51 +00:00
},
"images": {
"issue-generic": "resources/skins.minerva.icons.page.issues.default.color/issue-generic.svg"
}
},
"skins.minerva.icons.page.issues.medium.color": {
"class": "ResourceLoaderImageModule",
"selector": ".mw-ui-icon-minerva-{name}-mediumColor:before",
"defaultColor": "#ff5d01",
"images": {
"issue-severity-medium": "resources/skins.minerva.icons.page.issues.medium.color/issue-severity-medium.svg",
"issue-type-point-of-view": "resources/skins.minerva.icons.page.issues.medium.color/issue-type-point-of-view.svg"
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
}
},
"skins.minerva.mainPage.styles": {
"targets": [
"mobile",
"desktop"
],
"styles": [
"resources/skins.minerva.mainPage.styles/common.less"
]
},
"skins.minerva.userpage.icons": {
"class": "ResourceLoaderImageModule",
Hygiene: No need for un-prefixed icons any more These were added in I93264024f4915fc910c792b1905b89cdc6b8b546 for cached HTML but are no longer needed. Change-Id: I008856c0c5e26270ed82d02a5413576495920bac
2018-04-11 21:08:24 +00:00
"selector": ".mw-ui-icon-mf-{name}:before",
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"images": {
Restore Minerva specific userpage styles for all user pages In T182162 these were removed incorrectly. They should only have been partially removed. Bug: T187222 Change-Id: Ia3fb34250714fe4ccb10c32a7027fda167e06a16
2018-02-14 00:14:54 +00:00
"talk": "resources/skins.minerva.userpage.icons/talk.svg"
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
}
},
"skins.minerva.userpage.styles": {
"targets": [
"mobile",
"desktop"
],
"styles": [
"resources/skins.minerva.userpage.styles/userpage.less"
]
},
Render talk page as a tab instead of an overlay Following up on Jon's POC, this will get rid of the talk board component in favor of linking to the server rendered talk page. Additional Changes: * Cleaned up talk selenium tests. Removed talk_steps.rb which doesn't appear to be used anymore. * Changed talk add button classes to a single class * Moved "Add discussion" button to postheadinghtml per design mock * Added "...talk-explained", "...talk-explained-empty" messages to postheadinghtml per design mock * Due to undesirable jumps in window scroll caused by the section anchor & Toggler.js code when opening the TalkSectionOverlay (read fixme in code), a Promise is always returned from OverlayManager route to reset the scroll position to the top when the section overlay is opened. * Moved "mobile-frontend-talk-fullpage", "mobile-frontend-talk-reply-success", "mobile-frontend-talk-topic-feedback", "mobile-frontend-talk-explained" "mobile-frontend-talk-explained-empty" messages to minerva as minerva is the one who initiates those messages now. * Limited $talk selector to only `.talk` elements since amc talk tab does not need to be targeted * After saving a reply from TalkSectionOverlay, the DOM that is not part of the overlay becomes out of sync since a new reply was created. To get around this, an `onSaveComplete` callback was passed (similar to the TalkSectionAddOverlay) to execute a full page refresh. Although this is clunky, it is the easiest way to resync. Bug: T230695 Depends-On: I80201394fd7015db6700446142b0b4b20829f12e Change-Id: I243f1193bce0da9fa710fc3b5379f90b2d079680
2019-10-17 22:46:07 +00:00
"skins.minerva.talk.styles": {
"targets": [
"mobile",
"desktop"
],
"styles": [
"resources/skins.minerva.talk.styles/talkpage.less"
]
},
Separate AMC icons from non-AMC icons Currently a bunch of icons are loaded for all users that are only ever used for AMC. Clean this up and add notes on the necessary steps if these ever become the default. Bug: T229295 Change-Id: I4e16028e7121b0b3e1a60b9404183d483db52ad8
2019-08-22 22:13:57 +00:00
"skins.minerva.personalMenu.icons": {
Use user sandbox icon from OOUI It's called 'markup'. Since this icon only ever shows to logged in users there are no caching implications. Bug: T244444 Change-Id: I75f5365ccb5a41f1c0628532e81b5ec63804a2a8
2020-02-07 03:11:56 +00:00
"class": "ResourceLoaderOOUIIconPackModule",
"selectorWithoutVariant": ".mw-ui-icon-minerva-{name}:before",
Updating icons for AMC mode Replaced the following icons: - communityportal.svg - specialpages.svg - info.svg - contributions.svg Bug: T222228 Change-Id: Id7889aeb99abe39bc0efae0a1c6457826015302b
2019-06-06 12:39:52 +00:00
"defaultColor": "#4A4F53",
Use user sandbox icon from OOUI It's called 'markup'. Since this icon only ever shows to logged in users there are no caching implications. Bug: T244444 Change-Id: I75f5365ccb5a41f1c0628532e81b5ec63804a2a8
2020-02-07 03:11:56 +00:00
"icons": [ "markup" ],
"variants": []
Separate AMC icons from non-AMC icons Currently a bunch of icons are loaded for all users that are only ever used for AMC. Clean this up and add notes on the necessary steps if these ever become the default. Bug: T229295 Change-Id: I4e16028e7121b0b3e1a60b9404183d483db52ad8
2019-08-22 22:13:57 +00:00
},
"skins.minerva.mainMenu.advanced.icons": {
"class": "ResourceLoaderImageModule",
"selector": ".mw-ui-icon-minerva-{name}:before",
"defaultColor": "#4A4F53",
"images": {
[UI] [AMC] add recent changes to the AMC menu This mostly reverts commit 692309090dea405144a9e224524a5fec52e51700 and updates the icon. Bug: T224216 Change-Id: I7200aaef5a15479afb4bc99f5195e900351a055a
2019-07-30 17:27:34 +00:00
"recentchanges": {
"file": {
Upgrade skin.json schema to manifest_version 2 Bug: T242505 Change-Id: Iccc217fe695270c5a04811fdca5bd65c26ae6609
2020-01-11 04:31:33 +00:00
"ltr": "resources/skins.minerva.mainMenu.advanced.icons/recentChanges-ltr.svg",
Separate AMC icons from non-AMC icons Currently a bunch of icons are loaded for all users that are only ever used for AMC. Clean this up and add notes on the necessary steps if these ever become the default. Bug: T229295 Change-Id: I4e16028e7121b0b3e1a60b9404183d483db52ad8
2019-08-22 22:13:57 +00:00
"rtl": "resources/skins.minerva.mainMenu.advanced.icons/recentChanges-rtl.svg"
[UI] [AMC] add recent changes to the AMC menu This mostly reverts commit 692309090dea405144a9e224524a5fec52e51700 and updates the icon. Bug: T224216 Change-Id: I7200aaef5a15479afb4bc99f5195e900351a055a
2019-07-30 17:27:34 +00:00
}
},
Updating icons for AMC mode Replaced the following icons: - communityportal.svg - specialpages.svg - info.svg - contributions.svg Bug: T222228 Change-Id: Id7889aeb99abe39bc0efae0a1c6457826015302b
2019-06-06 12:39:52 +00:00
"specialpages": {
"file": {
Upgrade skin.json schema to manifest_version 2 Bug: T242505 Change-Id: Iccc217fe695270c5a04811fdca5bd65c26ae6609
2020-01-11 04:31:33 +00:00
"ltr": "resources/skins.minerva.mainMenu.advanced.icons/specialpages-ltr.svg",
Separate AMC icons from non-AMC icons Currently a bunch of icons are loaded for all users that are only ever used for AMC. Clean this up and add notes on the necessary steps if these ever become the default. Bug: T229295 Change-Id: I4e16028e7121b0b3e1a60b9404183d483db52ad8
2019-08-22 22:13:57 +00:00
"rtl": "resources/skins.minerva.mainMenu.advanced.icons/specialpages-rtl.svg"
Updating icons for AMC mode Replaced the following icons: - communityportal.svg - specialpages.svg - info.svg - contributions.svg Bug: T222228 Change-Id: Id7889aeb99abe39bc0efae0a1c6457826015302b
2019-06-06 12:39:52 +00:00
}
},
"communityportal": {
"file": {
Separate AMC icons from non-AMC icons Currently a bunch of icons are loaded for all users that are only ever used for AMC. Clean this up and add notes on the necessary steps if these ever become the default. Bug: T229295 Change-Id: I4e16028e7121b0b3e1a60b9404183d483db52ad8
2019-08-22 22:13:57 +00:00
"ltr": "resources/skins.minerva.mainMenu.advanced.icons/communityportal-ltr.svg",
"rtl": "resources/skins.minerva.mainMenu.advanced.icons/communityportal-rtl.svg"
}
}
}
},
"skins.minerva.mainMenu.icons": {
"class": "ResourceLoaderImageModule",
"selector": ".mw-ui-icon-minerva-{name}:before",
"defaultColor": "#4A4F53",
Do not use data URI on main menu icons data URIs increase CSS payload which delays render time. If we want to render these by default in the new main menu we will need to stop using data URIs. Bug: T225213 Change-Id: I876317ac28837fae48f504bb8d2637e0e7b85154
2019-11-26 23:11:02 +00:00
"useDataURI": false,
Separate AMC icons from non-AMC icons Currently a bunch of icons are loaded for all users that are only ever used for AMC. Clean this up and add notes on the necessary steps if these ever become the default. Bug: T229295 Change-Id: I4e16028e7121b0b3e1a60b9404183d483db52ad8
2019-08-22 22:13:57 +00:00
"images": {
Revert "Reduce 'userContributions' icon code" This reverts commit 7b4b65a30f0513e2d5f9458568a8dc6f3854bc49, which caused a regression in the user menu part of Advanced Mobile Contributions mode. Bug: T244436 Change-Id: Ifce627dac35b2cd05e1c5ebe658534b6b8d0de88
2020-02-06 18:26:17 +00:00
"contributions": {
Restore contributions icon to non-AMC menu Bug: T231363 Change-Id: I82b9b06a83454cf4b49d906a8358b338d30f892a
2019-08-27 17:33:56 +00:00
"file": {
Revert "Reduce 'userContributions' icon code" This reverts commit 7b4b65a30f0513e2d5f9458568a8dc6f3854bc49, which caused a regression in the user menu part of Advanced Mobile Contributions mode. Bug: T244436 Change-Id: Ifce627dac35b2cd05e1c5ebe658534b6b8d0de88
2020-02-06 18:26:17 +00:00
"ltr": "resources/skins.minerva.mainMenu.icons/contributions-ltr.svg",
"rtl": "resources/skins.minerva.mainMenu.icons/contributions-rtl.svg"
Restore contributions icon to non-AMC menu Bug: T231363 Change-Id: I82b9b06a83454cf4b49d906a8358b338d30f892a
2019-08-27 17:33:56 +00:00
}
},
[icon] revise icons Update the icons. Bug: T229440 Change-Id: I4460efba7b122b2a66e65924f311bb87f84160e5
2019-08-22 15:37:57 +00:00
"login": {
"file": {
"ltr": "resources/skins.minerva.mainMenu.icons/logIn-ltr.svg",
"rtl": "resources/skins.minerva.mainMenu.icons/logIn-rtl.svg"
}
},
Separate AMC icons from non-AMC icons Currently a bunch of icons are loaded for all users that are only ever used for AMC. Clean this up and add notes on the necessary steps if these ever become the default. Bug: T229295 Change-Id: I4e16028e7121b0b3e1a60b9404183d483db52ad8
2019-08-22 22:13:57 +00:00
"home": "resources/skins.minerva.mainMenu.icons/home.svg",
"logout": {
"file": {
"ltr": "resources/skins.minerva.mainMenu.icons/logOut-ltr.svg",
"rtl": "resources/skins.minerva.mainMenu.icons/logOut-rtl.svg"
Updating icons for AMC mode Replaced the following icons: - communityportal.svg - specialpages.svg - info.svg - contributions.svg Bug: T222228 Change-Id: Id7889aeb99abe39bc0efae0a1c6457826015302b
2019-06-06 12:39:52 +00:00
}
[UI] [new] add user menu Add new user menu. The changes required include: - Break up AuthMenuEntry into reusable components. They're now simple, independent, static functions in AuthUtil that are easy to reason about and compose. There's lots of verbose code because of the builder and director patterns. That is, most of the code is for building the thing we actually want to build instead of just building it. It's easy to write but no fun to read--even simple configurations are extremely verbose expressions that must be threaded through the system. These builders are also single purpose and unlikely to be reusable unlike a URI builder, for example. As objects, they're not especially composable either. - Similarly, break up Menu/DefaultBuilder into BuilderUtil and ban inheritance. Inheritance has not worked well on the frontend of MobileFrontend. I don't think it's going to work well here. E.g., I could have made changes to the base class' getPersonalTools() method such that the client passes a parameter for the advanced config or maybe I just override it in the subclass. In either case, I think it makes the whole hierarchy nuanced and harder to reason about for something that should be simple. - Add ProfileMenuEntry and LogOutMenuEntry for the user menu. - Rename insertLogInOutMenuItem() to insertAuthMenuItem() which matches the entry name, AuthMenuEntry. - Extension:SandboxLink is needed to display the sandbox link in the user menu. - Performance note: the toolbar is now processed in MinervaTemplate, which corresponds to removing the buildPersonalUrls() override. - To mimic the design of main menu, the following steps would be necessary: 1. Create a user/Default and user/Advanced user menu builder and also a user/IBuilder interface. 2. Create a user/Director. 3. Create a service entry for Minerva.Menu.UserDirector in ServiceWiring. The Director is actually powerless and doesn't get to make any decisions--the appropriate builder is passed in from ServiceWiring which checks the mode. 4. Access the service in SkinMinerva to set a userMenuHTML data member on the Minerva QuickTemplate. 5. In MinervaTemplate, access the userMenuHTML QuickTemplate member and do the usual song and dance of inflating a Mustache template. This patch does everything except add a service, which was agreed to be unnecessary, so that logic is now in SkinMinerva. - Wrap the existing echo user notifications button and new user menu button in a nav element. This seems like a semantic improvement. - The existing styling and logic for the search bar and search overlay are pretty messy and delicate. Changes made to that LESS endeavored to be surgical. There's lots of room for improvement in the toolbar but it's out of scope. - Rename logout icon to logOut. Bug: T214540 Change-Id: Ib517864fcf4e4d611e05525a6358ee6662fe4e05
2019-06-25 20:12:58 +00:00
},
Separate AMC icons from non-AMC icons Currently a bunch of icons are loaded for all users that are only ever used for AMC. Clean this up and add notes on the necessary steps if these ever become the default. Bug: T229295 Change-Id: I4e16028e7121b0b3e1a60b9404183d483db52ad8
2019-08-22 22:13:57 +00:00
"nearby": "resources/skins.minerva.mainMenu.icons/nearby.svg",
"random": "resources/skins.minerva.mainMenu.icons/random.svg",
"settings": "resources/skins.minerva.mainMenu.icons/settings.svg",
"watchlist": "resources/skins.minerva.mainMenu.icons/watchlist.svg"
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
}
},
"skins.minerva.mainMenu.styles": {
"targets": [
"mobile",
"desktop"
],
"styles": [
Reorganise stylesheets All stylesheet-only ResourceLoader modules now have a single entry point rather than multiple files. This eases compilation of the content of those modules by all toolchains, which will be useful when introducing the bundlesize tool. Change-Id: Ic38a3e51db2f419fe68efd23a2c48ee69218a526
2020-01-20 21:19:12 +00:00
"resources/skins.minerva.mainMenu.styles/index.less"
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
]
},
Only load notification icon (bell) CSS for logged in users * The notification-count style is only needed if you are logged in. Given a small percentage of our users are logged in, we load a lot of render blocking css unnecessarily. * The bell icon is not needed for anonymous users so pull that out from skins.minerva.icons.images which is loaded for all users into a module only used by logged in users (skins.minerva.icons.loggedin) * Simplify the user-button rule - it is overly specific - probably for historic reasons. Additional changes: * Simplify isAuthenticated helper Change-Id: Ia72e7e45d276e8aac1ff5471bf6158705c7b5f99
2017-12-13 01:25:10 +00:00
"skins.minerva.loggedin.styles": {
"targets": [
"mobile",
"desktop"
],
"styles": [
"resources/skins.minerva.loggedin.styles/styles.less"
]
},
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"skins.minerva.scripts": {
"targets": [
"mobile",
"desktop"
],
"dependencies": [
Refresh the user, bell and search icon * New module skins.minerva.icons.wikimedia provides icons from Wikimedia UI in Minerva * search selector in skins.minerva.content.styles.images is retained for cached HTML * skins.minerva.icons.loggedin now a ResourceLoaderOOUIIconPackModule and bell removed from repo. * userAvatar replaced with userAvatarOutline Bug: T224070 Change-Id: Ibed609371060acc4b69e5cd4cd4f20edc871b3ba
2019-07-09 19:12:51 +00:00
"skins.minerva.icons.wikimedia",
Embrace packageFiles Help with readability by using module.exports and require rather than the MobileFrontend provided mw.mobileFrontend module manager (and avoid adopting webpack at this time) Replace usages of mw.mobileFrontend.require with local require and module.exports (compatible with RL or Node implementation) Changes: * Notifications modules are merged into skins.minerva.scripts and initialised via a client side check. * new file overlayManager for exporting an overlayManager singleton rather than being hidden inside resources/skins.minerva.scripts/init.js * All M.define/M.requires swapped out for require where possible The `define` method is now forbidden in the repo. Bug: T212944 Change-Id: I44790dd3fc6fe42bb502d79c39c4081c223bf2b1
2019-07-02 21:10:10 +00:00
"mediawiki.ui.anchor",
Update: add secondary page actions submenu in AMC mode When advanced mobile contributions mode is enabled and `$wgMinervaOverflowInPageActions` is set, show a secondary overflow menu on main namespace articles and user namespace pages. The menu content varies for each namespace. The new submenu is *disabled* by default, even when AMC is active. This feature should not be deployed until instrumentation is available. The secondary menu is rendered in PHP using the existing menu system with some changes to the template. The checkbox hack is needed for no- JavaScript keyboard navigation until :focus-within is supported. CSS additions are documented in the source. All client side toolbar execution occurs in Toolbar.js. Enhancements are documented in the source. Minor changes to the existing download button: - Move download and edit button initialization to Toolbar. - Update copy (not visible) from "Download" to "Download PDF". - When the overflow menu is present, use the "hasText" / label style. Wikimedia UI icons are copied from OOUI at d00a0ac and seem useful to expose as HTTP URIs (not data URIs). The overflow menu does not show for pages provided by the content proxy since its entries depend on $tpl->data['nav_urls'] being populated. Bug: T216418 Depends-On: I0781151a8232b6a7b52f79a34298afcecb8e4271 Change-Id: I4b50a0e519024a7ab91dae6ab40b23cf14a03861
2019-04-04 21:20:39 +00:00
"wikimedia.ui",
Merge skins.minerva.scripts.top and skins.minerva.mainMenu into scripts These modules can safely be merged. Since skins.minerva.scripts.top is added via addModules to the HTML it must be marked as deprecated and remain temporarily as a redirection to skins.minerva.scripts All modules have been renamed to be in there new home - no deprecation notices are needed as they are not used outside Minerva. I leave skins.minerva.mainMenu.styles as it is used by Special:MobileMenu and needs to continue to do so. Change-Id: Ie919151630f4389f8e84e808bec003a6d3d07bd9
2019-02-07 16:09:20 +00:00
"skins.minerva.mainMenu.icons",
"skins.minerva.mainMenu.styles",
Make dependency to jquery.cookie explicit for mobileRedirect code Change-Id: I9ecdf9b507df6a9ec04933981ec5960c524e2323
2018-03-02 00:27:00 +00:00
"jquery.cookie",
Add feature flagged DownloadIcon Shortcut for print. Disabled by default and controlled by wgMinervaDownloadIcon Note that with lazy images enabled, images will not appear in the printed article. This can be easily addressed inside the onClick function in a later patchset with a few modifications to the Skin class. Currently the flag when enabled will show on all browsers. There are some open questions on the ticket about how we want to limit the feature. This shouldn't block review or merging. Bug: T177215 Change-Id: I49f1736870c743990b3fb9916247e07a597b2f59
2017-10-18 21:03:51 +00:00
"skins.minerva.icons.images.scripts",
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"mediawiki.util",
"mediawiki.router",
"mediawiki.Title",
Update: don't prompt to create User pages Suppress the redlink drawer for User namespace pages. The redlink drawer prompts the user to create a missing page but this hinders the usual workflow for User page visits specifically. A User page is connection to an account's contributions, age, and other activities and encouraging the creation of a missing User page when trying to view these connections is a hindrance, especially if the missing User page is not associated with the current user. Bug: T201339 Change-Id: I784493a8ecf28176b5a393cb52d7bfa9fa9b1309
2019-03-04 22:19:33 +00:00
"mediawiki.Uri",
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"mobile.startup",
A/B test bucketing wrapper for page issues AB. Provides a class that initiates AB-test bucketing and registers as a MF module. Activates the reading depth test for users who are bucketed in either buckets "A" or "B". Does not add event-logging or visual style changes for page issues AB test. Bug: T193584 Change-Id: If8504a35059c6d1b056cef063a595b1c2ffd351a
2018-05-09 15:14:44 +00:00
"mediawiki.user",
"mediawiki.storage",
"mediawiki.experiments"
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
],
"messages": [
Embrace packageFiles Help with readability by using module.exports and require rather than the MobileFrontend provided mw.mobileFrontend module manager (and avoid adopting webpack at this time) Replace usages of mw.mobileFrontend.require with local require and module.exports (compatible with RL or Node implementation) Changes: * Notifications modules are merged into skins.minerva.scripts and initialised via a client side check. * new file overlayManager for exporting an overlayManager singleton rather than being hidden inside resources/skins.minerva.scripts/init.js * All M.define/M.requires swapped out for require where possible The `define` method is now forbidden in the repo. Bug: T212944 Change-Id: I44790dd3fc6fe42bb502d79c39c4081c223bf2b1
2019-07-02 21:10:10 +00:00
"echo-badge-count",
"mobile-frontend-notifications-filter",
Mobile page issues - visual styling changes Changes: * Introduce Jan's beautifully documented $wgMinervaABSamplingRate Set to 1 to A/B test 50% of the population * Split out ambox template styles into a separate file referenced by hacks.less * Update cleanuptemplates setup script to consider two buckets Test pages: * Shqiponja_Partizane * World_War_II_in_Albania * Liberation_of_Tirana * French_Consulate * Abd_ar-Rahman_IV * M109_howitzer * Aimoin * Transport_in_Brazil * Transport_in_Cape_Verde Bug: T191303 Change-Id: I8d11e655ccb847b7999e64dda57b225ad8b1c23a
2018-05-08 22:03:52 +00:00
"skin-minerva-issue-learn-more",
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"mobile-frontend-meta-data-issues",
Section issues overlay has different heading Per https://phabricator.wikimedia.org/T197932#4417319 Note that given talk/category overlay does not use or display section issues, to simplify things any section other than 0 or all will use this heading. Bug: T197932 Change-Id: I737fb07aaadcea7772d0b08f8b0652dcf2f4623d
2018-07-11 21:13:19 +00:00
"minerva-meta-data-issues-section-header",
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"mobile-frontend-meta-data-issues-talk",
"mobile-frontend-meta-data-issues-categories",
"mobile-frontend-meta-data-issues-header",
"mobile-frontend-meta-data-issues-header-talk",
"mobile-frontend-languages-not-available",
"mobile-frontend-cookies-required",
Move redlink CTA out of skins.minerva.editor It is not part of the editor. Redlinks are part of page content. Bug: T198765 Change-Id: Iee77a228b6f2db1c5f2e85226d6cc1c6a73a89be
2018-09-20 22:52:35 +00:00
"mobile-frontend-editor-redlink-create",
"mobile-frontend-editor-redlink-leave",
"mobile-frontend-editor-redlink-explain",
Add feature flagged DownloadIcon Shortcut for print. Disabled by default and controlled by wgMinervaDownloadIcon Note that with lazy images enabled, images will not appear in the printed article. This can be easily addressed inside the onClick function in a later patchset with a few modifications to the Skin class. Currently the flag when enabled will show on all browsers. There are some open questions on the ticket about how we want to limit the feature. This shouldn't block review or merging. Bug: T177215 Change-Id: I49f1736870c743990b3fb9916247e07a597b2f59
2017-10-18 21:03:51 +00:00
"minerva-download",
Use core watchstar code Apply the mediawiki core watchstar to the Minerva skin. Note, watchstars in search and other locations will continue to be provided by the MobileFrontend library (see follow up patch I7b748dc87089389400b0035c62a3b9a00c2e43f9) Bug: T234970 Change-Id: I11bbe976412b50dba76a55f37887e4c9235d0be1
2019-09-19 21:19:07 +00:00
"minerva-watchlist-cta",
Render talk page as a tab instead of an overlay Following up on Jon's POC, this will get rid of the talk board component in favor of linking to the server rendered talk page. Additional Changes: * Cleaned up talk selenium tests. Removed talk_steps.rb which doesn't appear to be used anymore. * Changed talk add button classes to a single class * Moved "Add discussion" button to postheadinghtml per design mock * Added "...talk-explained", "...talk-explained-empty" messages to postheadinghtml per design mock * Due to undesirable jumps in window scroll caused by the section anchor & Toggler.js code when opening the TalkSectionOverlay (read fixme in code), a Promise is always returned from OverlayManager route to reset the scroll position to the top when the section overlay is opened. * Moved "mobile-frontend-talk-fullpage", "mobile-frontend-talk-reply-success", "mobile-frontend-talk-topic-feedback", "mobile-frontend-talk-explained" "mobile-frontend-talk-explained-empty" messages to minerva as minerva is the one who initiates those messages now. * Limited $talk selector to only `.talk` elements since amc talk tab does not need to be targeted * After saving a reply from TalkSectionOverlay, the DOM that is not part of the overlay becomes out of sync since a new reply was created. To get around this, an `onSaveComplete` callback was passed (similar to the TalkSectionAddOverlay) to execute a full page refresh. Although this is clunky, it is the easiest way to resync. Bug: T230695 Depends-On: I80201394fd7015db6700446142b0b4b20829f12e Change-Id: I243f1193bce0da9fa710fc3b5379f90b2d079680
2019-10-17 22:46:07 +00:00
"mobile-frontend-redirected-from",
"minerva-talk-full-page",
"minerva-talk-topic-feedback",
Logout users via API Ajax call to prevent extra step on Special:Logout Currently the Special:Logout page will ask "do you want to logout" even if we pass the logout token. To avoid that first let's log out user via API Ajax call. Bug: T232734 Change-Id: Ia4cc4253b99254d7a893a55d9e05918c5d8c87e5
2019-10-22 21:05:06 +00:00
"minerva-talk-reply-success",
"logging-out-notify",
"logout-failed"
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
],
Restore last modified active link color In I7abdbac4d2d16b931e2b110fcebf0dfc82146753 I accidentally removed the active link color (I meant to /move/ it from the critical path since it requires JavaScript) Change-Id: Ie86c3c9d03a0ed130a86c50bb548c9b47db6def6
2018-04-13 17:17:36 +00:00
"styles": [
Hygiene: IssuesOverlay moved from MobileFrontend to Minerva The CleanupOverlay is moved to Minerva and renamed the IssuesOverlay to be consistent with current terminology The new IssuesOverlay is defined inside the module skins.minerva.scripts to which it now belongs. Additional changes: * various file renames * overlay-cleanup renames overlay-issues * cleanuptemplates renamed issues.js * Add a test stub file to avoid the need to load templates inside the test environment After this change, I75f47622d94e504688e04dfb2892540473817053 should be merged to avoid confusion. Change-Id: I08945a324a6b878abe56efed1e988466085b3018
2018-08-16 19:00:38 +00:00
"resources/skins.minerva.scripts/styles.less",
[dev] match page issues LESS filename to JS naming Bug: T212944 Change-Id: I0fa44cdb26b24fff87a7c4dfd424fe4400ceee22
2019-07-10 20:10:43 +00:00
"resources/skins.minerva.scripts/page-issues/overlay/pageIssuesOverlay.less"
Restore last modified active link color In I7abdbac4d2d16b931e2b110fcebf0dfc82146753 I accidentally removed the active link color (I meant to /move/ it from the critical path since it requires JavaScript) Change-Id: Ie86c3c9d03a0ed130a86c50bb548c9b47db6def6
2018-04-13 17:17:36 +00:00
],
Hygiene: IssuesOverlay moved from MobileFrontend to Minerva The CleanupOverlay is moved to Minerva and renamed the IssuesOverlay to be consistent with current terminology The new IssuesOverlay is defined inside the module skins.minerva.scripts to which it now belongs. Additional changes: * various file renames * overlay-cleanup renames overlay-issues * cleanuptemplates renamed issues.js * Add a test stub file to avoid the need to load templates inside the test environment After this change, I75f47622d94e504688e04dfb2892540473817053 should be merged to avoid confusion. Change-Id: I08945a324a6b878abe56efed1e988466085b3018
2018-08-16 19:00:38 +00:00
"templates": {
MainMenu is a controller not a View and server rendered (take 2) There should be no caching implications for this change, as the main menu has been server side rendered on all wikis since 10th October. As Stephen pointed out somewhere, this is a bit of a micro-optimisation Let's simplify this code by always rendering it in the HTML. MainMenu.js as a result becomes a controller that just decides when to show it. The geolocation check for Nearby is removed given the fact that all grade A browsers for mediawiki have Geolocation support. ev.preventDefault in onSkinClick is dropped since the link to the '#' (the default behaviour) is wanted Additional changes * Browser support suggests "animations" class is redundant now * `open` event no longer filed - not being used anywhere * Transparent shield is now managed by the MainMenu controller not the skin (which was confusing) * Test geolocation using a simple feature tests rather than abstracting it away inside Browser * The main menu button is always hidden under either a translucent shield and/or the main menu itself when it has been opened so so it's not possible to ever click it while the menu is open - the click handler is thus simplified removing a check for the class of the button Bug: T234650 Change-Id: If101eebbdbda1519af922745917237648722820e
2019-09-05 21:55:55 +00:00
"IssueNotice.mustache": "resources/skins.minerva.scripts/page-issues/overlay/IssueNotice.mustache"
Hygiene: IssuesOverlay moved from MobileFrontend to Minerva The CleanupOverlay is moved to Minerva and renamed the IssuesOverlay to be consistent with current terminology The new IssuesOverlay is defined inside the module skins.minerva.scripts to which it now belongs. Additional changes: * various file renames * overlay-cleanup renames overlay-issues * cleanuptemplates renamed issues.js * Add a test stub file to avoid the need to load templates inside the test environment After this change, I75f47622d94e504688e04dfb2892540473817053 should be merged to avoid confusion. Change-Id: I08945a324a6b878abe56efed1e988466085b3018
2018-08-16 19:00:38 +00:00
},
Embrace packageFiles Help with readability by using module.exports and require rather than the MobileFrontend provided mw.mobileFrontend module manager (and avoid adopting webpack at this time) Replace usages of mw.mobileFrontend.require with local require and module.exports (compatible with RL or Node implementation) Changes: * Notifications modules are merged into skins.minerva.scripts and initialised via a client side check. * new file overlayManager for exporting an overlayManager singleton rather than being hidden inside resources/skins.minerva.scripts/init.js * All M.define/M.requires swapped out for require where possible The `define` method is now forbidden in the repo. Bug: T212944 Change-Id: I44790dd3fc6fe42bb502d79c39c4081c223bf2b1
2019-07-02 21:10:10 +00:00
"packageFiles": [
Make MobileFrontend dependency a soft one This extends the work in Ie29a1eb7746d56f7d8c99b74e5e3c213c30fdcf2 Bug: T171000 Change-Id: Ib125e1bdaace1893804892909c27a9f328445835
2019-12-18 21:15:26 +00:00
"resources/skins.minerva.scripts/setup.js",
"resources/skins.minerva.scripts/initMobile.js",
"resources/skins.minerva.scripts/searchSuggestReveal.js",
CtaDrawers no longer stay behind in DOM A new controller is added - drawers.js with methods for controlling display and removal of drawers. The existing code in references is moved there and extended to support scroll to hide behaviour Console warnings will disappear with this change. Additional changes: * Standardise the page issues element selector - should be the container not a link inside it (was a red link so triggering wrong behaviour) Bug: T214045 Change-Id: Id4719b5209dd7647775e2959e46dbae0c3dde3ac
2019-12-16 23:47:54 +00:00
"resources/skins.minerva.scripts/drawers.js",
Use core watchstar code Apply the mediawiki core watchstar to the Minerva skin. Note, watchstars in search and other locations will continue to be provided by the MobileFrontend library (see follow up patch I7b748dc87089389400b0035c62a3b9a00c2e43f9) Bug: T234970 Change-Id: I11bbe976412b50dba76a55f37887e4c9235d0be1
2019-09-19 21:19:07 +00:00
"resources/skins.minerva.scripts/ctaDrawers.js",
Merge skins.minerva.scripts.top and skins.minerva.mainMenu into scripts These modules can safely be merged. Since skins.minerva.scripts.top is added via addModules to the HTML it must be marked as deprecated and remain temporarily as a redirection to skins.minerva.scripts All modules have been renamed to be in there new home - no deprecation notices are needed as they are not used outside Minerva. I leave skins.minerva.mainMenu.styles as it is used by Special:MobileMenu and needs to continue to do so. Change-Id: Ie919151630f4389f8e84e808bec003a6d3d07bd9
2019-02-07 16:09:20 +00:00
"resources/skins.minerva.scripts/menu.js",
Hygiene: Load errorLogger earlier in stack Follow up to I07f01b4c025b2e5e4cbf88ec05e7c536442c62cc Bug: T202026 Change-Id: I190417e90fd27b21844a20f96ec1237416c57079
2018-09-06 20:47:13 +00:00
"resources/skins.minerva.scripts/errorLogging.js",
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"resources/skins.minerva.scripts/preInit.js",
Composition: DownloadIcon The DownloadIcon is reduced to a factory function that returns an instance of Icon Depends-On: I4d703eef68d51bbe0b03579c5cca0845e17b8c9d Depends-On: I4a4129b2cac7c7c49559beef0b8780f3211edf9c Bug: T205592 Change-Id: Ib87390d17bef6f50842f52cd84c9ce2b162aaff0
2018-11-08 00:06:54 +00:00
"resources/skins.minerva.scripts/downloadPageAction.js",
Update page issues folder structure Tests are untouched as these will be moved to headless node-qunit in a follow up. Bug: T212944 Change-Id: I3d9b43387e34fd49827e3ab62420f3555ff4b3cd
2019-07-02 20:34:03 +00:00
"resources/skins.minerva.scripts/page-issues/parser.js",
Hygiene: Separate cleanups library from initialisation In order to write tests, we'd like to separate code without side effects from code that executes it as part of setup. This shuffles dependencies and makes page and overlayManager parameters to the init function (injected dependencies) Change-Id: I96808541d48be7869fed3bc30babb80866e139ec
2018-07-30 14:45:44 +00:00
"resources/skins.minerva.scripts/AB.js",
pageIssuesOverlay is a factory function that returns an Overlay This experiments with making PageIssuesOverlay an Overlay with various options. The appending of children is a little messy and points at a need to standardise this some way (see https://phabricator.wikimedia.org/T209647) TODO: * Remove the iconString property on PageIssueSummary which is no longer needed Bug: T209647 Change-Id: Iadd798a820dca6bbb31edc9a8570b6db7aac237a
2018-11-24 01:49:47 +00:00
"resources/skins.minerva.scripts/page-issues/overlay/IssueNotice.js",
"resources/skins.minerva.scripts/page-issues/overlay/IssueList.js",
"resources/skins.minerva.scripts/page-issues/overlay/pageIssuesOverlay.js",
Hygiene: separate page issue view logic - Move page issue view components that do not modify the DOM during during construction to PageIssueLearnMoreLink.js and PageIssueLink.js. PascalCase is used optimistically for filenaming in the hopes that these functions can become something like a JSX component. A "new" function prefix is used in the meantime. - Move page issue view logic that munges the existing DOM to pageIssueFormatter.js. Substitute "create" prefixes for insert so that clients won't forget that calling the function is a modify operation. Alternative naming welcome but it shouldn't be confused with more idealistic components that do not depend on DOM state for construction. - Consolidate createPageIssueBanner() and createPageIssueBannerMultiple() into insertPageIssueBanner() as the code was quite similar and were it a true component, it would probably be a single component. All new files appear under page/ to keep their distinction from the overlay code clear. Some view logic remains in pageIssues.js but it shall be difficult to isolate. Bug: T212376 Change-Id: Iccce709c34fa8de5a28a5a00098add5775e3dc9a
2019-01-23 20:16:11 +00:00
"resources/skins.minerva.scripts/page-issues/page/PageIssueLearnMoreLink.js",
"resources/skins.minerva.scripts/page-issues/page/PageIssueLink.js",
"resources/skins.minerva.scripts/page-issues/page/pageIssueFormatter.js",
Update page issues folder structure Tests are untouched as these will be moved to headless node-qunit in a follow up. Bug: T212944 Change-Id: I3d9b43387e34fd49827e3ab62420f3555ff4b3cd
2019-07-02 20:34:03 +00:00
"resources/skins.minerva.scripts/page-issues/index.js",
Update: don't prompt to create User pages Suppress the redlink drawer for User namespace pages. The redlink drawer prompts the user to create a missing page but this hinders the usual workflow for User page visits specifically. A User page is connection to an account's contributions, age, and other activities and encouraging the creation of a missing User page when trying to view these connections is a hindrance, especially if the missing User page is not associated with the current user. Bug: T201339 Change-Id: I784493a8ecf28176b5a393cb52d7bfa9fa9b1309
2019-03-04 22:19:33 +00:00
"resources/skins.minerva.scripts/UriUtil.js",
"resources/skins.minerva.scripts/TitleUtil.js",
Hygiene: extract ToggleList to a reusable component A list that toggles visibility via the checkbox hack is needed in at least two spots: the page actions overflow menu and the user menu. This patch makes several refactors to turn what was previously hardcoded into page actions a reusable component: - Start a new components directory. Components are reusable and composable. The subdirectories are organized by function, not ResourceLoader module bundling which greatly improves the ability to see a component's full functionality in one directory instead of examining the entire codebase. See updates to README. - Extract pageactions.less into: - ToggleList.less: LESS for any checkbox hack list. - DropDownList.less: LESS for lists that open downwards. - MenuListItem.less: LESS for list items of menus. The division makes it easier to see concerns, dependencies, and change code. - Move pageActionMenu.mustache to a component and extract ToggleList template. - Extract ToggleList.js from Toolbar.js. Bug: T214540 Change-Id: I171831469a6733c458bc5c7ba249a5096ca975b8
2019-06-20 19:17:50 +00:00
"components/ToggleList/ToggleList.js",
Improve tab scrolling logic * If the leftmost tab is selected, scroll all the way to the left * If the rightmost tab is selected, scroll all the way to the right * If a tab in the middle is selected, scroll to center it * If the selected tab is wider than the tab container, make sure its start (left edge in LTR, right edge in RTL) is always made visible. As Bartosz reminded me, .scrollLeft in RTL is a cross-browser nightmare (see https://github.com/othree/jquery.rtl-scroll-type), so add a bunch of code working around this. Some of this logic is in OOUI already, but what's there is not enough for what we need here, and we also don't want to load OOUI for this. Bug: T223142 Change-Id: Ica298954b42f9daa4819043ec24bc0266290a927
2019-06-25 01:10:51 +00:00
"resources/skins.minerva.scripts/TabScroll.js",
Update: add secondary page actions submenu in AMC mode When advanced mobile contributions mode is enabled and `$wgMinervaOverflowInPageActions` is set, show a secondary overflow menu on main namespace articles and user namespace pages. The menu content varies for each namespace. The new submenu is *disabled* by default, even when AMC is active. This feature should not be deployed until instrumentation is available. The secondary menu is rendered in PHP using the existing menu system with some changes to the template. The checkbox hack is needed for no- JavaScript keyboard navigation until :focus-within is supported. CSS additions are documented in the source. All client side toolbar execution occurs in Toolbar.js. Enhancements are documented in the source. Minor changes to the existing download button: - Move download and edit button initialization to Toolbar. - Update copy (not visible) from "Download" to "Download PDF". - When the overflow menu is present, use the "hasText" / label style. Wikimedia UI icons are copied from OOUI at d00a0ac and seem useful to expose as HTTP URIs (not data URIs). The overflow menu does not show for pages provided by the content proxy since its entries depend on $tpl->data['nav_urls'] being populated. Bug: T216418 Depends-On: I0781151a8232b6a7b52f79a34298afcecb8e4271 Change-Id: I4b50a0e519024a7ab91dae6ab40b23cf14a03861
2019-04-04 21:20:39 +00:00
"resources/skins.minerva.scripts/Toolbar.js",
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"resources/skins.minerva.scripts/mobileRedirect.js",
"resources/skins.minerva.scripts/search.js",
Merge skins.minerva.talk and skins.minerva.watchstar into skins.minerva.script Logic is moved from server to client. Config is added via getSkinConfigVariables (e.g. passed to mw.config ) and a JavaScript if statement. The IIFE in watchstar and talk files is replaced with a module.exports function to avoid refactoring at this point and added risk. The file contents remain the same. skins.minerva.options is left as is, given the code is more experimental and used in the beta mode - should not be sent to all clients. Additional change: * Remove skins.minerva.toggling (that module has been empty for a week now and functionality moved to mobile.init module) Depends-On: Ie71adbe18e8dbeb661ddb9d7d3d1d0897891d515 Bug: T233048 Change-Id: Ife777e76d9d77894fb5d09e7c8f0238b00596a7a
2019-09-18 23:07:21 +00:00
"resources/skins.minerva.scripts/references.js",
"resources/skins.minerva.scripts/talk.js",
"resources/skins.minerva.scripts/watchstar.js"
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
]
},
Merge skin option modules into a single ResourceLoader module and move enabled logic to client It's presumed that skin options will eventually become the default or be removed from the skin. While they are not the default, it would be helpful to package them in one single module - as ResourceLoader modules are costly bloating the dependency graph in the MediaWiki startup module. In T167713 we talked about grouping our entry points by page rather than feature, which this seems consistent with. A page with special options enabled is different from a page without. Change-Id: Id948f913d4743532ba3442d2059a03c122419ff2
2018-09-26 23:03:20 +00:00
"skins.minerva.options": {
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"targets": [
"mobile",
"desktop"
],
"dependencies": [
Merge skin option modules into a single ResourceLoader module and move enabled logic to client It's presumed that skin options will eventually become the default or be removed from the skin. While they are not the default, it would be helpful to package them in one single module - as ResourceLoader modules are costly bloating the dependency graph in the MediaWiki startup module. In T167713 we talked about grouping our entry points by page rather than feature, which this seems consistent with. A page with special options enabled is different from a page without. Change-Id: Id948f913d4743532ba3442d2059a03c122419ff2
2018-09-26 23:03:20 +00:00
"skins.minerva.scripts",
Add share icon as mobile web beta feature Add a new beta feature - share icon. When user opts into beta the share icon will be visible on supported devices (Android OS and Chrome browser). Bug: T181195 Change-Id: Ie4b9dd05eea9b63422bd174048d8b1251cb02bf4
2018-09-17 23:37:57 +00:00
"mediawiki.language",
Remove Share feature The feature got into Beta in over a year ago and never made into the beta mode. For most of the time it was disabled for all users. There is no need to keep this code as it is dead code now. Change-Id: I9037f58b97373195e9d1b9f57789a6c531f42831
2019-10-24 14:31:58 +00:00
"mobile.startup"
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
],
skins.minerva.options uses packageFiles I want to remove the need for M.define in the Minerva repository. It's no longer necessary with packageFiles and will help tame a lot of the code we have here! Change-Id: If6a35a23e84a44adb965fd9c41265ba37eb8368e
2019-07-05 22:21:34 +00:00
"packageFiles": [
"resources/skins.minerva.options/index.js",
Remove Share feature The feature got into Beta in over a year ago and never made into the beta mode. For most of the time it was disabled for all users. There is no need to keep this code as it is dead code now. Change-Id: I9037f58b97373195e9d1b9f57789a6c531f42831
2019-10-24 14:31:58 +00:00
"resources/skins.minerva.options/categories.js"
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
]
}
Use tabs in skin.json Change-Id: I8fb66fe2f99786bfbdc598d460c18928dbb0faa0
2017-06-09 22:09:22 +00:00
},
Migrate from onResourceLoaderTestModules to QUnitTestModule The hook is deprecated as of this release cycle, see: <https://www.mediawiki.org/wiki/Manual:Hooks/ResourceLoaderTestModules>. Moving away from PHP code. This can now be done from JSON, and encourages use of a single module that is automatically named and registered as needed. Change-Id: I382692c70ca8e5f5ea658b07ebea6c47dd541724
2019-09-20 20:50:23 +00:00
"QUnitTestModule": {
"localBasePath": "",
"remoteSkinPath": "MinervaNeue",
"dependencies": [
"mobile.startup",
"mediawiki.user",
"mediawiki.experiments"
],
"packageFiles": [
"tests/qunit/skins.minerva.scripts/index.js",
"resources/skins.minerva.scripts/page-issues/parser.js",
"resources/skins.minerva.scripts/downloadPageAction.js",
"resources/skins.minerva.scripts/AB.js",
"resources/skins.minerva.scripts/page-issues/overlay/IssueNotice.js",
"resources/skins.minerva.scripts/page-issues/overlay/IssueList.js",
"resources/skins.minerva.scripts/page-issues/overlay/pageIssuesOverlay.js",
"resources/skins.minerva.scripts/page-issues/page/PageIssueLearnMoreLink.js",
"resources/skins.minerva.scripts/page-issues/page/PageIssueLink.js",
"resources/skins.minerva.scripts/page-issues/page/pageIssueFormatter.js",
"resources/skins.minerva.scripts/page-issues/index.js",
"resources/skins.minerva.scripts/UriUtil.js",
"resources/skins.minerva.scripts/TitleUtil.js",
"tests/qunit/skins.minerva.scripts/downloadPageAction.test.js",
"tests/qunit/skins.minerva.scripts/page-issues/parser.test.js",
"tests/qunit/skins.minerva.scripts/AB.test.js",
"tests/qunit/skins.minerva.scripts/page-issues/index.test.js",
"tests/qunit/skins.minerva.scripts/UriUtil.test.js",
Echo is removed from Minerva Managing the transition from old implementation to new: * A version number is exported from skins.minerva.scripts to tell dormant code added to Echo in I09c27a084100b223662f84de6cbe01bebe1fe774 to begin running. * A skinStyle is added for the new `ext.echo.mobile` module. `mobile.notifications.overlay` will soon cease to exist but is kept registered for backwards compatibility reasons - Drop ev.preventDefault call from onSkinClick - it is no longer necessary and will ensure notifications overlay closes when shield is clicked while it is open. Integration: * A server side hook SkinMinervaReplaceNotificationsBadge allows Echo to replace the current Minerva notification badge * A to-be-created client side hook is subscribed to to deal with the navigations drawer like functionality using the mainMenu code * id and class names are added to the container for the NotificationBadge for compatibility with ext.echo.init in Minerva's desktop mode (it will work like Vector) See I09c27a084100b223662f84de6cbe01bebe1fe774 for understanding the bigger picture. Depends-On: I09c27a084100b223662f84de6cbe01bebe1fe774 Bug: T221007 Change-Id: I4c11f1b241d629e1b294ebaec17472fbf944f8c7
2019-10-01 21:40:49 +00:00
"tests/qunit/skins.minerva.scripts/TitleUtil.test.js"
Migrate from onResourceLoaderTestModules to QUnitTestModule The hook is deprecated as of this release cycle, see: <https://www.mediawiki.org/wiki/Manual:Hooks/ResourceLoaderTestModules>. Moving away from PHP code. This can now be done from JSON, and encourages use of a single module that is automatically named and registered as needed. Change-Id: I382692c70ca8e5f5ea658b07ebea6c47dd541724
2019-09-20 20:50:23 +00:00
]
},
Use MediaWikiServices to cache commonly used helpers SkinMinerva cached the ContentHandler object for better performance. In the future the ContentHandler will be also used in the Menu, for better readability, store ContentHandler as Service. MediaWikiServices will initialize service on first access and cache it for future needs. Same applies to SkinUserPageHelper, Bug: T216152 Change-Id: Ia98dc860862360a68556272714669f0c3a13eb1e
2019-04-10 12:52:34 +00:00
"ServiceWiringFiles": [
"includes/ServiceWiring.php"
],
Upgrade skin.json schema to manifest_version 2 Bug: T242505 Change-Id: Iccc217fe695270c5a04811fdca5bd65c26ae6609
2020-01-11 04:31:33 +00:00
"manifest_version": 2
Use a Drawer for Block Notices When a user is blocked, the toast message provides insufficent information to the user. To provide more information, as well as a better design, the block message will be moved into a drawer. Bug: T165535 Change-Id: Ib025db3a8a4d1fd7bd05b69f9b5326943288372f Depends-On: I926918d0bd7f2176f188a2154dc5e99f6a8a7ad1
2018-04-14 17:54:25 +00:00
}
Reference in a new issue Copy permalink