wikimedia/mediawiki-skins-MinervaNeue
1
0
Fork 0
mirror of https://gerrit.wikimedia.org/r/mediawiki/skins/MinervaNeue synced 2024-11-23 22:03:39 +00:00
Code Issues Packages Projects Releases Wiki Activity
mediawiki-skins-MinervaNeue/skin.json

673 lines
16 KiB
JSON
Raw Normal View History

Add scaffolding for skin Change-Id: Ie9420dc85f658fa21a1524dca9374cb1e14fcad7
2017-04-11 02:30:17 +00:00
{
Move skin metadata keys to top of skin.json The keys that form the credits (name/description/url/etc.) are usually on top, and manifest_version is typically on the bottom. Change-Id: I1767b1e176c9cf892c1f627db4f5891fa6aade18
2018-05-08 01:19:40 +00:00
"name": "MinervaNeue",
"namemsg": "skinname-minerva",
"descriptionmsg": "minerva-skin-desc",
Set some authors inside Minerva Apologies in advance if any unintentional hurt feelings! This is based on a git blame of the skins directory in I985c4e3a88b59461d471945ccf74cd291db45a61 before the Minerva move and consulting the extension.json of MobileFrontend. I've listed anyone with over 100 commits to the MobileFrontend resources/ skins folder as an author. The Readers Web Team as the current maintainers are listed first. If you feel you should be listed as an author of this skin as someone who has contributed more than 100 commits to the skin code (not MobileFrontend code), apologies and please add yourself. Change-Id: Ifffb07d1decb47a5e08b9c45c88ccf106f0797a1
2018-07-24 11:26:36 +00:00
"author": [
Update link target of the team page Link redirected on mediawiki.org Change-Id: Icdd1ffdb7b60d5030a29fa24d2ad5b8e10d4975c
2022-08-05 12:54:00 +00:00
"[https://www.mediawiki.org/wiki/Readers/Web/Team Readers Web Team]",
Update Minerva's contributors I want to reflect the contributions of the existing members of the team that maintain the skin. All the added names are listed as the main contributors on the github with consistent contributions of at least 2 years https://github.com/wikimedia/mediawiki-skins-MinervaNeue/graphs/contributors Alex has overseen much of the effort in our mobile skin over the recent years Although we don't traditionally add designers to the authors section I think it makes sense that he should be listed. Change-Id: Ia2a37a6988a2712151ae0c21f9e31a11310a8a53
2020-05-06 16:54:44 +00:00
"Alex Hollender",
Set some authors inside Minerva Apologies in advance if any unintentional hurt feelings! This is based on a git blame of the skins directory in I985c4e3a88b59461d471945ccf74cd291db45a61 before the Minerva move and consulting the extension.json of MobileFrontend. I've listed anyone with over 100 commits to the MobileFrontend resources/ skins folder as an author. The Readers Web Team as the current maintainers are listed first. If you feel you should be listed as an author of this skin as someone who has contributed more than 100 commits to the skin code (not MobileFrontend code), apologies and please add yourself. Change-Id: Ifffb07d1decb47a5e08b9c45c88ccf106f0797a1
2018-07-24 11:26:36 +00:00
"Bahodir Mansurov",
Update Minerva's contributors I want to reflect the contributions of the existing members of the team that maintain the skin. All the added names are listed as the main contributors on the github with consistent contributions of at least 2 years https://github.com/wikimedia/mediawiki-skins-MinervaNeue/graphs/contributors Alex has overseen much of the effort in our mobile skin over the recent years Although we don't traditionally add designers to the authors section I think it makes sense that he should be listed. Change-Id: Ia2a37a6988a2712151ae0c21f9e31a11310a8a53
2020-05-06 16:54:44 +00:00
"Florian Schmidt",
"Jan Drewniak",
Set some authors inside Minerva Apologies in advance if any unintentional hurt feelings! This is based on a git blame of the skins directory in I985c4e3a88b59461d471945ccf74cd291db45a61 before the Minerva move and consulting the extension.json of MobileFrontend. I've listed anyone with over 100 commits to the MobileFrontend resources/ skins folder as an author. The Readers Web Team as the current maintainers are listed first. If you feel you should be listed as an author of this skin as someone who has contributed more than 100 commits to the skin code (not MobileFrontend code), apologies and please add yourself. Change-Id: Ifffb07d1decb47a5e08b9c45c88ccf106f0797a1
2018-07-24 11:26:36 +00:00
"Joaquin Hernandez",
"Jon Robson",
"Juliusz Gonera",
Update Minerva's contributors I want to reflect the contributions of the existing members of the team that maintain the skin. All the added names are listed as the main contributors on the github with consistent contributions of at least 2 years https://github.com/wikimedia/mediawiki-skins-MinervaNeue/graphs/contributors Alex has overseen much of the effort in our mobile skin over the recent years Although we don't traditionally add designers to the authors section I think it makes sense that he should be listed. Change-Id: Ia2a37a6988a2712151ae0c21f9e31a11310a8a53
2020-05-06 16:54:44 +00:00
"Piotr Miazga",
Set some authors inside Minerva Apologies in advance if any unintentional hurt feelings! This is based on a git blame of the skins directory in I985c4e3a88b59461d471945ccf74cd291db45a61 before the Minerva move and consulting the extension.json of MobileFrontend. I've listed anyone with over 100 commits to the MobileFrontend resources/ skins folder as an author. The Readers Web Team as the current maintainers are listed first. If you feel you should be listed as an author of this skin as someone who has contributed more than 100 commits to the skin code (not MobileFrontend code), apologies and please add yourself. Change-Id: Ifffb07d1decb47a5e08b9c45c88ccf106f0797a1
2018-07-24 11:26:36 +00:00
"Ryan Kaldari",
Update Minerva's contributors I want to reflect the contributions of the existing members of the team that maintain the skin. All the added names are listed as the main contributors on the github with consistent contributions of at least 2 years https://github.com/wikimedia/mediawiki-skins-MinervaNeue/graphs/contributors Alex has overseen much of the effort in our mobile skin over the recent years Although we don't traditionally add designers to the authors section I think it makes sense that he should be listed. Change-Id: Ia2a37a6988a2712151ae0c21f9e31a11310a8a53
2020-05-06 16:54:44 +00:00
"Nick Ray",
"Sam Smith",
"Stephen Niedzielski",
"Volker E."
Set some authors inside Minerva Apologies in advance if any unintentional hurt feelings! This is based on a git blame of the skins directory in I985c4e3a88b59461d471945ccf74cd291db45a61 before the Minerva move and consulting the extension.json of MobileFrontend. I've listed anyone with over 100 commits to the MobileFrontend resources/ skins folder as an author. The Readers Web Team as the current maintainers are listed first. If you feel you should be listed as an author of this skin as someone who has contributed more than 100 commits to the skin code (not MobileFrontend code), apologies and please add yourself. Change-Id: Ifffb07d1decb47a5e08b9c45c88ccf106f0797a1
2018-07-24 11:26:36 +00:00
],
Move skin metadata keys to top of skin.json The keys that form the credits (name/description/url/etc.) are usually on top, and manifest_version is typically on the bottom. Change-Id: I1767b1e176c9cf892c1f627db4f5891fa6aade18
2018-05-08 01:19:40 +00:00
"type": "skin",
"url": "https://www.mediawiki.org/wiki/Skin:MinervaNeue",
"license-name": "GPL-2.0-or-later",
"requires": {
build: Update MediaWiki requirement to 1.43 All skins in the MediaWiki tarball are expected to track MediaWiki's release directly. Change-Id: I40e986b853a3aa24d2021de51d7487ca9a78b1fe
2024-08-22 23:16:47 +00:00
"MediaWiki": ">= 1.43"
Move skin metadata keys to top of skin.json The keys that form the credits (name/description/url/etc.) are usually on top, and manifest_version is typically on the bottom. Change-Id: I1767b1e176c9cf892c1f627db4f5891fa6aade18
2018-05-08 01:19:40 +00:00
},
"config": {
Mobile web donate link Add the Donate link with a heart icon in Mobile menu. Bug: T219793 Change-Id: I65d1d7408e2df7b3ae307736ac6d498b1d7f7197
2020-06-17 18:07:02 +00:00
"MinervaDonateLink": {
Donate link should be in a separate group in main menu Bug: T219793 Change-Id: I7501c87eaa799e4c8a9052f5e3f650a89f376d1b
2020-06-25 21:06:46 +00:00
"value": {
Donate link is disabled by default for 3rd parties Bug: T191743 Change-Id: I2b57cd3fa270fab1385319f2cbd33e886ae33843
2021-12-10 19:21:14 +00:00
"base": false
Donate link should be in a separate group in main menu Bug: T219793 Change-Id: I7501c87eaa799e4c8a9052f5e3f650a89f376d1b
2020-06-25 21:06:46 +00:00
}
Mobile web donate link Add the Donate link with a heart icon in Mobile menu. Bug: T219793 Change-Id: I65d1d7408e2df7b3ae307736ac6d498b1d7f7197
2020-06-17 18:07:02 +00:00
},
Upgrade skin.json schema to manifest_version 2 Bug: T242505 Change-Id: Iccc217fe695270c5a04811fdca5bd65c26ae6609
2020-01-11 04:31:33 +00:00
"MinervaDownloadNamespaces": {
"value": [
0
]
},
Revert "Drop MinervaEnableSiteNotice" This reverts commit 33e5c1eb79868d799abffc0ba032f2b6369e6209. I talked to Gergo (tgr) about this and he's convinced me that probably I want to be more conservative and incremently roll the sitenotices out first. With that in mind I'm going to revert this change and do a config flag instead. Bug: T254391 Change-Id: If0f214d23a012fb4ae3e1dff1728f746a22f142a
2020-06-04 22:39:36 +00:00
"MinervaEnableSiteNotice": {
Change default of showing sitenotices to true Wikimedia-related configuration (false) now lives in mediawiki-config which allows us to move this value to the default of true, which should fit most other wikis better. Change-Id: I8060ed5e67370e35f7552b3191f2864fbeb6418e
2020-12-01 22:18:44 +00:00
"value": true
Revert "Drop MinervaEnableSiteNotice" This reverts commit 33e5c1eb79868d799abffc0ba032f2b6369e6209. I talked to Gergo (tgr) about this and he's convinced me that probably I want to be more conservative and incremently roll the sitenotices out first. With that in mind I'm going to revert this change and do a config flag instead. Bug: T254391 Change-Id: If0f214d23a012fb4ae3e1dff1728f746a22f142a
2020-06-04 22:39:36 +00:00
},
Upgrade skin.json schema to manifest_version 2 Bug: T242505 Change-Id: Iccc217fe695270c5a04811fdca5bd65c26ae6609
2020-01-11 04:31:33 +00:00
"MinervaAlwaysShowLanguageButton": {
"value": true
},
Talk tabs in AMC mode A new feature/skin option is added that is enabled safely inside a MobileFrontend available/unavailable hook that changes the skin to place talk tabs at the top of the page. These new talk tabs purposely show on the main page, user page and standard pages and do not show on special pages. Depends-On: Ie1a583657176acc6f7046c569c2e94fa2f72ff93 Bug: T212216 Change-Id: I57b70cd325666a287678dc897159b5bf9d089b78
2019-01-10 22:59:56 +00:00
"MinervaTalkAtTop": {
Upgrade skin.json schema to manifest_version 2 Bug: T242505 Change-Id: Iccc217fe695270c5a04811fdca5bd65c26ae6609
2020-01-11 04:31:33 +00:00
"value": {
"base": false,
"beta": false,
"loggedin": true
}
Talk tabs in AMC mode A new feature/skin option is added that is enabled safely inside a MobileFrontend available/unavailable hook that changes the skin to place talk tabs at the top of the page. These new talk tabs purposely show on the main page, user page and standard pages and do not show on special pages. Depends-On: Ie1a583657176acc6f7046c569c2e94fa2f72ff93 Bug: T212216 Change-Id: I57b70cd325666a287678dc897159b5bf9d089b78
2019-01-10 22:59:56 +00:00
},
Feature flag overhaul Two new feature flags: 1) MinervaPersonalMenu 2) MinervaAdvancedMainMenu Changes: * AMC defaults to false on desktop - desktop doesn't have AMC mode it just enables several skin options. * WHen inserting a link at the bottom of the page check whether the talk at top of the page (tabs) is enabled.. not AMC * Update ServiceWiring to construct menu based on MinervaAdvancedMainMenu and MinervaPersonalMenu - note when former is enabled but not latter there is no way to logout. Noted in README. * Use one entry point for skins.minerva.amc.styles/index.less * Document files inside skins.minerva.amc.styles to make it clear which features they are associated with * Drop history page styles when AMC is disabled - it's not possible to ever get to these as the history page redirects in non-AMC mode * Rename the class .minerva--amc-enabled to minerva--history-page-action-enabled to reflect its real purpose and move styles from skins.minerva.base.styles to skins.minerva.amc.styles No need to worry about cached HTML as AMC runs without cache... * Remove isAnyAMCOptionEnabled - it's an antipattern and should be discouraged as it discourages the art of feature flagging. Nothing is using it after these changes. * The AMC_MODE flag is disabled. There is no need for this - AMC is not a feature and therefore not a skin option. It is a mechanism for turning on other skin options. Tests are updated. Testing: It should now be possible to enable any feature in `beta` and see it in the beta of the site. Bug: T229295 Change-Id: I48959905f5c09721b14a27aa1a5ad82849ac6263
2019-08-22 20:31:31 +00:00
"MinervaAdvancedMainMenu": {
Upgrade skin.json schema to manifest_version 2 Bug: T242505 Change-Id: Iccc217fe695270c5a04811fdca5bd65c26ae6609
2020-01-11 04:31:33 +00:00
"value": {
"base": false,
"beta": false,
"amc": true
}
Feature flag overhaul Two new feature flags: 1) MinervaPersonalMenu 2) MinervaAdvancedMainMenu Changes: * AMC defaults to false on desktop - desktop doesn't have AMC mode it just enables several skin options. * WHen inserting a link at the bottom of the page check whether the talk at top of the page (tabs) is enabled.. not AMC * Update ServiceWiring to construct menu based on MinervaAdvancedMainMenu and MinervaPersonalMenu - note when former is enabled but not latter there is no way to logout. Noted in README. * Use one entry point for skins.minerva.amc.styles/index.less * Document files inside skins.minerva.amc.styles to make it clear which features they are associated with * Drop history page styles when AMC is disabled - it's not possible to ever get to these as the history page redirects in non-AMC mode * Rename the class .minerva--amc-enabled to minerva--history-page-action-enabled to reflect its real purpose and move styles from skins.minerva.base.styles to skins.minerva.amc.styles No need to worry about cached HTML as AMC runs without cache... * Remove isAnyAMCOptionEnabled - it's an antipattern and should be discouraged as it discourages the art of feature flagging. Nothing is using it after these changes. * The AMC_MODE flag is disabled. There is no need for this - AMC is not a feature and therefore not a skin option. It is a mechanism for turning on other skin options. Tests are updated. Testing: It should now be possible to enable any feature in `beta` and see it in the beta of the site. Bug: T229295 Change-Id: I48959905f5c09721b14a27aa1a5ad82849ac6263
2019-08-22 20:31:31 +00:00
},
"MinervaPersonalMenu": {
Upgrade skin.json schema to manifest_version 2 Bug: T242505 Change-Id: Iccc217fe695270c5a04811fdca5bd65c26ae6609
2020-01-11 04:31:33 +00:00
"value": {
"base": false,
"beta": false,
"amc": true
}
Feature flag overhaul Two new feature flags: 1) MinervaPersonalMenu 2) MinervaAdvancedMainMenu Changes: * AMC defaults to false on desktop - desktop doesn't have AMC mode it just enables several skin options. * WHen inserting a link at the bottom of the page check whether the talk at top of the page (tabs) is enabled.. not AMC * Update ServiceWiring to construct menu based on MinervaAdvancedMainMenu and MinervaPersonalMenu - note when former is enabled but not latter there is no way to logout. Noted in README. * Use one entry point for skins.minerva.amc.styles/index.less * Document files inside skins.minerva.amc.styles to make it clear which features they are associated with * Drop history page styles when AMC is disabled - it's not possible to ever get to these as the history page redirects in non-AMC mode * Rename the class .minerva--amc-enabled to minerva--history-page-action-enabled to reflect its real purpose and move styles from skins.minerva.base.styles to skins.minerva.amc.styles No need to worry about cached HTML as AMC runs without cache... * Remove isAnyAMCOptionEnabled - it's an antipattern and should be discouraged as it discourages the art of feature flagging. Nothing is using it after these changes. * The AMC_MODE flag is disabled. There is no need for this - AMC is not a feature and therefore not a skin option. It is a mechanism for turning on other skin options. Tests are updated. Testing: It should now be possible to enable any feature in `beta` and see it in the beta of the site. Bug: T229295 Change-Id: I48959905f5c09721b14a27aa1a5ad82849ac6263
2019-08-22 20:31:31 +00:00
},
Add config option for showing history link in page actions menu Bug: T213352 Change-Id: I6a53a7303434b0fd374bc5b6ea2dbc8e760807e6
2019-03-07 20:50:57 +00:00
"MinervaHistoryInPageActions": {
Upgrade skin.json schema to manifest_version 2 Bug: T242505 Change-Id: Iccc217fe695270c5a04811fdca5bd65c26ae6609
2020-01-11 04:31:33 +00:00
"value": {
"base": false,
"beta": false,
"loggedin": true
}
Add config option for showing history link in page actions menu Bug: T213352 Change-Id: I6a53a7303434b0fd374bc5b6ea2dbc8e760807e6
2019-03-07 20:50:57 +00:00
},
Update: add secondary page actions submenu in AMC mode When advanced mobile contributions mode is enabled and `$wgMinervaOverflowInPageActions` is set, show a secondary overflow menu on main namespace articles and user namespace pages. The menu content varies for each namespace. The new submenu is *disabled* by default, even when AMC is active. This feature should not be deployed until instrumentation is available. The secondary menu is rendered in PHP using the existing menu system with some changes to the template. The checkbox hack is needed for no- JavaScript keyboard navigation until :focus-within is supported. CSS additions are documented in the source. All client side toolbar execution occurs in Toolbar.js. Enhancements are documented in the source. Minor changes to the existing download button: - Move download and edit button initialization to Toolbar. - Update copy (not visible) from "Download" to "Download PDF". - When the overflow menu is present, use the "hasText" / label style. Wikimedia UI icons are copied from OOUI at d00a0ac and seem useful to expose as HTTP URIs (not data URIs). The overflow menu does not show for pages provided by the content proxy since its entries depend on $tpl->data['nav_urls'] being populated. Bug: T216418 Depends-On: I0781151a8232b6a7b52f79a34298afcecb8e4271 Change-Id: I4b50a0e519024a7ab91dae6ab40b23cf14a03861
2019-04-04 21:20:39 +00:00
"MinervaOverflowInPageActions": {
Upgrade skin.json schema to manifest_version 2 Bug: T242505 Change-Id: Iccc217fe695270c5a04811fdca5bd65c26ae6609
2020-01-11 04:31:33 +00:00
"value": {
"base": false,
"beta": false,
skin.json: Add value to MinervaOverflowInPageActions Added the loggedin value to MinervaOverflowInPageActions to enable the overflow menu for all logged in users. Bug: T308675 Change-Id: Ic19308c423efc40c70490fed474bee69f1972bca
2022-05-31 18:03:51 +00:00
"amc": true,
"loggedin": true
Upgrade skin.json schema to manifest_version 2 Bug: T242505 Change-Id: Iccc217fe695270c5a04811fdca5bd65c26ae6609
2020-01-11 04:31:33 +00:00
}
Update: add secondary page actions submenu in AMC mode When advanced mobile contributions mode is enabled and `$wgMinervaOverflowInPageActions` is set, show a secondary overflow menu on main namespace articles and user namespace pages. The menu content varies for each namespace. The new submenu is *disabled* by default, even when AMC is active. This feature should not be deployed until instrumentation is available. The secondary menu is rendered in PHP using the existing menu system with some changes to the template. The checkbox hack is needed for no- JavaScript keyboard navigation until :focus-within is supported. CSS additions are documented in the source. All client side toolbar execution occurs in Toolbar.js. Enhancements are documented in the source. Minor changes to the existing download button: - Move download and edit button initialization to Toolbar. - Update copy (not visible) from "Download" to "Download PDF". - When the overflow menu is present, use the "hasText" / label style. Wikimedia UI icons are copied from OOUI at d00a0ac and seem useful to expose as HTTP URIs (not data URIs). The overflow menu does not show for pages provided by the content proxy since its entries depend on $tpl->data['nav_urls'] being populated. Bug: T216418 Depends-On: I0781151a8232b6a7b52f79a34298afcecb8e4271 Change-Id: I4b50a0e519024a7ab91dae6ab40b23cf14a03861
2019-04-04 21:20:39 +00:00
},
Replace categories button with HTML rendering Bug: T246049 Change-Id: Id8c7493a525844b43c1628a1f4f09ae716ece2ba
2021-04-28 21:58:51 +00:00
"MinervaShowCategories": {
Upgrade skin.json schema to manifest_version 2 Bug: T242505 Change-Id: Iccc217fe695270c5a04811fdca5bd65c26ae6609
2020-01-11 04:31:33 +00:00
"value": {
"base": false,
Category feature not ready for logged in users When removing the category overlay this for AMC as part of Id8c7493a525844b43c1628a1f4f09ae716ece2ba the feature was enabled for logged in users unintentionally. Bug: T246049 Change-Id: I1be90b22afa1f6ad5094131485b38253d422cb11
2021-06-21 20:57:12 +00:00
"loggedin": false,
Upgrade skin.json schema to manifest_version 2 Bug: T242505 Change-Id: Iccc217fe695270c5a04811fdca5bd65c26ae6609
2020-01-11 04:31:33 +00:00
"amc": true
}
Move skin metadata keys to top of skin.json The keys that form the credits (name/description/url/etc.) are usually on top, and manifest_version is typically on the bottom. Change-Id: I1767b1e176c9cf892c1f627db4f5891fa6aade18
2018-05-08 01:19:40 +00:00
},
page issues is feature flagged * New feature/skin option is added and value is read inside the pageIssues setup code * issues-group-a class is added to page on server side to remove the flash of unstyled content * issues-group-A class is dropped (it's not doing anything!) * The minerva-issues flag will now accept any value to avoid confusion. It is used to override the default setting of wgMinervaPageIssuesNewTreatment A note has been added that this can be removed in future. Bug: T206179 Change-Id: I3d98fd8f8e1adc818ea03589d2c8f68fe991e861
2018-11-12 20:32:28 +00:00
"MinervaPageIssuesNewTreatment": {
Upgrade skin.json schema to manifest_version 2 Bug: T242505 Change-Id: Iccc217fe695270c5a04811fdca5bd65c26ae6609
2020-01-11 04:31:33 +00:00
"value": {
"base": true,
"beta": true
}
page issues is feature flagged * New feature/skin option is added and value is read inside the pageIssues setup code * issues-group-a class is added to page on server side to remove the flash of unstyled content * issues-group-A class is dropped (it's not doing anything!) * The minerva-issues flag will now accept any value to avoid confusion. It is used to override the default setting of wgMinervaPageIssuesNewTreatment A note has been added that this can be removed in future. Bug: T206179 Change-Id: I3d98fd8f8e1adc818ea03589d2c8f68fe991e861
2018-11-12 20:32:28 +00:00
},
Upgrade skin.json schema to manifest_version 2 Bug: T242505 Change-Id: Iccc217fe695270c5a04811fdca5bd65c26ae6609
2020-01-11 04:31:33 +00:00
"MinervaABSamplingRate": {
"value": 0
Add feature flag for night mode Adds a config flag, `MinervaNightMode`, and wires it up as a skin option for enabling/disabling the night mode toggle (sold separately) Additionally, allow this feature to be enabled via the `minervanightmode` query param For now, turning the flag on will result in the class `skin-nightmode-clientpref-1` being added to the HTML element, but in a later change this will be updated to switch values based on the forthcoming client pref Bug: T355118 Change-Id: I35848ab80ee75d324ceb35d17794e2d3e620cc19
2024-01-30 19:21:36 +00:00
},
"MinervaNightMode": {
"value": {
[Config] Reflect production defaults for night mode Night mode is currently enabled on AMC on all wikis so let's match that locally for development. Change-Id: I5d86d8ae27f4a7bccfdd6106ac20affba3e8e216
2024-05-17 23:11:53 +00:00
"base": false,
"loggedin": false,
"amc": true
Add feature flag for night mode Adds a config flag, `MinervaNightMode`, and wires it up as a skin option for enabling/disabling the night mode toggle (sold separately) Additionally, allow this feature to be enabled via the `minervanightmode` query param For now, turning the flag on will result in the class `skin-nightmode-clientpref-1` being added to the HTML element, but in a later change this will be updated to switch values based on the forthcoming client pref Bug: T355118 Change-Id: I35848ab80ee75d324ceb35d17794e2d3e620cc19
2024-01-30 19:21:36 +00:00
}
Allow pages to not appear in night mode - Add config to skin.json - Add the function in SkinMinerva.php to check exclusion of pages and namespaces. Bug: T355705 Change-Id: I0fa0eab3bfa57cc6864dbdd2d6aeaa5582767c3c
2024-02-06 22:26:55 +00:00
},
"MinervaNightModeOptions": {
"value": {
"exclude": {
"mainpage": false,
Restore night mode on history and diff pages Follow up to I0fa0eab3bfa57cc6864dbdd2d6aeaa5582767c3c Initially we want to enable night mode on all pages This config should therefore not apply to any pages initially. Bug: T355705 Change-Id: I2ca6d4a971d00d163fa82e93ac99959e41c87b91
2024-02-08 22:48:35 +00:00
"querystring": {},
Allow pages to not appear in night mode - Add config to skin.json - Add the function in SkinMinerva.php to check exclusion of pages and namespaces. Bug: T355705 Change-Id: I0fa0eab3bfa57cc6864dbdd2d6aeaa5582767c3c
2024-02-06 22:26:55 +00:00
"namespaces": [],
"pagetitles": []
}
},
feature(Minerva): Standardises terminology to 'Dark Mode' This update standardises the terminology from 'Night Mode' to 'Dark Mode' across interface messages. This change aligns with common terminology used in the industry. Changes: - `i18n/qqq.json`: Updated the term in the description of `skin-minerva-night-mode-unavailable` to 'Dark Mode'. - `skin.json`: Revised the description under the dark mode configuration section to use 'Dark Mode' instead of 'Night Mode', ensuring clarity and uniformity in our settings documentation. Additional Context: - This patch is not as critical as the Vector patch Bug: T361157 Change-Id: Ib6261b329f4cb5c466893c22b225d97e627f4aee
2024-04-24 15:37:34 +00:00
"description": "options for configuring where Dark/Night Mode should and should not apply. More details can be found in Hooks::shouldDisableNightMode PHP documentation."
Upgrade skin.json schema to manifest_version 2 Bug: T242505 Change-Id: Iccc217fe695270c5a04811fdca5bd65c26ae6609
2020-01-11 04:31:33 +00:00
}
Move skin metadata keys to top of skin.json The keys that form the credits (name/description/url/etc.) are usually on top, and manifest_version is typically on the bottom. Change-Id: I1767b1e176c9cf892c1f627db4f5891fa6aade18
2018-05-08 01:19:40 +00:00
},
"ValidSkinNames": {
Improve support in Minerva for addPortletLink * Use skin registration and set skin options as and when needed * Set link text-wrapper * Simplify addPortletLink hook * Update modifications to apply to items added prior to the hook Bug: T240910 Change-Id: Ic806adf3de6490ba9da11e8968a61b3d0acd93bc
2021-09-23 19:47:46 +00:00
"minerva": {
Namespace SkinMinerva Change-Id: I8f6bddac9f8cd060c551651e711ee987b8bbfbe3
2022-03-04 16:40:54 +00:00
"class": "MediaWiki\\Minerva\\Skins\\SkinMinerva",
Inject services in SkinMinerva Change-Id: I17ae52ab9bb251a501d9de38f8a7051118f9622e
2024-02-29 20:35:21 +00:00
"services": [
"GenderCache",
"LinkRenderer",
Inject service 'Minerva.LanguagesHelper' into SkinMinerva Change-Id: Ie81195f31194bab819491576681b02660ec057b4
2024-03-24 09:01:40 +00:00
"Minerva.LanguagesHelper",
Integrate service 'Minerva.Menu.UserMenuDirector' into SkinMinerva The service 'Minerva.Menu.UserMenuDirector' is bad because it depends on the global state. Change-Id: Ife13188745b39844356e7976379582d5f451f5a3
2024-03-24 15:08:11 +00:00
"Minerva.Menu.Definitions",
Migrate service 'Minerva.Menu.PageActionsDirector' into new class PageActions The service 'Minerva.Menu.PageActionsDirector' is bad because it depends on the global state. Create a new service 'Minerva.Menu.PageActions' and inject this. Change-Id: Ie84d02ef29d3b7809f490a1593cb2f3cef60b3a3
2024-05-19 12:30:25 +00:00
"Minerva.Menu.PageActions",
Inject service 'Minerva.Permissions' into SkinMinerva Change-Id: Ie68691d7030ea622f2bc232fea2df49b70484e19
2024-03-23 19:16:47 +00:00
"Minerva.Permissions",
Inject service 'Minerva.SkinOptions' into SkinMinerva Change-Id: Ia7e7660c55e16731366bdf6332d5237188e9bbb1
2024-03-23 17:20:57 +00:00
"Minerva.SkinOptions",
Inject service 'Minerva.SkinUserPageHelper' Change-Id: I91d8066ea860bd4aa5f19f4c326fad032be5b9d0
2024-03-24 10:49:33 +00:00
"Minerva.SkinUserPageHelper",
Inject services in SkinMinerva Change-Id: I17ae52ab9bb251a501d9de38f8a7051118f9622e
2024-02-29 20:35:21 +00:00
"NamespaceInfo",
"RevisionLookup",
Integrate service 'Minerva.Menu.MainDirector' into SkinMinerva The service 'Minerva.Menu.MainDirector' is bad because it depends on the global state. Change-Id: I170653006356932ecdd909b14c193f42c4a5f511
2024-03-25 09:54:20 +00:00
"UserIdentityUtils",
Inject services in SkinMinerva Change-Id: I17ae52ab9bb251a501d9de38f8a7051118f9622e
2024-02-29 20:35:21 +00:00
"UserOptionsManager"
],
Update UserOptionsLookup's FQN User-options related classes are being moved to the MediaWiki\User\Options namespace in MediaWiki Core; reflect that change here. Bug: T352284 Depends-On: I9822eb1553870b876d0b8a927e4e86c27d83bd52 Change-Id: I5a540772aafd2c4686e02f748b5fc61155920397
2023-11-29 12:41:59 +00:00
"args": [
{
"name": "minerva",
Indicate support for new heading HTML Add `"supportsMwHeading": true` to the skin definition, so that MediaWiki 1.43+ will output new heading markup when using this skin. https://www.mediawiki.org/wiki/Heading_HTML_changes The required CSS changes were already made in commit 97aed1ad86d1bf2c9789266b8d11d0aa2491be62. Bug: T365736 Change-Id: I6f050ac65e131fa946754f6d6cfe42c77175cbb2
2024-04-20 02:37:49 +00:00
"supportsMwHeading": true,
Update UserOptionsLookup's FQN User-options related classes are being moved to the MediaWiki\User\Options namespace in MediaWiki Core; reflect that change here. Bug: T352284 Depends-On: I9822eb1553870b876d0b8a927e4e86c27d83bd52 Change-Id: I5a540772aafd2c4686e02f748b5fc61155920397
2023-11-29 12:41:59 +00:00
"templateDirectory": "includes/Skins",
"templateSectionLinks": "SectionLinks",
"tempUserBanner": true,
Wrap sitenotices in core Depends-On: Ib48b1f54c326a0363841b2f592d8fd4cf7312b9b Bug: T361966 Change-Id: I28255d9630d2d69ace28fde1954f2a5811feae2a
2024-04-25 00:09:54 +00:00
"wrapSiteNotice": true,
Replace codex-search-styles with CodexModule Enhance MinervaNeue Skin with Codex Integration and Style Refinements. This update to the MinervaNeue skin introduces enhancements aimed at integrating with Codex UI components and the optimisation of skin-specific styles. These changes are in direct response to the objectives set forth in Phabricator task T356678, focusing on modernising the skin's aesthetics and functionality. Changes: - Enhanced skin.json to include new 'scripts' and 'styles' configurations, incorporating Codex UI components such as 'CdxButton' and a variety of Minerva-specific styles like 'skins.minerva.base.styles' and 'skins.minerva.content.styles.images'. - Refined `includes/Skins/SkinMinerva.php` by restructuring the method of loading skin and feature-specific styles. The update simplifies style management, allowing for a more granular approach to style application. This includes separating page-specific styles from feature-specific styles. Rationale: The implementation of Codex UI components within the MinervaNeue skin is to leverage modern web design principles, enhancing usability and aesthetic appeal. By refining the skin's style loading mechanism, we aim to at least maintain if not reduce the overhead, improve page load times, and offer a more customisable appearance, ultimately benefiting both end-users and developers. Bug: T356678 Change-Id: Ia96f58397c23126e940cc9263b30e0da88c90a29
2024-04-03 12:48:52 +00:00
"scripts": [
"skins.minerva.scripts"
],
"styles": [
Create new skins.minerva.styles module This merges the existing modules skins.minerva.base.styles and skins.minerva.mainMenu.styles into a new module skins.minerva.styles which is named consistently with Vector's style module. The old modules will be kept for caching reasons for at least one, and possibly two deploy cycles, after which we will continue this task. Additional change: * drop .minerva-icon--{name}-base20 and .minerva-icon--{name}-disabled variants since these are no longer utilized and only serve cached HTML Bug: T266361 Change-Id: Iccf415a22e9535603befae25b8cea467f9905437
2024-11-06 23:34:58 +00:00
"skins.minerva.styles",
Replace codex-search-styles with CodexModule Enhance MinervaNeue Skin with Codex Integration and Style Refinements. This update to the MinervaNeue skin introduces enhancements aimed at integrating with Codex UI components and the optimisation of skin-specific styles. These changes are in direct response to the objectives set forth in Phabricator task T356678, focusing on modernising the skin's aesthetics and functionality. Changes: - Enhanced skin.json to include new 'scripts' and 'styles' configurations, incorporating Codex UI components such as 'CdxButton' and a variety of Minerva-specific styles like 'skins.minerva.base.styles' and 'skins.minerva.content.styles.images'. - Refined `includes/Skins/SkinMinerva.php` by restructuring the method of loading skin and feature-specific styles. The update simplifies style management, allowing for a more granular approach to style application. This includes separating page-specific styles from feature-specific styles. Rationale: The implementation of Codex UI components within the MinervaNeue skin is to leverage modern web design principles, enhancing usability and aesthetic appeal. By refining the skin's style loading mechanism, we aim to at least maintain if not reduce the overhead, improve page load times, and offer a more customisable appearance, ultimately benefiting both end-users and developers. Bug: T356678 Change-Id: Ia96f58397c23126e940cc9263b30e0da88c90a29
2024-04-03 12:48:52 +00:00
"skins.minerva.content.styles.images",
"mediawiki.hlist",
"skins.minerva.codex.styles",
Merge Icon Style mergeIconStyleModules Merging skins.minerva.icons.wikimedia and skins.minerva.mainMenu.icons modules into skins.minerva.icons Bug: T266361 Change-Id: I4095da5a0c6d2cff8ccd1ff1504a2d54635d1828
2024-11-12 21:43:33 +00:00
"skins.minerva.icons"
Replace codex-search-styles with CodexModule Enhance MinervaNeue Skin with Codex Integration and Style Refinements. This update to the MinervaNeue skin introduces enhancements aimed at integrating with Codex UI components and the optimisation of skin-specific styles. These changes are in direct response to the objectives set forth in Phabricator task T356678, focusing on modernising the skin's aesthetics and functionality. Changes: - Enhanced skin.json to include new 'scripts' and 'styles' configurations, incorporating Codex UI components such as 'CdxButton' and a variety of Minerva-specific styles like 'skins.minerva.base.styles' and 'skins.minerva.content.styles.images'. - Refined `includes/Skins/SkinMinerva.php` by restructuring the method of loading skin and feature-specific styles. The update simplifies style management, allowing for a more granular approach to style application. This includes separating page-specific styles from feature-specific styles. Rationale: The implementation of Codex UI components within the MinervaNeue skin is to leverage modern web design principles, enhancing usability and aesthetic appeal. By refining the skin's style loading mechanism, we aim to at least maintain if not reduce the overhead, improve page load times, and offer a more customisable appearance, ultimately benefiting both end-users and developers. Bug: T356678 Change-Id: Ia96f58397c23126e940cc9263b30e0da88c90a29
2024-04-03 12:48:52 +00:00
],
Update UserOptionsLookup's FQN User-options related classes are being moved to the MediaWiki\User\Options namespace in MediaWiki Core; reflect that change here. Bug: T352284 Depends-On: I9822eb1553870b876d0b8a927e4e86c27d83bd52 Change-Id: I5a540772aafd2c4686e02f748b5fc61155920397
2023-11-29 12:41:59 +00:00
"messages": [
"variants",
"mobile-frontend-languages-not-available",
"minerva-page-actions-language-switcher",
"sitetitle",
"mainpage",
"searchbutton",
"minerva-user-navigation",
"mobile-frontend-main-menu-button-tooltip",
"mobile-frontend-footer-sitename"
],
"menus": [
"notifications",
"associated-pages"
],
"clientPrefEnabled": true,
"responsive": true,
"link": {
"text-wrapper": {
"tag": "span"
}
Improve support in Minerva for addPortletLink * Use skin registration and set skin options as and when needed * Set link text-wrapper * Simplify addPortletLink hook * Update modifications to apply to items added prior to the hook Bug: T240910 Change-Id: Ic806adf3de6490ba9da11e8968a61b3d0acd93bc
2021-09-23 19:47:46 +00:00
}
}
Update UserOptionsLookup's FQN User-options related classes are being moved to the MediaWiki\User\Options namespace in MediaWiki Core; reflect that change here. Bug: T352284 Depends-On: I9822eb1553870b876d0b8a927e4e86c27d83bd52 Change-Id: I5a540772aafd2c4686e02f748b5fc61155920397
2023-11-29 12:41:59 +00:00
]
Improve support in Minerva for addPortletLink * Use skin registration and set skin options as and when needed * Set link text-wrapper * Simplify addPortletLink hook * Update modifications to apply to items added prior to the hook Bug: T240910 Change-Id: Ic806adf3de6490ba9da11e8968a61b3d0acd93bc
2021-09-23 19:47:46 +00:00
}
Move skin metadata keys to top of skin.json The keys that form the credits (name/description/url/etc.) are usually on top, and manifest_version is typically on the bottom. Change-Id: I1767b1e176c9cf892c1f627db4f5891fa6aade18
2018-05-08 01:19:40 +00:00
},
Provide a code structure for menus handling and add Advanced menu Changes: - moved all menu elements definitions from SkinMinerva into a separate Definitions.php file - moved menu building from SkinMinerva into includes/menu/Main folder - introduced Builder pattern for easy menu building Minerva/Menu/Main/Director takes an Minerva/Menu/Main/IBuilder and builds the menu. The IBuilders use definitions from Minerva/Menu/Definitions file, so all definitions can be shared across different menus - used ServiceWiring file to register MainMenu Director as Service - left class_alias for old MenuBuilder as some extensions still use it - The hooks system have to stay like that as some extensions are using it (BlueSpiceMultiUpload and GrowthExperiments). - introduced AdvancedMenu builder for the AMC mode Bug: T216152 Change-Id: I210c3f1fa36bbd2f9108d728b12cbb21ee210354
2019-04-08 17:08:57 +00:00
"AutoloadNamespaces": {
Move some more classes to AutoloadNamespaces Bug: T187154 Change-Id: Ia78f963a08cec1490aaff462b9787f7a826bf62c
2020-04-18 15:52:04 +00:00
"MediaWiki\\Minerva\\": "includes/"
Provide a code structure for menus handling and add Advanced menu Changes: - moved all menu elements definitions from SkinMinerva into a separate Definitions.php file - moved menu building from SkinMinerva into includes/menu/Main folder - introduced Builder pattern for easy menu building Minerva/Menu/Main/Director takes an Minerva/Menu/Main/IBuilder and builds the menu. The IBuilders use definitions from Minerva/Menu/Definitions file, so all definitions can be shared across different menus - used ServiceWiring file to register MainMenu Director as Service - left class_alias for old MenuBuilder as some extensions still use it - The hooks system have to stay like that as some extensions are using it (BlueSpiceMultiUpload and GrowthExperiments). - introduced AdvancedMenu builder for the AMC mode Bug: T216152 Change-Id: I210c3f1fa36bbd2f9108d728b12cbb21ee210354
2019-04-08 17:08:57 +00:00
},
Use tabs in skin.json Change-Id: I8fb66fe2f99786bfbdc598d460c18928dbb0faa0
2017-06-09 22:09:22 +00:00
"ConfigRegistry": {
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"minerva": "GlobalVarConfig::newInstance"
},
Switch to MW core hooks to HookHandlers Bug: T315823 Change-Id: I0d1eb1e2ea584904ee3a130b938bd372048a47eb
2022-08-21 17:03:43 +00:00
"HookHandlers": {
"main": {
Inject services in Hooks and MobileFrontendHooks Change-Id: I8e0673689c2dbe14a385bbd1fe1725d203386bde
2024-02-26 19:47:57 +00:00
"class": "MediaWiki\\Minerva\\Hooks",
"services": [
"ConfiguredReadOnlyMode",
Inject service Minerva.SkinOptions into Hooks and MobileFrontendHooks Change-Id: Id343ae4cb8d1a73cfb647bfe440f2909e3835037
2024-03-12 19:35:14 +00:00
"Minerva.SkinOptions",
Inject services in Hooks and MobileFrontendHooks Change-Id: I8e0673689c2dbe14a385bbd1fe1725d203386bde
2024-02-26 19:47:57 +00:00
"UserOptionsLookup"
Use "optional_services" in skin.json Change-Id: Idab8a934e4c8f547d018907cb427effcab1d0f3f
2024-03-12 19:10:35 +00:00
],
"optional_services": [
"MobileFrontend.Context"
Inject services in Hooks and MobileFrontendHooks Change-Id: I8e0673689c2dbe14a385bbd1fe1725d203386bde
2024-02-26 19:47:57 +00:00
]
Use HookHandlers for MobileFrontend hooks The use of "HookHandlers" attribute in extension.json makes it possible to inject services into hook handler classes in a future patch. Bug: T315823 Change-Id: I9422f0cf7d5c14db544ea67c564d34e9eca3813b
2023-08-15 15:02:31 +00:00
},
"mobilefrontend": {
Inject services in Hooks and MobileFrontendHooks Change-Id: I8e0673689c2dbe14a385bbd1fe1725d203386bde
2024-02-26 19:47:57 +00:00
"class": "MediaWiki\\Minerva\\MobileFrontendHooks",
"services": [
Inject service Minerva.SkinOptions into Hooks and MobileFrontendHooks Change-Id: Id343ae4cb8d1a73cfb647bfe440f2909e3835037
2024-03-12 19:35:14 +00:00
"ConfigFactory",
"Minerva.SkinOptions"
Inject services in Hooks and MobileFrontendHooks Change-Id: I8e0673689c2dbe14a385bbd1fe1725d203386bde
2024-02-26 19:47:57 +00:00
]
Switch to MW core hooks to HookHandlers Bug: T315823 Change-Id: I0d1eb1e2ea584904ee3a130b938bd372048a47eb
2022-08-21 17:03:43 +00:00
}
},
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"Hooks": {
Style the desktop diff and history page of Minerva to look like mobile pages Depends-On: Ie8ac1aab6d2fe5f4575a6891c36efe497458e093 Bug: T305113 Bug: T240624 Change-Id: I5a4a2588da3d701be87690038c2c9b2bc1aa0365
2023-09-29 21:55:29 +00:00
"DifferenceEngineViewHeader": "main",
Switch to MW core hooks to HookHandlers Bug: T315823 Change-Id: I0d1eb1e2ea584904ee3a130b938bd372048a47eb
2022-08-21 17:03:43 +00:00
"ResourceLoaderRegisterModules": "main",
"SkinPageReadyConfig": "main",
"UserLogoutComplete": "main",
"FetchChangesList": "main",
Use HookHandlers for MobileFrontend hooks The use of "HookHandlers" attribute in extension.json makes it possible to inject services into hook handler classes in a future patch. Bug: T315823 Change-Id: I9422f0cf7d5c14db544ea67c564d34e9eca3813b
2023-08-15 15:02:31 +00:00
"MobileFrontendFeaturesRegistration": "mobilefrontend",
"RequestContextCreateSkinMobile": "mobilefrontend",
Set up user option for night mode Add a new user option, `minerva-night-mode`, and configure it with a default value of 2 (automatic based on OS). Rework the code in `getHtmlElementAttributes` to set the initial class value according to the user option, which will be set and saved inside of MobileFrontend Bug: T355118 Change-Id: I4b0d63a186f490ba10b7655b3af4dcb8b64bd400
2024-02-01 23:05:55 +00:00
"GetPreferences": "main",
hooks: implement PreferencesGetLayout Use mobile layout in Special:Preferences Bug: T320586 Depends-On: I468481b66bf96880d1779cd11a46e18745e2c894 Change-Id: Ic6aa01e6e8806d1f2be8e07ca6c83decd62bc641
2022-10-12 13:37:28 +00:00
"PreferencesGetLayout": "main",
Switch to MW core hooks to HookHandlers Bug: T315823 Change-Id: I0d1eb1e2ea584904ee3a130b938bd372048a47eb
2022-08-21 17:03:43 +00:00
"SpecialPageBeforeExecute": "main",
"ResourceLoaderGetConfigVars": "main",
"OutputPageBodyAttributes": "main"
Use tabs in skin.json Change-Id: I8fb66fe2f99786bfbdc598d460c18928dbb0faa0
2017-06-09 22:09:22 +00:00
},
styles: Implement mediawiki.skin.variables.less for MinervaNeue For now, only define: - @font-family-sans (unused in MinervaNeue, but for possible future use) - @border-radius-base With current implementation before this patch, MinervaNeue is relying on core's default `@border-radius` which is set to `0` to be close to HTML default. MinervaNeue is currently not applying correct skin's `border-radius`. Bug: T263270 Change-Id: I9a149eefd15efede27416ada4db07072e53628ec
2020-09-25 18:17:15 +00:00
"SkinLessImportPaths": {
"minerva": "resources/mediawiki.less"
},
Use tabs in skin.json Change-Id: I8fb66fe2f99786bfbdc598d460c18928dbb0faa0
2017-06-09 22:09:22 +00:00
"MessagesDirs": {
"MinervaNeue": [
"i18n"
]
},
"ResourceFileModulePaths": {
"localBasePath": "",
"remoteSkinPath": "MinervaNeue"
},
"ResourceModuleSkinStyles": {
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"minerva": {
Temporary fix for enabling Mobile VisualEditor in night mode Bug: T366832 Change-Id: If03069339261e380dc49defedccb01830d162483
2024-06-20 19:52:05 +00:00
"ext.visualEditor.core.mobile": [
"skinStyles/ext.visualEditor.core.mobile.less"
],
Move skinStyle from Echo to Minerva Bug: T257143 Change-Id: I1999185d19e171900f2da5acbd39125013d3582c
2022-11-19 00:13:40 +00:00
"ext.echo.styles.badge": [
"skinStyles/ext.echo.styles.badge.less"
],
Move css styles related to lazy-image-placeholder to skinStyles `lazy-image-placeholder` is needed only when MobileFrontend is enabled. So it makes sense to move those styles to mobile.init css. See more details here: T199351#6380240 Bug: T260406 Change-Id: I16ca734af33fb0f3c4c67f20bbca8631279d7778
2020-08-14 07:03:46 +00:00
"mobile.init.styles": [
"skinStyles/mobile.init.styles/mobile.less"
],
Reset: Drop p and div inside overlays Required for proper presentation of page issues overlay and multimedia viewer. The div rules were unnecessary. Bug: T205341 Change-Id: I6fea0f2013a11e5248b71619b795d794c8ed18ad
2024-02-14 02:55:25 +00:00
"mobile.mediaViewer": [
"skinStyles/mobile.mediaViewer.less"
],
Remove MinervaTemplate::getContentHtml * Move method to SkinMinerva * Turn preparePageContent into a getter that returns the subject page * Use getSubjectPage in template For mobile special pages this now means the page has two .content elements On those pages I've disabled the initial content element. It also means various .content <heading> and .content ul rules now apply that need to be disabled. While testing several other issues were taken care of - for example the h2 in errors Depends-On: I7761396d6a33830f279742be01240796573556a7 Bug: T291871 Change-Id: I13bc4b5dae7aed86eca31ef306212365e1759481
2021-10-04 22:03:29 +00:00
"mobile.special.nearby.styles": [
"skinStyles/mobile.special.nearby.styles.less"
],
Diff styles for moving paragraphs and empty lines * Fix styling of empty lines - cover full width * Disable the pseudo element shipped in core * Move styles from mobile.special.mobilediff.styles into mediawiki.diff.styles since the latter is always present, the former isn't if MobileFrontend is not available. Bug: T242310 Bug: T243235 Change-Id: Ic7d12fe890622e7b3ccc7bc56765f505ac0ab651
2020-01-20 21:47:19 +00:00
"mediawiki.diff.styles": [
"skinStyles/mediawiki.diff.styles.less"
],
Make MobileFrontend dependency a soft one This extends the work in Ie29a1eb7746d56f7d8c99b74e5e3c213c30fdcf2 Bug: T171000 Change-Id: Ib125e1bdaace1893804892909c27a9f328445835
2019-12-18 21:15:26 +00:00
"mediawiki.searchSuggest": [
"skinStyles/mediawiki.searchSuggest/index.less"
],
🐛 Bug: Fix iOS input text zoom bug on rcfilters input On iOS Safari, the screen zooms in when the user focused on the text input of the rcfilters overlay. This commit adds a quickfix to address this problem by setting the font-size to its initial value (assumed to be 16px). Bug: T231049 Change-Id: I98d28115e570a11d08ba2bd189c0b9151f834e7d
2019-09-02 15:58:33 +00:00
"mediawiki.rcfilters.filters.ui": [
"skinStyles/mediawiki.rcfilters.filters.ui.less"
],
Reset history page styles for Minerva This provides us with a blank canvas for styling Minerva's history page in AMC mode. I have also provided styles for a non-AMC mode (test by changing the class on body tag to minerva--amc-disabled). This will allow us to remove the SpecialMobileHistory page in mobile if we choose to do so. Change-Id: Ic57cb79903e90ce1bbfa6d87ab0499f09373e732
2019-03-29 21:43:19 +00:00
"mediawiki.action.history.styles": [
"skinStyles/mediawiki.action.history.styles.less"
],
Add Minerva specific mediawiki.interface.helpers.styles.less file This SkinStyle file adds paranthases around the (diff|hist) links and username(talk|contrib|block) links on special pages. Bug: T222394 Change-Id: Ic291cb795ccad556a5049d970c0282b2d4c65a11
2019-05-07 13:17:04 +00:00
"mediawiki.interface.helpers.styles": [
"skinStyles/mediawiki.interface.helpers.styles.less"
],
Reset history page styles for Minerva This provides us with a blank canvas for styling Minerva's history page in AMC mode. I have also provided styles for a non-AMC mode (test by changing the class on body tag to minerva--amc-disabled). This will allow us to remove the SpecialMobileHistory page in mobile if we choose to do so. Change-Id: Ic57cb79903e90ce1bbfa6d87ab0499f09373e732
2019-03-29 21:43:19 +00:00
"mediawiki.rcfilters.highlightCircles.seenunseen.styles": [],
Optimise Special:MobileOptions for tablet display Bug: T180095 Change-Id: I0ef0ce914a360848f8f66b39c40588f3fa04647c
2017-12-01 18:52:02 +00:00
"mobile.special.mobileoptions.styles": [
"skinStyles/mobile.special.mobileoptions.styles/minerva.less"
],
Restrict gallery styles to only pages which need it The mediawiki.page.gallery.styles module is only loaded when needed, yet inside hacks.less we load gallery styles unconditionally. The hacks.less file is also only meant for css that overrides template styles, so it didn't belong there anyway. Change-Id: I4afc91ad7f67ae66544708d25541b3e8dd247873
2017-12-13 02:03:28 +00:00
"mediawiki.page.gallery.styles": [
"skinStyles/mediawiki.page.gallery.styles/tablet.less"
],
Remove special page resource module handling This is handled by MobileFrontend now, just as it should do. We rely on skinStyles where possible. Depends-On: I665f6fe60939475249786fdc951149c38473fda6 Bug: T173597 Change-Id: I0fe9efcf98bbd8e188d91a29d4cfda897d47808d
2017-08-18 18:45:41 +00:00
"mediawiki.special.search.styles": [
"skinStyles/mediawiki.special.search.styles/minerva.less"
],
Always show search results at full width Ieebc40073eb3d0c8a56ebc8aec3f060199943ddc lowers the breakpoint at which search will break into 2 columns (search + interwiki), in large part because the 2nd column will also be occupied by Extension:SearchVue's side panel. On mobile, Extension:SearchVue presents differently (directly below a search result), so there's not as much need for a 2nd column this early - wider search results are prefered. Bug: T321377 Change-Id: I22c46cfad2e054be679d79cce9b8d1ae04e3c6f1
2022-12-14 14:29:31 +00:00
"mediawiki.special.search.interwikiwidget.styles": [
"skinStyles/mediawiki.special.search.interwikiwidget.styles/minerva.less"
],
Move Parsoid output overrides to 'mediawiki.skinning.content.parsoid' skinStyles We need to load these only when VisualEditor is loaded. This is the best way to ensure that. They have been haphazardly placed in different files. The goal of this change is to move content styling for Minerva out of mobile.editor.ve/minerva.less, and thus to be able to move this file to mediawiki/extensions/MobileFrontend (T202978). But I spotted the other places while working on that. Moved as-is: * skins.minerva.content.styles/links.less * mobile.editor.ve/minerva.less No longer needed: * skins.minerva.content.styles/text.less Parsoid now uses <sup> tags for references rather than <span>, so the existing rules for <sup> tags are enough. See T45094, <https://www.mediawiki.org/wiki/Specs/HTML/1.6.0/Extensions/Cite>. Was never needed: * skins.minerva.content.styles/thumbnails.less The styles from the core module 'mediawiki.skinning.content.parsoid' are never loaded, so we don't need to override them. Bug: T202978 Change-Id: I45e1cb89b65a41a29d2b1a361a79199745ccec14
2018-09-17 20:56:57 +00:00
"mediawiki.skinning.content.parsoid": [
"skinStyles/mediawiki.skinning.content.parsoid/minerva.less"
],
Minerva should use mediawiki.hlist Override provided styles Bug: T42062 Depends-On: I9305af5d30c8c24b44f4a0c6a466581c45fa3028 Change-Id: I7adda8ef99e5eee3df5bd7dc4da5081c1225f815
2017-06-01 23:09:24 +00:00
"mediawiki.hlist": [
"skinStyles/mediawiki.hlist/minerva.less"
Icon pseudo elements need top: 0 for RTL languages Document why so it doesn't get removed next time. Bug: T232260 Change-Id: I09cac0403c913e5ff10dfede9355a08f226f395d
2019-09-09 20:42:56 +00:00
],
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"mobile.languages.structured": [
Refactor LanguageOverlay styles In I629245100f4ca430a88e450939b90d075e7021f1, languageOverlay styles and LanguageSearcher styles were split into two different files. This commit mimics that change in skinStyles. All languageOverlay specific styles were moved to languageOverlay.less, while all LanguageSearcher styles were moved to LanguageSearcher.less. Other chagnes: * Changed a reference in init.js Bug: T215657 Change-Id: I395a61cd6051ad5c6b6601205f112b55f5ab8273
2019-02-22 17:59:56 +00:00
"skinStyles/mobile.languages.structured/LanguageSearcher.less"
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
],
"mobile.startup": [
Import all skinStyles/mobile.startup into mobile.startup.less This mimics the structure we follow in MobileFrontend's mobile.startup folder where we have a mobile.startup.js that imports all the mobile.startup files. Bug: T215657 Change-Id: Id7faa45adce7c5aa870d0f7c92f70d39995adac0
2019-02-22 18:15:34 +00:00
"skinStyles/mobile.startup/mobile.startup.less"
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
],
Remove special page resource module handling This is handled by MobileFrontend now, just as it should do. We rely on skinStyles where possible. Depends-On: I665f6fe60939475249786fdc951149c38473fda6 Bug: T173597 Change-Id: I0fe9efcf98bbd8e188d91a29d4cfda897d47808d
2017-08-18 18:45:41 +00:00
"mediawiki.special": [
"skinStyles/mobile.special.styles/minerva.less"
],
Mobile Preferences: Add styles for Special:Preferences mobile Added a stylesheet for when a user views Special:Preferences in mobile Bug: T311717 Depends-On: Ia7a730cd7f009dbb921a810f27fae4a9ee66f793 Change-Id: I83558ca5de50fa7d8c7d75572ffa1c600f660d66
2022-08-13 02:50:53 +00:00
"mediawiki.special.preferences.styles.ooui": [
"skinStyles/mediawiki.special.preferences.styles.ooui/minerva.less"
],
Remove special page resource module handling This is handled by MobileFrontend now, just as it should do. We rely on skinStyles where possible. Depends-On: I665f6fe60939475249786fdc951149c38473fda6 Bug: T173597 Change-Id: I0fe9efcf98bbd8e188d91a29d4cfda897d47808d
2017-08-18 18:45:41 +00:00
"mobile.special.styles": [
"skinStyles/mobile.special.styles/minerva.less"
],
Set editfont size to 16px (100%) Change-Id: I9bff880de792da756f14726042df0a0df4139d1b
2018-04-02 20:06:27 +00:00
"mediawiki.editfont.styles": [
"skinStyles/mediawiki.editfont.styles/minerva.css"
],
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"mediawiki.notification": [
Dev: Prep for storybook * Remove ambiguity in imports - say the file extension 'less' for all instances of variables and mixins. * Separate toast styles from drawer styles so they can be imported separately * associate header-action selector with its parent (.overlay-header) not parent's parent (.overlay) so it can be imported and rendered without the Overlay. Change-Id: Ib7e19a440ba095d6424d35305fb41d643ca9764c
2019-08-08 20:01:03 +00:00
"skinStyles/mobile.startup/drawers.less",
Center and align the expiry dropdown in watchstar widget Move the watchlist expiry dropdown list to be aligned in the centre, and its contents to be left-aligned. Bug: T261990 Change-Id: I3073618606636c78e6afb5bf19726c7b3973292b
2020-09-21 04:57:44 +00:00
"skinStyles/mobile.startup/toast.less",
"skinStyles/mediawiki.watchstar.widgets.css"
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
],
"mediawiki.action.edit.styles": [
"skinStyles/mediawiki.action.edit.styles/minerva.less"
],
JSON content: Fix table margins Change-Id: I50a2203adb66e634f9d995225075dc29a34ab4dd
2019-05-03 15:27:33 +00:00
"mediawiki.content.json": [
"skinStyles/mediawiki.content-json/minerva.less"
Adding skin styles for the changeslist module. The changeslist module is the list of results on special pages such as recent changes, watchlist, and parts of action history. Adds a skin style to special.changeslist module. Bug: T228419 Change-Id: I324b1f136f5314cb6acdba3155b07136bbde363a
2019-07-29 09:50:05 +00:00
],
"mediawiki.special.changeslist": [
Fix style of clock icon in changes lists Override core styles for the watchlist expiry clock icon in Recent Changes and Watchlists. Bug: T261415 Depends-On: I621b1571b57686beb9fb5802533b1e70d293bc2a Change-Id: Iefdd271aeb6135771aae832e930fe02c73248110
2020-09-23 02:15:08 +00:00
"skinStyles/mediawiki.special.changeslist.less",
"skinStyles/mediawiki.special.changeslist.watchlistexpiry.less"
Adding skin styles for the changeslist module. The changeslist module is the list of results on special pages such as recent changes, watchlist, and parts of action history. Adds a skin style to special.changeslist module. Bug: T228419 Change-Id: I324b1f136f5314cb6acdba3155b07136bbde363a
2019-07-29 09:50:05 +00:00
],
"mediawiki.special.changeslist.legend": [
"skinStyles/mediawiki.special.changeslist.legend.less"
Add max-width limit to empty watchlist page On the Watchlist, when there are no results, the page uses .info and .empty-page classes. This results in text running without max-length. Add max-width rule to contain it. Bug: T222872 Change-Id: I768f800a49e756da1ad2c123c842c37d18fa3310
2021-01-21 13:43:39 +00:00
],
"mobile.special.pagefeed.styles": [
"skinStyles/mobile.special.pagefeed.styles.less"
Explicitly set font size in VisualEditor + CodeMirror 6 This only effects Minerva desktop users of VE + CodeMirror. Bug: T357482 Change-Id: I2569517ba2ce67d3d6ac486ddbfb9a3ce99d8c8c
2024-08-20 21:19:32 +00:00
],
"+ext.CodeMirror.v6.visualEditor": [
"skinStyles/ext.visualEditor.codeMirror.less"
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
]
}
},
"ResourceModules": {
Create new skins.minerva.styles module This merges the existing modules skins.minerva.base.styles and skins.minerva.mainMenu.styles into a new module skins.minerva.styles which is named consistently with Vector's style module. The old modules will be kept for caching reasons for at least one, and possibly two deploy cycles, after which we will continue this task. Additional change: * drop .minerva-icon--{name}-base20 and .minerva-icon--{name}-disabled variants since these are no longer utilized and only serve cached HTML Bug: T266361 Change-Id: Iccf415a22e9535603befae25b8cea467f9905437
2024-11-06 23:34:58 +00:00
"skins.minerva.styles": {
"class": "MediaWiki\\ResourceLoader\\SkinModule",
"features": [
"normalize",
"accessibility",
"i18n-ordered-lists",
"content-body",
"content-tables",
"interface-core"
],
"styles": [
"resources/skins.minerva.base.styles/CSSCustomProperties.less",
"resources/skins.minerva.base.styles/skin.less",
"resources/skins.minerva.mainMenu.styles/index.less"
]
},
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"skins.minerva.base.styles": {
Create new skins.minerva.styles module This merges the existing modules skins.minerva.base.styles and skins.minerva.mainMenu.styles into a new module skins.minerva.styles which is named consistently with Vector's style module. The old modules will be kept for caching reasons for at least one, and possibly two deploy cycles, after which we will continue this task. Additional change: * drop .minerva-icon--{name}-base20 and .minerva-icon--{name}-disabled variants since these are no longer utilized and only serve cached HTML Bug: T266361 Change-Id: Iccf415a22e9535603befae25b8cea467f9905437
2024-11-06 23:34:58 +00:00
"deprecated": "Retained for caching reasons. Please use skins.minerva.styles instead.",
Remove ResourceLoaderSkinModule Since 95c4454cf95c20268d675b0eddd812ce42abf0f7 the class ResourceLoaderSkinModule doesn't do anything. Change-Id: I2d870278485d40c1b47c910d4fc34bafc58fc66c
2024-05-04 20:26:51 +00:00
"class": "MediaWiki\\ResourceLoader\\SkinModule",
Enable interface-temp-user-banner styles on Minerva skin Depends-On: I1e137dbd29f3c73efac901f43f8a8258e2a111fc Bug: T330510 Change-Id: I9ab262dc4e1d7cd2377a00b2c5f2ae10ddfab3fe
2023-06-15 21:50:04 +00:00
"features": [
Replace reset with SkinModule normalize Retain the existing font, margin and padding values as without these we would trigger a visual regression. Visual change: Four minor visual regression with this change relating to the button in the AMC CTA Drawer and suggested edits overlay heading. All are acceptable. Bug: T205341 Change-Id: I6331d88e5b7301fd13249414350a539738cfae53
2024-02-02 05:04:50 +00:00
"normalize",
Enable interface-temp-user-banner styles on Minerva skin Depends-On: I1e137dbd29f3c73efac901f43f8a8258e2a111fc Bug: T330510 Change-Id: I9ab262dc4e1d7cd2377a00b2c5f2ae10ddfab3fe
2023-06-15 21:50:04 +00:00
"accessibility",
"i18n-ordered-lists",
"content-body",
Minerva should use content-tables ResourceLoaderSkinModule feature The styles in Minerva are identical to the preset in core with the own exception being padding. Therefore use the upstream styles and retain only the override. Bug: T357998 Depends-On: I206e91dac7e14d80a5ffc6b533255b54dafca29a Change-Id: I3eb07a03b3b4e2a7544e5b07de6af9f67a1c965f
2024-03-11 21:08:31 +00:00
"content-tables",
Remove "interface-temp-user-banner" option In MediaWiki core change Ie2631221b0a07dd3bf55e970805d30fbb3cac190 the interface-temp-user-banner option is removed. Bug: T339379 Change-Id: Icf622c4be910f5d14de95355efa02c05930179bf
2023-06-29 23:09:53 +00:00
"interface-core"
Enable interface-temp-user-banner styles on Minerva skin Depends-On: I1e137dbd29f3c73efac901f43f8a8258e2a111fc Bug: T330510 Change-Id: I9ab262dc4e1d7cd2377a00b2c5f2ae10ddfab3fe
2023-06-15 21:50:04 +00:00
],
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"styles": [
Map color-based skin variables to CSS variables Additional changes: * Separate CSSCustomProperties.less from skin.less so that we can obtain the unmodified original values for the colors Depends-On: I363a97d33d85a9033da753f2a8fe730d80206639 Depends-On: I148eaca747352ffdc9d1423f20d34bd5a1d0e447 Bug: T356427 Change-Id: I916450c276cabb0c7c871525c50f95fb87f498ad
2024-02-20 22:40:56 +00:00
"resources/skins.minerva.base.styles/CSSCustomProperties.less",
"resources/skins.minerva.base.styles/skin.less"
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
]
},
Update: add internal and revise external link icons Bug: T190549 Change-Id: Iad7fdc2f2a730fa8874487c0d83355f21a0bf7ea
2018-06-14 16:51:50 +00:00
"skins.minerva.content.styles.images": {
Use namespaced ResourceLoader classes The old class names are deprecated since 1.39. Change-Id: Ie24b28ba27c5ce3c98e57a14117f01f4ca42824f
2023-12-01 13:35:19 +00:00
"class": "MediaWiki\\ResourceLoader\\ImageModule",
Adds a light-blue variant to the external link icon The light-blue variant is used in reference drawers on a dark background. Bug: T216961 Change-Id: Ic8fdf8f4a08ea7c8d7ae57ae8ce02a7d9a1e1dad
2019-04-25 14:06:08 +00:00
"selectorWithoutVariant": "{name}",
"selectorWithVariant": "{name}--{variant}",
External link icons should use defaultColor Depends-On: I0745e112d11026ed59d8daca990b313305cd094a Bug: T197909 Change-Id: Ic00b77e789b487d626f497d99197649c04bd6427
2018-06-26 23:25:31 +00:00
"defaultColor": "#36c",
Reduce render blocking styles by deferring loading of icons Change-Id: I8fb3b03833a49ade1d62fe4ded1a0c723cbe8f28 Depends-On: Iee77655d4868a7d921be8cc23776a7859d9acf0c Bug: T198930
2018-07-05 23:52:21 +00:00
"useDataURI": false,
Adds a light-blue variant to the external link icon The light-blue variant is used in reference drawers on a dark background. Bug: T216961 Change-Id: Ic8fdf8f4a08ea7c8d7ae57ae8ce02a7d9a1e1dad
2019-04-25 14:06:08 +00:00
"variants": {
"reference": {
icons: Put reference variant only on external link icon Change-Id: I94587e0695b211b6a92ddf155ab1dd2991c17739
2021-03-24 10:47:32 +00:00
"color": "#69f"
Adds a light-blue variant to the external link icon The light-blue variant is used in reference drawers on a dark background. Bug: T216961 Change-Id: Ic8fdf8f4a08ea7c8d7ae57ae8ce02a7d9a1e1dad
2019-04-25 14:06:08 +00:00
}
},
Update: add internal and revise external link icons Bug: T190549 Change-Id: Iad7fdc2f2a730fa8874487c0d83355f21a0bf7ea
2018-06-14 16:51:50 +00:00
"images": {
build: Update MediaWiki requirement to 1.41 All skins in the MediaWiki tarball are expected to track MediaWiki's release directly. Change-Id: I320ccbc07409ab9c2858fd1410ec91cda797b464
2023-08-19 06:32:31 +00:00
"toast.mw-notification-type-error, .mw-notification.mw-notification-type-error": "resources/skins.minerva.content.styles.images/error.svg",
Fix external icon specificity We've changed the selector in MW core to `.mw-parser-output a.external` a while ago. In order to show the correct image, selector needs to be amended. Change-Id: I83d7b4c8be2eda1876959d000e0fb2d493e12cbc
2021-11-09 07:13:02 +00:00
"a.external, .mw-parser-output a.external": {
Update: add internal and revise external link icons Bug: T190549 Change-Id: Iad7fdc2f2a730fa8874487c0d83355f21a0bf7ea
2018-06-14 16:51:50 +00:00
"file": {
"ltr": "resources/skins.minerva.content.styles.images/link-external-ltr.svg",
"rtl": "resources/skins.minerva.content.styles.images/link-external-rtl.svg"
icons: Put reference variant only on external link icon Change-Id: I94587e0695b211b6a92ddf155ab1dd2991c17739
2021-03-24 10:47:32 +00:00
},
"variants": [
"reference"
]
Update: add internal and revise external link icons Bug: T190549 Change-Id: Iad7fdc2f2a730fa8874487c0d83355f21a0bf7ea
2018-06-14 16:51:50 +00:00
}
}
},
Talk tabs in AMC mode A new feature/skin option is added that is enabled safely inside a MobileFrontend available/unavailable hook that changes the skin to place talk tabs at the top of the page. These new talk tabs purposely show on the main page, user page and standard pages and do not show on special pages. Depends-On: Ie1a583657176acc6f7046c569c2e94fa2f72ff93 Bug: T212216 Change-Id: I57b70cd325666a287678dc897159b5bf9d089b78
2019-01-10 22:59:56 +00:00
"skins.minerva.amc.styles": {
"styles": [
Feature flag overhaul Two new feature flags: 1) MinervaPersonalMenu 2) MinervaAdvancedMainMenu Changes: * AMC defaults to false on desktop - desktop doesn't have AMC mode it just enables several skin options. * WHen inserting a link at the bottom of the page check whether the talk at top of the page (tabs) is enabled.. not AMC * Update ServiceWiring to construct menu based on MinervaAdvancedMainMenu and MinervaPersonalMenu - note when former is enabled but not latter there is no way to logout. Noted in README. * Use one entry point for skins.minerva.amc.styles/index.less * Document files inside skins.minerva.amc.styles to make it clear which features they are associated with * Drop history page styles when AMC is disabled - it's not possible to ever get to these as the history page redirects in non-AMC mode * Rename the class .minerva--amc-enabled to minerva--history-page-action-enabled to reflect its real purpose and move styles from skins.minerva.base.styles to skins.minerva.amc.styles No need to worry about cached HTML as AMC runs without cache... * Remove isAnyAMCOptionEnabled - it's an antipattern and should be discouraged as it discourages the art of feature flagging. Nothing is using it after these changes. * The AMC_MODE flag is disabled. There is no need for this - AMC is not a feature and therefore not a skin option. It is a mechanism for turning on other skin options. Tests are updated. Testing: It should now be possible to enable any feature in `beta` and see it in the beta of the site. Bug: T229295 Change-Id: I48959905f5c09721b14a27aa1a5ad82849ac6263
2019-08-22 20:31:31 +00:00
"resources/skins.minerva.amc.styles/index.less"
Talk tabs in AMC mode A new feature/skin option is added that is enabled safely inside a MobileFrontend available/unavailable hook that changes the skin to place talk tabs at the top of the page. These new talk tabs purposely show on the main page, user page and standard pages and do not show on special pages. Depends-On: Ie1a583657176acc6f7046c569c2e94fa2f72ff93 Bug: T212216 Change-Id: I57b70cd325666a287678dc897159b5bf9d089b78
2019-01-10 22:59:56 +00:00
]
},
Use standardized icon classes and fix some missing icons The icon pack wikimedia.ui was strangely using a non-standard icon class using empty strings as a way to disable the default behaviour of setIcon. Instead of fighting APIs - use the methods available. The icon pack is also renamed to reflect what it's actually used for - providing icons for overflow menus and it is no longer loaded as a dependency by skins.minerva.scripts Fixes issues with: * History icon with AMC disabled and user is logged in * Table of contents icon * Language icon when it appears in overflow menu on user pages when logged in where AMC is disabled * listBullet appears in 2 modules as it is used in 2 places - the AMC overflow menu (log icon on user overflow menu) and for table of contents (JS only) Bug: T232383 Change-Id: I05220ffa56195be6a594e3a8a57ae16858088444
2020-04-01 23:25:04 +00:00
"skins.minerva.overflow.icons": {
Clean up icon selectors from cached HTML Bug: T344022 Change-Id: I170d86b52345b94a81e74f03b82aef7b522bbb39
2023-09-06 18:57:13 +00:00
"selectorWithoutVariant": ".minerva-icon--{name}",
Update: add secondary page actions submenu in AMC mode When advanced mobile contributions mode is enabled and `$wgMinervaOverflowInPageActions` is set, show a secondary overflow menu on main namespace articles and user namespace pages. The menu content varies for each namespace. The new submenu is *disabled* by default, even when AMC is active. This feature should not be deployed until instrumentation is available. The secondary menu is rendered in PHP using the existing menu system with some changes to the template. The checkbox hack is needed for no- JavaScript keyboard navigation until :focus-within is supported. CSS additions are documented in the source. All client side toolbar execution occurs in Toolbar.js. Enhancements are documented in the source. Minor changes to the existing download button: - Move download and edit button initialization to Toolbar. - Update copy (not visible) from "Download" to "Download PDF". - When the overflow menu is present, use the "hasText" / label style. Wikimedia UI icons are copied from OOUI at d00a0ac and seem useful to expose as HTTP URIs (not data URIs). The overflow menu does not show for pages provided by the content proxy since its entries depend on $tpl->data['nav_urls'] being populated. Bug: T216418 Depends-On: I0781151a8232b6a7b52f79a34298afcecb8e4271 Change-Id: I4b50a0e519024a7ab91dae6ab40b23cf14a03861
2019-04-04 21:20:39 +00:00
"useDataURI": false,
Use wikimedia.ui from core directly There's no reason to copy and paste all this here. These icons can be imported directly from core using ResourceLoaderOOUIIconPackModule Depends-On: I7800da87a6a10399f705b43e05c8592c766bae6f Change-Id: I1f25aaca9b7313cd95cefc7f5629b8a7e65c887f
2019-07-12 15:38:41 +00:00
"defaultColor": "#54595d",
Use namespaced ResourceLoader classes The old class names are deprecated since 1.39. Change-Id: Ie24b28ba27c5ce3c98e57a14117f01f4ca42824f
2023-12-01 13:35:19 +00:00
"class": "MediaWiki\\ResourceLoader\\OOUIIconPackModule",
Disable unused icon variants By default this module was inheriting variants and since it doesnt declare a property selectorWithVariant it was using the default selectorWithVariant rule which impacts OOUI icons. Explicitly disable the variants for this module as they are unused. This reduces the size of the modules. Follow up to: I87b060cf98194d81679da2610944f58e8d941389 Bug: T374145 Bug: T376226 Change-Id: Icc008449ee498a946066c4ce5d46adcac194bd3b
2024-10-03 17:06:12 +00:00
"variants": [],
Update Minerva skin to use Codex icons - Define icon size variables in icons.less - Update icon classes to use .cdx-mixin-css-icon() - Remove temporary fixes in icons.less - Add 'codex.styles' dependency in skin.json - Set 'useMaskImage' to true in skin.json Bug: T374145 Depends-On: Ia8f770aec365da77b39cb0258f546df7894e6ba4 Change-Id: I87b060cf98194d81679da2610944f58e8d941389
2024-09-25 00:23:04 +00:00
"useMaskImage": true,
Split line with many values in skin.json Makes it easier to read when there one value on each line Change-Id: Ib6e8231f718cb6bf17935e45dff696db850569b9
2019-10-25 16:30:37 +00:00
"icons": [
Add block button to user namespace overflow Bug: T307341 Change-Id: Ib8bcca0ab284900eff01468a416177435f02e7aa
2022-05-03 15:54:16 +00:00
"block",
Replace skins.minerva.mainMenu.advanced.icons with OOUI icons Additional changes: * Address a fixme relating to the overflow icon and move some AMC styles out of the critical path for non-AMC pages Note about ellipsis: The class mf-mw-ui-icon-rotate-clockwise cannot be used as it's part of MobileFrontend and loaded via JS. Minerva must work without MobileFrontend and this rotation is needed without JS. Bug: T244444 Change-Id: Ifd02c50305cf036dd6df640d778678668507e5eb
2020-04-29 04:13:55 +00:00
"ellipsis",
Split line with many values in skin.json Makes it easier to read when there one value on each line Change-Id: Ib6e8231f718cb6bf17935e45dff696db850569b9
2019-10-25 16:30:37 +00:00
"articleRedirect",
"infoFilled",
"link",
Allow Users with permissions to do expanded actions in Minerva on mobile Allow Users with the needed permissions to delete, protect or move pages in Minerva on mobile version. Bug: T231291 Change-Id: I1e438b7d3683d288a8a6c5a9f5dcea6b3b3d9f71
2021-03-09 19:43:14 +00:00
"move",
"lock",
"trash",
Split line with many values in skin.json Makes it easier to read when there one value on each line Change-Id: Ib6e8231f718cb6bf17935e45dff696db850569b9
2019-10-25 16:30:37 +00:00
"listBullet",
Rename UserRights to UserGroups The "User Rights" is called "User groups" on desktop. The Mobile site should not provide it's onw naming but use the same names as desktop. Bug: T230694 Depends-On: Ic9b7033e3f52f415ec8aec845a65a8452d0e5d8f Change-Id: Iaf116a5cc54cc400451550d9fa958adbbccc35c5
2019-09-05 10:10:58 +00:00
"logoWikidata",
extension.json: add qrCode icon to overflow.icons Bug: T339839 Bug: T242467 Depends-On: Ia845a593cef68e4456d50c6ef213bf9255507eef Change-Id: I453fe5ec3c92605837459ebc308a118d1389856e
2023-07-06 05:28:06 +00:00
"qrCode",
Rename UserRights to UserGroups The "User Rights" is called "User groups" on desktop. The Mobile site should not provide it's onw naming but use the same names as desktop. Bug: T230694 Depends-On: Ic9b7033e3f52f415ec8aec845a65a8452d0e5d8f Change-Id: Iaf116a5cc54cc400451550d9fa958adbbccc35c5
2019-09-05 10:10:58 +00:00
"quotes",
User menu overflow: add change block and unblock Added the "Change block" and "Unblock user" to the array of possible menu entries for the overflow menu. These buttons will only appear when a user is already blocked. Bug: T308570 Change-Id: I987083cfeb20a0c691d3fc631a9c844647fec9bf Depends-On: If60a1194d63fff2b7b5ae1565be25a3b7b44fdf1
2022-06-28 23:07:21 +00:00
"unBlock",
Menu: Add "unprotect" action when current user is an admin Accidentally via T231291, a regression was introduced such that, in AMC mode, when a page is protected to be edited only by admins, a corresponding unprotect action is not avaiable to reverse the protect action. This patch fixes that regression. Have tested locally and it works as expected. Bug: T285567 Change-Id: Ie20ca5d9c43fa54dff5d699eb59679585283bdb5
2021-06-30 17:20:39 +00:00
"unLock",
Rename UserRights to UserGroups The "User Rights" is called "User groups" on desktop. The Mobile site should not provide it's onw naming but use the same names as desktop. Bug: T230694 Depends-On: Ic9b7033e3f52f415ec8aec845a65a8452d0e5d8f Change-Id: Iaf116a5cc54cc400451550d9fa958adbbccc35c5
2019-09-05 10:10:58 +00:00
"userAvatarOutline",
"userTalk",
"userAvatar",
Add missing Create account icon on pt.wikinews.org Bug: T333881 Change-Id: I269f5eb571041af2680e1b4af8afeec4d3563a82
2023-04-15 13:04:57 +00:00
"userAdd",
Rename UserRights to UserGroups The "User Rights" is called "User groups" on desktop. The Mobile site should not provide it's onw naming but use the same names as desktop. Bug: T230694 Depends-On: Ic9b7033e3f52f415ec8aec845a65a8452d0e5d8f Change-Id: Iaf116a5cc54cc400451550d9fa958adbbccc35c5
2019-09-05 10:10:58 +00:00
"userGroup"
]
Refresh the user, bell and search icon * New module skins.minerva.icons.wikimedia provides icons from Wikimedia UI in Minerva * search selector in skins.minerva.content.styles.images is retained for cached HTML * skins.minerva.icons.loggedin now a ResourceLoaderOOUIIconPackModule and bell removed from repo. * userAvatar replaced with userAvatarOutline Bug: T224070 Change-Id: Ibed609371060acc4b69e5cd4cd4f20edc871b3ba
2019-07-09 19:12:51 +00:00
},
Merge Icon Style mergeIconStyleModules Merging skins.minerva.icons.wikimedia and skins.minerva.mainMenu.icons modules into skins.minerva.icons Bug: T266361 Change-Id: I4095da5a0c6d2cff8ccd1ff1504a2d54635d1828
2024-11-12 21:43:33 +00:00
"skins.minerva.icons": {
"selectorWithoutVariant": ".minerva-icon--{name}",
"useDataURI": false,
"defaultColor": "#54595d",
"class": "MediaWiki\\ResourceLoader\\OOUIIconPackModule",
"variants": [],
"useMaskImage": true,
"icons": [
"edit",
"wikiText",
"editLock",
"history",
"language",
"menu",
"search",
"userAvatar",
"userTalk",
"star",
"halfStar",
"unStar",
"die",
"heart",
"home",
"logIn",
"logOut",
"mapPin",
"settings",
"userContributions",
"unStar",
"watchlist"
]
},
Refresh the user, bell and search icon * New module skins.minerva.icons.wikimedia provides icons from Wikimedia UI in Minerva * search selector in skins.minerva.content.styles.images is retained for cached HTML * skins.minerva.icons.loggedin now a ResourceLoaderOOUIIconPackModule and bell removed from repo. * userAvatar replaced with userAvatarOutline Bug: T224070 Change-Id: Ibed609371060acc4b69e5cd4cd4f20edc871b3ba
2019-07-09 19:12:51 +00:00
"skins.minerva.icons.wikimedia": {
Merge Icon Style mergeIconStyleModules Merging skins.minerva.icons.wikimedia and skins.minerva.mainMenu.icons modules into skins.minerva.icons Bug: T266361 Change-Id: I4095da5a0c6d2cff8ccd1ff1504a2d54635d1828
2024-11-12 21:43:33 +00:00
"deprecated": "Retained for caching reasons. Please use skins.minerva.icons instead.",
Create new skins.minerva.styles module This merges the existing modules skins.minerva.base.styles and skins.minerva.mainMenu.styles into a new module skins.minerva.styles which is named consistently with Vector's style module. The old modules will be kept for caching reasons for at least one, and possibly two deploy cycles, after which we will continue this task. Additional change: * drop .minerva-icon--{name}-base20 and .minerva-icon--{name}-disabled variants since these are no longer utilized and only serve cached HTML Bug: T266361 Change-Id: Iccf415a22e9535603befae25b8cea467f9905437
2024-11-06 23:34:58 +00:00
"selectorWithoutVariant": ".minerva-icon--{name}",
Refresh the user, bell and search icon * New module skins.minerva.icons.wikimedia provides icons from Wikimedia UI in Minerva * search selector in skins.minerva.content.styles.images is retained for cached HTML * skins.minerva.icons.loggedin now a ResourceLoaderOOUIIconPackModule and bell removed from repo. * userAvatar replaced with userAvatarOutline Bug: T224070 Change-Id: Ibed609371060acc4b69e5cd4cd4f20edc871b3ba
2019-07-09 19:12:51 +00:00
"useDataURI": false,
"defaultColor": "#54595d",
Use namespaced ResourceLoader classes The old class names are deprecated since 1.39. Change-Id: Ie24b28ba27c5ce3c98e57a14117f01f4ca42824f
2023-12-01 13:35:19 +00:00
"class": "MediaWiki\\ResourceLoader\\OOUIIconPackModule",
Disable unused icon variants By default this module was inheriting variants and since it doesnt declare a property selectorWithVariant it was using the default selectorWithVariant rule which impacts OOUI icons. Explicitly disable the variants for this module as they are unused. This reduces the size of the modules. Follow up to: I87b060cf98194d81679da2610944f58e8d941389 Bug: T374145 Bug: T376226 Change-Id: Icc008449ee498a946066c4ce5d46adcac194bd3b
2024-10-03 17:06:12 +00:00
"variants": [],
Update Minerva skin to use Codex icons - Define icon size variables in icons.less - Update icon classes to use .cdx-mixin-css-icon() - Remove temporary fixes in icons.less - Add 'codex.styles' dependency in skin.json - Set 'useMaskImage' to true in skin.json Bug: T374145 Depends-On: Ia8f770aec365da77b39cb0258f546df7894e6ba4 Change-Id: I87b060cf98194d81679da2610944f58e8d941389
2024-09-25 00:23:04 +00:00
"useMaskImage": true,
Split line with many values in skin.json Makes it easier to read when there one value on each line Change-Id: Ib6e8231f718cb6bf17935e45dff696db850569b9
2019-10-25 16:30:37 +00:00
"icons": [
Rename several icons to WikimediaUI naming Renaming to WikimediaUI standard naming and adding to module skins.minerva.icons.wikimedia which is loaded via addModuleStyles 'edit' → 'editLock' 'edit-enabled' → 'edit' 'toc' → 'listBullet' (already included in wikimedia.ui module) 'mainmenu' → 'menu' 'language-switcher' → 'language' 'clock' → 'history' Icon `page-actions-overflow` which is only needed on AMC is moved out of the stable icon pack and added to skins.minerva.mainMenu.advanced.icons temporarily which is loaded on AMC pages only: 'page-actions-overflow' Additional changes: * Renaming 'clockIconClass' to 'historyIconClass' to stay on name. * Module `skins.minerva.icons.images` is deprecated and shipped for old HTML markup. It will be removed in 2 weeks. Bug: T232383 Change-Id: Ia3bafc74a85293c2414c0ef4ccf3bb20c75135d1
2020-03-25 02:02:02 +00:00
"edit",
Support extension of page actions via hook and addPortletLink This adds support for: mw.util.addPortletLink('p-views', '#', 'text', 'fooz',null, null,'#page-actions-overflow' ) and adding multiple edit icons via hooks. Depends-On: I655097769620301143140ded1cde4c7a16879ef4 Depends-On: I401805224c0f387ac85b52b50c1f298b83c03a91 Bug: T346944 Change-Id: I3c9d59f49f1b939981a7b2b450448db6736d5958
2023-09-27 00:17:21 +00:00
"wikiText",
Rename several icons to WikimediaUI naming Renaming to WikimediaUI standard naming and adding to module skins.minerva.icons.wikimedia which is loaded via addModuleStyles 'edit' → 'editLock' 'edit-enabled' → 'edit' 'toc' → 'listBullet' (already included in wikimedia.ui module) 'mainmenu' → 'menu' 'language-switcher' → 'language' 'clock' → 'history' Icon `page-actions-overflow` which is only needed on AMC is moved out of the stable icon pack and added to skins.minerva.mainMenu.advanced.icons temporarily which is loaded on AMC pages only: 'page-actions-overflow' Additional changes: * Renaming 'clockIconClass' to 'historyIconClass' to stay on name. * Module `skins.minerva.icons.images` is deprecated and shipped for old HTML markup. It will be removed in 2 weeks. Bug: T232383 Change-Id: Ia3bafc74a85293c2414c0ef4ccf3bb20c75135d1
2020-03-25 02:02:02 +00:00
"editLock",
"history",
"language",
"menu",
Split line with many values in skin.json Makes it easier to read when there one value on each line Change-Id: Ib6e8231f718cb6bf17935e45dff696db850569b9
2019-10-25 16:30:37 +00:00
"search",
"userAvatar",
Add yellow talk page message warning to non-main namespace pages Bug: T284642 Change-Id: I2895975efe1d09d228f80aff74381e88034a0137
2021-10-25 20:40:47 +00:00
"userTalk",
Split line with many values in skin.json Makes it easier to read when there one value on each line Change-Id: Ib6e8231f718cb6bf17935e45dff696db850569b9
2019-10-25 16:30:37 +00:00
"star",
Show half star for temporarily watched pages This does not complete watchlist expiry support in MinervaNeue. It only instructs the skin to show a half star instead of a full star on page load if the page is being temporarily watched. Bug: T251690 Change-Id: Ib5c479dcfe49041152ba662c56cc630c32eb220e
2020-08-24 21:49:04 +00:00
"halfStar",
Split line with many values in skin.json Makes it easier to read when there one value on each line Change-Id: Ib6e8231f718cb6bf17935e45dff696db850569b9
2019-10-25 16:30:37 +00:00
"unStar"
]
Update: add secondary page actions submenu in AMC mode When advanced mobile contributions mode is enabled and `$wgMinervaOverflowInPageActions` is set, show a secondary overflow menu on main namespace articles and user namespace pages. The menu content varies for each namespace. The new submenu is *disabled* by default, even when AMC is active. This feature should not be deployed until instrumentation is available. The secondary menu is rendered in PHP using the existing menu system with some changes to the template. The checkbox hack is needed for no- JavaScript keyboard navigation until :focus-within is supported. CSS additions are documented in the source. All client side toolbar execution occurs in Toolbar.js. Enhancements are documented in the source. Minor changes to the existing download button: - Move download and edit button initialization to Toolbar. - Update copy (not visible) from "Download" to "Download PDF". - When the overflow menu is present, use the "hasText" / label style. Wikimedia UI icons are copied from OOUI at d00a0ac and seem useful to expose as HTTP URIs (not data URIs). The overflow menu does not show for pages provided by the content proxy since its entries depend on $tpl->data['nav_urls'] being populated. Bug: T216418 Depends-On: I0781151a8232b6a7b52f79a34298afcecb8e4271 Change-Id: I4b50a0e519024a7ab91dae6ab40b23cf14a03861
2019-04-04 21:20:39 +00:00
},
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"skins.minerva.mainPage.styles": {
"styles": [
"resources/skins.minerva.mainPage.styles/common.less"
]
},
"skins.minerva.userpage.styles": {
"styles": [
"resources/skins.minerva.userpage.styles/userpage.less"
]
},
Separate AMC icons from non-AMC icons Currently a bunch of icons are loaded for all users that are only ever used for AMC. Clean this up and add notes on the necessary steps if these ever become the default. Bug: T229295 Change-Id: I4e16028e7121b0b3e1a60b9404183d483db52ad8
2019-08-22 22:13:57 +00:00
"skins.minerva.personalMenu.icons": {
Use namespaced ResourceLoader classes The old class names are deprecated since 1.39. Change-Id: Ie24b28ba27c5ce3c98e57a14117f01f4ca42824f
2023-12-01 13:35:19 +00:00
"class": "MediaWiki\\ResourceLoader\\OOUIIconPackModule",
Disable unused icon variants By default this module was inheriting variants and since it doesnt declare a property selectorWithVariant it was using the default selectorWithVariant rule which impacts OOUI icons. Explicitly disable the variants for this module as they are unused. This reduces the size of the modules. Follow up to: I87b060cf98194d81679da2610944f58e8d941389 Bug: T374145 Bug: T376226 Change-Id: Icc008449ee498a946066c4ce5d46adcac194bd3b
2024-10-03 17:06:12 +00:00
"variants": [],
Update Minerva skin to use Codex icons - Define icon size variables in icons.less - Update icon classes to use .cdx-mixin-css-icon() - Remove temporary fixes in icons.less - Add 'codex.styles' dependency in skin.json - Set 'useMaskImage' to true in skin.json Bug: T374145 Depends-On: Ia8f770aec365da77b39cb0258f546df7894e6ba4 Change-Id: I87b060cf98194d81679da2610944f58e8d941389
2024-09-25 00:23:04 +00:00
"useMaskImage": true,
Clean up icon selectors from cached HTML Bug: T344022 Change-Id: I170d86b52345b94a81e74f03b82aef7b522bbb39
2023-09-06 18:57:13 +00:00
"selectorWithoutVariant": ".minerva-icon--{name}",
Use standard palette color Base20 for icons Bug: T240500 Change-Id: I31302acb6dded8b367cff87e35df2ccbc30b4749
2020-04-21 03:23:37 +00:00
"defaultColor": "#54595d",
build: Update MediaWiki requirement to 1.41 All skins in the MediaWiki tarball are expected to track MediaWiki's release directly. Change-Id: I320ccbc07409ab9c2858fd1410ec91cda797b464
2023-08-19 06:32:31 +00:00
"icons": [
"sandbox"
],
Update modules to not use data URIs to reduce bundle size - Add "useDataURI": false to following modules: -- skins.minerva.mainMenu.advanced.icons -- skins.minerva.personalMenu.icons -- Remove .mw-ui-icon-mf-next-invert old class kept for caching from edit.page.js Bug: T346162 Change-Id: I362fdc9c68a7483c182e3540cba6501d9b12959d
2023-12-05 21:31:54 +00:00
"useDataURI": false
Separate AMC icons from non-AMC icons Currently a bunch of icons are loaded for all users that are only ever used for AMC. Clean this up and add notes on the necessary steps if these ever become the default. Bug: T229295 Change-Id: I4e16028e7121b0b3e1a60b9404183d483db52ad8
2019-08-22 22:13:57 +00:00
},
"skins.minerva.mainMenu.advanced.icons": {
Use namespaced ResourceLoader classes The old class names are deprecated since 1.39. Change-Id: Ie24b28ba27c5ce3c98e57a14117f01f4ca42824f
2023-12-01 13:35:19 +00:00
"class": "MediaWiki\\ResourceLoader\\OOUIIconPackModule",
Update Minerva skin to use Codex icons - Define icon size variables in icons.less - Update icon classes to use .cdx-mixin-css-icon() - Remove temporary fixes in icons.less - Add 'codex.styles' dependency in skin.json - Set 'useMaskImage' to true in skin.json Bug: T374145 Depends-On: Ia8f770aec365da77b39cb0258f546df7894e6ba4 Change-Id: I87b060cf98194d81679da2610944f58e8d941389
2024-09-25 00:23:04 +00:00
"useMaskImage": true,
Clean up icon selectors from cached HTML Bug: T344022 Change-Id: I170d86b52345b94a81e74f03b82aef7b522bbb39
2023-09-06 18:57:13 +00:00
"selectorWithoutVariant": ".minerva-icon--{name}",
Use standard palette color Base20 for icons Bug: T240500 Change-Id: I31302acb6dded8b367cff87e35df2ccbc30b4749
2020-04-21 03:23:37 +00:00
"defaultColor": "#54595d",
Replace skins.minerva.mainMenu.advanced.icons with OOUI icons Additional changes: * Address a fixme relating to the overflow icon and move some AMC styles out of the critical path for non-AMC pages Note about ellipsis: The class mf-mw-ui-icon-rotate-clockwise cannot be used as it's part of MobileFrontend and loaded via JS. Minerva must work without MobileFrontend and this rotation is needed without JS. Bug: T244444 Change-Id: Ifd02c50305cf036dd6df640d778678668507e5eb
2020-04-29 04:13:55 +00:00
"icons": [
"recentChanges",
"specialPages",
"speechBubbles"
],
Update modules to not use data URIs to reduce bundle size - Add "useDataURI": false to following modules: -- skins.minerva.mainMenu.advanced.icons -- skins.minerva.personalMenu.icons -- Remove .mw-ui-icon-mf-next-invert old class kept for caching from edit.page.js Bug: T346162 Change-Id: I362fdc9c68a7483c182e3540cba6501d9b12959d
2023-12-05 21:31:54 +00:00
"variants": [],
"useDataURI": false
Separate AMC icons from non-AMC icons Currently a bunch of icons are loaded for all users that are only ever used for AMC. Clean this up and add notes on the necessary steps if these ever become the default. Bug: T229295 Change-Id: I4e16028e7121b0b3e1a60b9404183d483db52ad8
2019-08-22 22:13:57 +00:00
},
"skins.minerva.mainMenu.icons": {
Merge Icon Style mergeIconStyleModules Merging skins.minerva.icons.wikimedia and skins.minerva.mainMenu.icons modules into skins.minerva.icons Bug: T266361 Change-Id: I4095da5a0c6d2cff8ccd1ff1504a2d54635d1828
2024-11-12 21:43:33 +00:00
"deprecated": "Retained for caching reasons. Please use skins.minerva.icons instead.",
Use namespaced ResourceLoader classes The old class names are deprecated since 1.39. Change-Id: Ie24b28ba27c5ce3c98e57a14117f01f4ca42824f
2023-12-01 13:35:19 +00:00
"class": "MediaWiki\\ResourceLoader\\OOUIIconPackModule",
Disable unused icon variants By default this module was inheriting variants and since it doesnt declare a property selectorWithVariant it was using the default selectorWithVariant rule which impacts OOUI icons. Explicitly disable the variants for this module as they are unused. This reduces the size of the modules. Follow up to: I87b060cf98194d81679da2610944f58e8d941389 Bug: T374145 Bug: T376226 Change-Id: Icc008449ee498a946066c4ce5d46adcac194bd3b
2024-10-03 17:06:12 +00:00
"variants": [],
Update Minerva skin to use Codex icons - Define icon size variables in icons.less - Update icon classes to use .cdx-mixin-css-icon() - Remove temporary fixes in icons.less - Add 'codex.styles' dependency in skin.json - Set 'useMaskImage' to true in skin.json Bug: T374145 Depends-On: Ia8f770aec365da77b39cb0258f546df7894e6ba4 Change-Id: I87b060cf98194d81679da2610944f58e8d941389
2024-09-25 00:23:04 +00:00
"useMaskImage": true,
Clean up icon selectors from cached HTML Bug: T344022 Change-Id: I170d86b52345b94a81e74f03b82aef7b522bbb39
2023-09-06 18:57:13 +00:00
"selectorWithoutVariant": ".minerva-icon--{name}",
Use standard palette color Base20 for icons Bug: T240500 Change-Id: I31302acb6dded8b367cff87e35df2ccbc30b4749
2020-04-21 03:23:37 +00:00
"defaultColor": "#54595d",
Do not use data URI on main menu icons data URIs increase CSS payload which delays render time. If we want to render these by default in the new main menu we will need to stop using data URIs. Bug: T225213 Change-Id: I876317ac28837fae48f504bb8d2637e0e7b85154
2019-11-26 23:11:02 +00:00
"useDataURI": false,
Use icons in skins.minerva.mainMenu.icons from OOUI For all mainMenu icons pull from OOUI icon packs. We make the necessary changes to Definitions.php, ToolbarBuilder and LogoutMenuEntry to ensure to update icon glyph names. There are caching implications for icons that show to anonymous users - these have been fixed for grade A browsers running JS by appending the new class to impacted elements. Grade C browsers being served cached HTML will not benefit from this emporary fix as available solutions are costly. As a result these users will not see icons until the cache expires (maximum of 4 weeks but likely 1 week) or is flushed via action=purge. This is acceptable given the amount of impacted users and the fact that icons are not essential for using the main menu. Note: The communityportal.svg icon while in the resources folder was not referenced anywhere in the codebase so its removal is safe. Please note the same icon in skins.minerva.mainMenu.advanced.icons which is used for the community portal menu item. Bug: T244444 Change-Id: I0f929f2f3b11362e02f0d02f57b90b34b5c93d24
2020-02-07 02:16:03 +00:00
"icons": [
"die",
Mobile web donate link Add the Donate link with a heart icon in Mobile menu. Bug: T219793 Change-Id: I65d1d7408e2df7b3ae307736ac6d498b1d7f7197
2020-06-17 18:07:02 +00:00
"heart",
Use icons in skins.minerva.mainMenu.icons from OOUI For all mainMenu icons pull from OOUI icon packs. We make the necessary changes to Definitions.php, ToolbarBuilder and LogoutMenuEntry to ensure to update icon glyph names. There are caching implications for icons that show to anonymous users - these have been fixed for grade A browsers running JS by appending the new class to impacted elements. Grade C browsers being served cached HTML will not benefit from this emporary fix as available solutions are costly. As a result these users will not see icons until the cache expires (maximum of 4 weeks but likely 1 week) or is flushed via action=purge. This is acceptable given the amount of impacted users and the fact that icons are not essential for using the main menu. Note: The communityportal.svg icon while in the resources folder was not referenced anywhere in the codebase so its removal is safe. Please note the same icon in skins.minerva.mainMenu.advanced.icons which is used for the community portal menu item. Bug: T244444 Change-Id: I0f929f2f3b11362e02f0d02f57b90b34b5c93d24
2020-02-07 02:16:03 +00:00
"home",
"logIn",
"logOut",
"mapPin",
"settings",
"userContributions",
Add the watchlist icon to Minerva Bug: T289619 Depends-On: I5b1af082503fe22ec6049784fc43b324534c5b95 Change-Id: If8d1fc44327ca89ba34b55ec66bf321db3e7fbdd
2022-01-13 21:04:03 +00:00
"unStar",
"watchlist"
Use icons in skins.minerva.mainMenu.icons from OOUI For all mainMenu icons pull from OOUI icon packs. We make the necessary changes to Definitions.php, ToolbarBuilder and LogoutMenuEntry to ensure to update icon glyph names. There are caching implications for icons that show to anonymous users - these have been fixed for grade A browsers running JS by appending the new class to impacted elements. Grade C browsers being served cached HTML will not benefit from this emporary fix as available solutions are costly. As a result these users will not see icons until the cache expires (maximum of 4 weeks but likely 1 week) or is flushed via action=purge. This is acceptable given the amount of impacted users and the fact that icons are not essential for using the main menu. Note: The communityportal.svg icon while in the resources folder was not referenced anywhere in the codebase so its removal is safe. Please note the same icon in skins.minerva.mainMenu.advanced.icons which is used for the community portal menu item. Bug: T244444 Change-Id: I0f929f2f3b11362e02f0d02f57b90b34b5c93d24
2020-02-07 02:16:03 +00:00
]
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
},
"skins.minerva.mainMenu.styles": {
Create new skins.minerva.styles module This merges the existing modules skins.minerva.base.styles and skins.minerva.mainMenu.styles into a new module skins.minerva.styles which is named consistently with Vector's style module. The old modules will be kept for caching reasons for at least one, and possibly two deploy cycles, after which we will continue this task. Additional change: * drop .minerva-icon--{name}-base20 and .minerva-icon--{name}-disabled variants since these are no longer utilized and only serve cached HTML Bug: T266361 Change-Id: Iccf415a22e9535603befae25b8cea467f9905437
2024-11-06 23:34:58 +00:00
"deprecated": "Retained for caching reasons. Please use skins.minerva.styles instead.",
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"styles": [
Reorganise stylesheets All stylesheet-only ResourceLoader modules now have a single entry point rather than multiple files. This eases compilation of the content of those modules by all toolchains, which will be useful when introducing the bundlesize tool. Change-Id: Ic38a3e51db2f419fe68efd23a2c48ee69218a526
2020-01-20 21:19:12 +00:00
"resources/skins.minerva.mainMenu.styles/index.less"
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
]
},
Only load notification icon (bell) CSS for logged in users * The notification-count style is only needed if you are logged in. Given a small percentage of our users are logged in, we load a lot of render blocking css unnecessarily. * The bell icon is not needed for anonymous users so pull that out from skins.minerva.icons.images which is loaded for all users into a module only used by logged in users (skins.minerva.icons.loggedin) * Simplify the user-button rule - it is overly specific - probably for historic reasons. Additional changes: * Simplify isAuthenticated helper Change-Id: Ia72e7e45d276e8aac1ff5471bf6158705c7b5f99
2017-12-13 01:25:10 +00:00
"skins.minerva.loggedin.styles": {
"styles": [
"resources/skins.minerva.loggedin.styles/styles.less"
]
},
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"skins.minerva.scripts": {
tests: Adopt private require() for skins.minerva.scripts (take 2) Resubmission of Ib68f45d93a (548e94da98), which caused an error due to `require('../../`)` not working outside the module base directory. This is fixed with regression test in T373065. Further confirmed in this repo by viewing `/wiki/Special:CreateAccount?campaign=loginCTA&useskin=minerva` with this patch applied. Without the T373065 fix, the console warns: > Error: Cannot require undefined file …/ToggleList.js ------- Support for private require() in tests is available since MW 1.41: https://mediawiki.org/wiki/RL/PKG#Private_export_and_import https://mediawiki.org/wiki/RL/PKG#Virtual_files_in_traditional_modules This fixes a confusing assertion in page-issues/index.test.js, where for "insertBannersOrNotice()" it was asserting that the HTML contain "⧼skin-minerva-issue-learn-more⧽", where the ⧼ character indicates the message is not found (i.e. an error). The test had to be written this way in order to pass, because the skins.minerva.scripts module was not actually loaded, and thus its templates and messages are not present either. This lack was filled in by index.js for mw.templates, but not mw.messages. By adopting private require(), these workarounds can all be removed. == Motivation == In change I3a4024ccf90e505581, I'm working on improving the testrunner config to enforce uselang=qqx on all tests. This is passing except for GrowthExperiments and Minerva, both of which have the above workarounds in place that caused a message to be undefined, and then kept in the assertion expectation. When using uselang=qqx, values are returned as (key) instead of ⧼key⧽, which exposes these message existence errors. By removing this workaround, the test will simply import the module in the test as normal, thus the messages will exist, and thus it will expect (key), and thus it will continue to pass even after enforcing uselang=qqx. Bug: T373482 Depends-On: I777f2c12e845a738edeac00e19818d4c939a1ef1 Change-Id: I6348e5ae00776c2c01d91fa90a431b6ffe3da25d
2024-08-23 04:25:52 +00:00
"localBasePath": "resources/skins.minerva.scripts",
"remoteSkinPath": "MinervaNeue/resources/skins.minerva.scripts",
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"dependencies": [
Merge Icon Style mergeIconStyleModules Merging skins.minerva.icons.wikimedia and skins.minerva.mainMenu.icons modules into skins.minerva.icons Bug: T266361 Change-Id: I4095da5a0c6d2cff8ccd1ff1504a2d54635d1828
2024-11-12 21:43:33 +00:00
"skins.minerva.icons",
"skins.minerva.styles",
jquery.cookie is deprecated Bug: T271995 Change-Id: I5750707cdd630de4c79784125ed7e6dc17079898
2023-05-15 21:07:28 +00:00
"mediawiki.cookie",
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"mediawiki.util",
"mediawiki.router",
"mediawiki.Title",
Update: don't prompt to create User pages Suppress the redlink drawer for User namespace pages. The redlink drawer prompts the user to create a missing page but this hinders the usual workflow for User page visits specifically. A User page is connection to an account's contributions, age, and other activities and encouraging the creation of a missing User page when trying to view these connections is a hindrance, especially if the missing User page is not associated with the current user. Bug: T201339 Change-Id: I784493a8ecf28176b5a393cb52d7bfa9fa9b1309
2019-03-04 22:19:33 +00:00
"mediawiki.Uri",
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"mobile.startup",
A/B test bucketing wrapper for page issues AB. Provides a class that initiates AB-test bucketing and registers as a MF module. Activates the reading depth test for users who are bucketed in either buckets "A" or "B". Does not add event-logging or visual style changes for page issues AB test. Bug: T193584 Change-Id: If8504a35059c6d1b056cef063a595b1c2ffd351a
2018-05-09 15:14:44 +00:00
"mediawiki.user",
"mediawiki.storage",
Use watchstar() instead of deprecated jQuery event to update watchstar classes Depends-on: I88af8585e8fc75f77ebef867d267199aeb2c6592 Change-Id: I859c9d763e77bb06b5109d419fb581258f3bd665
2021-12-08 21:08:18 +00:00
"mediawiki.experiments",
"mediawiki.page.watch.ajax"
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
],
"messages": [
Send a toast notification if night mode is not available Add a skin-night-mode-page-disabled class to the HTML element when a page was disabled by the new MinervaNightModeOptions configuration flag. Bug: T356653 Change-Id: I7a6582ef8f66e78cc6f07da06bc4d2a3277cfcf0
2024-02-08 22:52:46 +00:00
"skin-minerva-night-mode-unavailable",
Style the desktop diff and history page of Minerva to look like mobile pages Depends-On: Ie8ac1aab6d2fe5f4575a6891c36efe497458e093 Bug: T305113 Bug: T240624 Change-Id: I5a4a2588da3d701be87690038c2c9b2bc1aa0365
2023-09-29 21:55:29 +00:00
"skin-minerva-time-ago-seconds",
Document messages and add hours and minute units Follow up to I5a4a2588da3d701be87690038c2c9b2bc1aa0365 Change-Id: I6ea2b98bd3d03e586cc58307d3f2f0f1119059e3
2023-10-30 23:01:26 +00:00
"skin-minerva-time-ago-minutes",
"skin-minerva-time-ago-hours",
Style the desktop diff and history page of Minerva to look like mobile pages Depends-On: Ie8ac1aab6d2fe5f4575a6891c36efe497458e093 Bug: T305113 Bug: T240624 Change-Id: I5a4a2588da3d701be87690038c2c9b2bc1aa0365
2023-09-29 21:55:29 +00:00
"skin-minerva-time-ago-days",
"skin-minerva-time-ago-months",
"skin-minerva-time-ago-years",
Embrace packageFiles Help with readability by using module.exports and require rather than the MobileFrontend provided mw.mobileFrontend module manager (and avoid adopting webpack at this time) Replace usages of mw.mobileFrontend.require with local require and module.exports (compatible with RL or Node implementation) Changes: * Notifications modules are merged into skins.minerva.scripts and initialised via a client side check. * new file overlayManager for exporting an overlayManager singleton rather than being hidden inside resources/skins.minerva.scripts/init.js * All M.define/M.requires swapped out for require where possible The `define` method is now forbidden in the repo. Bug: T212944 Change-Id: I44790dd3fc6fe42bb502d79c39c4081c223bf2b1
2019-07-02 21:10:10 +00:00
"echo-badge-count",
Mobile page issues - visual styling changes Changes: * Introduce Jan's beautifully documented $wgMinervaABSamplingRate Set to 1 to A/B test 50% of the population * Split out ambox template styles into a separate file referenced by hacks.less * Update cleanuptemplates setup script to consider two buckets Test pages: * Shqiponja_Partizane * World_War_II_in_Albania * Liberation_of_Tirana * French_Consulate * Abd_ar-Rahman_IV * M109_howitzer * Aimoin * Transport_in_Brazil * Transport_in_Cape_Verde Bug: T191303 Change-Id: I8d11e655ccb847b7999e64dda57b225ad8b1c23a
2018-05-08 22:03:52 +00:00
"skin-minerva-issue-learn-more",
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"mobile-frontend-meta-data-issues",
Section issues overlay has different heading Per https://phabricator.wikimedia.org/T197932#4417319 Note that given talk/category overlay does not use or display section issues, to simplify things any section other than 0 or all will use this heading. Bug: T197932 Change-Id: I737fb07aaadcea7772d0b08f8b0652dcf2f4623d
2018-07-11 21:13:19 +00:00
"minerva-meta-data-issues-section-header",
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
"mobile-frontend-meta-data-issues-categories",
"mobile-frontend-meta-data-issues-header",
"mobile-frontend-languages-not-available",
"mobile-frontend-cookies-required",
Move redlink CTA out of skins.minerva.editor It is not part of the editor. Redlinks are part of page content. Bug: T198765 Change-Id: Iee77a228b6f2db1c5f2e85226d6cc1c6a73a89be
2018-09-20 22:52:35 +00:00
"mobile-frontend-editor-redlink-create",
"mobile-frontend-editor-redlink-leave",
"mobile-frontend-editor-redlink-explain",
Add feature flagged DownloadIcon Shortcut for print. Disabled by default and controlled by wgMinervaDownloadIcon Note that with lazy images enabled, images will not appear in the printed article. This can be easily addressed inside the onClick function in a later patchset with a few modifications to the Skin class. Currently the flag when enabled will show on all browsers. There are some open questions on the ticket about how we want to limit the feature. This shouldn't block review or merging. Bug: T177215 Change-Id: I49f1736870c743990b3fb9916247e07a597b2f59
2017-10-18 21:03:51 +00:00
"minerva-download",
Use core watchstar code Apply the mediawiki core watchstar to the Minerva skin. Note, watchstars in search and other locations will continue to be provided by the MobileFrontend library (see follow up patch I7b748dc87089389400b0035c62a3b9a00c2e43f9) Bug: T234970 Change-Id: I11bbe976412b50dba76a55f37887e4c9235d0be1
2019-09-19 21:19:07 +00:00
"minerva-watchlist-cta",
Remove talk page tools Bug: T319145 Change-Id: Ib432564e1049f18334653e5eb3981f0f051582b3
2022-10-02 12:44:18 +00:00
"mobile-frontend-redirected-from"
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
],
Restore last modified active link color In I7abdbac4d2d16b931e2b110fcebf0dfc82146753 I accidentally removed the active link color (I meant to /move/ it from the critical path since it requires JavaScript) Change-Id: Ie86c3c9d03a0ed130a86c50bb548c9b47db6def6
2018-04-13 17:17:36 +00:00
"styles": [
tests: Adopt private require() for skins.minerva.scripts (take 2) Resubmission of Ib68f45d93a (548e94da98), which caused an error due to `require('../../`)` not working outside the module base directory. This is fixed with regression test in T373065. Further confirmed in this repo by viewing `/wiki/Special:CreateAccount?campaign=loginCTA&useskin=minerva` with this patch applied. Without the T373065 fix, the console warns: > Error: Cannot require undefined file …/ToggleList.js ------- Support for private require() in tests is available since MW 1.41: https://mediawiki.org/wiki/RL/PKG#Private_export_and_import https://mediawiki.org/wiki/RL/PKG#Virtual_files_in_traditional_modules This fixes a confusing assertion in page-issues/index.test.js, where for "insertBannersOrNotice()" it was asserting that the HTML contain "⧼skin-minerva-issue-learn-more⧽", where the ⧼ character indicates the message is not found (i.e. an error). The test had to be written this way in order to pass, because the skins.minerva.scripts module was not actually loaded, and thus its templates and messages are not present either. This lack was filled in by index.js for mw.templates, but not mw.messages. By adopting private require(), these workarounds can all be removed. == Motivation == In change I3a4024ccf90e505581, I'm working on improving the testrunner config to enforce uselang=qqx on all tests. This is passing except for GrowthExperiments and Minerva, both of which have the above workarounds in place that caused a message to be undefined, and then kept in the assertion expectation. When using uselang=qqx, values are returned as (key) instead of ⧼key⧽, which exposes these message existence errors. By removing this workaround, the test will simply import the module in the test as normal, thus the messages will exist, and thus it will expect (key), and thus it will continue to pass even after enforcing uselang=qqx. Bug: T373482 Depends-On: I777f2c12e845a738edeac00e19818d4c939a1ef1 Change-Id: I6348e5ae00776c2c01d91fa90a431b6ffe3da25d
2024-08-23 04:25:52 +00:00
"styles.less"
Restore last modified active link color In I7abdbac4d2d16b931e2b110fcebf0dfc82146753 I accidentally removed the active link color (I meant to /move/ it from the critical path since it requires JavaScript) Change-Id: Ie86c3c9d03a0ed130a86c50bb548c9b47db6def6
2018-04-13 17:17:36 +00:00
],
Hygiene: IssuesOverlay moved from MobileFrontend to Minerva The CleanupOverlay is moved to Minerva and renamed the IssuesOverlay to be consistent with current terminology The new IssuesOverlay is defined inside the module skins.minerva.scripts to which it now belongs. Additional changes: * various file renames * overlay-cleanup renames overlay-issues * cleanuptemplates renamed issues.js * Add a test stub file to avoid the need to load templates inside the test environment After this change, I75f47622d94e504688e04dfb2892540473817053 should be merged to avoid confusion. Change-Id: I08945a324a6b878abe56efed1e988466085b3018
2018-08-16 19:00:38 +00:00
"templates": {
tests: Adopt private require() for skins.minerva.scripts (take 2) Resubmission of Ib68f45d93a (548e94da98), which caused an error due to `require('../../`)` not working outside the module base directory. This is fixed with regression test in T373065. Further confirmed in this repo by viewing `/wiki/Special:CreateAccount?campaign=loginCTA&useskin=minerva` with this patch applied. Without the T373065 fix, the console warns: > Error: Cannot require undefined file …/ToggleList.js ------- Support for private require() in tests is available since MW 1.41: https://mediawiki.org/wiki/RL/PKG#Private_export_and_import https://mediawiki.org/wiki/RL/PKG#Virtual_files_in_traditional_modules This fixes a confusing assertion in page-issues/index.test.js, where for "insertBannersOrNotice()" it was asserting that the HTML contain "⧼skin-minerva-issue-learn-more⧽", where the ⧼ character indicates the message is not found (i.e. an error). The test had to be written this way in order to pass, because the skins.minerva.scripts module was not actually loaded, and thus its templates and messages are not present either. This lack was filled in by index.js for mw.templates, but not mw.messages. By adopting private require(), these workarounds can all be removed. == Motivation == In change I3a4024ccf90e505581, I'm working on improving the testrunner config to enforce uselang=qqx on all tests. This is passing except for GrowthExperiments and Minerva, both of which have the above workarounds in place that caused a message to be undefined, and then kept in the assertion expectation. When using uselang=qqx, values are returned as (key) instead of ⧼key⧽, which exposes these message existence errors. By removing this workaround, the test will simply import the module in the test as normal, thus the messages will exist, and thus it will expect (key), and thus it will continue to pass even after enforcing uselang=qqx. Bug: T373482 Depends-On: I777f2c12e845a738edeac00e19818d4c939a1ef1 Change-Id: I6348e5ae00776c2c01d91fa90a431b6ffe3da25d
2024-08-23 04:25:52 +00:00
"IssueNotice.mustache": "page-issues/overlay/IssueNotice.mustache"
Hygiene: IssuesOverlay moved from MobileFrontend to Minerva The CleanupOverlay is moved to Minerva and renamed the IssuesOverlay to be consistent with current terminology The new IssuesOverlay is defined inside the module skins.minerva.scripts to which it now belongs. Additional changes: * various file renames * overlay-cleanup renames overlay-issues * cleanuptemplates renamed issues.js * Add a test stub file to avoid the need to load templates inside the test environment After this change, I75f47622d94e504688e04dfb2892540473817053 should be merged to avoid confusion. Change-Id: I08945a324a6b878abe56efed1e988466085b3018
2018-08-16 19:00:38 +00:00
},
Embrace packageFiles Help with readability by using module.exports and require rather than the MobileFrontend provided mw.mobileFrontend module manager (and avoid adopting webpack at this time) Replace usages of mw.mobileFrontend.require with local require and module.exports (compatible with RL or Node implementation) Changes: * Notifications modules are merged into skins.minerva.scripts and initialised via a client side check. * new file overlayManager for exporting an overlayManager singleton rather than being hidden inside resources/skins.minerva.scripts/init.js * All M.define/M.requires swapped out for require where possible The `define` method is now forbidden in the repo. Bug: T212944 Change-Id: I44790dd3fc6fe42bb502d79c39c4081c223bf2b1
2019-07-02 21:10:10 +00:00
"packageFiles": [
tests: Adopt private require() for skins.minerva.scripts (take 2) Resubmission of Ib68f45d93a (548e94da98), which caused an error due to `require('../../`)` not working outside the module base directory. This is fixed with regression test in T373065. Further confirmed in this repo by viewing `/wiki/Special:CreateAccount?campaign=loginCTA&useskin=minerva` with this patch applied. Without the T373065 fix, the console warns: > Error: Cannot require undefined file …/ToggleList.js ------- Support for private require() in tests is available since MW 1.41: https://mediawiki.org/wiki/RL/PKG#Private_export_and_import https://mediawiki.org/wiki/RL/PKG#Virtual_files_in_traditional_modules This fixes a confusing assertion in page-issues/index.test.js, where for "insertBannersOrNotice()" it was asserting that the HTML contain "⧼skin-minerva-issue-learn-more⧽", where the ⧼ character indicates the message is not found (i.e. an error). The test had to be written this way in order to pass, because the skins.minerva.scripts module was not actually loaded, and thus its templates and messages are not present either. This lack was filled in by index.js for mw.templates, but not mw.messages. By adopting private require(), these workarounds can all be removed. == Motivation == In change I3a4024ccf90e505581, I'm working on improving the testrunner config to enforce uselang=qqx on all tests. This is passing except for GrowthExperiments and Minerva, both of which have the above workarounds in place that caused a message to be undefined, and then kept in the assertion expectation. When using uselang=qqx, values are returned as (key) instead of ⧼key⧽, which exposes these message existence errors. By removing this workaround, the test will simply import the module in the test as normal, thus the messages will exist, and thus it will expect (key), and thus it will continue to pass even after enforcing uselang=qqx. Bug: T373482 Depends-On: I777f2c12e845a738edeac00e19818d4c939a1ef1 Change-Id: I6348e5ae00776c2c01d91fa90a431b6ffe3da25d
2024-08-23 04:25:52 +00:00
"setup.js",
"reportIfNightModeWasDisabledOnPage.js",
"addPortletLink.js",
"initMobile.js",
"searchSuggestReveal.js",
"drawers.js",
"ctaDrawers.js",
"menu.js",
"preInit.js",
"downloadPageAction.js",
"page-issues/parser.js",
"AB.js",
"page-issues/overlay/IssueNotice.js",
"page-issues/overlay/IssueList.js",
"page-issues/overlay/pageIssuesOverlay.js",
"page-issues/page/PageIssueLearnMoreLink.js",
"page-issues/page/PageIssueLink.js",
"page-issues/page/pageIssueFormatter.js",
"page-issues/index.js",
"UriUtil.js",
"TitleUtil.js",
"../../includes/Skins/ToggleList/ToggleList.js",
"TabScroll.js",
"Toolbar.js",
"mobileRedirect.js",
"search.js",
"references.js",
"watchstar.js"
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
]
},
Replace categories button with HTML rendering Bug: T246049 Change-Id: Id8c7493a525844b43c1628a1f4f09ae716ece2ba
2021-04-28 21:58:51 +00:00
"skins.minerva.categories.styles": {
Use namespaced ResourceLoader classes The old class names are deprecated since 1.39. Change-Id: Ie24b28ba27c5ce3c98e57a14117f01f4ca42824f
2023-12-01 13:35:19 +00:00
"class": "MediaWiki\\ResourceLoader\\SkinModule",
build: Update MediaWiki requirement to 1.41 All skins in the MediaWiki tarball are expected to track MediaWiki's release directly. Change-Id: I320ccbc07409ab9c2858fd1410ec91cda797b464
2023-08-19 06:32:31 +00:00
"features": [
"interface-category"
]
Replace codex-search-styles with CodexModule Enhance MinervaNeue Skin with Codex Integration and Style Refinements. This update to the MinervaNeue skin introduces enhancements aimed at integrating with Codex UI components and the optimisation of skin-specific styles. These changes are in direct response to the objectives set forth in Phabricator task T356678, focusing on modernising the skin's aesthetics and functionality. Changes: - Enhanced skin.json to include new 'scripts' and 'styles' configurations, incorporating Codex UI components such as 'CdxButton' and a variety of Minerva-specific styles like 'skins.minerva.base.styles' and 'skins.minerva.content.styles.images'. - Refined `includes/Skins/SkinMinerva.php` by restructuring the method of loading skin and feature-specific styles. The update simplifies style management, allowing for a more granular approach to style application. This includes separating page-specific styles from feature-specific styles. Rationale: The implementation of Codex UI components within the MinervaNeue skin is to leverage modern web design principles, enhancing usability and aesthetic appeal. By refining the skin's style loading mechanism, we aim to at least maintain if not reduce the overhead, improve page load times, and offer a more customisable appearance, ultimately benefiting both end-users and developers. Bug: T356678 Change-Id: Ia96f58397c23126e940cc9263b30e0da88c90a29
2024-04-03 12:48:52 +00:00
},
"skins.minerva.codex.styles": {
"class": "MediaWiki\\ResourceLoader\\CodexModule",
"codexStyleOnly": true,
"codexComponents": [
Drop message box styling modules from page load The skins.minerva.messageBox.styles module is loaded on pages with old revisions, but this message box is already being styled by another module added by core. Skins are not responsible for styling Codex. This is the responsibility of the code that adds the message box to the page. In addition to this we were loading another set of styles for message boxes on skins.minerva.codex.styles Bug: T375287 Change-Id: I0cf5dc6baf2e447b4944f04365addd614d59cfbe
2024-11-07 17:29:11 +00:00
"CdxButton"
Replace codex-search-styles with CodexModule Enhance MinervaNeue Skin with Codex Integration and Style Refinements. This update to the MinervaNeue skin introduces enhancements aimed at integrating with Codex UI components and the optimisation of skin-specific styles. These changes are in direct response to the objectives set forth in Phabricator task T356678, focusing on modernising the skin's aesthetics and functionality. Changes: - Enhanced skin.json to include new 'scripts' and 'styles' configurations, incorporating Codex UI components such as 'CdxButton' and a variety of Minerva-specific styles like 'skins.minerva.base.styles' and 'skins.minerva.content.styles.images'. - Refined `includes/Skins/SkinMinerva.php` by restructuring the method of loading skin and feature-specific styles. The update simplifies style management, allowing for a more granular approach to style application. This includes separating page-specific styles from feature-specific styles. Rationale: The implementation of Codex UI components within the MinervaNeue skin is to leverage modern web design principles, enhancing usability and aesthetic appeal. By refining the skin's style loading mechanism, we aim to at least maintain if not reduce the overhead, improve page load times, and offer a more customisable appearance, ultimately benefiting both end-users and developers. Bug: T356678 Change-Id: Ia96f58397c23126e940cc9263b30e0da88c90a29
2024-04-03 12:48:52 +00:00
]
Minerva is its own skin This is programmatic output from python3 scripts/migrate.py This will result in a Minerva skin dependent on MobileFrontend. Post merge we will rename message keys to have minerva- prefix Bug: T166748 Change-Id: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
2017-07-12 15:12:40 +00:00
}
Use tabs in skin.json Change-Id: I8fb66fe2f99786bfbdc598d460c18928dbb0faa0
2017-06-09 22:09:22 +00:00
},
Migrate from onResourceLoaderTestModules to QUnitTestModule The hook is deprecated as of this release cycle, see: <https://www.mediawiki.org/wiki/Manual:Hooks/ResourceLoaderTestModules>. Moving away from PHP code. This can now be done from JSON, and encourages use of a single module that is automatically named and registered as needed. Change-Id: I382692c70ca8e5f5ea658b07ebea6c47dd541724
2019-09-20 20:50:23 +00:00
"QUnitTestModule": {
tests: Adopt private require() for skins.minerva.scripts (take 2) Resubmission of Ib68f45d93a (548e94da98), which caused an error due to `require('../../`)` not working outside the module base directory. This is fixed with regression test in T373065. Further confirmed in this repo by viewing `/wiki/Special:CreateAccount?campaign=loginCTA&useskin=minerva` with this patch applied. Without the T373065 fix, the console warns: > Error: Cannot require undefined file …/ToggleList.js ------- Support for private require() in tests is available since MW 1.41: https://mediawiki.org/wiki/RL/PKG#Private_export_and_import https://mediawiki.org/wiki/RL/PKG#Virtual_files_in_traditional_modules This fixes a confusing assertion in page-issues/index.test.js, where for "insertBannersOrNotice()" it was asserting that the HTML contain "⧼skin-minerva-issue-learn-more⧽", where the ⧼ character indicates the message is not found (i.e. an error). The test had to be written this way in order to pass, because the skins.minerva.scripts module was not actually loaded, and thus its templates and messages are not present either. This lack was filled in by index.js for mw.templates, but not mw.messages. By adopting private require(), these workarounds can all be removed. == Motivation == In change I3a4024ccf90e505581, I'm working on improving the testrunner config to enforce uselang=qqx on all tests. This is passing except for GrowthExperiments and Minerva, both of which have the above workarounds in place that caused a message to be undefined, and then kept in the assertion expectation. When using uselang=qqx, values are returned as (key) instead of ⧼key⧽, which exposes these message existence errors. By removing this workaround, the test will simply import the module in the test as normal, thus the messages will exist, and thus it will expect (key), and thus it will continue to pass even after enforcing uselang=qqx. Bug: T373482 Depends-On: I777f2c12e845a738edeac00e19818d4c939a1ef1 Change-Id: I6348e5ae00776c2c01d91fa90a431b6ffe3da25d
2024-08-23 04:25:52 +00:00
"localBasePath": "tests/qunit/skins.minerva.scripts",
"remoteSkinPath": "MinervaNeue/tests/qunit/skins.minerva.scripts",
Migrate from onResourceLoaderTestModules to QUnitTestModule The hook is deprecated as of this release cycle, see: <https://www.mediawiki.org/wiki/Manual:Hooks/ResourceLoaderTestModules>. Moving away from PHP code. This can now be done from JSON, and encourages use of a single module that is automatically named and registered as needed. Change-Id: I382692c70ca8e5f5ea658b07ebea6c47dd541724
2019-09-20 20:50:23 +00:00
"dependencies": [
Send a toast notification if night mode is not available Add a skin-night-mode-page-disabled class to the HTML element when a page was disabled by the new MinervaNightModeOptions configuration flag. Bug: T356653 Change-Id: I7a6582ef8f66e78cc6f07da06bc4d2a3277cfcf0
2024-02-08 22:52:46 +00:00
"mediawiki.cookie",
tests: Adopt private require() for skins.minerva.scripts (take 2) Resubmission of Ib68f45d93a (548e94da98), which caused an error due to `require('../../`)` not working outside the module base directory. This is fixed with regression test in T373065. Further confirmed in this repo by viewing `/wiki/Special:CreateAccount?campaign=loginCTA&useskin=minerva` with this patch applied. Without the T373065 fix, the console warns: > Error: Cannot require undefined file …/ToggleList.js ------- Support for private require() in tests is available since MW 1.41: https://mediawiki.org/wiki/RL/PKG#Private_export_and_import https://mediawiki.org/wiki/RL/PKG#Virtual_files_in_traditional_modules This fixes a confusing assertion in page-issues/index.test.js, where for "insertBannersOrNotice()" it was asserting that the HTML contain "⧼skin-minerva-issue-learn-more⧽", where the ⧼ character indicates the message is not found (i.e. an error). The test had to be written this way in order to pass, because the skins.minerva.scripts module was not actually loaded, and thus its templates and messages are not present either. This lack was filled in by index.js for mw.templates, but not mw.messages. By adopting private require(), these workarounds can all be removed. == Motivation == In change I3a4024ccf90e505581, I'm working on improving the testrunner config to enforce uselang=qqx on all tests. This is passing except for GrowthExperiments and Minerva, both of which have the above workarounds in place that caused a message to be undefined, and then kept in the assertion expectation. When using uselang=qqx, values are returned as (key) instead of ⧼key⧽, which exposes these message existence errors. By removing this workaround, the test will simply import the module in the test as normal, thus the messages will exist, and thus it will expect (key), and thus it will continue to pass even after enforcing uselang=qqx. Bug: T373482 Depends-On: I777f2c12e845a738edeac00e19818d4c939a1ef1 Change-Id: I6348e5ae00776c2c01d91fa90a431b6ffe3da25d
2024-08-23 04:25:52 +00:00
"skins.minerva.scripts",
Migrate from onResourceLoaderTestModules to QUnitTestModule The hook is deprecated as of this release cycle, see: <https://www.mediawiki.org/wiki/Manual:Hooks/ResourceLoaderTestModules>. Moving away from PHP code. This can now be done from JSON, and encourages use of a single module that is automatically named and registered as needed. Change-Id: I382692c70ca8e5f5ea658b07ebea6c47dd541724
2019-09-20 20:50:23 +00:00
"mobile.startup",
"mediawiki.user",
QUnit: Add dependency on mw.Uri Allows running the tests via `grunt qunit --qunit-project=MinervaNeue` with I977150ece26f5878a0ccc42d39bed6c7e74e9602 Change-Id: I8f747e3df196055361d53d00fea833fb9de892f0
2022-02-02 10:15:48 +00:00
"mediawiki.experiments",
"mediawiki.Uri"
Migrate from onResourceLoaderTestModules to QUnitTestModule The hook is deprecated as of this release cycle, see: <https://www.mediawiki.org/wiki/Manual:Hooks/ResourceLoaderTestModules>. Moving away from PHP code. This can now be done from JSON, and encourages use of a single module that is automatically named and registered as needed. Change-Id: I382692c70ca8e5f5ea658b07ebea6c47dd541724
2019-09-20 20:50:23 +00:00
],
tests: Adopt private require() for skins.minerva.scripts (take 2) Resubmission of Ib68f45d93a (548e94da98), which caused an error due to `require('../../`)` not working outside the module base directory. This is fixed with regression test in T373065. Further confirmed in this repo by viewing `/wiki/Special:CreateAccount?campaign=loginCTA&useskin=minerva` with this patch applied. Without the T373065 fix, the console warns: > Error: Cannot require undefined file …/ToggleList.js ------- Support for private require() in tests is available since MW 1.41: https://mediawiki.org/wiki/RL/PKG#Private_export_and_import https://mediawiki.org/wiki/RL/PKG#Virtual_files_in_traditional_modules This fixes a confusing assertion in page-issues/index.test.js, where for "insertBannersOrNotice()" it was asserting that the HTML contain "⧼skin-minerva-issue-learn-more⧽", where the ⧼ character indicates the message is not found (i.e. an error). The test had to be written this way in order to pass, because the skins.minerva.scripts module was not actually loaded, and thus its templates and messages are not present either. This lack was filled in by index.js for mw.templates, but not mw.messages. By adopting private require(), these workarounds can all be removed. == Motivation == In change I3a4024ccf90e505581, I'm working on improving the testrunner config to enforce uselang=qqx on all tests. This is passing except for GrowthExperiments and Minerva, both of which have the above workarounds in place that caused a message to be undefined, and then kept in the assertion expectation. When using uselang=qqx, values are returned as (key) instead of ⧼key⧽, which exposes these message existence errors. By removing this workaround, the test will simply import the module in the test as normal, thus the messages will exist, and thus it will expect (key), and thus it will continue to pass even after enforcing uselang=qqx. Bug: T373482 Depends-On: I777f2c12e845a738edeac00e19818d4c939a1ef1 Change-Id: I6348e5ae00776c2c01d91fa90a431b6ffe3da25d
2024-08-23 04:25:52 +00:00
"scripts": [
"integration.test.js",
"downloadPageAction.test.js",
"page-issues/parser.test.js",
"AB.test.js",
"page-issues/index.test.js",
"UriUtil.test.js",
"TitleUtil.test.js",
"watchstar.test.js"
Migrate from onResourceLoaderTestModules to QUnitTestModule The hook is deprecated as of this release cycle, see: <https://www.mediawiki.org/wiki/Manual:Hooks/ResourceLoaderTestModules>. Moving away from PHP code. This can now be done from JSON, and encourages use of a single module that is automatically named and registered as needed. Change-Id: I382692c70ca8e5f5ea658b07ebea6c47dd541724
2019-09-20 20:50:23 +00:00
]
},
Use MediaWikiServices to cache commonly used helpers SkinMinerva cached the ContentHandler object for better performance. In the future the ContentHandler will be also used in the Menu, for better readability, store ContentHandler as Service. MediaWikiServices will initialize service on first access and cache it for future needs. Same applies to SkinUserPageHelper, Bug: T216152 Change-Id: Ia98dc860862360a68556272714669f0c3a13eb1e
2019-04-10 12:52:34 +00:00
"ServiceWiringFiles": [
"includes/ServiceWiring.php"
],
Set MobileFrontendEditorAvailableSkins attribute The attribute tells MF this skin is ready to allow the user to show the editor. Bug: T257746 Depends-On: Iac3fc9571827782c2a9fe9531b885218e2159d29 Change-Id: Ib435929376bc34a1dcede1cd142b0e1cb186b6a9
2022-04-19 18:10:59 +00:00
"attributes": {
Disable Extension:DarkMode on Minerva Bug: T357598 Change-Id: I590ebe574c4c23507525a118cd99cbe31af022db
2024-02-15 01:29:05 +00:00
"DarkMode": {
"Disabled": [
"minerva"
]
},
Set MobileFrontendEditorAvailableSkins attribute The attribute tells MF this skin is ready to allow the user to show the editor. Bug: T257746 Depends-On: Iac3fc9571827782c2a9fe9531b885218e2159d29 Change-Id: Ib435929376bc34a1dcede1cd142b0e1cb186b6a9
2022-04-19 18:10:59 +00:00
"MobileFrontend": {
"EditorAvailableSkins": [
"minerva"
]
Support extension of page actions via hook and addPortletLink This adds support for: mw.util.addPortletLink('p-views', '#', 'text', 'fooz',null, null,'#page-actions-overflow' ) and adding multiple edit icons via hooks. Depends-On: I655097769620301143140ded1cde4c7a16879ef4 Depends-On: I401805224c0f387ac85b52b50c1f298b83c03a91 Bug: T346944 Change-Id: I3c9d59f49f1b939981a7b2b450448db6736d5958
2023-09-27 00:17:21 +00:00
},
"VisualEditor": {
"IconSkins": [
"minerva"
]
Set MobileFrontendEditorAvailableSkins attribute The attribute tells MF this skin is ready to allow the user to show the editor. Bug: T257746 Depends-On: Iac3fc9571827782c2a9fe9531b885218e2159d29 Change-Id: Ib435929376bc34a1dcede1cd142b0e1cb186b6a9
2022-04-19 18:10:59 +00:00
}
},
Set up user option for night mode Add a new user option, `minerva-night-mode`, and configure it with a default value of 2 (automatic based on OS). Rework the code in `getHtmlElementAttributes` to set the initial class value according to the user option, which will be set and saved inside of MobileFrontend Bug: T355118 Change-Id: I4b0d63a186f490ba10b7655b3af4dcb8b64bd400
2024-02-01 23:05:55 +00:00
"DefaultUserOptions": {
Rename the skin night mode classes to more readable classes The classes: - skin-night-mode-clientpref-0 - skin-night-mode-clientpref-1 - skin-night-mode-clientpref-2 is being replaced with - skin-theme-clientpref-day - skin-theme-clientpref-night - skin-theme-clientpref-os - Moved $forceNightMode to be a text parameter (dat|night|os) - Keep adding the old classes to the html element, to give the ability of gradual deployment The preference is renamed from minerva-night-mode to minerva-theme (a follow up to consider migrating existing values will follow). The query string minervanightmode continues to behave the same but now accepts other values such as day, night and os. Bug: T359983 Change-Id: Ia253de68f94236e7fe2219b736dd6084c64ce838
2024-03-18 19:14:23 +00:00
"minerva-theme": "day"
Set up user option for night mode Add a new user option, `minerva-night-mode`, and configure it with a default value of 2 (automatic based on OS). Rework the code in `getHtmlElementAttributes` to set the initial class value according to the user option, which will be set and saved inside of MobileFrontend Bug: T355118 Change-Id: I4b0d63a186f490ba10b7655b3af4dcb8b64bd400
2024-02-01 23:05:55 +00:00
},
Upgrade skin.json schema to manifest_version 2 Bug: T242505 Change-Id: Iccc217fe695270c5a04811fdca5bd65c26ae6609
2020-01-11 04:31:33 +00:00
"manifest_version": 2
Use a Drawer for Block Notices When a user is blocked, the toast message provides insufficent information to the user. To provide more information, as well as a better design, the block message will be moved into a drawer. Bug: T165535 Change-Id: Ib025db3a8a4d1fd7bd05b69f9b5326943288372f Depends-On: I926918d0bd7f2176f188a2154dc5e99f6a8a7ad1
2018-04-14 17:54:25 +00:00
}
Reference in a new issue Copy permalink